* [PATCH] drm/rockchip: remove vop_writel
@ 2022-05-21 19:07 ` Tom Rix
0 siblings, 0 replies; 8+ messages in thread
From: Tom Rix @ 2022-05-21 19:07 UTC (permalink / raw)
To: hjc, heiko, airlied, daniel
Cc: dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel, Tom Rix
cppcheck reports
[drivers/gpu/drm/rockchip/rockchip_drm_vop.c:186]: (style) The function 'vop_writel' is never used.
vop_writel is static function that is not used, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 74562d40f639..d1026e78feff 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -183,12 +183,6 @@ struct vop {
struct vop_win win[];
};
-static inline void vop_writel(struct vop *vop, uint32_t offset, uint32_t v)
-{
- writel(v, vop->regs + offset);
- vop->regsbak[offset >> 2] = v;
-}
-
static inline uint32_t vop_readl(struct vop *vop, uint32_t offset)
{
return readl(vop->regs + offset);
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] drm/rockchip: remove vop_writel
@ 2022-05-21 19:07 ` Tom Rix
0 siblings, 0 replies; 8+ messages in thread
From: Tom Rix @ 2022-05-21 19:07 UTC (permalink / raw)
To: hjc, heiko, airlied, daniel
Cc: dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel, Tom Rix
cppcheck reports
[drivers/gpu/drm/rockchip/rockchip_drm_vop.c:186]: (style) The function 'vop_writel' is never used.
vop_writel is static function that is not used, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 74562d40f639..d1026e78feff 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -183,12 +183,6 @@ struct vop {
struct vop_win win[];
};
-static inline void vop_writel(struct vop *vop, uint32_t offset, uint32_t v)
-{
- writel(v, vop->regs + offset);
- vop->regsbak[offset >> 2] = v;
-}
-
static inline uint32_t vop_readl(struct vop *vop, uint32_t offset)
{
return readl(vop->regs + offset);
--
2.27.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] drm/rockchip: remove vop_writel
@ 2022-05-21 19:07 ` Tom Rix
0 siblings, 0 replies; 8+ messages in thread
From: Tom Rix @ 2022-05-21 19:07 UTC (permalink / raw)
To: hjc, heiko, airlied, daniel
Cc: linux-rockchip, Tom Rix, linux-arm-kernel, dri-devel, linux-kernel
cppcheck reports
[drivers/gpu/drm/rockchip/rockchip_drm_vop.c:186]: (style) The function 'vop_writel' is never used.
vop_writel is static function that is not used, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 74562d40f639..d1026e78feff 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -183,12 +183,6 @@ struct vop {
struct vop_win win[];
};
-static inline void vop_writel(struct vop *vop, uint32_t offset, uint32_t v)
-{
- writel(v, vop->regs + offset);
- vop->regsbak[offset >> 2] = v;
-}
-
static inline uint32_t vop_readl(struct vop *vop, uint32_t offset)
{
return readl(vop->regs + offset);
--
2.27.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] drm/rockchip: remove vop_writel
2022-05-21 19:07 ` Tom Rix
(?)
(?)
@ 2022-09-15 13:40 ` Heiko Stuebner
-1 siblings, 0 replies; 8+ messages in thread
From: Heiko Stuebner @ 2022-09-15 13:40 UTC (permalink / raw)
To: Tom Rix, airlied, hjc, daniel
Cc: Heiko Stuebner, linux-arm-kernel, dri-devel, linux-kernel,
linux-rockchip
On Sat, 21 May 2022 15:07:16 -0400, Tom Rix wrote:
> cppcheck reports
> [drivers/gpu/drm/rockchip/rockchip_drm_vop.c:186]: (style) The function 'vop_writel' is never used.
>
> vop_writel is static function that is not used, so remove it.
Applied, thanks!
[1/1] drm/rockchip: remove vop_writel
commit: 98a65e6d498c46b0beec7a40aac4b3e404642993
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/rockchip: remove vop_writel
@ 2022-09-15 13:40 ` Heiko Stuebner
0 siblings, 0 replies; 8+ messages in thread
From: Heiko Stuebner @ 2022-09-15 13:40 UTC (permalink / raw)
To: Tom Rix, airlied, hjc, daniel
Cc: Heiko Stuebner, linux-arm-kernel, dri-devel, linux-kernel,
linux-rockchip
On Sat, 21 May 2022 15:07:16 -0400, Tom Rix wrote:
> cppcheck reports
> [drivers/gpu/drm/rockchip/rockchip_drm_vop.c:186]: (style) The function 'vop_writel' is never used.
>
> vop_writel is static function that is not used, so remove it.
Applied, thanks!
[1/1] drm/rockchip: remove vop_writel
commit: 98a65e6d498c46b0beec7a40aac4b3e404642993
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/rockchip: remove vop_writel
@ 2022-09-15 13:40 ` Heiko Stuebner
0 siblings, 0 replies; 8+ messages in thread
From: Heiko Stuebner @ 2022-09-15 13:40 UTC (permalink / raw)
To: Tom Rix, airlied, hjc, daniel
Cc: linux-rockchip, dri-devel, linux-arm-kernel, linux-kernel
On Sat, 21 May 2022 15:07:16 -0400, Tom Rix wrote:
> cppcheck reports
> [drivers/gpu/drm/rockchip/rockchip_drm_vop.c:186]: (style) The function 'vop_writel' is never used.
>
> vop_writel is static function that is not used, so remove it.
Applied, thanks!
[1/1] drm/rockchip: remove vop_writel
commit: 98a65e6d498c46b0beec7a40aac4b3e404642993
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/rockchip: remove vop_writel
@ 2022-09-15 13:40 ` Heiko Stuebner
0 siblings, 0 replies; 8+ messages in thread
From: Heiko Stuebner @ 2022-09-15 13:40 UTC (permalink / raw)
To: Tom Rix, airlied, hjc, daniel
Cc: Heiko Stuebner, linux-arm-kernel, dri-devel, linux-kernel,
linux-rockchip
On Sat, 21 May 2022 15:07:16 -0400, Tom Rix wrote:
> cppcheck reports
> [drivers/gpu/drm/rockchip/rockchip_drm_vop.c:186]: (style) The function 'vop_writel' is never used.
>
> vop_writel is static function that is not used, so remove it.
Applied, thanks!
[1/1] drm/rockchip: remove vop_writel
commit: 98a65e6d498c46b0beec7a40aac4b3e404642993
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 8+ messages in thread