All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2] include/configs: Remove rootwait=1 to all the affected boards
@ 2022-05-22 13:22 Michael Trimarchi
  2022-05-23  4:34 ` Heiko Schocher
  2022-06-07 16:47 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Trimarchi @ 2022-05-22 13:22 UTC (permalink / raw)
  To: Yegor Yefremov, Marcin Niestroj, Ariel D'Alessandro,
	Chris Packham, Wolfgang Denk, Stefan Roese, Rick Chen,
	Heiko Schocher, Simon Glass, Lokesh Vutla, open list
  Cc: linux-amarula, open list

rootwait=1 is not a valid kernel boot parameters. According
to the documenation is only rootwait

rootwait	[KNL]	Wait (indefinitely) for root device to show up.
			Useful for devices that are detected asynchronously
			(e.g. USB and MMC devices).

Fix:
Unknown kernel command line parameters "rootwait=1", will be passed to user space.

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
Changes V1->V2:
	- Add ti/nand.h
---
 include/configs/am335x_evm.h           | 2 +-
 include/configs/am43xx_evm.h           | 2 +-
 include/configs/baltos.h               | 2 +-
 include/configs/chiliboard.h           | 2 +-
 include/configs/etamin.h               | 2 +-
 include/configs/imx8mn_bsh_smm_s2.h    | 2 +-
 include/configs/siemens-am33x-common.h | 4 ++--
 include/configs/ti_armv7_keystone2.h   | 2 +-
 include/environment/ti/nand.h          | 2 +-
 9 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h
index fd5b209a52..f301a6dc83 100644
--- a/include/configs/am335x_evm.h
+++ b/include/configs/am335x_evm.h
@@ -34,7 +34,7 @@
 		"root=${nandroot} " \
 		"rootfstype=${nandrootfstype}\0" \
 	"nandroot=ubi0:rootfs rw ubi.mtd=NAND.file-system,2048\0" \
-	"nandrootfstype=ubifs rootwait=1\0" \
+	"nandrootfstype=ubifs rootwait\0" \
 	"nandboot=echo Booting from nand ...; " \
 		"run nandargs; " \
 		"nand read ${fdtaddr} NAND.u-boot-spl-os; " \
diff --git a/include/configs/am43xx_evm.h b/include/configs/am43xx_evm.h
index 5057441f75..1f5c3cd04e 100644
--- a/include/configs/am43xx_evm.h
+++ b/include/configs/am43xx_evm.h
@@ -166,7 +166,7 @@
 		"root=${nandroot} " \
 		"rootfstype=${nandrootfstype}\0" \
 	"nandroot=ubi0:rootfs rw ubi.mtd=NAND.file-system,4096\0" \
-	"nandrootfstype=ubifs rootwait=1\0" \
+	"nandrootfstype=ubifs rootwait\0" \
 	"nandboot=echo Booting from nand ...; " \
 		"run nandargs; " \
 		"nand read ${fdtaddr} NAND.u-boot-spl-os; " \
diff --git a/include/configs/baltos.h b/include/configs/baltos.h
index b881d8c03f..7b43741fde 100644
--- a/include/configs/baltos.h
+++ b/include/configs/baltos.h
@@ -37,7 +37,7 @@
 		"root=${nandroot} " \
 		"rootfstype=${nandrootfstype}\0" \
 	"nandroot=ubi0:rootfs rw ubi.mtd=5\0" \
-	"nandrootfstype=ubifs rootwait=1\0" \
+	"nandrootfstype=ubifs rootwait\0" \
 	"nandboot=echo Booting from nand ...; " \
 		"run nandargs; " \
 		"setenv loadaddr 0x84000000; " \
diff --git a/include/configs/chiliboard.h b/include/configs/chiliboard.h
index 82acda595f..8bad0f9ac4 100644
--- a/include/configs/chiliboard.h
+++ b/include/configs/chiliboard.h
@@ -20,7 +20,7 @@
 		"root=${nandroot} " \
 		"rootfstype=${nandrootfstype}\0" \
 	"nandroot=ubi0:rootfs rw ubi.mtd=NAND.file-system\0" \
-	"nandrootfstype=ubifs rootwait=1\0" \
+	"nandrootfstype=ubifs rootwait\0" \
 	"nandboot=echo Booting from nand ...; " \
 		"run nandargs; " \
 		"nand read ${fdt_addr} NAND.u-boot-spl-os; " \
diff --git a/include/configs/etamin.h b/include/configs/etamin.h
index 9cf93924df..1c0a86d1ed 100644
--- a/include/configs/etamin.h
+++ b/include/configs/etamin.h
@@ -113,7 +113,7 @@
 	"nand_active_ubi_vol=rootfs_a\0" \
 	"rootfs_name=rootfs\0" \
 	"kernel_name=uImage\0"\
-	"nand_root_fs_type=ubifs rootwait=1\0" \
+	"nand_root_fs_type=ubifs rootwait\0" \
 	"nand_args=run bootargs_defaults;" \
 		"mtdparts default;" \
 		"setenv ${partitionset_active} true;" \
diff --git a/include/configs/imx8mn_bsh_smm_s2.h b/include/configs/imx8mn_bsh_smm_s2.h
index 098f23b206..f752978369 100644
--- a/include/configs/imx8mn_bsh_smm_s2.h
+++ b/include/configs/imx8mn_bsh_smm_s2.h
@@ -21,7 +21,7 @@
 		"root=${nandroot} " \
 		"rootfstype=${nandrootfstype}\0" \
 	"nandroot=ubi0:root rw ubi.mtd=nandrootfs\0" \
-	"nandrootfstype=ubifs rootwait=1\0" \
+	"nandrootfstype=ubifs rootwait\0" \
 	"nandboot=echo Booting from nand ...; " \
 		"run nandargs; " \
 		"nand read ${fdt_addr_r} nanddtb; " \
diff --git a/include/configs/siemens-am33x-common.h b/include/configs/siemens-am33x-common.h
index 08c4d52d65..9f1a6cd51b 100644
--- a/include/configs/siemens-am33x-common.h
+++ b/include/configs/siemens-am33x-common.h
@@ -237,7 +237,7 @@
 	"nand_active_ubi_vol=rootfs_a\0" \
 	"nand_active_ubi_vol_A=rootfs_a\0" \
 	"nand_active_ubi_vol_B=rootfs_b\0" \
-	"nand_root_fs_type=ubifs rootwait=1\0" \
+	"nand_root_fs_type=ubifs rootwait\0" \
 	"nand_src_addr=0x280000\0" \
 	"nand_src_addr_A=0x280000\0" \
 	"nand_src_addr_B=0x780000\0" \
@@ -314,7 +314,7 @@
 	"nand_active_ubi_vol=rootfs_a\0" \
 	"rootfs_name=rootfs\0" \
 	"kernel_name=uImage\0"\
-	"nand_root_fs_type=ubifs rootwait=1\0" \
+	"nand_root_fs_type=ubifs rootwait\0" \
 	"nand_args=run bootargs_defaults;" \
 		"mtdparts default;" \
 		"setenv ${partitionset_active} true;" \
diff --git a/include/configs/ti_armv7_keystone2.h b/include/configs/ti_armv7_keystone2.h
index 57f013cbf8..133daecf71 100644
--- a/include/configs/ti_armv7_keystone2.h
+++ b/include/configs/ti_armv7_keystone2.h
@@ -180,7 +180,7 @@
 		"sf write ${loadaddr} 0 ${filesize}\0"		\
 	"burn_uboot_nand=nand erase 0 0x100000; "			\
 		"nand write ${loadaddr} 0 ${filesize}\0"		\
-	"args_all=setenv bootargs console=ttyS0,115200n8 rootwait=1 "	\
+	"args_all=setenv bootargs console=ttyS0,115200n8 rootwait "	\
 		KERNEL_MTD_PARTS					\
 	"args_net=setenv bootargs ${bootargs} rootfstype=nfs "		\
 		"root=/dev/nfs rw nfsroot=${serverip}:${nfs_root},"	\
diff --git a/include/environment/ti/nand.h b/include/environment/ti/nand.h
index 11dcefcc41..7d00afa2b1 100644
--- a/include/environment/ti/nand.h
+++ b/include/environment/ti/nand.h
@@ -14,7 +14,7 @@
 		"root=${nandroot} " \
 		"rootfstype=${nandrootfstype}\0" \
 	"nandroot=ubi0:rootfs rw ubi.mtd=NAND.file-system,2048\0" \
-	"nandrootfstype=ubifs rootwait=1\0" \
+	"nandrootfstype=ubifs rootwait\0" \
 	"nandboot=echo Booting from nand ...; " \
 		"run nandargs; " \
 		"nand read ${fdtaddr} NAND.u-boot-spl-os; " \
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH V2] include/configs: Remove rootwait=1 to all the affected boards
  2022-05-22 13:22 [PATCH V2] include/configs: Remove rootwait=1 to all the affected boards Michael Trimarchi
@ 2022-05-23  4:34 ` Heiko Schocher
  2022-06-07 16:47 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Heiko Schocher @ 2022-05-23  4:34 UTC (permalink / raw)
  To: Michael Trimarchi, Yegor Yefremov, Marcin Niestroj,
	Ariel D'Alessandro, Chris Packham, Wolfgang Denk,
	Stefan Roese, Rick Chen, Simon Glass, Lokesh Vutla, open list
  Cc: linux-amarula

Hello Michael,

On 22.05.22 15:22, Michael Trimarchi wrote:
> rootwait=1 is not a valid kernel boot parameters. According
> to the documenation is only rootwait
> 
> rootwait	[KNL]	Wait (indefinitely) for root device to show up.
> 			Useful for devices that are detected asynchronously
> 			(e.g. USB and MMC devices).
> 
> Fix:
> Unknown kernel command line parameters "rootwait=1", will be passed to user space.
> 
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
> Changes V1->V2:
> 	- Add ti/nand.h
> ---
>  include/configs/am335x_evm.h           | 2 +-
>  include/configs/am43xx_evm.h           | 2 +-
>  include/configs/baltos.h               | 2 +-
>  include/configs/chiliboard.h           | 2 +-
>  include/configs/etamin.h               | 2 +-
>  include/configs/imx8mn_bsh_smm_s2.h    | 2 +-
>  include/configs/siemens-am33x-common.h | 4 ++--
>  include/configs/ti_armv7_keystone2.h   | 2 +-
>  include/environment/ti/nand.h          | 2 +-
>  9 files changed, 10 insertions(+), 10 deletions(-)

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH V2] include/configs: Remove rootwait=1 to all the affected boards
  2022-05-22 13:22 [PATCH V2] include/configs: Remove rootwait=1 to all the affected boards Michael Trimarchi
  2022-05-23  4:34 ` Heiko Schocher
@ 2022-06-07 16:47 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2022-06-07 16:47 UTC (permalink / raw)
  To: Michael Trimarchi
  Cc: Yegor Yefremov, Marcin Niestroj, Ariel D'Alessandro,
	Chris Packham, Wolfgang Denk, Stefan Roese, Rick Chen,
	Heiko Schocher, Simon Glass, Lokesh Vutla, open list,
	linux-amarula

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

On Sun, May 22, 2022 at 03:22:08PM +0200, Michael Trimarchi wrote:

> rootwait=1 is not a valid kernel boot parameters. According
> to the documenation is only rootwait
> 
> rootwait	[KNL]	Wait (indefinitely) for root device to show up.
> 			Useful for devices that are detected asynchronously
> 			(e.g. USB and MMC devices).
> 
> Fix:
> Unknown kernel command line parameters "rootwait=1", will be passed to user space.
> 
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Reviewed-by: Heiko Schocher <hs@denx.de>

Applied to u-boot/next, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-07 16:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-22 13:22 [PATCH V2] include/configs: Remove rootwait=1 to all the affected boards Michael Trimarchi
2022-05-23  4:34 ` Heiko Schocher
2022-06-07 16:47 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.