* [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_exec_create
@ 2022-05-23 12:19 sai.gowtham.ch
2022-05-23 12:19 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_create: Added test description for test case sai.gowtham.ch
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: sai.gowtham.ch @ 2022-05-23 12:19 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Add test description to gem_exec_create
Sai Gowtham Ch (2):
i915/gem_exec_create: Added test description for test case.
HAX: don't do full run
tests/i915/gem_exec_create.c | 10 ++
tests/intel-ci/fast-feedback.testlist | 184 --------------------------
2 files changed, 10 insertions(+), 184 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_create: Added test description for test case.
2022-05-23 12:19 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_exec_create sai.gowtham.ch
@ 2022-05-23 12:19 ` sai.gowtham.ch
2022-05-25 15:23 ` Kamil Konieczny
2022-05-23 12:19 ` [igt-dev] [PATCH i-g-t 2/2] HAX: don't do full run sai.gowtham.ch
2022-05-23 15:47 ` [igt-dev] ✗ GitLab.Pipeline: warning for HAX add description to gem_exec_create Patchwork
2 siblings, 1 reply; 8+ messages in thread
From: sai.gowtham.ch @ 2022-05-23 12:19 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Added test description for all the subtests that are available.
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
---
tests/i915/gem_exec_create.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/tests/i915/gem_exec_create.c b/tests/i915/gem_exec_create.c
index 78d5ffb3..fd09ef02 100644
--- a/tests/i915/gem_exec_create.c
+++ b/tests/i915/gem_exec_create.c
@@ -47,6 +47,10 @@
#include "i915_drm.h"
#include "i915/intel_memory_region.h"
+IGT_TEST_DESCRIPTION("\n This test overloads the driver with transient active "
+ "objects and checks if we don't kill the system under the "
+ "mempressure. Some of the symptoms this test look for include "
+ "mysterious hangs.");
#define ENGINE_FLAGS (I915_EXEC_RING_MASK | I915_EXEC_BSD_MASK)
static double elapsed(const struct timespec *start, const struct timespec *end)
@@ -166,6 +170,7 @@ igt_main
I915_DEVICE_MEMORY);
}
+ igt_describe("Checks if we kill the systems by overloading it with active objects");
igt_subtest_with_dynamic("legacy")
for_each_combination(regions, 1, set) {
char *sub_name = memregion_dynamic_subtest_name(regions);
@@ -177,6 +182,7 @@ igt_main
free(sub_name);
}
+ igt_describe("Quick sanitycheck of the above test setup iterating over engines");
igt_subtest_with_dynamic("basic")
for_each_combination(regions, 1, set) {
char *sub_name = memregion_dynamic_subtest_name(regions);
@@ -188,6 +194,7 @@ igt_main
free(sub_name);
}
+ igt_describe("This test does a concurrent execution");
igt_subtest_with_dynamic("forked")
for_each_combination(regions, 1, set) {
char *sub_name = memregion_dynamic_subtest_name(regions);
@@ -199,6 +206,9 @@ igt_main
free(sub_name);
}
+
+ igt_describe("This test does a forced reclaim, behaving like a bad application"
+ " leaking its bo cache");
igt_subtest_with_dynamic("madvise")
for_each_combination(regions, 1, set) {
char *sub_name = memregion_dynamic_subtest_name(regions);
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_create: Added test description for test case.
2022-05-23 12:19 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_create: Added test description for test case sai.gowtham.ch
@ 2022-05-25 15:23 ` Kamil Konieczny
0 siblings, 0 replies; 8+ messages in thread
From: Kamil Konieczny @ 2022-05-25 15:23 UTC (permalink / raw)
To: igt-dev; +Cc: Sai Gowtham Ch
Hi Sai,
On 2022-05-23 at 17:49:15 +0530, sai.gowtham.ch@intel.com wrote:
> From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
>
> Added test description for all the subtests that are available.
>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
> ---
> tests/i915/gem_exec_create.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/tests/i915/gem_exec_create.c b/tests/i915/gem_exec_create.c
> index 78d5ffb3..fd09ef02 100644
> --- a/tests/i915/gem_exec_create.c
> +++ b/tests/i915/gem_exec_create.c
> @@ -47,6 +47,10 @@
> #include "i915_drm.h"
> #include "i915/intel_memory_region.h"
>
> +IGT_TEST_DESCRIPTION("\n This test overloads the driver with transient active "
------------------------ ^ ^
Remove these white chars from beginning.
> + "objects and checks if we don't kill the system under the "
> + "mempressure. Some of the symptoms this test look for include "
---------------- ^
s/mempressure/memory pressure/
> + "mysterious hangs.");
> #define ENGINE_FLAGS (I915_EXEC_RING_MASK | I915_EXEC_BSD_MASK)
>
> static double elapsed(const struct timespec *start, const struct timespec *end)
> @@ -166,6 +170,7 @@ igt_main
> I915_DEVICE_MEMORY);
> }
>
> + igt_describe("Checks if we kill the systems by overloading it with active objects");
s/systems/system/
Please add use of only legacy engines here.
> igt_subtest_with_dynamic("legacy")
> for_each_combination(regions, 1, set) {
> char *sub_name = memregion_dynamic_subtest_name(regions);
> @@ -177,6 +182,7 @@ igt_main
> free(sub_name);
> }
>
> + igt_describe("Quick sanitycheck of the above test setup iterating over engines");
Please do not make remarks about "above test", order can change
later, so
s/sanitycheck/sanity check/
s/of the above test setup//
s/over/over all/
> igt_subtest_with_dynamic("basic")
> for_each_combination(regions, 1, set) {
> char *sub_name = memregion_dynamic_subtest_name(regions);
> @@ -188,6 +194,7 @@ igt_main
> free(sub_name);
> }
>
> + igt_describe("This test does a concurrent execution");
Please find better description here.
> igt_subtest_with_dynamic("forked")
> for_each_combination(regions, 1, set) {
> char *sub_name = memregion_dynamic_subtest_name(regions);
> @@ -199,6 +206,9 @@ igt_main
> free(sub_name);
> }
>
> +
> + igt_describe("This test does a forced reclaim, behaving like a bad application"
> + " leaking its bo cache");
> igt_subtest_with_dynamic("madvise")
> for_each_combination(regions, 1, set) {
> char *sub_name = memregion_dynamic_subtest_name(regions);
> --
> 2.35.1
>
BR,
Kamil
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] HAX: don't do full run
2022-05-23 12:19 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_exec_create sai.gowtham.ch
2022-05-23 12:19 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_create: Added test description for test case sai.gowtham.ch
@ 2022-05-23 12:19 ` sai.gowtham.ch
2022-05-23 15:47 ` [igt-dev] ✗ GitLab.Pipeline: warning for HAX add description to gem_exec_create Patchwork
2 siblings, 0 replies; 8+ messages in thread
From: sai.gowtham.ch @ 2022-05-23 12:19 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Just for test description, no full run is necessary
Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
---
tests/intel-ci/fast-feedback.testlist | 184 --------------------------
1 file changed, 184 deletions(-)
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index b579c20a..e69de29b 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -1,184 +0,0 @@
-# Keep alphabetically sorted by default
-
-igt@core_auth@basic-auth
-igt@debugfs_test@read_all_entries
-igt@fbdev@eof
-igt@fbdev@info
-igt@fbdev@nullptr
-igt@fbdev@read
-igt@fbdev@write
-igt@gem_basic@bad-close
-igt@gem_basic@create-close
-igt@gem_basic@create-fd-close
-igt@gem_busy@busy@all
-igt@gem_close_race@basic-process
-igt@gem_close_race@basic-threads
-igt@gem_ctx_create@basic
-igt@gem_ctx_create@basic-files
-igt@gem_ctx_exec@basic
-igt@gem_exec_basic@basic
-igt@gem_exec_create@basic
-igt@gem_exec_fence@basic-busy
-igt@gem_exec_fence@basic-wait
-igt@gem_exec_fence@basic-await
-igt@gem_exec_fence@nb-await
-igt@gem_exec_gttfill@basic
-igt@gem_exec_parallel@engines
-igt@gem_exec_store@basic
-igt@gem_flink_basic@bad-flink
-igt@gem_flink_basic@bad-open
-igt@gem_flink_basic@basic
-igt@gem_flink_basic@double-flink
-igt@gem_flink_basic@flink-lifetime
-igt@gem_huc_copy@huc-copy
-igt@gem_linear_blits@basic
-igt@gem_mmap@basic
-igt@gem_mmap_gtt@basic
-igt@gem_render_linear_blits@basic
-igt@gem_render_tiled_blits@basic
-igt@gem_ringfill@basic-all
-igt@gem_softpin@allocator-basic
-igt@gem_softpin@allocator-basic-reserve
-igt@gem_softpin@safe-alignment
-igt@gem_sync@basic-all
-igt@gem_sync@basic-each
-igt@gem_tiled_blits@basic
-igt@gem_tiled_fence_blits@basic
-igt@gem_tiled_pread_basic
-igt@gem_wait@busy@all
-igt@gem_wait@wait@all
-igt@i915_getparams_basic@basic-eu-total
-igt@i915_getparams_basic@basic-subslice-total
-igt@i915_hangman@error-state-basic
-igt@kms_addfb_basic@addfb25-bad-modifier
-igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling
-igt@kms_addfb_basic@addfb25-modifier-no-flag
-igt@kms_addfb_basic@addfb25-x-tiled-legacy
-igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy
-igt@kms_addfb_basic@addfb25-yf-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-small-legacy
-igt@kms_addfb_basic@bad-pitch-0
-igt@kms_addfb_basic@bad-pitch-1024
-igt@kms_addfb_basic@bad-pitch-128
-igt@kms_addfb_basic@bad-pitch-256
-igt@kms_addfb_basic@bad-pitch-32
-igt@kms_addfb_basic@bad-pitch-63
-igt@kms_addfb_basic@bad-pitch-65536
-igt@kms_addfb_basic@bad-pitch-999
-igt@kms_addfb_basic@basic
-igt@kms_addfb_basic@basic-x-tiled-legacy
-igt@kms_addfb_basic@basic-y-tiled-legacy
-igt@kms_addfb_basic@bo-too-small
-igt@kms_addfb_basic@bo-too-small-due-to-tiling
-igt@kms_addfb_basic@clobberred-modifier
-igt@kms_addfb_basic@framebuffer-vs-set-tiling
-igt@kms_addfb_basic@invalid-get-prop
-igt@kms_addfb_basic@invalid-get-prop-any
-igt@kms_addfb_basic@invalid-set-prop
-igt@kms_addfb_basic@invalid-set-prop-any
-igt@kms_addfb_basic@no-handle
-igt@kms_addfb_basic@size-max
-igt@kms_addfb_basic@small-bo
-igt@kms_addfb_basic@tile-pitch-mismatch
-igt@kms_addfb_basic@too-high
-igt@kms_addfb_basic@too-wide
-igt@kms_addfb_basic@unused-handle
-igt@kms_addfb_basic@unused-modifier
-igt@kms_addfb_basic@unused-offsets
-igt@kms_addfb_basic@unused-pitches
-igt@kms_busy@basic
-igt@kms_chamelium@dp-hpd-fast
-igt@kms_chamelium@dp-edid-read
-igt@kms_chamelium@dp-crc-fast
-igt@kms_chamelium@hdmi-hpd-fast
-igt@kms_chamelium@hdmi-edid-read
-igt@kms_chamelium@hdmi-crc-fast
-igt@kms_chamelium@vga-hpd-fast
-igt@kms_chamelium@vga-edid-read
-igt@kms_prop_blob@basic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-after-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size
-igt@kms_cursor_legacy@basic-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size
-igt@kms_flip@basic-flip-vs-dpms
-igt@kms_flip@basic-flip-vs-modeset
-igt@kms_flip@basic-flip-vs-wf_vblank
-igt@kms_flip@basic-plain-flip
-igt@kms_force_connector_basic@force-connector-state
-igt@kms_force_connector_basic@force-edid
-igt@kms_force_connector_basic@force-load-detect
-igt@kms_force_connector_basic@prune-stale-modes
-igt@kms_frontbuffer_tracking@basic
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d
-igt@kms_pipe_crc_basic@hang-read-crc-pipe-a
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence
-igt@kms_pipe_crc_basic@read-crc-pipe-a
-igt@kms_pipe_crc_basic@read-crc-pipe-b
-igt@kms_pipe_crc_basic@read-crc-pipe-c
-igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence
-igt@kms_psr@primary_page_flip
-igt@kms_psr@cursor_plane_move
-igt@kms_psr@sprite_plane_onoff
-igt@kms_psr@primary_mmap_gtt
-igt@kms_setmode@basic-clone-single-crtc
-igt@i915_pm_backlight@basic-brightness
-igt@i915_pm_rpm@basic-pci-d3-state
-igt@i915_pm_rpm@basic-rte
-igt@i915_pm_rps@basic-api
-igt@prime_self_import@basic-llseek-bad
-igt@prime_self_import@basic-llseek-size
-igt@prime_self_import@basic-with_fd_dup
-igt@prime_self_import@basic-with_one_bo
-igt@prime_self_import@basic-with_one_bo_two_files
-igt@prime_self_import@basic-with_two_bos
-igt@prime_vgem@basic-fence-flip
-igt@prime_vgem@basic-fence-mmap
-igt@prime_vgem@basic-fence-read
-igt@prime_vgem@basic-gtt
-igt@prime_vgem@basic-read
-igt@prime_vgem@basic-write
-igt@prime_vgem@basic-userptr
-igt@vgem_basic@setversion
-igt@vgem_basic@create
-igt@vgem_basic@debugfs
-igt@vgem_basic@dmabuf-export
-igt@vgem_basic@dmabuf-fence
-igt@vgem_basic@dmabuf-fence-before
-igt@vgem_basic@dmabuf-mmap
-igt@vgem_basic@mmap
-igt@vgem_basic@second-client
-igt@vgem_basic@sysfs
-
-# All tests that do module unloading and reloading are executed last.
-# They will sometimes reveal issues of earlier tests leaving the
-# driver in a broken state that is not otherwise noticed in that test.
-
-igt@core_hotunplug@unbind-rebind
-igt@vgem_basic@unload
-igt@i915_module_load@reload
-igt@gem_lmem_swapping@basic
-igt@gem_lmem_swapping@parallel-random-engines
-igt@gem_lmem_swapping@random-engines
-igt@gem_lmem_swapping@verify-random
-igt@i915_pm_rpm@module-reload
-
-# Kernel selftests
-igt@i915_selftest@live
-igt@dmabuf@all
-
-# System wide suspend tests
-igt@i915_suspend@basic-s2idle-without-i915
-igt@i915_suspend@basic-s3-without-i915
-igt@gem_exec_suspend@basic-s0
-igt@gem_exec_suspend@basic-s3
-igt@kms_chamelium@common-hpd-after-suspend
-igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] ✗ GitLab.Pipeline: warning for HAX add description to gem_exec_create
2022-05-23 12:19 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_exec_create sai.gowtham.ch
2022-05-23 12:19 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_create: Added test description for test case sai.gowtham.ch
2022-05-23 12:19 ` [igt-dev] [PATCH i-g-t 2/2] HAX: don't do full run sai.gowtham.ch
@ 2022-05-23 15:47 ` Patchwork
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-05-23 15:47 UTC (permalink / raw)
To: sai.gowtham.ch; +Cc: igt-dev
== Series Details ==
Series: HAX add description to gem_exec_create
URL : https://patchwork.freedesktop.org/series/104282/
State : warning
== Summary ==
Pipeline status: FAILED.
see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/593922 for the overview.
test:ninja-test-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/23051507):
Ok: 22
Expected Fail: 3
Fail: 289
Unexpected Pass: 0
Skipped: 0
Timeout: 0
Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
section_end:1653320668:step_script
section_start:1653320668:upload_artifacts_on_failure
Uploading artifacts for failed job
Uploading artifacts...
build: found 1728 matching files and directories
Uploading artifacts as "archive" to coordinator... 201 Created id=23051507 responseStatus=201 Created token=agGiueeX
section_end:1653320681:upload_artifacts_on_failure
section_start:1653320681:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1653320681:cleanup_file_variables
ERROR: Job failed: exit code 1
== Logs ==
For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/593922
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_exec_create
@ 2022-06-26 18:42 sai.gowtham.ch
2022-06-26 18:42 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_create: Added test description for test case sai.gowtham.ch
0 siblings, 1 reply; 8+ messages in thread
From: sai.gowtham.ch @ 2022-06-26 18:42 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Add test description to gem_exec_create.
Sai Gowtham Ch (2):
i915/gem_exec_create: Added test description for test case.
HAX: don't do full run
tests/i915/gem_exec_create.c | 14 ++
tests/intel-ci/fast-feedback.testlist | 177 --------------------------
2 files changed, 14 insertions(+), 177 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_create: Added test description for test case.
2022-06-26 18:42 [igt-dev] [PATCH i-g-t 0/2] " sai.gowtham.ch
@ 2022-06-26 18:42 ` sai.gowtham.ch
2022-06-27 14:13 ` Kamil Konieczny
0 siblings, 1 reply; 8+ messages in thread
From: sai.gowtham.ch @ 2022-06-26 18:42 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Added test description for all the subtests that are available.
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
---
tests/i915/gem_exec_create.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/tests/i915/gem_exec_create.c b/tests/i915/gem_exec_create.c
index 78d5ffb3..55773243 100644
--- a/tests/i915/gem_exec_create.c
+++ b/tests/i915/gem_exec_create.c
@@ -47,6 +47,11 @@
#include "i915_drm.h"
#include "i915/intel_memory_region.h"
+IGT_TEST_DESCRIPTION("This test overloads the driver with transient active"
+ " objects and checks if we don't kill the system under the"
+ " memory pressure. Some of the symptoms this test look for include"
+ " mysterious hangs.");
+
#define ENGINE_FLAGS (I915_EXEC_RING_MASK | I915_EXEC_BSD_MASK)
static double elapsed(const struct timespec *start, const struct timespec *end)
@@ -166,6 +171,8 @@ igt_main
I915_DEVICE_MEMORY);
}
+ igt_describe("Check if we kill the system by overloading it with active objects"
+ " iterating over legacy engines.");
igt_subtest_with_dynamic("legacy")
for_each_combination(regions, 1, set) {
char *sub_name = memregion_dynamic_subtest_name(regions);
@@ -177,6 +184,8 @@ igt_main
free(sub_name);
}
+ igt_describe("Check if we kill system by overloading it with active objects"
+ " iterating over all engines.");
igt_subtest_with_dynamic("basic")
for_each_combination(regions, 1, set) {
char *sub_name = memregion_dynamic_subtest_name(regions);
@@ -188,6 +197,8 @@ igt_main
free(sub_name);
}
+ igt_describe("Concurrently overloads system with active objects and checks"
+ " if we kill system");
igt_subtest_with_dynamic("forked")
for_each_combination(regions, 1, set) {
char *sub_name = memregion_dynamic_subtest_name(regions);
@@ -199,6 +210,9 @@ igt_main
free(sub_name);
}
+
+ igt_describe("This test does a forced reclaim, behaving like a bad application"
+ " leaking its bo cache");
igt_subtest_with_dynamic("madvise")
for_each_combination(regions, 1, set) {
char *sub_name = memregion_dynamic_subtest_name(regions);
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_create: Added test description for test case.
2022-06-26 18:42 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_create: Added test description for test case sai.gowtham.ch
@ 2022-06-27 14:13 ` Kamil Konieczny
0 siblings, 0 replies; 8+ messages in thread
From: Kamil Konieczny @ 2022-06-27 14:13 UTC (permalink / raw)
To: igt-dev; +Cc: Sai Gowtham Ch
Hi Sai,
On 2022-06-27 at 00:12:44 +0530, sai.gowtham.ch@intel.com wrote:
> From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
>
> Added test description for all the subtests that are available.
>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
> ---
> tests/i915/gem_exec_create.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/tests/i915/gem_exec_create.c b/tests/i915/gem_exec_create.c
> index 78d5ffb3..55773243 100644
> --- a/tests/i915/gem_exec_create.c
> +++ b/tests/i915/gem_exec_create.c
> @@ -47,6 +47,11 @@
> #include "i915_drm.h"
> #include "i915/intel_memory_region.h"
>
> +IGT_TEST_DESCRIPTION("This test overloads the driver with transient active"
----------------------- ^
> + " objects and checks if we don't kill the system under the"
--------------- ^
Please align this and following two lines to one above.
> + " memory pressure. Some of the symptoms this test look for include"
> + " mysterious hangs.");
> +
> #define ENGINE_FLAGS (I915_EXEC_RING_MASK | I915_EXEC_BSD_MASK)
>
> static double elapsed(const struct timespec *start, const struct timespec *end)
> @@ -166,6 +171,8 @@ igt_main
> I915_DEVICE_MEMORY);
> }
>
> + igt_describe("Check if we kill the system by overloading it with active objects"
> + " iterating over legacy engines.");
> igt_subtest_with_dynamic("legacy")
> for_each_combination(regions, 1, set) {
> char *sub_name = memregion_dynamic_subtest_name(regions);
> @@ -177,6 +184,8 @@ igt_main
> free(sub_name);
> }
>
> + igt_describe("Check if we kill system by overloading it with active objects"
> + " iterating over all engines.");
> igt_subtest_with_dynamic("basic")
> for_each_combination(regions, 1, set) {
> char *sub_name = memregion_dynamic_subtest_name(regions);
> @@ -188,6 +197,8 @@ igt_main
> free(sub_name);
> }
>
> + igt_describe("Concurrently overloads system with active objects and checks"
> + " if we kill system");
--------------------------------------- ^
Add dot here at the end of sentence.
> igt_subtest_with_dynamic("forked")
> for_each_combination(regions, 1, set) {
> char *sub_name = memregion_dynamic_subtest_name(regions);
> @@ -199,6 +210,9 @@ igt_main
> free(sub_name);
> }
>
> +
> + igt_describe("This test does a forced reclaim, behaving like a bad application"
> + " leaking its bo cache");
------------------------------------------ ^
Same here, add dot.
With that fixed you can add my r-b tag.
Regards,
Kamil
> igt_subtest_with_dynamic("madvise")
> for_each_combination(regions, 1, set) {
> char *sub_name = memregion_dynamic_subtest_name(regions);
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_exec_create
@ 2022-06-28 4:43 sai.gowtham.ch
2022-06-28 4:43 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_create: Added test description for test case sai.gowtham.ch
0 siblings, 1 reply; 8+ messages in thread
From: sai.gowtham.ch @ 2022-06-28 4:43 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Add test description to gem_exec_create.
Sai Gowtham Ch (2):
i915/gem_exec_create: Added test description for test case.
HAX: don't do full run
tests/i915/gem_exec_create.c | 13 ++
tests/intel-ci/fast-feedback.testlist | 178 +-------------------------
2 files changed, 14 insertions(+), 177 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_create: Added test description for test case.
2022-06-28 4:43 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_exec_create sai.gowtham.ch
@ 2022-06-28 4:43 ` sai.gowtham.ch
0 siblings, 0 replies; 8+ messages in thread
From: sai.gowtham.ch @ 2022-06-28 4:43 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Added test description for all the subtests that are available.
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
tests/i915/gem_exec_create.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/tests/i915/gem_exec_create.c b/tests/i915/gem_exec_create.c
index 78d5ffb3..449aa5b2 100644
--- a/tests/i915/gem_exec_create.c
+++ b/tests/i915/gem_exec_create.c
@@ -47,6 +47,10 @@
#include "i915_drm.h"
#include "i915/intel_memory_region.h"
+IGT_TEST_DESCRIPTION("This test overloads the driver with transient active objects"
+ " and checks if we don't kill the system under the memory pressure"
+ " some of the symptoms this test look for include mysterious hangs.");
+
#define ENGINE_FLAGS (I915_EXEC_RING_MASK | I915_EXEC_BSD_MASK)
static double elapsed(const struct timespec *start, const struct timespec *end)
@@ -166,6 +170,8 @@ igt_main
I915_DEVICE_MEMORY);
}
+ igt_describe("Check if we kill the system by overloading it with active objects"
+ " iterating over legacy engines.");
igt_subtest_with_dynamic("legacy")
for_each_combination(regions, 1, set) {
char *sub_name = memregion_dynamic_subtest_name(regions);
@@ -177,6 +183,8 @@ igt_main
free(sub_name);
}
+ igt_describe("Check if we kill system by overloading it with active objects"
+ " iterating over all engines.");
igt_subtest_with_dynamic("basic")
for_each_combination(regions, 1, set) {
char *sub_name = memregion_dynamic_subtest_name(regions);
@@ -188,6 +196,8 @@ igt_main
free(sub_name);
}
+ igt_describe("Concurrently overloads system with active objects and checks"
+ " if we kill system.");
igt_subtest_with_dynamic("forked")
for_each_combination(regions, 1, set) {
char *sub_name = memregion_dynamic_subtest_name(regions);
@@ -199,6 +209,9 @@ igt_main
free(sub_name);
}
+
+ igt_describe("This test does a forced reclaim, behaving like a bad application"
+ " leaking its bo cache.");
igt_subtest_with_dynamic("madvise")
for_each_combination(regions, 1, set) {
char *sub_name = memregion_dynamic_subtest_name(regions);
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-06-28 4:44 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-23 12:19 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_exec_create sai.gowtham.ch
2022-05-23 12:19 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_create: Added test description for test case sai.gowtham.ch
2022-05-25 15:23 ` Kamil Konieczny
2022-05-23 12:19 ` [igt-dev] [PATCH i-g-t 2/2] HAX: don't do full run sai.gowtham.ch
2022-05-23 15:47 ` [igt-dev] ✗ GitLab.Pipeline: warning for HAX add description to gem_exec_create Patchwork
2022-06-26 18:42 [igt-dev] [PATCH i-g-t 0/2] " sai.gowtham.ch
2022-06-26 18:42 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_create: Added test description for test case sai.gowtham.ch
2022-06-27 14:13 ` Kamil Konieczny
2022-06-28 4:43 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_exec_create sai.gowtham.ch
2022-06-28 4:43 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_create: Added test description for test case sai.gowtham.ch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.