* [PATCH] can: ctucanfd: platform: add missing dependency to HAS_IOMEM
@ 2022-05-23 12:37 Marc Kleine-Budde
2022-05-23 15:15 ` Pavel Pisa
0 siblings, 1 reply; 2+ messages in thread
From: Marc Kleine-Budde @ 2022-05-23 12:37 UTC (permalink / raw)
To: linux-can; +Cc: Marc Kleine-Budde, kernel test robot, Pavel Pisa, Ondrej Ille
The kernel test robot noticed that the ctucanfd platform driver fails
during modpost on platforms that don't support IOMEM.
| ERROR: modpost: "devm_ioremap_resource" [drivers/net/can/ctucanfd/ctucanfd_platform.ko] undefined!
This patch adds the missing HAS_IOMEM dependency.
Fixes: e8f0c23a2415 ("can: ctucanfd: CTU CAN FD open-source IP core - platform/SoC support.")
Reported-by: kernel test robot <lkp@intel.com>
Cc: Pavel Pisa <pisa@cmp.felk.cvut.cz> (maintainer:CTU CAN FD DRIVER)
Cc: Ondrej Ille <ondrej.ille@gmail.com> (maintainer:CTU CAN FD DRIVER)
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/ctucanfd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/ctucanfd/Kconfig b/drivers/net/can/ctucanfd/Kconfig
index 3c383612eb17..6e2073351a8f 100644
--- a/drivers/net/can/ctucanfd/Kconfig
+++ b/drivers/net/can/ctucanfd/Kconfig
@@ -23,7 +23,7 @@ config CAN_CTUCANFD_PCI
config CAN_CTUCANFD_PLATFORM
tristate "CTU CAN-FD IP core platform (FPGA, SoC) driver"
- depends on OF || COMPILE_TEST
+ depends on HAS_IOMEM && (OF || COMPILE_TEST)
select CAN_CTUCANFD
help
The core has been tested together with OpenCores SJA1000
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] can: ctucanfd: platform: add missing dependency to HAS_IOMEM
2022-05-23 12:37 [PATCH] can: ctucanfd: platform: add missing dependency to HAS_IOMEM Marc Kleine-Budde
@ 2022-05-23 15:15 ` Pavel Pisa
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Pisa @ 2022-05-23 15:15 UTC (permalink / raw)
To: Marc Kleine-Budde
Cc: linux-can, kernel test robot, Ondrej Ille, Matej Vasilevski
Hello Marc,
thanks much for correction.
On Monday 23 of May 2022 14:37:20 Marc Kleine-Budde wrote:
> The kernel test robot noticed that the ctucanfd platform driver fails
> during modpost on platforms that don't support IOMEM.
>
> | ERROR: modpost: "devm_ioremap_resource"
> | [drivers/net/can/ctucanfd/ctucanfd_platform.ko] undefined!
>
> This patch adds the missing HAS_IOMEM dependency.
>
> Fixes: e8f0c23a2415 ("can: ctucanfd: CTU CAN FD open-source IP core -
> platform/SoC support.") Reported-by: kernel test robot <lkp@intel.com>
> Cc: Pavel Pisa <pisa@cmp.felk.cvut.cz> (maintainer:CTU CAN FD DRIVER)
> Cc: Ondrej Ille <ondrej.ille@gmail.com> (maintainer:CTU CAN FD DRIVER)
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
> ---
> drivers/net/can/ctucanfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/ctucanfd/Kconfig
> b/drivers/net/can/ctucanfd/Kconfig index 3c383612eb17..6e2073351a8f 100644
> --- a/drivers/net/can/ctucanfd/Kconfig
> +++ b/drivers/net/can/ctucanfd/Kconfig
> @@ -23,7 +23,7 @@ config CAN_CTUCANFD_PCI
>
> config CAN_CTUCANFD_PLATFORM
> tristate "CTU CAN-FD IP core platform (FPGA, SoC) driver"
> - depends on OF || COMPILE_TEST
> + depends on HAS_IOMEM && (OF || COMPILE_TEST)
> select CAN_CTUCANFD
> help
> The core has been tested together with OpenCores SJA1000
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-23 15:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-23 12:37 [PATCH] can: ctucanfd: platform: add missing dependency to HAS_IOMEM Marc Kleine-Budde
2022-05-23 15:15 ` Pavel Pisa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.