* [PATCH] mtd: maps: Fix refcount leak in ap_flash_init
@ 2022-05-23 14:32 ` Miaoqian Lin
0 siblings, 0 replies; 9+ messages in thread
From: Miaoqian Lin @ 2022-05-23 14:32 UTC (permalink / raw)
To: Linus Walleij, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-arm-kernel, linux-mtd, linux-kernel
Cc: linmq006
of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/mtd/maps/physmap-versatile.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/maps/physmap-versatile.c b/drivers/mtd/maps/physmap-versatile.c
index ad7cd9cfaee0..6ba6a1dd127c 100644
--- a/drivers/mtd/maps/physmap-versatile.c
+++ b/drivers/mtd/maps/physmap-versatile.c
@@ -93,6 +93,7 @@ static int ap_flash_init(struct platform_device *pdev)
return -ENODEV;
}
ebi_base = of_iomap(ebi, 0);
+ of_node_put(ebi);
if (!ebi_base)
return -ENODEV;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] mtd: maps: Fix refcount leak in ap_flash_init
@ 2022-05-23 14:32 ` Miaoqian Lin
0 siblings, 0 replies; 9+ messages in thread
From: Miaoqian Lin @ 2022-05-23 14:32 UTC (permalink / raw)
To: Linus Walleij, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-arm-kernel, linux-mtd, linux-kernel
Cc: linmq006
of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/mtd/maps/physmap-versatile.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/maps/physmap-versatile.c b/drivers/mtd/maps/physmap-versatile.c
index ad7cd9cfaee0..6ba6a1dd127c 100644
--- a/drivers/mtd/maps/physmap-versatile.c
+++ b/drivers/mtd/maps/physmap-versatile.c
@@ -93,6 +93,7 @@ static int ap_flash_init(struct platform_device *pdev)
return -ENODEV;
}
ebi_base = of_iomap(ebi, 0);
+ of_node_put(ebi);
if (!ebi_base)
return -ENODEV;
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] mtd: maps: Fix refcount leak in ap_flash_init
2022-05-23 14:32 ` Miaoqian Lin
(?)
@ 2022-05-24 7:26 ` Linus Walleij
-1 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2022-05-24 7:26 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
linux-arm-kernel, linux-mtd, linux-kernel
On Mon, May 23, 2022 at 4:33 PM Miaoqian Lin <linmq006@gmail.com> wrote:
> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] mtd: maps: Fix refcount leak in ap_flash_init
@ 2022-05-24 7:26 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2022-05-24 7:26 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
linux-arm-kernel, linux-mtd, linux-kernel
On Mon, May 23, 2022 at 4:33 PM Miaoqian Lin <linmq006@gmail.com> wrote:
> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] mtd: maps: Fix refcount leak in ap_flash_init
@ 2022-05-24 7:26 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2022-05-24 7:26 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
linux-arm-kernel, linux-mtd, linux-kernel
On Mon, May 23, 2022 at 4:33 PM Miaoqian Lin <linmq006@gmail.com> wrote:
> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mtd: maps: Fix refcount leak in ap_flash_init
2022-05-23 14:32 ` Miaoqian Lin
(?)
@ 2022-06-09 12:42 ` Miquel Raynal
-1 siblings, 0 replies; 9+ messages in thread
From: Miquel Raynal @ 2022-06-09 12:42 UTC (permalink / raw)
To: Miaoqian Lin, Linus Walleij, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-arm-kernel, linux-mtd, linux-kernel
On Mon, 2022-05-23 at 14:32:55 UTC, Miaoqian Lin wrote:
> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] mtd: maps: Fix refcount leak in ap_flash_init
@ 2022-06-09 12:42 ` Miquel Raynal
0 siblings, 0 replies; 9+ messages in thread
From: Miquel Raynal @ 2022-06-09 12:42 UTC (permalink / raw)
To: Miaoqian Lin, Linus Walleij, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-arm-kernel, linux-mtd, linux-kernel
On Mon, 2022-05-23 at 14:32:55 UTC, Miaoqian Lin wrote:
> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] mtd: maps: Fix refcount leak in ap_flash_init
@ 2022-06-09 12:42 ` Miquel Raynal
0 siblings, 0 replies; 9+ messages in thread
From: Miquel Raynal @ 2022-06-09 12:42 UTC (permalink / raw)
To: Miaoqian Lin, Linus Walleij, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-arm-kernel, linux-mtd, linux-kernel
On Mon, 2022-05-23 at 14:32:55 UTC, Miaoqian Lin wrote:
> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread