All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf/marvell_cn10k: Add MPAM support for TAD PMU
@ 2022-05-23 14:57 ` Tanmay Jagdale
  0 siblings, 0 replies; 6+ messages in thread
From: Tanmay Jagdale @ 2022-05-23 14:57 UTC (permalink / raw)
  To: will, mark.rutland
  Cc: linux-arm-kernel, linux-kernel, sgoutham, lcherian, bbhushan2,
	amitsinght, Tanmay Jagdale

The TAD PMU supports following counters that can be filtered by MPAM
partition id.
    - (0x1a) tad_alloc_dtg : Allocations to DTG.
    - (0x1b) tad_alloc_ltg : Allocations to LTG.
    - (0x1c) tad_alloc_any : Total allocations to DTG/LTG.
    - (0x1d) tad_hit_dtg   : DTG hits.
    - (0x1e) tad_hit_ltg   : LTG hits.
    - (0x1f) tad_hit_any   : Hit in LTG/DTG.
    - (0x20) tad_tag_rd    : Total tag reads.

Add a new 'partid' attribute of 16-bits to get the partition id
passed from perf tool. This value would be stored in config1 field
of perf_event_attr structure.

Example:
perf stat -e tad/tad_alloc_any,partid=0x12/ <program>

- Drop read of TAD_PRF since we don't have to preserve any
  bit fields and always write an updated value.
- Update register offsets of TAD_PRF and TAD_PFC.

Signed-off-by: Tanmay Jagdale <tanmay@marvell.com>
---
 drivers/perf/marvell_cn10k_tad_pmu.c | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/drivers/perf/marvell_cn10k_tad_pmu.c b/drivers/perf/marvell_cn10k_tad_pmu.c
index 282d3a071a67..f552e6bffcac 100644
--- a/drivers/perf/marvell_cn10k_tad_pmu.c
+++ b/drivers/perf/marvell_cn10k_tad_pmu.c
@@ -18,10 +18,12 @@
 #include <linux/perf_event.h>
 #include <linux/platform_device.h>
 
-#define TAD_PFC_OFFSET		0x0
+#define TAD_PFC_OFFSET		0x800
 #define TAD_PFC(counter)	(TAD_PFC_OFFSET | (counter << 3))
-#define TAD_PRF_OFFSET		0x100
+#define TAD_PRF_OFFSET		0x900
 #define TAD_PRF(counter)	(TAD_PRF_OFFSET | (counter << 3))
+#define TAD_PRF_MATCH_PARTID	(1 << 8)
+#define TAD_PRF_PARTID_NS	(1 << 10)
 #define TAD_PRF_CNTSEL_MASK	0xFF
 #define TAD_MAX_COUNTERS	8
 
@@ -86,23 +88,32 @@ static void tad_pmu_event_counter_start(struct perf_event *event, int flags)
 	struct hw_perf_event *hwc = &event->hw;
 	u32 event_idx = event->attr.config;
 	u32 counter_idx = hwc->idx;
+	u32 partid_filter = 0;
 	u64 reg_val;
+	u32 partid;
 	int i;
 
 	hwc->state = 0;
 
+	/* Extract the partid (if any) passed by user */
+	partid = event->attr.config1 & 0x3f;
+
 	/* Typically TAD_PFC() are zeroed to start counting */
 	for (i = 0; i < tad_pmu->region_cnt; i++)
 		writeq_relaxed(0, tad_pmu->regions[i].base +
 			       TAD_PFC(counter_idx));
 
+	/* Only some counters are filterable by MPAM */
+	if (partid && (event_idx > 0x19) && (event_idx < 0x21))
+		partid_filter = TAD_PRF_MATCH_PARTID | TAD_PRF_PARTID_NS |
+				(partid << 11);
+
 	/* TAD()_PFC() start counting on the write
 	 * which sets TAD()_PRF()[CNTSEL] != 0
 	 */
 	for (i = 0; i < tad_pmu->region_cnt; i++) {
-		reg_val = readq_relaxed(tad_pmu->regions[i].base +
-					TAD_PRF(counter_idx));
-		reg_val |= (event_idx & 0xFF);
+		reg_val = (event_idx & 0xFF);
+		reg_val |= partid_filter;
 		writeq_relaxed(reg_val,	tad_pmu->regions[i].base +
 			       TAD_PRF(counter_idx));
 	}
@@ -221,9 +232,11 @@ static const struct attribute_group tad_pmu_events_attr_group = {
 };
 
 PMU_FORMAT_ATTR(event, "config:0-7");
+PMU_FORMAT_ATTR(partid, "config1:0-15");
 
 static struct attribute *tad_pmu_format_attrs[] = {
 	&format_attr_event.attr,
+	&format_attr_partid.attr,
 	NULL
 };
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] perf/marvell_cn10k: Add MPAM support for TAD PMU
@ 2022-05-23 14:57 ` Tanmay Jagdale
  0 siblings, 0 replies; 6+ messages in thread
From: Tanmay Jagdale @ 2022-05-23 14:57 UTC (permalink / raw)
  To: will, mark.rutland
  Cc: linux-arm-kernel, linux-kernel, sgoutham, lcherian, bbhushan2,
	amitsinght, Tanmay Jagdale

The TAD PMU supports following counters that can be filtered by MPAM
partition id.
    - (0x1a) tad_alloc_dtg : Allocations to DTG.
    - (0x1b) tad_alloc_ltg : Allocations to LTG.
    - (0x1c) tad_alloc_any : Total allocations to DTG/LTG.
    - (0x1d) tad_hit_dtg   : DTG hits.
    - (0x1e) tad_hit_ltg   : LTG hits.
    - (0x1f) tad_hit_any   : Hit in LTG/DTG.
    - (0x20) tad_tag_rd    : Total tag reads.

Add a new 'partid' attribute of 16-bits to get the partition id
passed from perf tool. This value would be stored in config1 field
of perf_event_attr structure.

Example:
perf stat -e tad/tad_alloc_any,partid=0x12/ <program>

- Drop read of TAD_PRF since we don't have to preserve any
  bit fields and always write an updated value.
- Update register offsets of TAD_PRF and TAD_PFC.

Signed-off-by: Tanmay Jagdale <tanmay@marvell.com>
---
 drivers/perf/marvell_cn10k_tad_pmu.c | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/drivers/perf/marvell_cn10k_tad_pmu.c b/drivers/perf/marvell_cn10k_tad_pmu.c
index 282d3a071a67..f552e6bffcac 100644
--- a/drivers/perf/marvell_cn10k_tad_pmu.c
+++ b/drivers/perf/marvell_cn10k_tad_pmu.c
@@ -18,10 +18,12 @@
 #include <linux/perf_event.h>
 #include <linux/platform_device.h>
 
-#define TAD_PFC_OFFSET		0x0
+#define TAD_PFC_OFFSET		0x800
 #define TAD_PFC(counter)	(TAD_PFC_OFFSET | (counter << 3))
-#define TAD_PRF_OFFSET		0x100
+#define TAD_PRF_OFFSET		0x900
 #define TAD_PRF(counter)	(TAD_PRF_OFFSET | (counter << 3))
+#define TAD_PRF_MATCH_PARTID	(1 << 8)
+#define TAD_PRF_PARTID_NS	(1 << 10)
 #define TAD_PRF_CNTSEL_MASK	0xFF
 #define TAD_MAX_COUNTERS	8
 
@@ -86,23 +88,32 @@ static void tad_pmu_event_counter_start(struct perf_event *event, int flags)
 	struct hw_perf_event *hwc = &event->hw;
 	u32 event_idx = event->attr.config;
 	u32 counter_idx = hwc->idx;
+	u32 partid_filter = 0;
 	u64 reg_val;
+	u32 partid;
 	int i;
 
 	hwc->state = 0;
 
+	/* Extract the partid (if any) passed by user */
+	partid = event->attr.config1 & 0x3f;
+
 	/* Typically TAD_PFC() are zeroed to start counting */
 	for (i = 0; i < tad_pmu->region_cnt; i++)
 		writeq_relaxed(0, tad_pmu->regions[i].base +
 			       TAD_PFC(counter_idx));
 
+	/* Only some counters are filterable by MPAM */
+	if (partid && (event_idx > 0x19) && (event_idx < 0x21))
+		partid_filter = TAD_PRF_MATCH_PARTID | TAD_PRF_PARTID_NS |
+				(partid << 11);
+
 	/* TAD()_PFC() start counting on the write
 	 * which sets TAD()_PRF()[CNTSEL] != 0
 	 */
 	for (i = 0; i < tad_pmu->region_cnt; i++) {
-		reg_val = readq_relaxed(tad_pmu->regions[i].base +
-					TAD_PRF(counter_idx));
-		reg_val |= (event_idx & 0xFF);
+		reg_val = (event_idx & 0xFF);
+		reg_val |= partid_filter;
 		writeq_relaxed(reg_val,	tad_pmu->regions[i].base +
 			       TAD_PRF(counter_idx));
 	}
@@ -221,9 +232,11 @@ static const struct attribute_group tad_pmu_events_attr_group = {
 };
 
 PMU_FORMAT_ATTR(event, "config:0-7");
+PMU_FORMAT_ATTR(partid, "config1:0-15");
 
 static struct attribute *tad_pmu_format_attrs[] = {
 	&format_attr_event.attr,
+	&format_attr_partid.attr,
 	NULL
 };
 
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf/marvell_cn10k: Add MPAM support for TAD PMU
  2022-05-23 14:57 ` Tanmay Jagdale
@ 2022-05-23 16:37   ` Rob Herring
  -1 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-05-23 16:37 UTC (permalink / raw)
  To: Tanmay Jagdale
  Cc: will, mark.rutland, linux-arm-kernel, linux-kernel, sgoutham,
	lcherian, bbhushan2, amitsinght

On Mon, May 23, 2022 at 08:27:38PM +0530, Tanmay Jagdale wrote:
> The TAD PMU supports following counters that can be filtered by MPAM
> partition id.

How are you setting the PARTID? There's no support yet in the kernel to 
set it. 

>     - (0x1a) tad_alloc_dtg : Allocations to DTG.
>     - (0x1b) tad_alloc_ltg : Allocations to LTG.
>     - (0x1c) tad_alloc_any : Total allocations to DTG/LTG.
>     - (0x1d) tad_hit_dtg   : DTG hits.
>     - (0x1e) tad_hit_ltg   : LTG hits.
>     - (0x1f) tad_hit_any   : Hit in LTG/DTG.
>     - (0x20) tad_tag_rd    : Total tag reads.
> 
> Add a new 'partid' attribute of 16-bits to get the partition id
> passed from perf tool. This value would be stored in config1 field
> of perf_event_attr structure.
> 
> Example:
> perf stat -e tad/tad_alloc_any,partid=0x12/ <program>

How would userspace get the 0x12 value?

> 
> - Drop read of TAD_PRF since we don't have to preserve any
>   bit fields and always write an updated value.
> - Update register offsets of TAD_PRF and TAD_PFC.
> 
> Signed-off-by: Tanmay Jagdale <tanmay@marvell.com>
> ---
>  drivers/perf/marvell_cn10k_tad_pmu.c | 23 ++++++++++++++++++-----
>  1 file changed, 18 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/perf/marvell_cn10k_tad_pmu.c b/drivers/perf/marvell_cn10k_tad_pmu.c
> index 282d3a071a67..f552e6bffcac 100644
> --- a/drivers/perf/marvell_cn10k_tad_pmu.c
> +++ b/drivers/perf/marvell_cn10k_tad_pmu.c
> @@ -18,10 +18,12 @@
>  #include <linux/perf_event.h>
>  #include <linux/platform_device.h>
>  
> -#define TAD_PFC_OFFSET		0x0
> +#define TAD_PFC_OFFSET		0x800
>  #define TAD_PFC(counter)	(TAD_PFC_OFFSET | (counter << 3))
> -#define TAD_PRF_OFFSET		0x100
> +#define TAD_PRF_OFFSET		0x900
>  #define TAD_PRF(counter)	(TAD_PRF_OFFSET | (counter << 3))
> +#define TAD_PRF_MATCH_PARTID	(1 << 8)
> +#define TAD_PRF_PARTID_NS	(1 << 10)
>  #define TAD_PRF_CNTSEL_MASK	0xFF
>  #define TAD_MAX_COUNTERS	8

Does this h/w block follow the MPAM specification or just uses PARTID in 
its own way?

Rob

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf/marvell_cn10k: Add MPAM support for TAD PMU
@ 2022-05-23 16:37   ` Rob Herring
  0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-05-23 16:37 UTC (permalink / raw)
  To: Tanmay Jagdale
  Cc: will, mark.rutland, linux-arm-kernel, linux-kernel, sgoutham,
	lcherian, bbhushan2, amitsinght

On Mon, May 23, 2022 at 08:27:38PM +0530, Tanmay Jagdale wrote:
> The TAD PMU supports following counters that can be filtered by MPAM
> partition id.

How are you setting the PARTID? There's no support yet in the kernel to 
set it. 

>     - (0x1a) tad_alloc_dtg : Allocations to DTG.
>     - (0x1b) tad_alloc_ltg : Allocations to LTG.
>     - (0x1c) tad_alloc_any : Total allocations to DTG/LTG.
>     - (0x1d) tad_hit_dtg   : DTG hits.
>     - (0x1e) tad_hit_ltg   : LTG hits.
>     - (0x1f) tad_hit_any   : Hit in LTG/DTG.
>     - (0x20) tad_tag_rd    : Total tag reads.
> 
> Add a new 'partid' attribute of 16-bits to get the partition id
> passed from perf tool. This value would be stored in config1 field
> of perf_event_attr structure.
> 
> Example:
> perf stat -e tad/tad_alloc_any,partid=0x12/ <program>

How would userspace get the 0x12 value?

> 
> - Drop read of TAD_PRF since we don't have to preserve any
>   bit fields and always write an updated value.
> - Update register offsets of TAD_PRF and TAD_PFC.
> 
> Signed-off-by: Tanmay Jagdale <tanmay@marvell.com>
> ---
>  drivers/perf/marvell_cn10k_tad_pmu.c | 23 ++++++++++++++++++-----
>  1 file changed, 18 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/perf/marvell_cn10k_tad_pmu.c b/drivers/perf/marvell_cn10k_tad_pmu.c
> index 282d3a071a67..f552e6bffcac 100644
> --- a/drivers/perf/marvell_cn10k_tad_pmu.c
> +++ b/drivers/perf/marvell_cn10k_tad_pmu.c
> @@ -18,10 +18,12 @@
>  #include <linux/perf_event.h>
>  #include <linux/platform_device.h>
>  
> -#define TAD_PFC_OFFSET		0x0
> +#define TAD_PFC_OFFSET		0x800
>  #define TAD_PFC(counter)	(TAD_PFC_OFFSET | (counter << 3))
> -#define TAD_PRF_OFFSET		0x100
> +#define TAD_PRF_OFFSET		0x900
>  #define TAD_PRF(counter)	(TAD_PRF_OFFSET | (counter << 3))
> +#define TAD_PRF_MATCH_PARTID	(1 << 8)
> +#define TAD_PRF_PARTID_NS	(1 << 10)
>  #define TAD_PRF_CNTSEL_MASK	0xFF
>  #define TAD_MAX_COUNTERS	8

Does this h/w block follow the MPAM specification or just uses PARTID in 
its own way?

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] perf/marvell_cn10k: Add MPAM support for TAD PMU
@ 2022-05-24  6:17 ` Tanmay Jagdale
  0 siblings, 0 replies; 6+ messages in thread
From: Tanmay Jagdale @ 2022-05-24  6:17 UTC (permalink / raw)
  To: Rob Herring
  Cc: will, mark.rutland, linux-arm-kernel, linux-kernel,
	Sunil Kovvuri Goutham, Linu Cherian, Bharat Bhushan,
	Amit Singh Tomar, james.morse

Hi Rob,


> > The TAD PMU supports following counters that can be filtered by MPAM
> > partition id.
> 
> How are you setting the PARTID? There's no support yet in the kernel to
> set it.
We have ported MPAM support from James Morse private tree to test this.

> 
> >     - (0x1a) tad_alloc_dtg : Allocations to DTG.
> >     - (0x1b) tad_alloc_ltg : Allocations to LTG.
> >     - (0x1c) tad_alloc_any : Total allocations to DTG/LTG.
> >     - (0x1d) tad_hit_dtg   : DTG hits.
> >     - (0x1e) tad_hit_ltg   : LTG hits.
> >     - (0x1f) tad_hit_any   : Hit in LTG/DTG.
> >     - (0x20) tad_tag_rd    : Total tag reads.
> >
> > Add a new 'partid' attribute of 16-bits to get the partition id
> > passed from perf tool. This value would be stored in config1 field
> > of perf_event_attr structure.
> >
> > Example:
> > perf stat -e tad/tad_alloc_any,partid=0x12/ <program>
> 
> How would userspace get the 0x12 value?
It's up to the user to create partition id and use the same id here.
For testing, I had used the MPAM resctrl infrastructure to create
and get partition ID.

> 
> >
> > - Drop read of TAD_PRF since we don't have to preserve any
> >   bit fields and always write an updated value.
> > - Update register offsets of TAD_PRF and TAD_PFC.
> >
> > Signed-off-by: Tanmay Jagdale <tanmay@marvell.com>
> > ---
> >  drivers/perf/marvell_cn10k_tad_pmu.c | 23 ++++++++++++++++++-----
> >  1 file changed, 18 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/perf/marvell_cn10k_tad_pmu.c
> b/drivers/perf/marvell_cn10k_tad_pmu.c
> > index 282d3a071a67..f552e6bffcac 100644
> > --- a/drivers/perf/marvell_cn10k_tad_pmu.c
> > +++ b/drivers/perf/marvell_cn10k_tad_pmu.c
> > @@ -18,10 +18,12 @@
> >  #include <linux/perf_event.h>
> >  #include <linux/platform_device.h>
> >
> > -#define TAD_PFC_OFFSET		0x0
> > +#define TAD_PFC_OFFSET		0x800
> >  #define TAD_PFC(counter)	(TAD_PFC_OFFSET | (counter << 3))
> > -#define TAD_PRF_OFFSET		0x100
> > +#define TAD_PRF_OFFSET		0x900
> >  #define TAD_PRF(counter)	(TAD_PRF_OFFSET | (counter << 3))
> > +#define TAD_PRF_MATCH_PARTID	(1 << 8)
> > +#define TAD_PRF_PARTID_NS	(1 << 10)
> >  #define TAD_PRF_CNTSEL_MASK	0xFF
> >  #define TAD_MAX_COUNTERS	8
> 
> Does this h/w block follow the MPAM specification or just uses PARTID in
> its own way?
No, these counters are not as per the MPAM monitoring specification and we
use them in our own way.

Thanks,
Tanmay
> 
> Rob

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] perf/marvell_cn10k: Add MPAM support for TAD PMU
@ 2022-05-24  6:17 ` Tanmay Jagdale
  0 siblings, 0 replies; 6+ messages in thread
From: Tanmay Jagdale @ 2022-05-24  6:17 UTC (permalink / raw)
  To: Rob Herring
  Cc: will, mark.rutland, linux-arm-kernel, linux-kernel,
	Sunil Kovvuri Goutham, Linu Cherian, Bharat Bhushan,
	Amit Singh Tomar, james.morse

Hi Rob,


> > The TAD PMU supports following counters that can be filtered by MPAM
> > partition id.
> 
> How are you setting the PARTID? There's no support yet in the kernel to
> set it.
We have ported MPAM support from James Morse private tree to test this.

> 
> >     - (0x1a) tad_alloc_dtg : Allocations to DTG.
> >     - (0x1b) tad_alloc_ltg : Allocations to LTG.
> >     - (0x1c) tad_alloc_any : Total allocations to DTG/LTG.
> >     - (0x1d) tad_hit_dtg   : DTG hits.
> >     - (0x1e) tad_hit_ltg   : LTG hits.
> >     - (0x1f) tad_hit_any   : Hit in LTG/DTG.
> >     - (0x20) tad_tag_rd    : Total tag reads.
> >
> > Add a new 'partid' attribute of 16-bits to get the partition id
> > passed from perf tool. This value would be stored in config1 field
> > of perf_event_attr structure.
> >
> > Example:
> > perf stat -e tad/tad_alloc_any,partid=0x12/ <program>
> 
> How would userspace get the 0x12 value?
It's up to the user to create partition id and use the same id here.
For testing, I had used the MPAM resctrl infrastructure to create
and get partition ID.

> 
> >
> > - Drop read of TAD_PRF since we don't have to preserve any
> >   bit fields and always write an updated value.
> > - Update register offsets of TAD_PRF and TAD_PFC.
> >
> > Signed-off-by: Tanmay Jagdale <tanmay@marvell.com>
> > ---
> >  drivers/perf/marvell_cn10k_tad_pmu.c | 23 ++++++++++++++++++-----
> >  1 file changed, 18 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/perf/marvell_cn10k_tad_pmu.c
> b/drivers/perf/marvell_cn10k_tad_pmu.c
> > index 282d3a071a67..f552e6bffcac 100644
> > --- a/drivers/perf/marvell_cn10k_tad_pmu.c
> > +++ b/drivers/perf/marvell_cn10k_tad_pmu.c
> > @@ -18,10 +18,12 @@
> >  #include <linux/perf_event.h>
> >  #include <linux/platform_device.h>
> >
> > -#define TAD_PFC_OFFSET		0x0
> > +#define TAD_PFC_OFFSET		0x800
> >  #define TAD_PFC(counter)	(TAD_PFC_OFFSET | (counter << 3))
> > -#define TAD_PRF_OFFSET		0x100
> > +#define TAD_PRF_OFFSET		0x900
> >  #define TAD_PRF(counter)	(TAD_PRF_OFFSET | (counter << 3))
> > +#define TAD_PRF_MATCH_PARTID	(1 << 8)
> > +#define TAD_PRF_PARTID_NS	(1 << 10)
> >  #define TAD_PRF_CNTSEL_MASK	0xFF
> >  #define TAD_MAX_COUNTERS	8
> 
> Does this h/w block follow the MPAM specification or just uses PARTID in
> its own way?
No, these counters are not as per the MPAM monitoring specification and we
use them in our own way.

Thanks,
Tanmay
> 
> Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-05-24  6:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-23 14:57 [PATCH] perf/marvell_cn10k: Add MPAM support for TAD PMU Tanmay Jagdale
2022-05-23 14:57 ` Tanmay Jagdale
2022-05-23 16:37 ` Rob Herring
2022-05-23 16:37   ` Rob Herring
2022-05-24  6:17 Tanmay Jagdale
2022-05-24  6:17 ` Tanmay Jagdale

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.