All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu/discovery: make amdgpu_discovery_get_mall_info static
@ 2022-05-24  8:11 ` Jiapeng Chong
  0 siblings, 0 replies; 6+ messages in thread
From: Jiapeng Chong @ 2022-05-24  8:11 UTC (permalink / raw)
  To: alexander.deucher
  Cc: christian.koenig, Xinhui.Pan, airlied, daniel, Likun.Gao,
	flora.cui, yifan1.zhang, luben.tuikov, amd-gfx, dri-devel,
	linux-kernel, Jiapeng Chong, Abaci Robot

This symbol is not used outside of amdgpu_discovery.c, so marks it static.

Fixes the following w1 warning:

drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1364:5: warning: no
previous prototype for ‘amdgpu_discovery_get_mall_info’
[-Wmissing-prototypes].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index 881570dced41..16cdfb30b013 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
@@ -1361,7 +1361,7 @@ union mall_info {
 	struct mall_info_v1_0 v1;
 };
 
-int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
+static int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
 {
 	struct binary_header *bhdr;
 	union mall_info *mall_info;
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] drm/amdgpu/discovery: make amdgpu_discovery_get_mall_info static
@ 2022-05-24  8:11 ` Jiapeng Chong
  0 siblings, 0 replies; 6+ messages in thread
From: Jiapeng Chong @ 2022-05-24  8:11 UTC (permalink / raw)
  To: alexander.deucher
  Cc: yifan1.zhang, Jiapeng Chong, airlied, Xinhui.Pan, Abaci Robot,
	linux-kernel, amd-gfx, luben.tuikov, dri-devel, Likun.Gao,
	flora.cui, christian.koenig

This symbol is not used outside of amdgpu_discovery.c, so marks it static.

Fixes the following w1 warning:

drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1364:5: warning: no
previous prototype for ‘amdgpu_discovery_get_mall_info’
[-Wmissing-prototypes].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index 881570dced41..16cdfb30b013 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
@@ -1361,7 +1361,7 @@ union mall_info {
 	struct mall_info_v1_0 v1;
 };
 
-int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
+static int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
 {
 	struct binary_header *bhdr;
 	union mall_info *mall_info;
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] drm/amdgpu/discovery: make amdgpu_discovery_get_mall_info static
@ 2022-05-24  8:11 ` Jiapeng Chong
  0 siblings, 0 replies; 6+ messages in thread
From: Jiapeng Chong @ 2022-05-24  8:11 UTC (permalink / raw)
  To: alexander.deucher
  Cc: yifan1.zhang, Jiapeng Chong, airlied, Xinhui.Pan, Abaci Robot,
	linux-kernel, amd-gfx, luben.tuikov, dri-devel, daniel,
	Likun.Gao, flora.cui, christian.koenig

This symbol is not used outside of amdgpu_discovery.c, so marks it static.

Fixes the following w1 warning:

drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1364:5: warning: no
previous prototype for ‘amdgpu_discovery_get_mall_info’
[-Wmissing-prototypes].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index 881570dced41..16cdfb30b013 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
@@ -1361,7 +1361,7 @@ union mall_info {
 	struct mall_info_v1_0 v1;
 };
 
-int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
+static int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
 {
 	struct binary_header *bhdr;
 	union mall_info *mall_info;
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu/discovery: make amdgpu_discovery_get_mall_info static
  2022-05-24  8:11 ` Jiapeng Chong
  (?)
@ 2022-05-24 21:22   ` Luben Tuikov
  -1 siblings, 0 replies; 6+ messages in thread
From: Luben Tuikov @ 2022-05-24 21:22 UTC (permalink / raw)
  To: Jiapeng Chong, alexander.deucher
  Cc: christian.koenig, Xinhui.Pan, airlied, daniel, Likun.Gao,
	flora.cui, yifan1.zhang, amd-gfx, dri-devel, linux-kernel,
	Abaci Robot

This is already static, in our local branch, from this commit:

commit 6852e61a0917a2
Author: Evan Quan <evan.quan@amd.com>
Date:   Thu May 19 17:28:12 2022 +0800

    drm/amdgpu: suppress some compile warnings
    
    Suppress two compile warnings about "no previous prototype".
    
    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Evan Quan <evan.quan@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

Regards,
Luben


On 2022-05-24 04:11, Jiapeng Chong wrote:
> This symbol is not used outside of amdgpu_discovery.c, so marks it static.
> 
> Fixes the following w1 warning:
> 
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1364:5: warning: no
> previous prototype for ‘amdgpu_discovery_get_mall_info’
> [-Wmissing-prototypes].
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> index 881570dced41..16cdfb30b013 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> @@ -1361,7 +1361,7 @@ union mall_info {
>  	struct mall_info_v1_0 v1;
>  };
>  
> -int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
> +static int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
>  {
>  	struct binary_header *bhdr;
>  	union mall_info *mall_info;

Regards,
-- 
Luben

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu/discovery: make amdgpu_discovery_get_mall_info static
@ 2022-05-24 21:22   ` Luben Tuikov
  0 siblings, 0 replies; 6+ messages in thread
From: Luben Tuikov @ 2022-05-24 21:22 UTC (permalink / raw)
  To: Jiapeng Chong, alexander.deucher
  Cc: yifan1.zhang, airlied, Xinhui.Pan, Abaci Robot, linux-kernel,
	amd-gfx, dri-devel, Likun.Gao, flora.cui, christian.koenig

This is already static, in our local branch, from this commit:

commit 6852e61a0917a2
Author: Evan Quan <evan.quan@amd.com>
Date:   Thu May 19 17:28:12 2022 +0800

    drm/amdgpu: suppress some compile warnings
    
    Suppress two compile warnings about "no previous prototype".
    
    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Evan Quan <evan.quan@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

Regards,
Luben


On 2022-05-24 04:11, Jiapeng Chong wrote:
> This symbol is not used outside of amdgpu_discovery.c, so marks it static.
> 
> Fixes the following w1 warning:
> 
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1364:5: warning: no
> previous prototype for ‘amdgpu_discovery_get_mall_info’
> [-Wmissing-prototypes].
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> index 881570dced41..16cdfb30b013 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> @@ -1361,7 +1361,7 @@ union mall_info {
>  	struct mall_info_v1_0 v1;
>  };
>  
> -int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
> +static int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
>  {
>  	struct binary_header *bhdr;
>  	union mall_info *mall_info;

Regards,
-- 
Luben

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu/discovery: make amdgpu_discovery_get_mall_info static
@ 2022-05-24 21:22   ` Luben Tuikov
  0 siblings, 0 replies; 6+ messages in thread
From: Luben Tuikov @ 2022-05-24 21:22 UTC (permalink / raw)
  To: Jiapeng Chong, alexander.deucher
  Cc: yifan1.zhang, airlied, Xinhui.Pan, Abaci Robot, linux-kernel,
	amd-gfx, dri-devel, daniel, Likun.Gao, flora.cui,
	christian.koenig

This is already static, in our local branch, from this commit:

commit 6852e61a0917a2
Author: Evan Quan <evan.quan@amd.com>
Date:   Thu May 19 17:28:12 2022 +0800

    drm/amdgpu: suppress some compile warnings
    
    Suppress two compile warnings about "no previous prototype".
    
    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Evan Quan <evan.quan@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

Regards,
Luben


On 2022-05-24 04:11, Jiapeng Chong wrote:
> This symbol is not used outside of amdgpu_discovery.c, so marks it static.
> 
> Fixes the following w1 warning:
> 
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1364:5: warning: no
> previous prototype for ‘amdgpu_discovery_get_mall_info’
> [-Wmissing-prototypes].
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> index 881570dced41..16cdfb30b013 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> @@ -1361,7 +1361,7 @@ union mall_info {
>  	struct mall_info_v1_0 v1;
>  };
>  
> -int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
> +static int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
>  {
>  	struct binary_header *bhdr;
>  	union mall_info *mall_info;

Regards,
-- 
Luben

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-24 21:22 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-24  8:11 [PATCH] drm/amdgpu/discovery: make amdgpu_discovery_get_mall_info static Jiapeng Chong
2022-05-24  8:11 ` Jiapeng Chong
2022-05-24  8:11 ` Jiapeng Chong
2022-05-24 21:22 ` Luben Tuikov
2022-05-24 21:22   ` Luben Tuikov
2022-05-24 21:22   ` Luben Tuikov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.