* [PATCH] drm/msm/dpu: Remove unused code
@ 2022-05-24 8:14 ` Jiapeng Chong
0 siblings, 0 replies; 4+ messages in thread
From: Jiapeng Chong @ 2022-05-24 8:14 UTC (permalink / raw)
To: robdclark
Cc: quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel, vkoul,
quic_khsieh, linux-arm-msm, dri-devel, freedreno, linux-kernel,
Jiapeng Chong, Abaci Robot
Eliminate the follow clang warning:
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:544:33: warning: variable
‘mode’ set but not used [-Wunused-but-set-variable].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 52516eb20cb8..658171799b9a 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -541,7 +541,6 @@ static int dpu_encoder_virt_atomic_check(
struct dpu_encoder_virt *dpu_enc;
struct msm_drm_private *priv;
struct dpu_kms *dpu_kms;
- const struct drm_display_mode *mode;
struct drm_display_mode *adj_mode;
struct msm_display_topology topology;
struct dpu_global_state *global_state;
@@ -559,7 +558,6 @@ static int dpu_encoder_virt_atomic_check(
priv = drm_enc->dev->dev_private;
dpu_kms = to_dpu_kms(priv->kms);
- mode = &crtc_state->mode;
adj_mode = &crtc_state->adjusted_mode;
global_state = dpu_kms_get_global_state(crtc_state->state);
if (IS_ERR(global_state))
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/msm/dpu: Remove unused code
@ 2022-05-24 8:14 ` Jiapeng Chong
0 siblings, 0 replies; 4+ messages in thread
From: Jiapeng Chong @ 2022-05-24 8:14 UTC (permalink / raw)
To: robdclark
Cc: freedreno, Jiapeng Chong, airlied, linux-arm-msm, Abaci Robot,
quic_abhinavk, dri-devel, quic_khsieh, vkoul, dmitry.baryshkov,
sean, linux-kernel
Eliminate the follow clang warning:
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:544:33: warning: variable
‘mode’ set but not used [-Wunused-but-set-variable].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 52516eb20cb8..658171799b9a 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -541,7 +541,6 @@ static int dpu_encoder_virt_atomic_check(
struct dpu_encoder_virt *dpu_enc;
struct msm_drm_private *priv;
struct dpu_kms *dpu_kms;
- const struct drm_display_mode *mode;
struct drm_display_mode *adj_mode;
struct msm_display_topology topology;
struct dpu_global_state *global_state;
@@ -559,7 +558,6 @@ static int dpu_encoder_virt_atomic_check(
priv = drm_enc->dev->dev_private;
dpu_kms = to_dpu_kms(priv->kms);
- mode = &crtc_state->mode;
adj_mode = &crtc_state->adjusted_mode;
global_state = dpu_kms_get_global_state(crtc_state->state);
if (IS_ERR(global_state))
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/msm/dpu: Remove unused code
2022-05-24 8:14 ` Jiapeng Chong
@ 2022-05-31 18:14 ` Abhinav Kumar
-1 siblings, 0 replies; 4+ messages in thread
From: Abhinav Kumar @ 2022-05-31 18:14 UTC (permalink / raw)
To: Jiapeng Chong, robdclark
Cc: dmitry.baryshkov, sean, airlied, daniel, vkoul, quic_khsieh,
linux-arm-msm, dri-devel, freedreno, linux-kernel, Abaci Robot
On 5/24/2022 1:14 AM, Jiapeng Chong wrote:
> Eliminate the follow clang warning:
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:544:33: warning: variable
> ‘mode’ set but not used [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Fixes: 3177589c6e93("drm/msm/dpu: encoder: drop unused mode_fixup callback")
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index 52516eb20cb8..658171799b9a 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -541,7 +541,6 @@ static int dpu_encoder_virt_atomic_check(
> struct dpu_encoder_virt *dpu_enc;
> struct msm_drm_private *priv;
> struct dpu_kms *dpu_kms;
> - const struct drm_display_mode *mode;
> struct drm_display_mode *adj_mode;
> struct msm_display_topology topology;
> struct dpu_global_state *global_state;
> @@ -559,7 +558,6 @@ static int dpu_encoder_virt_atomic_check(
>
> priv = drm_enc->dev->dev_private;
> dpu_kms = to_dpu_kms(priv->kms);
> - mode = &crtc_state->mode;
> adj_mode = &crtc_state->adjusted_mode;
> global_state = dpu_kms_get_global_state(crtc_state->state);
> if (IS_ERR(global_state))
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/msm/dpu: Remove unused code
@ 2022-05-31 18:14 ` Abhinav Kumar
0 siblings, 0 replies; 4+ messages in thread
From: Abhinav Kumar @ 2022-05-31 18:14 UTC (permalink / raw)
To: Jiapeng Chong, robdclark
Cc: freedreno, airlied, linux-arm-msm, Abaci Robot, linux-kernel,
dri-devel, quic_khsieh, vkoul, dmitry.baryshkov, sean
On 5/24/2022 1:14 AM, Jiapeng Chong wrote:
> Eliminate the follow clang warning:
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:544:33: warning: variable
> ‘mode’ set but not used [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Fixes: 3177589c6e93("drm/msm/dpu: encoder: drop unused mode_fixup callback")
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index 52516eb20cb8..658171799b9a 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -541,7 +541,6 @@ static int dpu_encoder_virt_atomic_check(
> struct dpu_encoder_virt *dpu_enc;
> struct msm_drm_private *priv;
> struct dpu_kms *dpu_kms;
> - const struct drm_display_mode *mode;
> struct drm_display_mode *adj_mode;
> struct msm_display_topology topology;
> struct dpu_global_state *global_state;
> @@ -559,7 +558,6 @@ static int dpu_encoder_virt_atomic_check(
>
> priv = drm_enc->dev->dev_private;
> dpu_kms = to_dpu_kms(priv->kms);
> - mode = &crtc_state->mode;
> adj_mode = &crtc_state->adjusted_mode;
> global_state = dpu_kms_get_global_state(crtc_state->state);
> if (IS_ERR(global_state))
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-31 18:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-24 8:14 [PATCH] drm/msm/dpu: Remove unused code Jiapeng Chong
2022-05-24 8:14 ` Jiapeng Chong
2022-05-31 18:14 ` Abhinav Kumar
2022-05-31 18:14 ` Abhinav Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.