* linux-next: build warning after merge of the bluetooth tree
@ 2022-05-16 7:57 Stephen Rothwell
2022-05-23 22:22 ` Stephen Rothwell
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2022-05-16 7:57 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Yury Norov
Cc: Luiz Augusto von Dentz, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 2097 bytes --]
Hi all,
After merging the bluetooth tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
In file included from include/linux/cpumask.h:12,
from include/linux/mm_types_task.h:14,
from include/linux/mm_types.h:5,
from include/linux/buildid.h:5,
from include/linux/module.h:14,
from net/bluetooth/mgmt.c:27:
In function 'bitmap_copy',
inlined from 'bitmap_copy_clear_tail' at include/linux/bitmap.h:270:2,
inlined from 'bitmap_from_u64' at include/linux/bitmap.h:622:2,
inlined from 'set_device_flags' at net/bluetooth/mgmt.c:4534:4:
include/linux/bitmap.h:261:9: warning: 'memcpy' forming offset [4, 7] is out of the bounds [0, 4] of object 'flags' with type 'long unsigned int[1]' [-Warray-bounds]
261 | memcpy(dst, src, len);
| ^~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/kasan-checks.h:5,
from include/asm-generic/rwonce.h:26,
from ./arch/arm/include/generated/asm/rwonce.h:1,
from include/linux/compiler.h:248,
from include/linux/build_bug.h:5,
from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/module.h:12,
from net/bluetooth/mgmt.c:27:
net/bluetooth/mgmt.c: In function 'set_device_flags':
net/bluetooth/mgmt.c:4532:40: note: 'flags' declared here
4532 | DECLARE_BITMAP(flags, __HCI_CONN_NUM_FLAGS);
| ^~~~~
include/linux/types.h:11:23: note: in definition of macro 'DECLARE_BITMAP'
11 | unsigned long name[BITS_TO_LONGS(bits)]
| ^~~~
Introduced by commit
a9a347655d22 ("Bluetooth: MGMT: Add conditions for setting HCI_CONN_FLAG_REMOTE_WAKEUP")
Bitmaps consist of unsigned longs (in this case 32 bits) ...
(This warning only happens due to chnges in the bitmap tree.)
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the bluetooth tree
2022-05-16 7:57 linux-next: build warning after merge of the bluetooth tree Stephen Rothwell
@ 2022-05-23 22:22 ` Stephen Rothwell
2022-06-05 22:06 ` Stephen Rothwell
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2022-05-23 22:22 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Yury Norov
Cc: Luiz Augusto von Dentz, Linux Kernel Mailing List,
Linux Next Mailing List, David Miller, Networking
[-- Attachment #1: Type: text/plain, Size: 2306 bytes --]
Hi all,
On Mon, 16 May 2022 17:57:57 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the bluetooth tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from include/linux/cpumask.h:12,
> from include/linux/mm_types_task.h:14,
> from include/linux/mm_types.h:5,
> from include/linux/buildid.h:5,
> from include/linux/module.h:14,
> from net/bluetooth/mgmt.c:27:
> In function 'bitmap_copy',
> inlined from 'bitmap_copy_clear_tail' at include/linux/bitmap.h:270:2,
> inlined from 'bitmap_from_u64' at include/linux/bitmap.h:622:2,
> inlined from 'set_device_flags' at net/bluetooth/mgmt.c:4534:4:
> include/linux/bitmap.h:261:9: warning: 'memcpy' forming offset [4, 7] is out of the bounds [0, 4] of object 'flags' with type 'long unsigned int[1]' [-Warray-bounds]
> 261 | memcpy(dst, src, len);
> | ^~~~~~~~~~~~~~~~~~~~~
> In file included from include/linux/kasan-checks.h:5,
> from include/asm-generic/rwonce.h:26,
> from ./arch/arm/include/generated/asm/rwonce.h:1,
> from include/linux/compiler.h:248,
> from include/linux/build_bug.h:5,
> from include/linux/container_of.h:5,
> from include/linux/list.h:5,
> from include/linux/module.h:12,
> from net/bluetooth/mgmt.c:27:
> net/bluetooth/mgmt.c: In function 'set_device_flags':
> net/bluetooth/mgmt.c:4532:40: note: 'flags' declared here
> 4532 | DECLARE_BITMAP(flags, __HCI_CONN_NUM_FLAGS);
> | ^~~~~
> include/linux/types.h:11:23: note: in definition of macro 'DECLARE_BITMAP'
> 11 | unsigned long name[BITS_TO_LONGS(bits)]
> | ^~~~
>
> Introduced by commit
>
> a9a347655d22 ("Bluetooth: MGMT: Add conditions for setting HCI_CONN_FLAG_REMOTE_WAKEUP")
>
> Bitmaps consist of unsigned longs (in this case 32 bits) ...
>
> (This warning only happens due to chnges in the bitmap tree.)
I still got this warning yesterday ...
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the bluetooth tree
2022-05-23 22:22 ` Stephen Rothwell
@ 2022-06-05 22:06 ` Stephen Rothwell
2022-06-05 22:40 ` Yury Norov
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2022-06-05 22:06 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Yury Norov
Cc: Luiz Augusto von Dentz, Linux Kernel Mailing List,
Linux Next Mailing List, David Miller, Networking,
Linus Torvalds
[-- Attachment #1: Type: text/plain, Size: 2540 bytes --]
Hi all,
On Tue, 24 May 2022 08:22:56 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Mon, 16 May 2022 17:57:57 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the bluetooth tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > In file included from include/linux/cpumask.h:12,
> > from include/linux/mm_types_task.h:14,
> > from include/linux/mm_types.h:5,
> > from include/linux/buildid.h:5,
> > from include/linux/module.h:14,
> > from net/bluetooth/mgmt.c:27:
> > In function 'bitmap_copy',
> > inlined from 'bitmap_copy_clear_tail' at include/linux/bitmap.h:270:2,
> > inlined from 'bitmap_from_u64' at include/linux/bitmap.h:622:2,
> > inlined from 'set_device_flags' at net/bluetooth/mgmt.c:4534:4:
> > include/linux/bitmap.h:261:9: warning: 'memcpy' forming offset [4, 7] is out of the bounds [0, 4] of object 'flags' with type 'long unsigned int[1]' [-Warray-bounds]
> > 261 | memcpy(dst, src, len);
> > | ^~~~~~~~~~~~~~~~~~~~~
> > In file included from include/linux/kasan-checks.h:5,
> > from include/asm-generic/rwonce.h:26,
> > from ./arch/arm/include/generated/asm/rwonce.h:1,
> > from include/linux/compiler.h:248,
> > from include/linux/build_bug.h:5,
> > from include/linux/container_of.h:5,
> > from include/linux/list.h:5,
> > from include/linux/module.h:12,
> > from net/bluetooth/mgmt.c:27:
> > net/bluetooth/mgmt.c: In function 'set_device_flags':
> > net/bluetooth/mgmt.c:4532:40: note: 'flags' declared here
> > 4532 | DECLARE_BITMAP(flags, __HCI_CONN_NUM_FLAGS);
> > | ^~~~~
> > include/linux/types.h:11:23: note: in definition of macro 'DECLARE_BITMAP'
> > 11 | unsigned long name[BITS_TO_LONGS(bits)]
> > | ^~~~
> >
> > Introduced by commit
> >
> > a9a347655d22 ("Bluetooth: MGMT: Add conditions for setting HCI_CONN_FLAG_REMOTE_WAKEUP")
> >
> > Bitmaps consist of unsigned longs (in this case 32 bits) ...
> >
> > (This warning only happens due to chnges in the bitmap tree.)
>
> I still got this warning yesterday ...
And today, I get this warning when build Linus' tree :-(
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the bluetooth tree
2022-06-05 22:06 ` Stephen Rothwell
@ 2022-06-05 22:40 ` Yury Norov
2022-06-06 1:16 ` Stephen Rothwell
0 siblings, 1 reply; 11+ messages in thread
From: Yury Norov @ 2022-06-05 22:40 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
Linux Kernel Mailing List, Linux Next Mailing List, David Miller,
Networking, Linus Torvalds
On Mon, Jun 06, 2022 at 08:06:31AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> On Tue, 24 May 2022 08:22:56 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Mon, 16 May 2022 17:57:57 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the bluetooth tree, today's linux-next build (arm
> > > multi_v7_defconfig) produced this warning:
> > >
> > > In file included from include/linux/cpumask.h:12,
> > > from include/linux/mm_types_task.h:14,
> > > from include/linux/mm_types.h:5,
> > > from include/linux/buildid.h:5,
> > > from include/linux/module.h:14,
> > > from net/bluetooth/mgmt.c:27:
> > > In function 'bitmap_copy',
> > > inlined from 'bitmap_copy_clear_tail' at include/linux/bitmap.h:270:2,
> > > inlined from 'bitmap_from_u64' at include/linux/bitmap.h:622:2,
> > > inlined from 'set_device_flags' at net/bluetooth/mgmt.c:4534:4:
> > > include/linux/bitmap.h:261:9: warning: 'memcpy' forming offset [4, 7] is out of the bounds [0, 4] of object 'flags' with type 'long unsigned int[1]' [-Warray-bounds]
> > > 261 | memcpy(dst, src, len);
> > > | ^~~~~~~~~~~~~~~~~~~~~
> > > In file included from include/linux/kasan-checks.h:5,
> > > from include/asm-generic/rwonce.h:26,
> > > from ./arch/arm/include/generated/asm/rwonce.h:1,
> > > from include/linux/compiler.h:248,
> > > from include/linux/build_bug.h:5,
> > > from include/linux/container_of.h:5,
> > > from include/linux/list.h:5,
> > > from include/linux/module.h:12,
> > > from net/bluetooth/mgmt.c:27:
> > > net/bluetooth/mgmt.c: In function 'set_device_flags':
> > > net/bluetooth/mgmt.c:4532:40: note: 'flags' declared here
> > > 4532 | DECLARE_BITMAP(flags, __HCI_CONN_NUM_FLAGS);
> > > | ^~~~~
> > > include/linux/types.h:11:23: note: in definition of macro 'DECLARE_BITMAP'
> > > 11 | unsigned long name[BITS_TO_LONGS(bits)]
> > > | ^~~~
> > >
> > > Introduced by commit
> > >
> > > a9a347655d22 ("Bluetooth: MGMT: Add conditions for setting HCI_CONN_FLAG_REMOTE_WAKEUP")
> > >
> > > Bitmaps consist of unsigned longs (in this case 32 bits) ...
> > >
> > > (This warning only happens due to chnges in the bitmap tree.)
> >
> > I still got this warning yesterday ...
>
> And today, I get this warning when build Linus' tree :-(
Hi Stephen,
I completely forgot about this bug, and sent a quick fix when this
was spotted by Sudip [1]. Linus proposed another fix [2] that drops
bitmap API in net/bluetooth/mgmt.c.
I would prefer Linus' version, and this is the way I already suggested
to Luiz before in this thread.
Thanks,
Yury
[1] https://lore.kernel.org/lkml/YpyJ9qTNHJzz0FHY@debian/t/
[2] https://lore.kernel.org/lkml/CAHk-=whqgEA=OOPQs7JF=xps3VxjJ5uUnfXgzTv4gqTDhraZFA@mail.gmail.com/T/#mcf29754f405443ca7d2a18db863c7a20439bd5a0
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the bluetooth tree
2022-06-05 22:40 ` Yury Norov
@ 2022-06-06 1:16 ` Stephen Rothwell
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2022-06-06 1:16 UTC (permalink / raw)
To: Yury Norov
Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
Linux Kernel Mailing List, Linux Next Mailing List, David Miller,
Networking, Linus Torvalds
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
Hi Yury,
On Sun, 5 Jun 2022 15:40:27 -0700 Yury Norov <yury.norov@gmail.com> wrote:
>
> I completely forgot about this bug, and sent a quick fix when this
> was spotted by Sudip [1]. Linus proposed another fix [2] that drops
> bitmap API in net/bluetooth/mgmt.c.
>
> I would prefer Linus' version, and this is the way I already suggested
> to Luiz before in this thread.
>
> Thanks,
> Yury
>
> [1] https://lore.kernel.org/lkml/YpyJ9qTNHJzz0FHY@debian/t/
> [2] https://lore.kernel.org/lkml/CAHk-=whqgEA=OOPQs7JF=xps3VxjJ5uUnfXgzTv4gqTDhraZFA@mail.gmail.com/T/#mcf29754f405443ca7d2a18db863c7a20439bd5a0
Linus has applied his fix to his tree now (before -rc1), so it should
be all good.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the bluetooth tree
@ 2024-05-08 2:24 Stephen Rothwell
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2024-05-08 2:24 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg
Cc: Kiran K, Luiz Augusto von Dentz, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
Hi all,
After merging the bluetooth tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
In file included from drivers/bluetooth/hci_ldisc.c:34:
drivers/bluetooth/btintel.h:373:13: warning: 'btintel_hw_error' defined but not used [-Wunused-function]
373 | static void btintel_hw_error(struct hci_dev *hdev, u8 code)
| ^~~~~~~~~~~~~~~~
Introduced by commit
1d8e17157eb5 ("Bluetooth: btintel: Export few static functions")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the bluetooth tree
[not found] <PH0PR11MB51264FB7874380983C3A653BD3CF9@PH0PR11MB5126.namprd11.prod.outlook.com>
@ 2022-05-16 18:18 ` Yury Norov
0 siblings, 0 replies; 11+ messages in thread
From: Yury Norov @ 2022-05-16 18:18 UTC (permalink / raw)
To: Von Dentz, Luiz
Cc: Stephen Rothwell, Marcel Holtmann, Johan Hedberg,
Linux Kernel Mailing List, Linux Next Mailing List
On Mon, May 16, 2022 at 04:58:44PM +0000, Von Dentz, Luiz wrote:
> Hi Stephen,
>
> Interesting, so we may want to stop using bitmap_from_u64 and replace with
> bitmap_from_arr32 given the former seems to expect at least 8 bytes:
Hi Luiz,
The problem is that br_params->flags and hdev->conn_flags are bitmaps
(declared with DECLARE_BITMAP), while cp->current_flags is declared
as u32.
Is it possible to declare cp->current_flags with DECLARE_BITMAP, or
declare local current_flags as unsigned long?
DECLARE_BITMAP(current_flags, __HCI_CONN_NUM_FLAGS) = {cp->current_flags};
If so, you can drop this conversion to and from fixed size arrays,
in the following code and use bitmap API more consistently.
For example the line
if ((supported_flags | current_flags) != supported_flags)
would turn to:
if (bitmap_subset(supported_flags, current_flags))
Alternatively, because __HCI_CONN_NUM_FLAGS == 2, and if you don't
expect adding 30+ new any flags soon, you can drop bitmap API here
and use hweight32/64 as appropriate.
Thanks,
Yury
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 74937a834648..878be1cac5b7 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -4519,7 +4519,8 @@ static int set_device_flags(struct sock *sk, struct
> hci_dev *hdev, void *data,
> cp->addr.type);
>
> if (br_params) {
> - bitmap_from_u64(br_params->flags, current_flags);
> + bitmap_from_arr32(br_params->flags, ¤t_flags,
> + __HCI_CONN_NUM_FLAGS);
> status = MGMT_STATUS_SUCCESS;
> } else {
> bt_dev_warn(hdev, "No such BR/EDR device %pMR (0x%x)",
> @@ -4531,7 +4532,8 @@ static int set_device_flags(struct sock *sk, struct
> hci_dev *hdev, void *data,
> if (params) {
> DECLARE_BITMAP(flags, __HCI_CONN_NUM_FLAGS);
>
> - bitmap_from_u64(flags, current_flags);
> + bitmap_from_arr32(flags, ¤t_flags,
> + __HCI_CONN_NUM_FLAGS);
>
> /* Devices using RPAs can only be programmed in the
> * acceptlist LL Privacy has been enable otherwise they
> @@ -4546,7 +4548,8 @@ static int set_device_flags(struct sock *sk, struct
> hci_dev *hdev, void *data,
> goto unlock;
> }
>
> - bitmap_from_u64(params->flags, current_flags);
> + bitmap_from_arr32(params->flags, ¤t_flags,
> + __HCI_CONN_NUM_FLAGS);
> status = MGMT_STATUS_SUCCESS;
>
> /* Update passive scan if HCI_CONN_FLAG_DEVICE_PRIVACY
>
>
> ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
> From: Stephen Rothwell
> Sent: Monday, May 16, 2022 12:57 AM
> To: Marcel Holtmann; Johan Hedberg; Yury Norov
> Cc: Von Dentz, Luiz; Linux Kernel Mailing List; Linux Next Mailing List
> Subject: linux-next: build warning after merge of the bluetooth tree
>
> Hi all,
>
> After merging the bluetooth tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from include/linux/cpumask.h:12,
> from include/linux/mm_types_task.h:14,
> from include/linux/mm_types.h:5,
> from include/linux/buildid.h:5,
> from include/linux/module.h:14,
> from net/bluetooth/mgmt.c:27:
> In function 'bitmap_copy',
> inlined from 'bitmap_copy_clear_tail' at include/linux/bitmap.h:270:2,
> inlined from 'bitmap_from_u64' at include/linux/bitmap.h:622:2,
> inlined from 'set_device_flags' at net/bluetooth/mgmt.c:4534:4:
> include/linux/bitmap.h:261:9: warning: 'memcpy' forming offset [4, 7] is out of
> the bounds [0, 4] of object 'flags' with type 'long unsigned int[1]'
> [-Warray-bounds]
> 261 | memcpy(dst, src, len);
> | ^~~~~~~~~~~~~~~~~~~~~
> In file included from include/linux/kasan-checks.h:5,
> from include/asm-generic/rwonce.h:26,
> from ./arch/arm/include/generated/asm/rwonce.h:1,
> from include/linux/compiler.h:248,
> from include/linux/build_bug.h:5,
> from include/linux/container_of.h:5,
> from include/linux/list.h:5,
> from include/linux/module.h:12,
> from net/bluetooth/mgmt.c:27:
> net/bluetooth/mgmt.c: In function 'set_device_flags':
> net/bluetooth/mgmt.c:4532:40: note: 'flags' declared here
> 4532 | DECLARE_BITMAP(flags, __HCI_CONN_NUM_FLAGS);
> | ^~~~~
> include/linux/types.h:11:23: note: in definition of macro 'DECLARE_BITMAP'
> 11 | unsigned long name[BITS_TO_LONGS(bits)]
> | ^~~~
>
> Introduced by commit
>
> a9a347655d22 ("Bluetooth: MGMT: Add conditions for setting
> HCI_CONN_FLAG_REMOTE_WAKEUP")
>
> Bitmaps consist of unsigned longs (in this case 32 bits) ...
>
> (This warning only happens due to chnges in the bitmap tree.)
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the bluetooth tree
@ 2019-11-22 0:07 Stephen Rothwell
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2019-11-22 0:07 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg
Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 503 bytes --]
Hi all,
After merging the bluetooth tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
net/bluetooth/hci_core.c: In function 'hci_dev_do_open':
net/bluetooth/hci_core.c:1447:8: warning: 'invalid_bdaddr' may be used uninitialized in this function [-Wmaybe-uninitialized]
1447 | bool invalid_bdaddr;
| ^~~~~~~~~~~~~~
Introduced by commit
cadbc2f459be ("Bluetooth: Move error check into the right if-clause")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the bluetooth tree
@ 2019-03-17 23:30 Stephen Rothwell
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2019-03-17 23:30 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Sean Wang
[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]
Hi all,
After merging the bluetooth tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/bluetooth/btmtksdio.c: In function 'btmtksdio_interrupt':
drivers/bluetooth/btmtksdio.c:470:2: warning: 'old_len' may be used uninitialized in this function [-Wmaybe-uninitialized]
print_hex_dump(KERN_ERR, "err sdio rx: ", DUMP_PREFIX_NONE, 4, 1,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
old_data, old_len, true);
~~~~~~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btmtksdio.c:376:15: note: 'old_len' was declared here
unsigned int old_len;
^~~~~~~
drivers/bluetooth/btmtksdio.c:470:2: warning: 'old_data' may be used uninitialized in this function [-Wmaybe-uninitialized]
print_hex_dump(KERN_ERR, "err sdio rx: ", DUMP_PREFIX_NONE, 4, 1,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
old_data, old_len, true);
~~~~~~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btmtksdio.c:375:17: note: 'old_data' was declared here
unsigned char *old_data;
^~~~~~~~
Introduced by commit
d74eef2834b5 ("Bluetooth: mediatek: add support for MediaTek MT7663S and MT7668S SDIO")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the bluetooth tree
2017-11-14 0:56 Stephen Rothwell
@ 2017-11-14 9:00 ` Hans de Goede
0 siblings, 0 replies; 11+ messages in thread
From: Hans de Goede @ 2017-11-14 9:00 UTC (permalink / raw)
To: Stephen Rothwell, Marcel Holtmann, Johan Hedberg
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Hi,
On 14-11-17 01:56, Stephen Rothwell wrote:
> Hi all,
>
> After merging the bluetooth tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/bluetooth/Kconfig:35:warning: multi-line strings not supported
>
> Introduced by commit
>
> 86be3c232877 ("Bluetooth: btusb: Add a Kconfig option to enable USB autosuspend by default")
>
> There is a missing close double quote ...
Ugh, sorry about that, a patch (on top of the original) fixing this
is coming up right away.
Regards,
Hans
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the bluetooth tree
@ 2017-11-14 0:56 Stephen Rothwell
2017-11-14 9:00 ` Hans de Goede
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2017-11-14 0:56 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Hans de Goede
Hi all,
After merging the bluetooth tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/bluetooth/Kconfig:35:warning: multi-line strings not supported
Introduced by commit
86be3c232877 ("Bluetooth: btusb: Add a Kconfig option to enable USB autosuspend by default")
There is a missing close double quote ...
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2024-05-08 2:24 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 7:57 linux-next: build warning after merge of the bluetooth tree Stephen Rothwell
2022-05-23 22:22 ` Stephen Rothwell
2022-06-05 22:06 ` Stephen Rothwell
2022-06-05 22:40 ` Yury Norov
2022-06-06 1:16 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2024-05-08 2:24 Stephen Rothwell
[not found] <PH0PR11MB51264FB7874380983C3A653BD3CF9@PH0PR11MB5126.namprd11.prod.outlook.com>
2022-05-16 18:18 ` Yury Norov
2019-11-22 0:07 Stephen Rothwell
2019-03-17 23:30 Stephen Rothwell
2017-11-14 0:56 Stephen Rothwell
2017-11-14 9:00 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.