* [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform
@ 2022-05-24 10:29 ` wen.ping.teh
0 siblings, 0 replies; 14+ messages in thread
From: wen.ping.teh @ 2022-05-24 10:29 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, Dinh Nguyen, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-kernel, devicetree, Teh Wen Ping,
Yves Vandervennet, Dinh Nguyen
From: Teh Wen Ping <wen.ping.teh@intel.com>
Add Stratix 10 Software Virtual Platform device tree
Signed-off-by: Yves Vandervennet <yvanderv@opensource.altera.com>
Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
Signed-off-by: Teh Wen Ping <wen.ping.teh@intel.com>
---
arch/arm64/Kconfig.platforms | 3 +-
arch/arm64/boot/dts/altera/Makefile | 3 +-
.../dts/altera/socfpga_stratix10_swvp.dts | 131 ++++++++++++++++++
3 files changed, 135 insertions(+), 2 deletions(-)
create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index de9a18d3026f..48abe5dafaae 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -249,7 +249,8 @@ config ARCH_INTEL_SOCFPGA
bool "Intel's SoCFPGA ARMv8 Families"
help
This enables support for Intel's SoCFPGA ARMv8 families:
- Stratix 10 (ex. Altera), Agilex and eASIC N5X.
+ Stratix 10 (ex. Altera), Stratix10 Software Virtual Platform,
+ Agilex and eASIC N5X.
config ARCH_SYNQUACER
bool "Socionext SynQuacer SoC Family"
diff --git a/arch/arm64/boot/dts/altera/Makefile b/arch/arm64/boot/dts/altera/Makefile
index 4db83fbeb115..1bf0c472f6b4 100644
--- a/arch/arm64/boot/dts/altera/Makefile
+++ b/arch/arm64/boot/dts/altera/Makefile
@@ -1,3 +1,4 @@
# SPDX-License-Identifier: GPL-2.0-only
dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_stratix10_socdk.dtb \
- socfpga_stratix10_socdk_nand.dtb
+ socfpga_stratix10_socdk_nand.dtb \
+ socfpga_stratix10_swvp.dtb
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
new file mode 100644
index 000000000000..209e26d3611b
--- /dev/null
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
@@ -0,0 +1,131 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2022, Intel Corporation
+ */
+
+#include "socfpga_stratix10.dtsi"
+
+/ {
+ model = "SOCFPGA Stratix 10 SWVP";
+ compatible = "arm,foundation-aarch64", "arm,vexpress";
+
+ aliases {
+ serial0 = &uart0;
+ serial1 = &uart1;
+
+ timer0 = &timer0;
+ timer1 = &timer1;
+ timer2 = &timer2;
+ timer3 = &timer3;
+
+ ethernet0 = &gmac0;
+ ethernet1 = &gmac1;
+ ethernet2 = &gmac2;
+ };
+
+ chosen {
+ bootargs = "rdinit=/sbin/init ip=dhcp mem=2048M";
+ stdout-path = "serial1:115200n8";
+ linux,initrd-start = <0x10000000>;
+ linux,initrd-end = <0x125c8324>;
+ };
+
+ memory {
+ device_type = "memory";
+ reg = <0x0 0x0 0x0 0x80000000>;
+ };
+
+ soc {
+ clocks {
+ osc1 {
+ clock-frequency = <25000000>;
+ };
+ };
+
+ l2-cache@fffff000 {
+ compatible = "arm,pl310-cache";
+ reg = <0xfffff000 0x1000>;
+ interrupts = <0x0 0x12 0x4>;
+ cache-unified;
+ cache-level = <0x2>;
+ linux,phandle = <0x1>;
+ };
+ };
+};
+
+&cpu0 {
+ enable-method = "spin-table";
+ cpu-release-addr = <0x0 0x0000fff8>;
+};
+
+&cpu1 {
+ enable-method = "spin-table";
+ cpu-release-addr = <0x0 0x0000fff8>;
+};
+
+&cpu2 {
+ enable-method = "spin-table";
+ cpu-release-addr = <0x0 0x0000fff8>;
+};
+
+&cpu3 {
+ enable-method = "spin-table";
+ cpu-release-addr = <0x0 0x0000fff8>;
+};
+
+&gmac0 {
+ status = "okay";
+ phy-mode = "rgmii";
+ phy-addr = <0xffffffff>;
+ snps,max-mtu = <0x0>;
+};
+
+&gmac1 {
+ status = "okay";
+ phy-mode = "rgmii";
+ phy-addr = <0xffffffff>;
+};
+
+&gmac2 {
+ status = "okay";
+ phy-mode = "rgmii";
+ phy-addr = <0xffffffff>;
+};
+
+&mmc {
+ status = "okay";
+ altr,dw-mshc-ciu-div = <0x3>;
+ altr,dw-mshc-sdr-timing = <0x0 0x3>;
+ cap-sd-highspeed;
+ cap-mmc-highspeed;
+ broken-cd;
+ bus-width = <4>;
+};
+
+&uart0 {
+ status = "okay";
+};
+
+&uart1 {
+ status = "okay";
+};
+
+&usb0 {
+ clocks = <&clkmgr STRATIX10_L4_MP_CLK>;
+ status = "okay";
+};
+
+&usb1 {
+ clocks = <&clkmgr STRATIX10_L4_MP_CLK>;
+ status = "okay";
+};
+
+&rst {
+ altr,modrst-offset = <0x20>;
+};
+
+&sysmgr {
+ reg = <0xffd12000 0x1000>;
+ interrupts = <0x0 0x10 0x4>;
+ cpu1-start-addr = <0xffd06230>;
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform
@ 2022-05-24 10:29 ` wen.ping.teh
0 siblings, 0 replies; 14+ messages in thread
From: wen.ping.teh @ 2022-05-24 10:29 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, Dinh Nguyen, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-kernel, devicetree, Teh Wen Ping,
Yves Vandervennet, Dinh Nguyen
From: Teh Wen Ping <wen.ping.teh@intel.com>
Add Stratix 10 Software Virtual Platform device tree
Signed-off-by: Yves Vandervennet <yvanderv@opensource.altera.com>
Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
Signed-off-by: Teh Wen Ping <wen.ping.teh@intel.com>
---
arch/arm64/Kconfig.platforms | 3 +-
arch/arm64/boot/dts/altera/Makefile | 3 +-
.../dts/altera/socfpga_stratix10_swvp.dts | 131 ++++++++++++++++++
3 files changed, 135 insertions(+), 2 deletions(-)
create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index de9a18d3026f..48abe5dafaae 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -249,7 +249,8 @@ config ARCH_INTEL_SOCFPGA
bool "Intel's SoCFPGA ARMv8 Families"
help
This enables support for Intel's SoCFPGA ARMv8 families:
- Stratix 10 (ex. Altera), Agilex and eASIC N5X.
+ Stratix 10 (ex. Altera), Stratix10 Software Virtual Platform,
+ Agilex and eASIC N5X.
config ARCH_SYNQUACER
bool "Socionext SynQuacer SoC Family"
diff --git a/arch/arm64/boot/dts/altera/Makefile b/arch/arm64/boot/dts/altera/Makefile
index 4db83fbeb115..1bf0c472f6b4 100644
--- a/arch/arm64/boot/dts/altera/Makefile
+++ b/arch/arm64/boot/dts/altera/Makefile
@@ -1,3 +1,4 @@
# SPDX-License-Identifier: GPL-2.0-only
dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_stratix10_socdk.dtb \
- socfpga_stratix10_socdk_nand.dtb
+ socfpga_stratix10_socdk_nand.dtb \
+ socfpga_stratix10_swvp.dtb
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
new file mode 100644
index 000000000000..209e26d3611b
--- /dev/null
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
@@ -0,0 +1,131 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2022, Intel Corporation
+ */
+
+#include "socfpga_stratix10.dtsi"
+
+/ {
+ model = "SOCFPGA Stratix 10 SWVP";
+ compatible = "arm,foundation-aarch64", "arm,vexpress";
+
+ aliases {
+ serial0 = &uart0;
+ serial1 = &uart1;
+
+ timer0 = &timer0;
+ timer1 = &timer1;
+ timer2 = &timer2;
+ timer3 = &timer3;
+
+ ethernet0 = &gmac0;
+ ethernet1 = &gmac1;
+ ethernet2 = &gmac2;
+ };
+
+ chosen {
+ bootargs = "rdinit=/sbin/init ip=dhcp mem=2048M";
+ stdout-path = "serial1:115200n8";
+ linux,initrd-start = <0x10000000>;
+ linux,initrd-end = <0x125c8324>;
+ };
+
+ memory {
+ device_type = "memory";
+ reg = <0x0 0x0 0x0 0x80000000>;
+ };
+
+ soc {
+ clocks {
+ osc1 {
+ clock-frequency = <25000000>;
+ };
+ };
+
+ l2-cache@fffff000 {
+ compatible = "arm,pl310-cache";
+ reg = <0xfffff000 0x1000>;
+ interrupts = <0x0 0x12 0x4>;
+ cache-unified;
+ cache-level = <0x2>;
+ linux,phandle = <0x1>;
+ };
+ };
+};
+
+&cpu0 {
+ enable-method = "spin-table";
+ cpu-release-addr = <0x0 0x0000fff8>;
+};
+
+&cpu1 {
+ enable-method = "spin-table";
+ cpu-release-addr = <0x0 0x0000fff8>;
+};
+
+&cpu2 {
+ enable-method = "spin-table";
+ cpu-release-addr = <0x0 0x0000fff8>;
+};
+
+&cpu3 {
+ enable-method = "spin-table";
+ cpu-release-addr = <0x0 0x0000fff8>;
+};
+
+&gmac0 {
+ status = "okay";
+ phy-mode = "rgmii";
+ phy-addr = <0xffffffff>;
+ snps,max-mtu = <0x0>;
+};
+
+&gmac1 {
+ status = "okay";
+ phy-mode = "rgmii";
+ phy-addr = <0xffffffff>;
+};
+
+&gmac2 {
+ status = "okay";
+ phy-mode = "rgmii";
+ phy-addr = <0xffffffff>;
+};
+
+&mmc {
+ status = "okay";
+ altr,dw-mshc-ciu-div = <0x3>;
+ altr,dw-mshc-sdr-timing = <0x0 0x3>;
+ cap-sd-highspeed;
+ cap-mmc-highspeed;
+ broken-cd;
+ bus-width = <4>;
+};
+
+&uart0 {
+ status = "okay";
+};
+
+&uart1 {
+ status = "okay";
+};
+
+&usb0 {
+ clocks = <&clkmgr STRATIX10_L4_MP_CLK>;
+ status = "okay";
+};
+
+&usb1 {
+ clocks = <&clkmgr STRATIX10_L4_MP_CLK>;
+ status = "okay";
+};
+
+&rst {
+ altr,modrst-offset = <0x20>;
+};
+
+&sysmgr {
+ reg = <0xffd12000 0x1000>;
+ interrupts = <0x0 0x10 0x4>;
+ cpu1-start-addr = <0xffd06230>;
+};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform
2022-05-24 10:29 ` wen.ping.teh
@ 2022-05-24 11:04 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-24 11:04 UTC (permalink / raw)
To: wen.ping.teh, Catalin Marinas, Will Deacon, Dinh Nguyen,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-kernel, devicetree, Yves Vandervennet,
Dinh Nguyen
On 24/05/2022 12:29, wen.ping.teh@intel.com wrote:
> From: Teh Wen Ping <wen.ping.teh@intel.com>
>
> Add Stratix 10 Software Virtual Platform device tree
>
> Signed-off-by: Yves Vandervennet <yvanderv@opensource.altera.com>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> Signed-off-by: Teh Wen Ping <wen.ping.teh@intel.com>
> ---
> arch/arm64/Kconfig.platforms | 3 +-
> arch/arm64/boot/dts/altera/Makefile | 3 +-
> .../dts/altera/socfpga_stratix10_swvp.dts | 131 ++++++++++++++++++
> 3 files changed, 135 insertions(+), 2 deletions(-)
> create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index de9a18d3026f..48abe5dafaae 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -249,7 +249,8 @@ config ARCH_INTEL_SOCFPGA
> bool "Intel's SoCFPGA ARMv8 Families"
> help
> This enables support for Intel's SoCFPGA ARMv8 families:
> - Stratix 10 (ex. Altera), Agilex and eASIC N5X.
> + Stratix 10 (ex. Altera), Stratix10 Software Virtual Platform,
> + Agilex and eASIC N5X.
>
> config ARCH_SYNQUACER
> bool "Socionext SynQuacer SoC Family"
> diff --git a/arch/arm64/boot/dts/altera/Makefile b/arch/arm64/boot/dts/altera/Makefile
> index 4db83fbeb115..1bf0c472f6b4 100644
> --- a/arch/arm64/boot/dts/altera/Makefile
> +++ b/arch/arm64/boot/dts/altera/Makefile
> @@ -1,3 +1,4 @@
> # SPDX-License-Identifier: GPL-2.0-only
> dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_stratix10_socdk.dtb \
> - socfpga_stratix10_socdk_nand.dtb
> + socfpga_stratix10_socdk_nand.dtb \
> + socfpga_stratix10_swvp.dtb
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> new file mode 100644
> index 000000000000..209e26d3611b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> @@ -0,0 +1,131 @@
> +// SPDX-License-Identifier: GPL-2.0
No need for indentation before GPL.
> +/*
> + * Copyright (C) 2022, Intel Corporation
> + */
> +
> +#include "socfpga_stratix10.dtsi"
> +
> +/ {
> + model = "SOCFPGA Stratix 10 SWVP";
> + compatible = "arm,foundation-aarch64", "arm,vexpress";
Does not look like compatible for stratix at all... Please do not invent
stuff but take a look at existing code and customize it.
> +
> + aliases {
> + serial0 = &uart0;
> + serial1 = &uart1;
> +
> + timer0 = &timer0;
> + timer1 = &timer1;
> + timer2 = &timer2;
> + timer3 = &timer3;
> +
> + ethernet0 = &gmac0;
> + ethernet1 = &gmac1;
> + ethernet2 = &gmac2;
> + };
> +
> + chosen {
> + bootargs = "rdinit=/sbin/init ip=dhcp mem=2048M";
Bo bootargs,
> + stdout-path = "serial1:115200n8";
> + linux,initrd-start = <0x10000000>;
> + linux,initrd-end = <0x125c8324>;
> + };
> +
> + memory {
> + device_type = "memory";
> + reg = <0x0 0x0 0x0 0x80000000>;
> + };
> +
> + soc {
> + clocks {
> + osc1 {
> + clock-frequency = <25000000>;
Override by label.
> + };
> + };
> +
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform
@ 2022-05-24 11:04 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-24 11:04 UTC (permalink / raw)
To: wen.ping.teh, Catalin Marinas, Will Deacon, Dinh Nguyen,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-kernel, devicetree, Yves Vandervennet,
Dinh Nguyen
On 24/05/2022 12:29, wen.ping.teh@intel.com wrote:
> From: Teh Wen Ping <wen.ping.teh@intel.com>
>
> Add Stratix 10 Software Virtual Platform device tree
>
> Signed-off-by: Yves Vandervennet <yvanderv@opensource.altera.com>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> Signed-off-by: Teh Wen Ping <wen.ping.teh@intel.com>
> ---
> arch/arm64/Kconfig.platforms | 3 +-
> arch/arm64/boot/dts/altera/Makefile | 3 +-
> .../dts/altera/socfpga_stratix10_swvp.dts | 131 ++++++++++++++++++
> 3 files changed, 135 insertions(+), 2 deletions(-)
> create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index de9a18d3026f..48abe5dafaae 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -249,7 +249,8 @@ config ARCH_INTEL_SOCFPGA
> bool "Intel's SoCFPGA ARMv8 Families"
> help
> This enables support for Intel's SoCFPGA ARMv8 families:
> - Stratix 10 (ex. Altera), Agilex and eASIC N5X.
> + Stratix 10 (ex. Altera), Stratix10 Software Virtual Platform,
> + Agilex and eASIC N5X.
>
> config ARCH_SYNQUACER
> bool "Socionext SynQuacer SoC Family"
> diff --git a/arch/arm64/boot/dts/altera/Makefile b/arch/arm64/boot/dts/altera/Makefile
> index 4db83fbeb115..1bf0c472f6b4 100644
> --- a/arch/arm64/boot/dts/altera/Makefile
> +++ b/arch/arm64/boot/dts/altera/Makefile
> @@ -1,3 +1,4 @@
> # SPDX-License-Identifier: GPL-2.0-only
> dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_stratix10_socdk.dtb \
> - socfpga_stratix10_socdk_nand.dtb
> + socfpga_stratix10_socdk_nand.dtb \
> + socfpga_stratix10_swvp.dtb
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> new file mode 100644
> index 000000000000..209e26d3611b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> @@ -0,0 +1,131 @@
> +// SPDX-License-Identifier: GPL-2.0
No need for indentation before GPL.
> +/*
> + * Copyright (C) 2022, Intel Corporation
> + */
> +
> +#include "socfpga_stratix10.dtsi"
> +
> +/ {
> + model = "SOCFPGA Stratix 10 SWVP";
> + compatible = "arm,foundation-aarch64", "arm,vexpress";
Does not look like compatible for stratix at all... Please do not invent
stuff but take a look at existing code and customize it.
> +
> + aliases {
> + serial0 = &uart0;
> + serial1 = &uart1;
> +
> + timer0 = &timer0;
> + timer1 = &timer1;
> + timer2 = &timer2;
> + timer3 = &timer3;
> +
> + ethernet0 = &gmac0;
> + ethernet1 = &gmac1;
> + ethernet2 = &gmac2;
> + };
> +
> + chosen {
> + bootargs = "rdinit=/sbin/init ip=dhcp mem=2048M";
Bo bootargs,
> + stdout-path = "serial1:115200n8";
> + linux,initrd-start = <0x10000000>;
> + linux,initrd-end = <0x125c8324>;
> + };
> +
> + memory {
> + device_type = "memory";
> + reg = <0x0 0x0 0x0 0x80000000>;
> + };
> +
> + soc {
> + clocks {
> + osc1 {
> + clock-frequency = <25000000>;
Override by label.
> + };
> + };
> +
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform
2022-05-24 10:29 ` wen.ping.teh
@ 2022-05-24 11:23 ` Robin Murphy
-1 siblings, 0 replies; 14+ messages in thread
From: Robin Murphy @ 2022-05-24 11:23 UTC (permalink / raw)
To: wen.ping.teh, Catalin Marinas, Will Deacon, Dinh Nguyen,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-kernel, devicetree, Yves Vandervennet,
Dinh Nguyen
On 2022-05-24 11:29, wen.ping.teh@intel.com wrote:
> From: Teh Wen Ping <wen.ping.teh@intel.com>
>
> Add Stratix 10 Software Virtual Platform device tree
>
> Signed-off-by: Yves Vandervennet <yvanderv@opensource.altera.com>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> Signed-off-by: Teh Wen Ping <wen.ping.teh@intel.com>
> ---
> arch/arm64/Kconfig.platforms | 3 +-
> arch/arm64/boot/dts/altera/Makefile | 3 +-
> .../dts/altera/socfpga_stratix10_swvp.dts | 131 ++++++++++++++++++
> 3 files changed, 135 insertions(+), 2 deletions(-)
> create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index de9a18d3026f..48abe5dafaae 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -249,7 +249,8 @@ config ARCH_INTEL_SOCFPGA
> bool "Intel's SoCFPGA ARMv8 Families"
> help
> This enables support for Intel's SoCFPGA ARMv8 families:
> - Stratix 10 (ex. Altera), Agilex and eASIC N5X.
> + Stratix 10 (ex. Altera), Stratix10 Software Virtual Platform,
> + Agilex and eASIC N5X.
>
> config ARCH_SYNQUACER
> bool "Socionext SynQuacer SoC Family"
> diff --git a/arch/arm64/boot/dts/altera/Makefile b/arch/arm64/boot/dts/altera/Makefile
> index 4db83fbeb115..1bf0c472f6b4 100644
> --- a/arch/arm64/boot/dts/altera/Makefile
> +++ b/arch/arm64/boot/dts/altera/Makefile
> @@ -1,3 +1,4 @@
> # SPDX-License-Identifier: GPL-2.0-only
> dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_stratix10_socdk.dtb \
> - socfpga_stratix10_socdk_nand.dtb
> + socfpga_stratix10_socdk_nand.dtb \
> + socfpga_stratix10_swvp.dtb
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> new file mode 100644
> index 000000000000..209e26d3611b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> @@ -0,0 +1,131 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2022, Intel Corporation
> + */
> +
> +#include "socfpga_stratix10.dtsi"
> +
> +/ {
> + model = "SOCFPGA Stratix 10 SWVP";
> + compatible = "arm,foundation-aarch64", "arm,vexpress";
This is definitely not compatible with any Arm Versatile Express
platform. It doesn't even have RAM in the same place, for starters.
> +
> + aliases {
> + serial0 = &uart0;
> + serial1 = &uart1;
> +
> + timer0 = &timer0;
> + timer1 = &timer1;
> + timer2 = &timer2;
> + timer3 = &timer3;
> +
> + ethernet0 = &gmac0;
> + ethernet1 = &gmac1;
> + ethernet2 = &gmac2;
> + };
> +
> + chosen {
> + bootargs = "rdinit=/sbin/init ip=dhcp mem=2048M";
> + stdout-path = "serial1:115200n8";
> + linux,initrd-start = <0x10000000>;
> + linux,initrd-end = <0x125c8324>;
> + };
> +
> + memory {
> + device_type = "memory";
> + reg = <0x0 0x0 0x0 0x80000000>;
> + };
> +
> + soc {
> + clocks {
> + osc1 {
> + clock-frequency = <25000000>;
> + };
> + };
> +
> + l2-cache@fffff000 {
> + compatible = "arm,pl310-cache";
Yikes, I hope not!
I didn't think AArch64 even allows outer caches that don't honour CPU
cache maintenance by VA? Either way I can't imagine we'd ever accept
PL310 support in mainline, so even if your model does actually have this
for some inexplicable reason, I don't think there's any point exposing
it in the DT.
Robin.
> + reg = <0xfffff000 0x1000>;
> + interrupts = <0x0 0x12 0x4>;
> + cache-unified;
> + cache-level = <0x2>;
> + linux,phandle = <0x1>;
> + };
> + };
> +};
> +
> +&cpu0 {
> + enable-method = "spin-table";
> + cpu-release-addr = <0x0 0x0000fff8>;
> +};
> +
> +&cpu1 {
> + enable-method = "spin-table";
> + cpu-release-addr = <0x0 0x0000fff8>;
> +};
> +
> +&cpu2 {
> + enable-method = "spin-table";
> + cpu-release-addr = <0x0 0x0000fff8>;
> +};
> +
> +&cpu3 {
> + enable-method = "spin-table";
> + cpu-release-addr = <0x0 0x0000fff8>;
> +};
> +
> +&gmac0 {
> + status = "okay";
> + phy-mode = "rgmii";
> + phy-addr = <0xffffffff>;
> + snps,max-mtu = <0x0>;
> +};
> +
> +&gmac1 {
> + status = "okay";
> + phy-mode = "rgmii";
> + phy-addr = <0xffffffff>;
> +};
> +
> +&gmac2 {
> + status = "okay";
> + phy-mode = "rgmii";
> + phy-addr = <0xffffffff>;
> +};
> +
> +&mmc {
> + status = "okay";
> + altr,dw-mshc-ciu-div = <0x3>;
> + altr,dw-mshc-sdr-timing = <0x0 0x3>;
> + cap-sd-highspeed;
> + cap-mmc-highspeed;
> + broken-cd;
> + bus-width = <4>;
> +};
> +
> +&uart0 {
> + status = "okay";
> +};
> +
> +&uart1 {
> + status = "okay";
> +};
> +
> +&usb0 {
> + clocks = <&clkmgr STRATIX10_L4_MP_CLK>;
> + status = "okay";
> +};
> +
> +&usb1 {
> + clocks = <&clkmgr STRATIX10_L4_MP_CLK>;
> + status = "okay";
> +};
> +
> +&rst {
> + altr,modrst-offset = <0x20>;
> +};
> +
> +&sysmgr {
> + reg = <0xffd12000 0x1000>;
> + interrupts = <0x0 0x10 0x4>;
> + cpu1-start-addr = <0xffd06230>;
> +};
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform
@ 2022-05-24 11:23 ` Robin Murphy
0 siblings, 0 replies; 14+ messages in thread
From: Robin Murphy @ 2022-05-24 11:23 UTC (permalink / raw)
To: wen.ping.teh, Catalin Marinas, Will Deacon, Dinh Nguyen,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-kernel, devicetree, Yves Vandervennet,
Dinh Nguyen
On 2022-05-24 11:29, wen.ping.teh@intel.com wrote:
> From: Teh Wen Ping <wen.ping.teh@intel.com>
>
> Add Stratix 10 Software Virtual Platform device tree
>
> Signed-off-by: Yves Vandervennet <yvanderv@opensource.altera.com>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> Signed-off-by: Teh Wen Ping <wen.ping.teh@intel.com>
> ---
> arch/arm64/Kconfig.platforms | 3 +-
> arch/arm64/boot/dts/altera/Makefile | 3 +-
> .../dts/altera/socfpga_stratix10_swvp.dts | 131 ++++++++++++++++++
> 3 files changed, 135 insertions(+), 2 deletions(-)
> create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index de9a18d3026f..48abe5dafaae 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -249,7 +249,8 @@ config ARCH_INTEL_SOCFPGA
> bool "Intel's SoCFPGA ARMv8 Families"
> help
> This enables support for Intel's SoCFPGA ARMv8 families:
> - Stratix 10 (ex. Altera), Agilex and eASIC N5X.
> + Stratix 10 (ex. Altera), Stratix10 Software Virtual Platform,
> + Agilex and eASIC N5X.
>
> config ARCH_SYNQUACER
> bool "Socionext SynQuacer SoC Family"
> diff --git a/arch/arm64/boot/dts/altera/Makefile b/arch/arm64/boot/dts/altera/Makefile
> index 4db83fbeb115..1bf0c472f6b4 100644
> --- a/arch/arm64/boot/dts/altera/Makefile
> +++ b/arch/arm64/boot/dts/altera/Makefile
> @@ -1,3 +1,4 @@
> # SPDX-License-Identifier: GPL-2.0-only
> dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_stratix10_socdk.dtb \
> - socfpga_stratix10_socdk_nand.dtb
> + socfpga_stratix10_socdk_nand.dtb \
> + socfpga_stratix10_swvp.dtb
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> new file mode 100644
> index 000000000000..209e26d3611b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> @@ -0,0 +1,131 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2022, Intel Corporation
> + */
> +
> +#include "socfpga_stratix10.dtsi"
> +
> +/ {
> + model = "SOCFPGA Stratix 10 SWVP";
> + compatible = "arm,foundation-aarch64", "arm,vexpress";
This is definitely not compatible with any Arm Versatile Express
platform. It doesn't even have RAM in the same place, for starters.
> +
> + aliases {
> + serial0 = &uart0;
> + serial1 = &uart1;
> +
> + timer0 = &timer0;
> + timer1 = &timer1;
> + timer2 = &timer2;
> + timer3 = &timer3;
> +
> + ethernet0 = &gmac0;
> + ethernet1 = &gmac1;
> + ethernet2 = &gmac2;
> + };
> +
> + chosen {
> + bootargs = "rdinit=/sbin/init ip=dhcp mem=2048M";
> + stdout-path = "serial1:115200n8";
> + linux,initrd-start = <0x10000000>;
> + linux,initrd-end = <0x125c8324>;
> + };
> +
> + memory {
> + device_type = "memory";
> + reg = <0x0 0x0 0x0 0x80000000>;
> + };
> +
> + soc {
> + clocks {
> + osc1 {
> + clock-frequency = <25000000>;
> + };
> + };
> +
> + l2-cache@fffff000 {
> + compatible = "arm,pl310-cache";
Yikes, I hope not!
I didn't think AArch64 even allows outer caches that don't honour CPU
cache maintenance by VA? Either way I can't imagine we'd ever accept
PL310 support in mainline, so even if your model does actually have this
for some inexplicable reason, I don't think there's any point exposing
it in the DT.
Robin.
> + reg = <0xfffff000 0x1000>;
> + interrupts = <0x0 0x12 0x4>;
> + cache-unified;
> + cache-level = <0x2>;
> + linux,phandle = <0x1>;
> + };
> + };
> +};
> +
> +&cpu0 {
> + enable-method = "spin-table";
> + cpu-release-addr = <0x0 0x0000fff8>;
> +};
> +
> +&cpu1 {
> + enable-method = "spin-table";
> + cpu-release-addr = <0x0 0x0000fff8>;
> +};
> +
> +&cpu2 {
> + enable-method = "spin-table";
> + cpu-release-addr = <0x0 0x0000fff8>;
> +};
> +
> +&cpu3 {
> + enable-method = "spin-table";
> + cpu-release-addr = <0x0 0x0000fff8>;
> +};
> +
> +&gmac0 {
> + status = "okay";
> + phy-mode = "rgmii";
> + phy-addr = <0xffffffff>;
> + snps,max-mtu = <0x0>;
> +};
> +
> +&gmac1 {
> + status = "okay";
> + phy-mode = "rgmii";
> + phy-addr = <0xffffffff>;
> +};
> +
> +&gmac2 {
> + status = "okay";
> + phy-mode = "rgmii";
> + phy-addr = <0xffffffff>;
> +};
> +
> +&mmc {
> + status = "okay";
> + altr,dw-mshc-ciu-div = <0x3>;
> + altr,dw-mshc-sdr-timing = <0x0 0x3>;
> + cap-sd-highspeed;
> + cap-mmc-highspeed;
> + broken-cd;
> + bus-width = <4>;
> +};
> +
> +&uart0 {
> + status = "okay";
> +};
> +
> +&uart1 {
> + status = "okay";
> +};
> +
> +&usb0 {
> + clocks = <&clkmgr STRATIX10_L4_MP_CLK>;
> + status = "okay";
> +};
> +
> +&usb1 {
> + clocks = <&clkmgr STRATIX10_L4_MP_CLK>;
> + status = "okay";
> +};
> +
> +&rst {
> + altr,modrst-offset = <0x20>;
> +};
> +
> +&sysmgr {
> + reg = <0xffd12000 0x1000>;
> + interrupts = <0x0 0x10 0x4>;
> + cpu1-start-addr = <0xffd06230>;
> +};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform
2022-05-24 10:29 ` wen.ping.teh
@ 2022-05-24 13:53 ` Dinh Nguyen
-1 siblings, 0 replies; 14+ messages in thread
From: Dinh Nguyen @ 2022-05-24 13:53 UTC (permalink / raw)
To: wen.ping.teh, Catalin Marinas, Will Deacon, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-kernel, devicetree, Yves Vandervennet,
Dinh Nguyen
On 5/24/22 05:29, wen.ping.teh@intel.com wrote:
> From: Teh Wen Ping <wen.ping.teh@intel.com>
>
> Add Stratix 10 Software Virtual Platform device tree
>
> Signed-off-by: Yves Vandervennet <yvanderv@opensource.altera.com>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
Please remove the above 2 addresses, they no longer exists.
Dinh
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform
@ 2022-05-24 13:53 ` Dinh Nguyen
0 siblings, 0 replies; 14+ messages in thread
From: Dinh Nguyen @ 2022-05-24 13:53 UTC (permalink / raw)
To: wen.ping.teh, Catalin Marinas, Will Deacon, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-kernel, devicetree, Yves Vandervennet,
Dinh Nguyen
On 5/24/22 05:29, wen.ping.teh@intel.com wrote:
> From: Teh Wen Ping <wen.ping.teh@intel.com>
>
> Add Stratix 10 Software Virtual Platform device tree
>
> Signed-off-by: Yves Vandervennet <yvanderv@opensource.altera.com>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
Please remove the above 2 addresses, they no longer exists.
Dinh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform
2022-05-24 11:04 ` Krzysztof Kozlowski
@ 2022-06-02 3:46 ` wen.ping.teh
-1 siblings, 0 replies; 14+ messages in thread
From: wen.ping.teh @ 2022-06-02 3:46 UTC (permalink / raw)
To: krzysztof.kozlowski
Cc: catalin.marinas, devicetree, dinguyen, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-kernel, robh+dt, wen.ping.teh, will
From: wen.ping.teh@intel.com
Hello Krzysztof,
>> + chosen {
>> + bootargs = "rdinit=/sbin/init ip=dhcp mem=2048M";
>
>Bo bootargs,
Could you clarify what does "Bo bootargs," mean?
Thanks,
Wen Ping
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform
@ 2022-06-02 3:46 ` wen.ping.teh
0 siblings, 0 replies; 14+ messages in thread
From: wen.ping.teh @ 2022-06-02 3:46 UTC (permalink / raw)
To: krzysztof.kozlowski
Cc: catalin.marinas, devicetree, dinguyen, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-kernel, robh+dt, wen.ping.teh, will
From: wen.ping.teh@intel.com
Hello Krzysztof,
>> + chosen {
>> + bootargs = "rdinit=/sbin/init ip=dhcp mem=2048M";
>
>Bo bootargs,
Could you clarify what does "Bo bootargs," mean?
Thanks,
Wen Ping
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform
2022-06-02 3:46 ` wen.ping.teh
@ 2022-06-02 9:51 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-02 9:51 UTC (permalink / raw)
To: wen.ping.teh
Cc: catalin.marinas, devicetree, dinguyen, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-kernel, robh+dt, will
On 02/06/2022 05:46, wen.ping.teh@intel.com wrote:
> From: wen.ping.teh@intel.com
>
> Hello Krzysztof,
>
>>> + chosen {
>>> + bootargs = "rdinit=/sbin/init ip=dhcp mem=2048M";
>>
>> Bo bootargs,
> Could you clarify what does "Bo bootargs," mean?
Ah, there was a typo. Should be: "No bootargs".
Please remove such bootargs because this is not a property of a hardware
and different user system could use different bootargs.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform
@ 2022-06-02 9:51 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-02 9:51 UTC (permalink / raw)
To: wen.ping.teh
Cc: catalin.marinas, devicetree, dinguyen, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-kernel, robh+dt, will
On 02/06/2022 05:46, wen.ping.teh@intel.com wrote:
> From: wen.ping.teh@intel.com
>
> Hello Krzysztof,
>
>>> + chosen {
>>> + bootargs = "rdinit=/sbin/init ip=dhcp mem=2048M";
>>
>> Bo bootargs,
> Could you clarify what does "Bo bootargs," mean?
Ah, there was a typo. Should be: "No bootargs".
Please remove such bootargs because this is not a property of a hardware
and different user system could use different bootargs.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform
2022-05-24 11:23 ` Robin Murphy
@ 2022-06-02 14:38 ` wen.ping.teh
-1 siblings, 0 replies; 14+ messages in thread
From: wen.ping.teh @ 2022-06-02 14:38 UTC (permalink / raw)
To: robin.murphy
Cc: catalin.marinas, devicetree, dinguyen, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-kernel, robh+dt, wen.ping.teh, will
From: wen.ping.teh@intel.com
Hello Robin,
>> +/ {
>> + model = "SOCFPGA Stratix 10 SWVP";
>> + compatible = "arm,foundation-aarch64", "arm,vexpress";
>
>This is definitely not compatible with any Arm Versatile Express
>platform. It doesn't even have RAM in the same place, for starters.
Will change to the correct platform i.e. "altr,socfpga-stratix10"
>> + l2-cache@fffff000 {
>> + compatible = "arm,pl310-cache";
>
>Yikes, I hope not!
>
>I didn't think AArch64 even allows outer caches that don't honour CPU
>cache maintenance by VA? Either way I can't imagine we'd ever accept
>PL310 support in mainline, so even if your model does actually have this
>for some inexplicable reason, I don't think there's any point exposing
>it in the DT.
Will remove outer cache.
All fixes have been done in v2 patch.
https://lore.kernel.org/linux-arm-kernel/20220602141151.3431212-1-wen.ping.teh@intel.com/T/#u
Thanks,
Wen Ping
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform
@ 2022-06-02 14:38 ` wen.ping.teh
0 siblings, 0 replies; 14+ messages in thread
From: wen.ping.teh @ 2022-06-02 14:38 UTC (permalink / raw)
To: robin.murphy
Cc: catalin.marinas, devicetree, dinguyen, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-kernel, robh+dt, wen.ping.teh, will
From: wen.ping.teh@intel.com
Hello Robin,
>> +/ {
>> + model = "SOCFPGA Stratix 10 SWVP";
>> + compatible = "arm,foundation-aarch64", "arm,vexpress";
>
>This is definitely not compatible with any Arm Versatile Express
>platform. It doesn't even have RAM in the same place, for starters.
Will change to the correct platform i.e. "altr,socfpga-stratix10"
>> + l2-cache@fffff000 {
>> + compatible = "arm,pl310-cache";
>
>Yikes, I hope not!
>
>I didn't think AArch64 even allows outer caches that don't honour CPU
>cache maintenance by VA? Either way I can't imagine we'd ever accept
>PL310 support in mainline, so even if your model does actually have this
>for some inexplicable reason, I don't think there's any point exposing
>it in the DT.
Will remove outer cache.
All fixes have been done in v2 patch.
https://lore.kernel.org/linux-arm-kernel/20220602141151.3431212-1-wen.ping.teh@intel.com/T/#u
Thanks,
Wen Ping
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2022-06-02 14:40 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-24 10:29 [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform wen.ping.teh
2022-05-24 10:29 ` wen.ping.teh
2022-05-24 11:04 ` Krzysztof Kozlowski
2022-05-24 11:04 ` Krzysztof Kozlowski
2022-06-02 3:46 ` wen.ping.teh
2022-06-02 3:46 ` wen.ping.teh
2022-06-02 9:51 ` Krzysztof Kozlowski
2022-06-02 9:51 ` Krzysztof Kozlowski
2022-05-24 11:23 ` Robin Murphy
2022-05-24 11:23 ` Robin Murphy
2022-06-02 14:38 ` wen.ping.teh
2022-06-02 14:38 ` wen.ping.teh
2022-05-24 13:53 ` Dinh Nguyen
2022-05-24 13:53 ` Dinh Nguyen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.