* [Buildroot] [PATCH v2] package/linux-tools: openssl dependency for x86_64 selftests
@ 2022-05-24 17:05 Jarkko Sakkinen
2022-05-25 7:07 ` Yann E. MORIN
2022-06-01 20:53 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2022-05-24 17:05 UTC (permalink / raw)
To: buildroot; +Cc: Peter Seiderer, Jarkko Sakkinen, Yann E. MORIN
On x86_64, libssl is a dependency for kselftests. selftests/sgx depends on
it. Thus, select it in "Config.in", and add it as a build dependency in
"linux-tool-selftests.mk.in".
Link: https://lore.kernel.org/buildroot/20220517224809.21f77949@gmx.net/
Suggested-by: Peter Seiderer <ps.report@gmx.net>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@iki.fi>
---
v2:
Config.in: BR2_PACKAGE_LIBOPENSSL => BR2_PACKAGE_OPENSSL
---
package/linux-tools/Config.in | 1 +
package/linux-tools/linux-tool-selftests.mk.in | 3 +++
2 files changed, 4 insertions(+)
diff --git a/package/linux-tools/Config.in b/package/linux-tools/Config.in
index 791f2c085c..6217fcfb7a 100644
--- a/package/linux-tools/Config.in
+++ b/package/linux-tools/Config.in
@@ -98,6 +98,7 @@ config BR2_PACKAGE_LINUX_TOOLS_SELFTESTS
select BR2_PACKAGE_LIBCAP_NG
select BR2_PACKAGE_UTIL_LINUX
select BR2_PACKAGE_UTIL_LINUX_SCHEDUTILS # runtime (taskset)
+ select BR2_PACKAGE_OPENSSL if BR2_x86_64
help
Build and install (to /usr/lib/kselftests) kernel selftests.
diff --git a/package/linux-tools/linux-tool-selftests.mk.in b/package/linux-tools/linux-tool-selftests.mk.in
index b824c11bd6..06158e6147 100644
--- a/package/linux-tools/linux-tool-selftests.mk.in
+++ b/package/linux-tools/linux-tool-selftests.mk.in
@@ -17,6 +17,9 @@ endif
endif
SELFTESTS_DEPENDENCIES = libcap-ng popt
+ifeq ($(NORMALIZED_ARCH),x86_64)
+SELFTESTS_DEPENDENCIES += openssl
+endif
SELFTESTS_MAKE_FLAGS = \
$(LINUX_MAKE_FLAGS) \
--
2.36.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH v2] package/linux-tools: openssl dependency for x86_64 selftests
2022-05-24 17:05 [Buildroot] [PATCH v2] package/linux-tools: openssl dependency for x86_64 selftests Jarkko Sakkinen
@ 2022-05-25 7:07 ` Yann E. MORIN
2022-05-26 0:37 ` Jarkko Sakkinen
2022-06-01 20:53 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2022-05-25 7:07 UTC (permalink / raw)
To: Jarkko Sakkinen; +Cc: Peter Seiderer, buildroot
Jarkko, All,
On 2022-05-24 20:05 +0300, Jarkko Sakkinen spake thusly:
> On x86_64, libssl is a dependency for kselftests. selftests/sgx depends on
> it. Thus, select it in "Config.in", and add it as a build dependency in
> "linux-tool-selftests.mk.in".
>
> Link: https://lore.kernel.org/buildroot/20220517224809.21f77949@gmx.net/
> Suggested-by: Peter Seiderer <ps.report@gmx.net>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@iki.fi>
> ---
> v2:
> Config.in: BR2_PACKAGE_LIBOPENSSL => BR2_PACKAGE_OPENSSL
> ---
> package/linux-tools/Config.in | 1 +
> package/linux-tools/linux-tool-selftests.mk.in | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/package/linux-tools/Config.in b/package/linux-tools/Config.in
> index 791f2c085c..6217fcfb7a 100644
> --- a/package/linux-tools/Config.in
> +++ b/package/linux-tools/Config.in
> @@ -98,6 +98,7 @@ config BR2_PACKAGE_LINUX_TOOLS_SELFTESTS
> select BR2_PACKAGE_LIBCAP_NG
> select BR2_PACKAGE_UTIL_LINUX
> select BR2_PACKAGE_UTIL_LINUX_SCHEDUTILS # runtime (taskset)
> + select BR2_PACKAGE_OPENSSL if BR2_x86_64
> help
> Build and install (to /usr/lib/kselftests) kernel selftests.
>
> diff --git a/package/linux-tools/linux-tool-selftests.mk.in b/package/linux-tools/linux-tool-selftests.mk.in
> index b824c11bd6..06158e6147 100644
> --- a/package/linux-tools/linux-tool-selftests.mk.in
> +++ b/package/linux-tools/linux-tool-selftests.mk.in
> @@ -17,6 +17,9 @@ endif
> endif
>
> SELFTESTS_DEPENDENCIES = libcap-ng popt
> +ifeq ($(NORMALIZED_ARCH),x86_64)
> +SELFTESTS_DEPENDENCIES += openssl
> +endif
I've changed ths codition to be in the package being actually enabled,
so that the real confdition to require openssl is only handled in
Config.in (or we'd have to sync the two everytime a new arch needs
openssl...)
Applied to master, thanks.
Regards,
Yann E. MORIN.
> SELFTESTS_MAKE_FLAGS = \
> $(LINUX_MAKE_FLAGS) \
> --
> 2.36.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH v2] package/linux-tools: openssl dependency for x86_64 selftests
2022-05-25 7:07 ` Yann E. MORIN
@ 2022-05-26 0:37 ` Jarkko Sakkinen
0 siblings, 0 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2022-05-26 0:37 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Peter Seiderer, buildroot
On Wed, 2022-05-25 at 09:07 +0200, Yann E. MORIN wrote:
> Jarkko, All,
>
> On 2022-05-24 20:05 +0300, Jarkko Sakkinen spake thusly:
> > On x86_64, libssl is a dependency for kselftests. selftests/sgx depends on
> > it. Thus, select it in "Config.in", and add it as a build dependency in
> > "linux-tool-selftests.mk.in".
> >
> > Link: https://lore.kernel.org/buildroot/20220517224809.21f77949@gmx.net/
> > Suggested-by: Peter Seiderer <ps.report@gmx.net>
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@iki.fi>
> > ---
> > v2:
> > Config.in: BR2_PACKAGE_LIBOPENSSL => BR2_PACKAGE_OPENSSL
> > ---
> > package/linux-tools/Config.in | 1 +
> > package/linux-tools/linux-tool-selftests.mk.in | 3 +++
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/package/linux-tools/Config.in b/package/linux-tools/Config.in
> > index 791f2c085c..6217fcfb7a 100644
> > --- a/package/linux-tools/Config.in
> > +++ b/package/linux-tools/Config.in
> > @@ -98,6 +98,7 @@ config BR2_PACKAGE_LINUX_TOOLS_SELFTESTS
> > select BR2_PACKAGE_LIBCAP_NG
> > select BR2_PACKAGE_UTIL_LINUX
> > select BR2_PACKAGE_UTIL_LINUX_SCHEDUTILS # runtime (taskset)
> > + select BR2_PACKAGE_OPENSSL if BR2_x86_64
> > help
> > Build and install (to /usr/lib/kselftests) kernel selftests.
> >
> > diff --git a/package/linux-tools/linux-tool-selftests.mk.in b/package/linux-tools/linux-tool-selftests.mk.in
> > index b824c11bd6..06158e6147 100644
> > --- a/package/linux-tools/linux-tool-selftests.mk.in
> > +++ b/package/linux-tools/linux-tool-selftests.mk.in
> > @@ -17,6 +17,9 @@ endif
> > endif
> >
> > SELFTESTS_DEPENDENCIES = libcap-ng popt
> > +ifeq ($(NORMALIZED_ARCH),x86_64)
> > +SELFTESTS_DEPENDENCIES += openssl
> > +endif
>
> I've changed ths codition to be in the package being actually enabled,
> so that the real confdition to require openssl is only handled in
> Config.in (or we'd have to sync the two everytime a new arch needs
> openssl...)
>
> Applied to master, thanks.
Thank you, appreciate it!
Just for the record, there's also a bug in the selftest itself
preventing packaging it:
https://lore.kernel.org/linux-sgx/20220523181120.54547-1-jarkko@kernel.org/T/#u
BR, Jarkko
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH v2] package/linux-tools: openssl dependency for x86_64 selftests
2022-05-24 17:05 [Buildroot] [PATCH v2] package/linux-tools: openssl dependency for x86_64 selftests Jarkko Sakkinen
2022-05-25 7:07 ` Yann E. MORIN
@ 2022-06-01 20:53 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2022-06-01 20:53 UTC (permalink / raw)
To: Jarkko Sakkinen; +Cc: Peter Seiderer, Yann E. MORIN, buildroot
>>>>> "Jarkko" == Jarkko Sakkinen <jarkko.sakkinen@iki.fi> writes:
> On x86_64, libssl is a dependency for kselftests. selftests/sgx depends on
> it. Thus, select it in "Config.in", and add it as a build dependency in
> "linux-tool-selftests.mk.in".
> Link: https://lore.kernel.org/buildroot/20220517224809.21f77949@gmx.net/
> Suggested-by: Peter Seiderer <ps.report@gmx.net>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@iki.fi>
> ---
> v2:
> Config.in: BR2_PACKAGE_LIBOPENSSL => BR2_PACKAGE_OPENSSL
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-01 20:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-24 17:05 [Buildroot] [PATCH v2] package/linux-tools: openssl dependency for x86_64 selftests Jarkko Sakkinen
2022-05-25 7:07 ` Yann E. MORIN
2022-05-26 0:37 ` Jarkko Sakkinen
2022-06-01 20:53 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.