All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: renesas: r8a779f0: Add thermal support
@ 2022-05-25 15:13 Wolfram Sang
  2022-06-09  9:19 ` Geert Uytterhoeven
  2022-06-12 19:48 ` Wolfram Sang
  0 siblings, 2 replies; 6+ messages in thread
From: Wolfram Sang @ 2022-05-25 15:13 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Linh Phung, Wolfram Sang, Geert Uytterhoeven, Magnus Damm,
	Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel

From: Linh Phung <linh.phung.jy@renesas.com>

Add support for 3 TSC nodes of thermal. The 4th node is for the control
domain and not for Linux.

Signed-off-by: Linh Phung <linh.phung.jy@renesas.com>
[wsa: rebased, fixed resource size, removed unused 4th node breaking probe]
Signed-off-by: Wolfram Sang <wsa@kernel.org>
---

Works fine on my Spider board and allowed me to disconnect the fan :)

 arch/arm64/boot/dts/renesas/r8a779f0.dtsi | 56 +++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
index df46fb87cffc..d89064f86d85 100644
--- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
@@ -157,6 +157,18 @@ sysc: system-controller@e6180000 {
 			#power-domain-cells = <1>;
 		};
 
+		tsc: thermal@e6198000 {
+			compatible = "renesas,r8a779f0-thermal";
+			/* The 4th sensor is in control domain and not for Linux */
+			reg = <0 0xe6198000 0 0x200>,
+			      <0 0xe61a0000 0 0x200>,
+			      <0 0xe61a8000 0 0x200>;
+			clocks = <&cpg CPG_MOD 919>;
+			power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
+			resets = <&cpg 919>;
+			#thermal-sensor-cells = <1>;
+		};
+
 		i2c0: i2c@e6500000 {
 			compatible = "renesas,i2c-r8a779f0",
 				     "renesas,rcar-gen4-i2c";
@@ -360,6 +372,50 @@ prr: chipid@fff00044 {
 		};
 	};
 
+	thermal-zones {
+		sensor_thermal1: sensor-thermal1 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+			thermal-sensors = <&tsc 0>;
+
+			trips {
+				sensor1_crit: sensor1-crit {
+					temperature = <120000>;
+					hysteresis = <1000>;
+					type = "critical";
+				};
+			};
+		};
+
+		sensor_thermal2: sensor-thermal2 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+			thermal-sensors = <&tsc 1>;
+
+			trips {
+				sensor2_crit: sensor2-crit {
+					temperature = <120000>;
+					hysteresis = <1000>;
+					type = "critical";
+				};
+			};
+		};
+
+		sensor_thermal3: sensor-thermal3 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+			thermal-sensors = <&tsc 2>;
+
+			trips {
+				sensor3_crit: sensor3-crit {
+					temperature = <120000>;
+					hysteresis = <1000>;
+					type = "critical";
+				};
+			};
+		};
+	};
+
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts-extended = <&gic GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: renesas: r8a779f0: Add thermal support
  2022-05-25 15:13 [PATCH] arm64: dts: renesas: r8a779f0: Add thermal support Wolfram Sang
@ 2022-06-09  9:19 ` Geert Uytterhoeven
  2022-06-12 19:48 ` Wolfram Sang
  1 sibling, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2022-06-09  9:19 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Linux-Renesas, Linh Phung, Wolfram Sang, Geert Uytterhoeven,
	Magnus Damm, Rob Herring, Krzysztof Kozlowski,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List

On Wed, May 25, 2022 at 5:14 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> From: Linh Phung <linh.phung.jy@renesas.com>
>
> Add support for 3 TSC nodes of thermal. The 4th node is for the control
> domain and not for Linux.
>
> Signed-off-by: Linh Phung <linh.phung.jy@renesas.com>
> [wsa: rebased, fixed resource size, removed unused 4th node breaking probe]
> Signed-off-by: Wolfram Sang <wsa@kernel.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: renesas: r8a779f0: Add thermal support
  2022-05-25 15:13 [PATCH] arm64: dts: renesas: r8a779f0: Add thermal support Wolfram Sang
  2022-06-09  9:19 ` Geert Uytterhoeven
@ 2022-06-12 19:48 ` Wolfram Sang
  2022-06-13  9:11   ` Geert Uytterhoeven
  1 sibling, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2022-06-12 19:48 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Linh Phung, Geert Uytterhoeven, Magnus Damm, Rob Herring,
	Krzysztof Kozlowski, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

On Wed, May 25, 2022 at 05:13:55PM +0200, Wolfram Sang wrote:
> From: Linh Phung <linh.phung.jy@renesas.com>
> 
> Add support for 3 TSC nodes of thermal. The 4th node is for the control
> domain and not for Linux.
> 
> Signed-off-by: Linh Phung <linh.phung.jy@renesas.com>
> [wsa: rebased, fixed resource size, removed unused 4th node breaking probe]
> Signed-off-by: Wolfram Sang <wsa@kernel.org>

Eeks, this should have been:

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Shall I resend?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: renesas: r8a779f0: Add thermal support
  2022-06-12 19:48 ` Wolfram Sang
@ 2022-06-13  9:11   ` Geert Uytterhoeven
  2022-06-13  9:25     ` Wolfram Sang
  0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2022-06-13  9:11 UTC (permalink / raw)
  To: Wolfram Sang, Linux-Renesas, Linh Phung, Magnus Damm,
	Rob Herring, Krzysztof Kozlowski,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List
  Cc: Geert Uytterhoeven

Hi Wolfram,

On Sun, Jun 12, 2022 at 9:48 PM Wolfram Sang <wsa@kernel.org> wrote:
> On Wed, May 25, 2022 at 05:13:55PM +0200, Wolfram Sang wrote:
> > From: Linh Phung <linh.phung.jy@renesas.com>
> >
> > Add support for 3 TSC nodes of thermal. The 4th node is for the control
> > domain and not for Linux.
> >
> > Signed-off-by: Linh Phung <linh.phung.jy@renesas.com>
> > [wsa: rebased, fixed resource size, removed unused 4th node breaking probe]
> > Signed-off-by: Wolfram Sang <wsa@kernel.org>
>
> Eeks, this should have been:
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Shall I resend?

No need to resend, I can fix that while applying.
Unless you want to make other changes, which I believe is not the case,
as only the DT bindings patch needed a new version?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: renesas: r8a779f0: Add thermal support
  2022-06-13  9:11   ` Geert Uytterhoeven
@ 2022-06-13  9:25     ` Wolfram Sang
  2022-06-15 13:33       ` Geert Uytterhoeven
  0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2022-06-13  9:25 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linux-Renesas, Linh Phung, Magnus Damm, Rob Herring,
	Krzysztof Kozlowski,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, Geert Uytterhoeven

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]


> No need to resend, I can fix that while applying.

Thanks!

> Unless you want to make other changes, which I believe is not the case,
> as only the DT bindings patch needed a new version?

Nope, no changes needed.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: renesas: r8a779f0: Add thermal support
  2022-06-13  9:25     ` Wolfram Sang
@ 2022-06-15 13:33       ` Geert Uytterhoeven
  0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2022-06-15 13:33 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Linux-Renesas, Linh Phung, Magnus Damm, Rob Herring,
	Krzysztof Kozlowski,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List

Hi Wolfram,

On Mon, Jun 13, 2022 at 11:25 AM Wolfram Sang <wsa@kernel.org> wrote:
> > No need to resend, I can fix that while applying.
>
> Thanks!
>
> > Unless you want to make other changes, which I believe is not the case,
> > as only the DT bindings patch needed a new version?
>
> Nope, no changes needed.

Actually other changes are needed, as "make dtbs_check" complains,
rightfully:

    arm64/boot/dts/renesas/r8a779f0-spider.dtb: thermal-zones:
'sensor-thermal1', 'sensor-thermal2', 'sensor-thermal3' do not match
any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$',
'pinctrl-[0-9]+'
            From schema:
Documentation/devicetree/bindings/thermal/thermal-zones.yaml

As I have already queued this patch, I will amend the commit, by
changing the node names to sensor[123]-thermal.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-06-15 13:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-25 15:13 [PATCH] arm64: dts: renesas: r8a779f0: Add thermal support Wolfram Sang
2022-06-09  9:19 ` Geert Uytterhoeven
2022-06-12 19:48 ` Wolfram Sang
2022-06-13  9:11   ` Geert Uytterhoeven
2022-06-13  9:25     ` Wolfram Sang
2022-06-15 13:33       ` Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.