From: Andrew Morton <akpm@linux-foundation.org>
To: Jessica Clarke <jrtc27@jrtc27.com>
Cc: kernel test robot <lkp@intel.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-riscv@lists.infradead.org, linux-rdma@vger.kernel.org,
linux-pci@vger.kernel.org, linux-parport@lists.infradead.org,
linux-omap@vger.kernel.org, linux-mm@kvack.org,
linux-fbdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
dri-devel@lists.freedesktop.org, bpf@vger.kernel.org,
amd-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org
Subject: Re: [linux-next:master] BUILD REGRESSION 8cb8311e95e3bb58bd84d6350365f14a718faa6d
Date: Wed, 25 May 2022 15:20:06 -0700 [thread overview]
Message-ID: <20220525152006.e87d3fa50aca58fdc1b43b6a@linux-foundation.org> (raw)
In-Reply-To: <F0E25DFF-8256-48FF-8B88-C0E3730A3E5E@jrtc27.com>
On Wed, 25 May 2022 23:07:35 +0100 Jessica Clarke <jrtc27@jrtc27.com> wrote:
> This is i386, so an unsigned long is 32-bit, but i_blocks is a blkcnt_t
> i.e. a u64, which makes the shift without a cast of the LHS fishy.
Ah, of course, thanks. I remember 32 bits ;)
--- a/mm/shmem.c~mm-shmemc-suppress-shift-warning
+++ a/mm/shmem.c
@@ -1945,7 +1945,7 @@ alloc_nohuge:
spin_lock_irq(&info->lock);
info->alloced += folio_nr_pages(folio);
- inode->i_blocks += BLOCKS_PER_PAGE << folio_order(folio);
+ inode->i_blocks += (blkcnt_t)BLOCKS_PER_PAGE << folio_order(folio);
shmem_recalc_inode(inode);
spin_unlock_irq(&info->lock);
alloced = true;
_
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Jessica Clarke <jrtc27@jrtc27.com>
Cc: linux-fbdev@vger.kernel.org, kernel test robot <lkp@intel.com>,
kvm@vger.kernel.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, linux-staging@lists.linux.dev,
alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
amd-gfx@lists.freedesktop.org, linux-pci@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-omap@vger.kernel.org,
bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-parport@lists.infradead.org
Subject: Re: [linux-next:master] BUILD REGRESSION 8cb8311e95e3bb58bd84d6350365f14a718faa6d
Date: Wed, 25 May 2022 15:20:06 -0700 [thread overview]
Message-ID: <20220525152006.e87d3fa50aca58fdc1b43b6a@linux-foundation.org> (raw)
In-Reply-To: <F0E25DFF-8256-48FF-8B88-C0E3730A3E5E@jrtc27.com>
On Wed, 25 May 2022 23:07:35 +0100 Jessica Clarke <jrtc27@jrtc27.com> wrote:
> This is i386, so an unsigned long is 32-bit, but i_blocks is a blkcnt_t
> i.e. a u64, which makes the shift without a cast of the LHS fishy.
Ah, of course, thanks. I remember 32 bits ;)
--- a/mm/shmem.c~mm-shmemc-suppress-shift-warning
+++ a/mm/shmem.c
@@ -1945,7 +1945,7 @@ alloc_nohuge:
spin_lock_irq(&info->lock);
info->alloced += folio_nr_pages(folio);
- inode->i_blocks += BLOCKS_PER_PAGE << folio_order(folio);
+ inode->i_blocks += (blkcnt_t)BLOCKS_PER_PAGE << folio_order(folio);
shmem_recalc_inode(inode);
spin_unlock_irq(&info->lock);
alloced = true;
_
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Jessica Clarke <jrtc27@jrtc27.com>
Cc: linux-fbdev@vger.kernel.org, kernel test robot <lkp@intel.com>,
kvm@vger.kernel.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, linux-staging@lists.linux.dev,
alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
amd-gfx@lists.freedesktop.org, linux-pci@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-omap@vger.kernel.org,
bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-parport@lists.infradead.org
Subject: Re: [linux-next:master] BUILD REGRESSION 8cb8311e95e3bb58bd84d6350365f14a718faa6d
Date: Wed, 25 May 2022 15:20:06 -0700 [thread overview]
Message-ID: <20220525152006.e87d3fa50aca58fdc1b43b6a@linux-foundation.org> (raw)
In-Reply-To: <F0E25DFF-8256-48FF-8B88-C0E3730A3E5E@jrtc27.com>
On Wed, 25 May 2022 23:07:35 +0100 Jessica Clarke <jrtc27@jrtc27.com> wrote:
> This is i386, so an unsigned long is 32-bit, but i_blocks is a blkcnt_t
> i.e. a u64, which makes the shift without a cast of the LHS fishy.
Ah, of course, thanks. I remember 32 bits ;)
--- a/mm/shmem.c~mm-shmemc-suppress-shift-warning
+++ a/mm/shmem.c
@@ -1945,7 +1945,7 @@ alloc_nohuge:
spin_lock_irq(&info->lock);
info->alloced += folio_nr_pages(folio);
- inode->i_blocks += BLOCKS_PER_PAGE << folio_order(folio);
+ inode->i_blocks += (blkcnt_t)BLOCKS_PER_PAGE << folio_order(folio);
shmem_recalc_inode(inode);
spin_unlock_irq(&info->lock);
alloced = true;
_
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Jessica Clarke <jrtc27@jrtc27.com>
Cc: kernel test robot <lkp@intel.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-riscv@lists.infradead.org, linux-rdma@vger.kernel.org,
linux-pci@vger.kernel.org, linux-parport@lists.infradead.org,
linux-omap@vger.kernel.org, linux-mm@kvack.org,
linux-fbdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
dri-devel@lists.freedesktop.org, bpf@vger.kernel.org,
amd-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org
Subject: Re: [linux-next:master] BUILD REGRESSION 8cb8311e95e3bb58bd84d6350365f14a718faa6d
Date: Wed, 25 May 2022 15:20:06 -0700 [thread overview]
Message-ID: <20220525152006.e87d3fa50aca58fdc1b43b6a@linux-foundation.org> (raw)
In-Reply-To: <F0E25DFF-8256-48FF-8B88-C0E3730A3E5E@jrtc27.com>
On Wed, 25 May 2022 23:07:35 +0100 Jessica Clarke <jrtc27@jrtc27.com> wrote:
> This is i386, so an unsigned long is 32-bit, but i_blocks is a blkcnt_t
> i.e. a u64, which makes the shift without a cast of the LHS fishy.
Ah, of course, thanks. I remember 32 bits ;)
--- a/mm/shmem.c~mm-shmemc-suppress-shift-warning
+++ a/mm/shmem.c
@@ -1945,7 +1945,7 @@ alloc_nohuge:
spin_lock_irq(&info->lock);
info->alloced += folio_nr_pages(folio);
- inode->i_blocks += BLOCKS_PER_PAGE << folio_order(folio);
+ inode->i_blocks += (blkcnt_t)BLOCKS_PER_PAGE << folio_order(folio);
shmem_recalc_inode(inode);
spin_unlock_irq(&info->lock);
alloced = true;
_
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Jessica Clarke <jrtc27@jrtc27.com>
Cc: kernel test robot <lkp@intel.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-riscv@lists.infradead.org, linux-rdma@vger.kernel.org,
linux-pci@vger.kernel.org, linux-parport@lists.infradead.org,
linux-omap@vger.kernel.org, linux-mm@kvack.org,
linux-fbdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
dri-devel@lists.freedesktop.org, bpf@vger.kernel.org,
amd-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org
Subject: Re: [linux-next:master] BUILD REGRESSION 8cb8311e95e3bb58bd84d6350365f14a718faa6d
Date: Wed, 25 May 2022 15:20:06 -0700 [thread overview]
Message-ID: <20220525152006.e87d3fa50aca58fdc1b43b6a@linux-foundation.org> (raw)
In-Reply-To: <F0E25DFF-8256-48FF-8B88-C0E3730A3E5E@jrtc27.com>
On Wed, 25 May 2022 23:07:35 +0100 Jessica Clarke <jrtc27@jrtc27.com> wrote:
> This is i386, so an unsigned long is 32-bit, but i_blocks is a blkcnt_t
> i.e. a u64, which makes the shift without a cast of the LHS fishy.
Ah, of course, thanks. I remember 32 bits ;)
--- a/mm/shmem.c~mm-shmemc-suppress-shift-warning
+++ a/mm/shmem.c
@@ -1945,7 +1945,7 @@ alloc_nohuge:
spin_lock_irq(&info->lock);
info->alloced += folio_nr_pages(folio);
- inode->i_blocks += BLOCKS_PER_PAGE << folio_order(folio);
+ inode->i_blocks += (blkcnt_t)BLOCKS_PER_PAGE << folio_order(folio);
shmem_recalc_inode(inode);
spin_unlock_irq(&info->lock);
alloced = true;
_
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-25 22:20 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 21:35 [linux-next:master] BUILD REGRESSION 8cb8311e95e3bb58bd84d6350365f14a718faa6d kernel test robot
2022-05-25 21:35 ` kernel test robot
2022-05-25 21:35 ` kernel test robot
2022-05-25 21:35 ` kernel test robot
2022-05-25 21:35 ` kernel test robot
2022-05-25 21:50 ` Andrew Morton
2022-05-25 21:50 ` Andrew Morton
2022-05-25 21:50 ` Andrew Morton
2022-05-25 21:50 ` Andrew Morton
2022-05-25 21:50 ` Andrew Morton
2022-05-25 22:07 ` Jessica Clarke
2022-05-25 22:07 ` Jessica Clarke
2022-05-25 22:07 ` Jessica Clarke
2022-05-25 22:07 ` Jessica Clarke
2022-05-25 22:20 ` Andrew Morton [this message]
2022-05-25 22:20 ` Andrew Morton
2022-05-25 22:20 ` Andrew Morton
2022-05-25 22:20 ` Andrew Morton
2022-05-25 22:20 ` Andrew Morton
2022-05-26 1:16 ` Matthew Wilcox
2022-05-26 1:16 ` Matthew Wilcox
2022-05-26 1:16 ` Matthew Wilcox
2022-05-26 1:16 ` Matthew Wilcox
2022-05-26 1:16 ` Matthew Wilcox
2022-05-26 8:48 ` Dan Carpenter
2022-05-26 8:48 ` Dan Carpenter
2022-05-26 8:48 ` Dan Carpenter
2022-05-26 8:48 ` Dan Carpenter
2022-05-26 8:48 ` Dan Carpenter
2022-05-26 14:28 ` Matthew Wilcox
2022-05-26 14:28 ` Matthew Wilcox
2022-05-26 14:28 ` Matthew Wilcox
2022-05-26 14:28 ` Matthew Wilcox
2022-05-26 14:28 ` Matthew Wilcox
2022-05-26 15:03 ` Dan Carpenter
2022-05-26 15:03 ` Dan Carpenter
2022-05-26 15:03 ` Dan Carpenter
2022-05-26 15:03 ` Dan Carpenter
2022-05-26 15:03 ` Dan Carpenter
2022-05-26 8:19 ` Dan Carpenter
2022-05-26 8:19 ` Dan Carpenter
2022-05-26 8:19 ` Dan Carpenter
2022-05-26 8:19 ` Dan Carpenter
2022-05-26 8:19 ` Dan Carpenter
2022-05-26 8:32 ` Arnd Bergmann
2022-05-26 8:32 ` Arnd Bergmann
2022-05-26 8:32 ` Arnd Bergmann
2022-05-26 8:32 ` Arnd Bergmann
2022-05-26 8:32 ` Arnd Bergmann
2022-06-16 5:11 ` Chen, Rong A
2022-06-16 5:11 ` Chen, Rong A
2022-06-16 5:11 ` Chen, Rong A
2022-06-16 5:11 ` Chen, Rong A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220525152006.e87d3fa50aca58fdc1b43b6a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bpf@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jrtc27@jrtc27.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.