[igt-dev] [PATCH i-g-t] test/kms_plane_alpha_blend: clearer validation for coverage-7efc

[igt-dev] [PATCH i-g-t] test/kms_plane_alpha_blend: clearer validation for coverage-7efc

[Melissa Wen]

Inspired by previous change in alpha-7efc, get a clearer validation for
the swappable property of plane_alpha and fg.alpha in the coverage blend
formula. Get rid of the 8-increment alpha loop by refactoring
coverage-7efc in favor of one-shot check format, avoiding doubts related
to bit precision and rounding issue.

Signed-off-by: Melissa Wen <mwen@igalia.com>
---
 tests/kms_plane_alpha_blend.c | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index 8e54dfd6..001a1479 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -420,20 +420,18 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
 	igt_pipe_crc_start(data->pipe_crc);
 
 	/* for coverage, plane alpha and fb alpha should be swappable, so swap fb and alpha */
-	for (i = 0; i < 256; i += 8) {
-		igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, ((i/2) << 8) | (i/2));
-		igt_plane_set_fb(plane, &data->argb_fb_cov_fc);
-		igt_display_commit2(display, COMMIT_ATOMIC);
+	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
+	igt_plane_set_fb(plane, &data->argb_fb_cov_fc);
+	igt_display_commit2(display, COMMIT_ATOMIC);
 
-		igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &ref_crc);
+	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &ref_crc);
 
-		igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, (i << 8) | i);
-		igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
-		igt_display_commit2(display, COMMIT_ATOMIC);
+	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0xfcfc);
+	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
+	igt_display_commit2(display, COMMIT_ATOMIC);
 
-		igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
-		igt_assert_crc_equal(&ref_crc, &crc);
-	}
+	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
+	igt_assert_crc_equal(&ref_crc, &crc);
 
 	igt_pipe_crc_stop(data->pipe_crc);
 }
@@ -537,7 +535,8 @@ static void run_subtests(data_t *data, enum pipe pipe)
 	igt_subtest_f("pipe-%s-alpha-7efc", kmstest_pipe_name(pipe))
 		run_test_on_pipe_planes(data, pipe, false, true, alpha_7efc);
 
-	igt_describe("Tests pipe coverage blending properties.");
+	igt_describe("Uses alpha values 0x7e and 0xfc to validate fg.alpha and "
+		     "plane_alpha are swappable on coverage blend mode.");
 	igt_subtest_f("pipe-%s-coverage-7efc", kmstest_pipe_name(pipe))
 		run_test_on_pipe_planes(data, pipe, true, true, coverage_7efc);
 
-- 
2.35.1

[igt-dev] ✗ GitLab.Pipeline: warning for test/kms_plane_alpha_blend: clearer validation for coverage-7efc

[Patchwork]

== Series Details ==

Series: test/kms_plane_alpha_blend: clearer validation for coverage-7efc
URL   : https://patchwork.freedesktop.org/series/104366/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/595872 for the overview.

build:tests-debian-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/23136029):
  Preparing environment
  Running on runner-jda81xmt-project-3185-concurrent-1 via fdo-equinix-m3l-9...
  section_end:1653502402:prepare_script
  section_start:1653502402:get_sources
  Getting source from Git repository
  $ eval "$CI_PRE_CLONE_SCRIPT"
  Fetching changes...
  Reinitialized existing Git repository in /builds/gfx-ci/igt-ci-tags/.git/
  Checking out 8ea6a654 as intel/IGTPW_7173...
  
  Skipping Git submodules setup
  section_end:1653502403:get_sources
  section_start:1653502403:step_script
  Executing "step_script" stage of the job script
  Using docker image sha256:ca01fc804bb92e5df42a202dd7e0470610c6711c66a808525defcb8bbb774078 for registry.freedesktop.org/gfx-ci/igt-ci-tags/build-debian:commit-8ea6a654a9a672d82bd075b77d20d82928d79523 with digest registry.freedesktop.org/gfx-ci/igt-ci-tags/build-debian@sha256:b9fe73c6ff5d68f5692fd18b9076735679c8bfa7ed393e752dd4927a2cdf9874 ...
  section_end:1653502404:step_script
  section_start:1653502404:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1653502405:cleanup_file_variables
  ERROR: Job failed (system failure): Error response from daemon: failed to get digest sha256:ca01fc804bb92e5df42a202dd7e0470610c6711c66a808525defcb8bbb774078: open /var/lib/docker/image/overlay2/imagedb/content/sha256/ca01fc804bb92e5df42a202dd7e0470610c6711c66a808525defcb8bbb774078: no such file or directory (docker.go:654:0s)

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/595872

[igt-dev] ✗ Fi.CI.BAT: failure for test/kms_plane_alpha_blend: clearer validation for coverage-7efc

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 8022 bytes --]

== Series Details ==

Series: test/kms_plane_alpha_blend: clearer validation for coverage-7efc
URL   : https://patchwork.freedesktop.org/series/104366/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11700 -> IGTPW_7173
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_7173 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_7173, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/index.html

Participating hosts (46 -> 45)
------------------------------

  Additional (1): bat-adls-5 
  Missing    (2): fi-hsw-4770 bat-dg2-9 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_7173:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@client:
    - fi-bdw-5557u:       [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11700/fi-bdw-5557u/igt@i915_selftest@live@client.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/fi-bdw-5557u/igt@i915_selftest@live@client.html

  
Known issues
------------

  Here are the changes found in IGTPW_7173 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@gem:
    - fi-pnv-d510:        NOTRUN -> [DMESG-FAIL][3] ([i915#4528])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/fi-pnv-d510/igt@i915_selftest@live@gem.html

  * igt@i915_selftest@live@hangcheck:
    - fi-hsw-g3258:       [PASS][4] -> [INCOMPLETE][5] ([i915#4785])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11700/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
    - bat-dg1-6:          [PASS][6] -> [DMESG-FAIL][7] ([i915#4494] / [i915#4957])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11700/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/bat-dg1-6/igt@i915_selftest@live@hangcheck.html

  * igt@kms_busy@basic@modeset:
    - bat-adlp-4:         [PASS][8] -> [DMESG-WARN][9] ([i915#3576]) +1 similar issue
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11700/bat-adlp-4/igt@kms_busy@basic@modeset.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/bat-adlp-4/igt@kms_busy@basic@modeset.html

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-blb-e6850:       NOTRUN -> [SKIP][10] ([fdo#109271])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/fi-blb-e6850/igt@kms_chamelium@common-hpd-after-suspend.html

  * igt@kms_flip@basic-flip-vs-modeset@a-edp1:
    - fi-tgl-u2:          [PASS][11] -> [DMESG-WARN][12] ([i915#402]) +2 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11700/fi-tgl-u2/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/fi-tgl-u2/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html

  * igt@runner@aborted:
    - fi-hsw-g3258:       NOTRUN -> [FAIL][13] ([fdo#109271] / [i915#4312])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/fi-hsw-g3258/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s0@smem:
    - {fi-ehl-2}:         [DMESG-WARN][14] ([i915#5122]) -> [PASS][15]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11700/fi-ehl-2/igt@gem_exec_suspend@basic-s0@smem.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/fi-ehl-2/igt@gem_exec_suspend@basic-s0@smem.html

  * igt@i915_selftest@live@hugepages:
    - {bat-adln-1}:       [DMESG-WARN][16] -> [PASS][17]
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11700/bat-adln-1/igt@i915_selftest@live@hugepages.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/bat-adln-1/igt@i915_selftest@live@hugepages.html

  * igt@i915_selftest@live@requests:
    - fi-blb-e6850:       [DMESG-FAIL][18] ([i915#4528]) -> [PASS][19]
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11700/fi-blb-e6850/igt@i915_selftest@live@requests.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/fi-blb-e6850/igt@i915_selftest@live@requests.html
    - bat-adlp-4:         [DMESG-FAIL][20] -> [PASS][21]
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11700/bat-adlp-4/igt@i915_selftest@live@requests.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/bat-adlp-4/igt@i915_selftest@live@requests.html
    - fi-pnv-d510:        [DMESG-FAIL][22] ([i915#4528]) -> [PASS][23]
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11700/fi-pnv-d510/igt@i915_selftest@live@requests.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/fi-pnv-d510/igt@i915_selftest@live@requests.html

  * igt@kms_flip@basic-flip-vs-modeset@b-edp1:
    - {bat-adlp-6}:       [DMESG-WARN][24] ([i915#3576]) -> [PASS][25] +1 similar issue
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11700/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@b-edp1.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@b-edp1.html
    - bat-adlp-4:         [DMESG-WARN][26] ([i915#3576]) -> [PASS][27] +1 similar issue
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11700/bat-adlp-4/igt@kms_flip@basic-flip-vs-modeset@b-edp1.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/bat-adlp-4/igt@kms_flip@basic-flip-vs-modeset@b-edp1.html

  * igt@kms_flip@basic-plain-flip@a-edp1:
    - fi-tgl-u2:          [DMESG-WARN][28] ([i915#402]) -> [PASS][29]
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11700/fi-tgl-u2/igt@kms_flip@basic-plain-flip@a-edp1.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/fi-tgl-u2/igt@kms_flip@basic-plain-flip@a-edp1.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
  [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
  [i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
  [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
  [i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6492 -> IGTPW_7173

  CI-20190529: 20190529
  CI_DRM_11700: f5895776c32b7fc5c196fafef3f5dab7e5ad19c6 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_7173: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/index.html
  IGT_6492: ef18e59c374472e961a3a145724e7381eb4800aa @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7173/index.html

[-- Attachment #2: Type: text/html, Size: 8736 bytes --]

Re: [igt-dev] [PATCH i-g-t] test/kms_plane_alpha_blend: clearer validation for coverage-7efc

[Kim, Sung joon]

[AMD Official Use Only - General]

Looks good to me.
One suggestion would be adding some information (e.g. commit id, etc...) about the change that enabled Coverage alpha blend mode made in the kernel in your description?

Reviewed-by: Sung Joon Kim <sungkim@amd.com>

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> Melissa Wen
> Sent: Wednesday, May 25, 2022 1:10 PM
> To: igt-dev@lists.freedesktop.org
> Cc: petri.latvala@intel.com; markyacoub@google.com
> Subject: [igt-dev] [PATCH i-g-t] test/kms_plane_alpha_blend: clearer
> validation for coverage-7efc
>
> Inspired by previous change in alpha-7efc, get a clearer validation for
> the swappable property of plane_alpha and fg.alpha in the coverage blend
> formula. Get rid of the 8-increment alpha loop by refactoring
> coverage-7efc in favor of one-shot check format, avoiding doubts related
> to bit precision and rounding issue.
>
> Signed-off-by: Melissa Wen <mwen@igalia.com>
> ---
>  tests/kms_plane_alpha_blend.c | 23 +++++++++++------------
>  1 file changed, 11 insertions(+), 12 deletions(-)
>
> diff --git a/tests/kms_plane_alpha_blend.c
> b/tests/kms_plane_alpha_blend.c
> index 8e54dfd6..001a1479 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -420,20 +420,18 @@ static void coverage_7efc(data_t *data, enum pipe
> pipe, igt_plane_t *plane)
>       igt_pipe_crc_start(data->pipe_crc);
>
>       /* for coverage, plane alpha and fb alpha should be swappable, so
> swap fb and alpha */
> -     for (i = 0; i < 256; i += 8) {
> -             igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, ((i/2)
> << 8) | (i/2));
> -             igt_plane_set_fb(plane, &data->argb_fb_cov_fc);
> -             igt_display_commit2(display, COMMIT_ATOMIC);
> +     igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
> +     igt_plane_set_fb(plane, &data->argb_fb_cov_fc);
> +     igt_display_commit2(display, COMMIT_ATOMIC);
>
> -             igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc,
> &ref_crc);
> +     igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc,
> &ref_crc);
>
> -             igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, (i << 8)
> | i);
> -             igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
> -             igt_display_commit2(display, COMMIT_ATOMIC);
> +     igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0xfcfc);
> +     igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
> +     igt_display_commit2(display, COMMIT_ATOMIC);
>
> -             igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc,
> &crc);
> -             igt_assert_crc_equal(&ref_crc, &crc);
> -     }
> +     igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> +     igt_assert_crc_equal(&ref_crc, &crc);
>
>       igt_pipe_crc_stop(data->pipe_crc);
>  }
> @@ -537,7 +535,8 @@ static void run_subtests(data_t *data, enum pipe
> pipe)
>       igt_subtest_f("pipe-%s-alpha-7efc", kmstest_pipe_name(pipe))
>               run_test_on_pipe_planes(data, pipe, false, true, alpha_7efc);
>
> -     igt_describe("Tests pipe coverage blending properties.");
> +     igt_describe("Uses alpha values 0x7e and 0xfc to validate fg.alpha
> and "
> +                  "plane_alpha are swappable on coverage blend mode.");
>       igt_subtest_f("pipe-%s-coverage-7efc", kmstest_pipe_name(pipe))
>               run_test_on_pipe_planes(data, pipe, true, true,
> coverage_7efc);
>
> --
> 2.35.1

Re: [igt-dev] [PATCH i-g-t] test/kms_plane_alpha_blend: clearer validation for coverage-7efc

[Melissa Wen]

[-- Attachment #1: Type: text/plain, Size: 4305 bytes --]

On 05/26, Kim, Sung joon wrote:
> [AMD Official Use Only - General]
> 
> Looks good to me.
> One suggestion would be adding some information (e.g. commit id, etc...) about the change that enabled Coverage alpha blend mode made in the kernel in your description?
> 
> Reviewed-by: Sung Joon Kim <sungkim@amd.com>

Hi,

Thanks for taking a look at it.

I think you are talking about those kernel changes in the AMD display
driver.  As kms_plane_alpha_blend should be a generic test for any GPU
vendors, the improvement here is not retricted to AMD, so I would prefer
to keep the message generic too.

But from your suggestion, I included the commit for alpha-7efc change,
where I exemplify the problems of the original approach for different
vendors. I just sent a v2 and included your r-b.

Let me know if you are okay with it.

BR,

Melissa
> 
> > -----Original Message-----
> > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> > Melissa Wen
> > Sent: Wednesday, May 25, 2022 1:10 PM
> > To: igt-dev@lists.freedesktop.org
> > Cc: petri.latvala@intel.com; markyacoub@google.com
> > Subject: [igt-dev] [PATCH i-g-t] test/kms_plane_alpha_blend: clearer
> > validation for coverage-7efc
> >
> > Inspired by previous change in alpha-7efc, get a clearer validation for
> > the swappable property of plane_alpha and fg.alpha in the coverage blend
> > formula. Get rid of the 8-increment alpha loop by refactoring
> > coverage-7efc in favor of one-shot check format, avoiding doubts related
> > to bit precision and rounding issue.
> >
> > Signed-off-by: Melissa Wen <mwen@igalia.com>
> > ---
> >  tests/kms_plane_alpha_blend.c | 23 +++++++++++------------
> >  1 file changed, 11 insertions(+), 12 deletions(-)
> >
> > diff --git a/tests/kms_plane_alpha_blend.c
> > b/tests/kms_plane_alpha_blend.c
> > index 8e54dfd6..001a1479 100644
> > --- a/tests/kms_plane_alpha_blend.c
> > +++ b/tests/kms_plane_alpha_blend.c
> > @@ -420,20 +420,18 @@ static void coverage_7efc(data_t *data, enum pipe
> > pipe, igt_plane_t *plane)
> >       igt_pipe_crc_start(data->pipe_crc);
> >
> >       /* for coverage, plane alpha and fb alpha should be swappable, so
> > swap fb and alpha */
> > -     for (i = 0; i < 256; i += 8) {
> > -             igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, ((i/2)
> > << 8) | (i/2));
> > -             igt_plane_set_fb(plane, &data->argb_fb_cov_fc);
> > -             igt_display_commit2(display, COMMIT_ATOMIC);
> > +     igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
> > +     igt_plane_set_fb(plane, &data->argb_fb_cov_fc);
> > +     igt_display_commit2(display, COMMIT_ATOMIC);
> >
> > -             igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc,
> > &ref_crc);
> > +     igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc,
> > &ref_crc);
> >
> > -             igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, (i << 8)
> > | i);
> > -             igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
> > -             igt_display_commit2(display, COMMIT_ATOMIC);
> > +     igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0xfcfc);
> > +     igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
> > +     igt_display_commit2(display, COMMIT_ATOMIC);
> >
> > -             igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc,
> > &crc);
> > -             igt_assert_crc_equal(&ref_crc, &crc);
> > -     }
> > +     igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> > +     igt_assert_crc_equal(&ref_crc, &crc);
> >
> >       igt_pipe_crc_stop(data->pipe_crc);
> >  }
> > @@ -537,7 +535,8 @@ static void run_subtests(data_t *data, enum pipe
> > pipe)
> >       igt_subtest_f("pipe-%s-alpha-7efc", kmstest_pipe_name(pipe))
> >               run_test_on_pipe_planes(data, pipe, false, true, alpha_7efc);
> >
> > -     igt_describe("Tests pipe coverage blending properties.");
> > +     igt_describe("Uses alpha values 0x7e and 0xfc to validate fg.alpha
> > and "
> > +                  "plane_alpha are swappable on coverage blend mode.");
> >       igt_subtest_f("pipe-%s-coverage-7efc", kmstest_pipe_name(pipe))
> >               run_test_on_pipe_planes(data, pipe, true, true,
> > coverage_7efc);
> >
> > --
> > 2.35.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]