* [PATCH] dt-bindings: mmc: Fix unevaluatedProperties warnings in examples
@ 2022-05-26 1:42 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-05-26 1:42 UTC (permalink / raw)
To: Ulf Hansson, Krzysztof Kozlowski, Florian Fainelli,
Broadcom internal kernel review list, Hu Ziji, Al Cooper
Cc: linux-mmc, devicetree, linux-arm-kernel, linux-kernel
The 'unevaluatedProperties' schema checks is not fully working and doesn't
catch some cases where there's a $ref to another schema. A fix is pending,
but results in new warnings in examples. Fix the warnings by removing
spurious properties or adding a missing property to the schema.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml | 2 --
Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml | 3 +++
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
index b672202fff4e..5ecdac9de484 100644
--- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
+++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
@@ -75,7 +75,6 @@ examples:
sd-uhs-sdr104;
sdhci,auto-cmd12;
interrupts = <0x0 0x26 0x4>;
- interrupt-names = "sdio0_0";
clocks = <&scmi_clk 245>;
clock-names = "sw_sdio";
};
@@ -94,7 +93,6 @@ examples:
non-removable;
bus-width = <0x8>;
interrupts = <0x0 0x27 0x4>;
- interrupt-names = "sdio1_0";
clocks = <&scmi_clk 245>;
clock-names = "sw_sdio";
};
diff --git a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
index c79639e9027e..aca1a4a8daea 100644
--- a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
@@ -56,6 +56,9 @@ properties:
- const: core
- const: axi
+ interrupts:
+ maxItems: 1
+
marvell,xenon-sdhc-id:
$ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] dt-bindings: mmc: Fix unevaluatedProperties warnings in examples
@ 2022-05-26 1:42 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-05-26 1:42 UTC (permalink / raw)
To: Ulf Hansson, Krzysztof Kozlowski, Florian Fainelli,
Broadcom internal kernel review list, Hu Ziji, Al Cooper
Cc: linux-mmc, devicetree, linux-arm-kernel, linux-kernel
The 'unevaluatedProperties' schema checks is not fully working and doesn't
catch some cases where there's a $ref to another schema. A fix is pending,
but results in new warnings in examples. Fix the warnings by removing
spurious properties or adding a missing property to the schema.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml | 2 --
Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml | 3 +++
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
index b672202fff4e..5ecdac9de484 100644
--- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
+++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
@@ -75,7 +75,6 @@ examples:
sd-uhs-sdr104;
sdhci,auto-cmd12;
interrupts = <0x0 0x26 0x4>;
- interrupt-names = "sdio0_0";
clocks = <&scmi_clk 245>;
clock-names = "sw_sdio";
};
@@ -94,7 +93,6 @@ examples:
non-removable;
bus-width = <0x8>;
interrupts = <0x0 0x27 0x4>;
- interrupt-names = "sdio1_0";
clocks = <&scmi_clk 245>;
clock-names = "sw_sdio";
};
diff --git a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
index c79639e9027e..aca1a4a8daea 100644
--- a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
@@ -56,6 +56,9 @@ properties:
- const: core
- const: axi
+ interrupts:
+ maxItems: 1
+
marvell,xenon-sdhc-id:
$ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] dt-bindings: mmc: Fix unevaluatedProperties warnings in examples
2022-05-26 1:42 ` Rob Herring
@ 2022-06-01 12:46 ` Ulf Hansson
-1 siblings, 0 replies; 8+ messages in thread
From: Ulf Hansson @ 2022-06-01 12:46 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Florian Fainelli,
Broadcom internal kernel review list, Hu Ziji, Al Cooper,
linux-mmc, devicetree, linux-arm-kernel, linux-kernel
On Thu, 26 May 2022 at 03:42, Rob Herring <robh@kernel.org> wrote:
>
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples. Fix the warnings by removing
> spurious properties or adding a missing property to the schema.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Queued for v5.20 on the devel branch, thanks!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml | 2 --
> Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml | 3 +++
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> index b672202fff4e..5ecdac9de484 100644
> --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> @@ -75,7 +75,6 @@ examples:
> sd-uhs-sdr104;
> sdhci,auto-cmd12;
> interrupts = <0x0 0x26 0x4>;
> - interrupt-names = "sdio0_0";
> clocks = <&scmi_clk 245>;
> clock-names = "sw_sdio";
> };
> @@ -94,7 +93,6 @@ examples:
> non-removable;
> bus-width = <0x8>;
> interrupts = <0x0 0x27 0x4>;
> - interrupt-names = "sdio1_0";
> clocks = <&scmi_clk 245>;
> clock-names = "sw_sdio";
> };
> diff --git a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> index c79639e9027e..aca1a4a8daea 100644
> --- a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> @@ -56,6 +56,9 @@ properties:
> - const: core
> - const: axi
>
> + interrupts:
> + maxItems: 1
> +
> marvell,xenon-sdhc-id:
> $ref: /schemas/types.yaml#/definitions/uint32
> minimum: 0
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Fix unevaluatedProperties warnings in examples
@ 2022-06-01 12:46 ` Ulf Hansson
0 siblings, 0 replies; 8+ messages in thread
From: Ulf Hansson @ 2022-06-01 12:46 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Florian Fainelli,
Broadcom internal kernel review list, Hu Ziji, Al Cooper,
linux-mmc, devicetree, linux-arm-kernel, linux-kernel
On Thu, 26 May 2022 at 03:42, Rob Herring <robh@kernel.org> wrote:
>
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples. Fix the warnings by removing
> spurious properties or adding a missing property to the schema.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Queued for v5.20 on the devel branch, thanks!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml | 2 --
> Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml | 3 +++
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> index b672202fff4e..5ecdac9de484 100644
> --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> @@ -75,7 +75,6 @@ examples:
> sd-uhs-sdr104;
> sdhci,auto-cmd12;
> interrupts = <0x0 0x26 0x4>;
> - interrupt-names = "sdio0_0";
> clocks = <&scmi_clk 245>;
> clock-names = "sw_sdio";
> };
> @@ -94,7 +93,6 @@ examples:
> non-removable;
> bus-width = <0x8>;
> interrupts = <0x0 0x27 0x4>;
> - interrupt-names = "sdio1_0";
> clocks = <&scmi_clk 245>;
> clock-names = "sw_sdio";
> };
> diff --git a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> index c79639e9027e..aca1a4a8daea 100644
> --- a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> @@ -56,6 +56,9 @@ properties:
> - const: core
> - const: axi
>
> + interrupts:
> + maxItems: 1
> +
> marvell,xenon-sdhc-id:
> $ref: /schemas/types.yaml#/definitions/uint32
> minimum: 0
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Fix unevaluatedProperties warnings in examples
2022-06-01 12:46 ` Ulf Hansson
@ 2022-06-01 14:04 ` Rob Herring
-1 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-06-01 14:04 UTC (permalink / raw)
To: Ulf Hansson
Cc: Krzysztof Kozlowski, Florian Fainelli,
Broadcom internal kernel review list, Hu Ziji, Al Cooper,
linux-mmc, devicetree, linux-arm-kernel, linux-kernel
On Wed, Jun 01, 2022 at 02:46:21PM +0200, Ulf Hansson wrote:
> On Thu, 26 May 2022 at 03:42, Rob Herring <robh@kernel.org> wrote:
> >
> > The 'unevaluatedProperties' schema checks is not fully working and doesn't
> > catch some cases where there's a $ref to another schema. A fix is pending,
> > but results in new warnings in examples. Fix the warnings by removing
> > spurious properties or adding a missing property to the schema.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Queued for v5.20 on the devel branch, thanks!
Can you take for 5.19 instead so I can enable this in dtschema sooner
rather than later?
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Fix unevaluatedProperties warnings in examples
@ 2022-06-01 14:04 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-06-01 14:04 UTC (permalink / raw)
To: Ulf Hansson
Cc: Krzysztof Kozlowski, Florian Fainelli,
Broadcom internal kernel review list, Hu Ziji, Al Cooper,
linux-mmc, devicetree, linux-arm-kernel, linux-kernel
On Wed, Jun 01, 2022 at 02:46:21PM +0200, Ulf Hansson wrote:
> On Thu, 26 May 2022 at 03:42, Rob Herring <robh@kernel.org> wrote:
> >
> > The 'unevaluatedProperties' schema checks is not fully working and doesn't
> > catch some cases where there's a $ref to another schema. A fix is pending,
> > but results in new warnings in examples. Fix the warnings by removing
> > spurious properties or adding a missing property to the schema.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Queued for v5.20 on the devel branch, thanks!
Can you take for 5.19 instead so I can enable this in dtschema sooner
rather than later?
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Fix unevaluatedProperties warnings in examples
2022-06-01 14:04 ` Rob Herring
@ 2022-06-01 14:20 ` Ulf Hansson
-1 siblings, 0 replies; 8+ messages in thread
From: Ulf Hansson @ 2022-06-01 14:20 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Florian Fainelli,
Broadcom internal kernel review list, Hu Ziji, Al Cooper,
linux-mmc, devicetree, linux-arm-kernel, linux-kernel
On Wed, 1 Jun 2022 at 16:04, Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Jun 01, 2022 at 02:46:21PM +0200, Ulf Hansson wrote:
> > On Thu, 26 May 2022 at 03:42, Rob Herring <robh@kernel.org> wrote:
> > >
> > > The 'unevaluatedProperties' schema checks is not fully working and doesn't
> > > catch some cases where there's a $ref to another schema. A fix is pending,
> > > but results in new warnings in examples. Fix the warnings by removing
> > > spurious properties or adding a missing property to the schema.
> > >
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> >
> > Queued for v5.20 on the devel branch, thanks!
>
> Can you take for 5.19 instead so I can enable this in dtschema sooner
> rather than later?
Sure! I have moved the patch to the fixes branch now.
Kind regards
Uffe
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Fix unevaluatedProperties warnings in examples
@ 2022-06-01 14:20 ` Ulf Hansson
0 siblings, 0 replies; 8+ messages in thread
From: Ulf Hansson @ 2022-06-01 14:20 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Florian Fainelli,
Broadcom internal kernel review list, Hu Ziji, Al Cooper,
linux-mmc, devicetree, linux-arm-kernel, linux-kernel
On Wed, 1 Jun 2022 at 16:04, Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Jun 01, 2022 at 02:46:21PM +0200, Ulf Hansson wrote:
> > On Thu, 26 May 2022 at 03:42, Rob Herring <robh@kernel.org> wrote:
> > >
> > > The 'unevaluatedProperties' schema checks is not fully working and doesn't
> > > catch some cases where there's a $ref to another schema. A fix is pending,
> > > but results in new warnings in examples. Fix the warnings by removing
> > > spurious properties or adding a missing property to the schema.
> > >
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> >
> > Queued for v5.20 on the devel branch, thanks!
>
> Can you take for 5.19 instead so I can enable this in dtschema sooner
> rather than later?
Sure! I have moved the patch to the fixes branch now.
Kind regards
Uffe
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-06-01 14:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-26 1:42 [PATCH] dt-bindings: mmc: Fix unevaluatedProperties warnings in examples Rob Herring
2022-05-26 1:42 ` Rob Herring
2022-06-01 12:46 ` Ulf Hansson
2022-06-01 12:46 ` Ulf Hansson
2022-06-01 14:04 ` Rob Herring
2022-06-01 14:04 ` Rob Herring
2022-06-01 14:20 ` Ulf Hansson
2022-06-01 14:20 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.