* [PATCH] ARM: omap2: Fix refcount leak in omap3xxx_prm_late_init
@ 2022-05-26 7:37 ` Miaoqian Lin
0 siblings, 0 replies; 4+ messages in thread
From: Miaoqian Lin @ 2022-05-26 7:37 UTC (permalink / raw)
To: Paul Walmsley, Tony Lindgren, Russell King, Nishanth Menon,
Santosh Shilimkar, linux-omap, linux-arm-kernel, linux-kernel
Cc: linmq006
of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: 1e037794f7f0 ("ARM: OMAP3+: PRM: register interrupt information from DT")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
arch/arm/mach-omap2/prm3xxx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/prm3xxx.c b/arch/arm/mach-omap2/prm3xxx.c
index 1b442b128569..63e73e9b82bc 100644
--- a/arch/arm/mach-omap2/prm3xxx.c
+++ b/arch/arm/mach-omap2/prm3xxx.c
@@ -708,6 +708,7 @@ static int omap3xxx_prm_late_init(void)
}
irq_num = of_irq_get(np, 0);
+ of_node_put(np);
if (irq_num == -EPROBE_DEFER)
return irq_num;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: omap2: Fix refcount leak in omap3xxx_prm_late_init
@ 2022-05-26 7:37 ` Miaoqian Lin
0 siblings, 0 replies; 4+ messages in thread
From: Miaoqian Lin @ 2022-05-26 7:37 UTC (permalink / raw)
To: Paul Walmsley, Tony Lindgren, Russell King, Nishanth Menon,
Santosh Shilimkar, linux-omap, linux-arm-kernel, linux-kernel
Cc: linmq006
of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: 1e037794f7f0 ("ARM: OMAP3+: PRM: register interrupt information from DT")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
arch/arm/mach-omap2/prm3xxx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/prm3xxx.c b/arch/arm/mach-omap2/prm3xxx.c
index 1b442b128569..63e73e9b82bc 100644
--- a/arch/arm/mach-omap2/prm3xxx.c
+++ b/arch/arm/mach-omap2/prm3xxx.c
@@ -708,6 +708,7 @@ static int omap3xxx_prm_late_init(void)
}
irq_num = of_irq_get(np, 0);
+ of_node_put(np);
if (irq_num == -EPROBE_DEFER)
return irq_num;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: omap2: Fix refcount leak in omap3xxx_prm_late_init
2022-05-26 7:37 ` Miaoqian Lin
@ 2022-06-28 5:10 ` Tony Lindgren
-1 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2022-06-28 5:10 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Paul Walmsley, Russell King, Nishanth Menon, Santosh Shilimkar,
linux-omap, linux-arm-kernel, linux-kernel
* Miaoqian Lin <linmq006@gmail.com> [220526 10:33]:
> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
Thanks applying into omap-for-v5.10/soc.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: omap2: Fix refcount leak in omap3xxx_prm_late_init
@ 2022-06-28 5:10 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2022-06-28 5:10 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Paul Walmsley, Russell King, Nishanth Menon, Santosh Shilimkar,
linux-omap, linux-arm-kernel, linux-kernel
* Miaoqian Lin <linmq006@gmail.com> [220526 10:33]:
> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
Thanks applying into omap-for-v5.10/soc.
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-28 5:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-26 7:37 [PATCH] ARM: omap2: Fix refcount leak in omap3xxx_prm_late_init Miaoqian Lin
2022-05-26 7:37 ` Miaoqian Lin
2022-06-28 5:10 ` Tony Lindgren
2022-06-28 5:10 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.