* [PATCH V2] x86/idt: traceponit.c: fix comment for irq vector tracepoints
@ 2022-05-26 11:08 sunliming
2022-05-26 16:24 ` Dave Hansen
0 siblings, 1 reply; 3+ messages in thread
From: sunliming @ 2022-05-26 11:08 UTC (permalink / raw)
To: mingo, linux-tip-commits, dave.hansen, rostedt
Cc: x86, linux-kernel, sunliming, kelulanainsley
Commit:
4b9a8dca0e58 ("x86/idt: Remove the tracing IDT completely")
removed the 'tracing IDT' from arch/x86/kernel/tracepoint.c,
but left related comment. So that the comment become anachronistic.
Just remove the comment.
Signed-off-by: sunliming <sunliming@kylinos.cn>
---
arch/x86/kernel/tracepoint.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/x86/kernel/tracepoint.c b/arch/x86/kernel/tracepoint.c
index fcfc077afe2d..065191022035 100644
--- a/arch/x86/kernel/tracepoint.c
+++ b/arch/x86/kernel/tracepoint.c
@@ -1,9 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
/*
- * Code for supporting irq vector tracepoints.
- *
* Copyright (C) 2013 Seiji Aguchi <seiji.aguchi@hds.com>
- *
*/
#include <linux/jump_label.h>
#include <linux/atomic.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] x86/idt: traceponit.c: fix comment for irq vector tracepoints
2022-05-26 11:08 [PATCH V2] x86/idt: traceponit.c: fix comment for irq vector tracepoints sunliming
@ 2022-05-26 16:24 ` Dave Hansen
2022-05-26 18:38 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Dave Hansen @ 2022-05-26 16:24 UTC (permalink / raw)
To: sunliming, mingo, linux-tip-commits, dave.hansen, rostedt
Cc: x86, linux-kernel, kelulanainsley
On 5/26/22 04:08, sunliming wrote:
>
> diff --git a/arch/x86/kernel/tracepoint.c b/arch/x86/kernel/tracepoint.c
> index fcfc077afe2d..065191022035 100644
> --- a/arch/x86/kernel/tracepoint.c
> +++ b/arch/x86/kernel/tracepoint.c
> @@ -1,9 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Code for supporting irq vector tracepoints.
> - *
> * Copyright (C) 2013 Seiji Aguchi <seiji.aguchi@hds.com>
> - *
> */
> #include <linux/jump_label.h>
> #include <linux/atomic.h>
While I'm also generally careful about removing others' copyrights, Mr.
Aguchi only touched this file once and all of the code from that one
touch appears to be gone to me. Shouldn't we just zap the whole comment?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] x86/idt: traceponit.c: fix comment for irq vector tracepoints
2022-05-26 16:24 ` Dave Hansen
@ 2022-05-26 18:38 ` Steven Rostedt
0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2022-05-26 18:38 UTC (permalink / raw)
To: Dave Hansen
Cc: sunliming, mingo, linux-tip-commits, dave.hansen, x86,
linux-kernel, kelulanainsley
On Thu, 26 May 2022 09:24:31 -0700
Dave Hansen <dave.hansen@intel.com> wrote:
> On 5/26/22 04:08, sunliming wrote:
> >
> > diff --git a/arch/x86/kernel/tracepoint.c b/arch/x86/kernel/tracepoint.c
> > index fcfc077afe2d..065191022035 100644
> > --- a/arch/x86/kernel/tracepoint.c
> > +++ b/arch/x86/kernel/tracepoint.c
> > @@ -1,9 +1,6 @@
> > // SPDX-License-Identifier: GPL-2.0
> > /*
> > - * Code for supporting irq vector tracepoints.
> > - *
> > * Copyright (C) 2013 Seiji Aguchi <seiji.aguchi@hds.com>
> > - *
> > */
> > #include <linux/jump_label.h>
> > #include <linux/atomic.h>
>
> While I'm also generally careful about removing others' copyrights, Mr.
> Aguchi only touched this file once and all of the code from that one
> touch appears to be gone to me. Shouldn't we just zap the whole comment?
Perhaps, but that's a different change than this is addressing. This is
only addressing fixing the comments about the removal of the code.
But looking at the history of this file. Seiji created it, but the only
code that remains in the file was mostly added by Thomas. The only lines
that Seiji has now is the whitespace and the brackets.
I would still have the removal of the copyright as a separate patch.
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-26 18:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-26 11:08 [PATCH V2] x86/idt: traceponit.c: fix comment for irq vector tracepoints sunliming
2022-05-26 16:24 ` Dave Hansen
2022-05-26 18:38 ` Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.