All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eugenio Pérez" <eperezma@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
	netdev@vger.kernel.org
Cc: martinh@xilinx.com, Stefano Garzarella <sgarzare@redhat.com>,
	martinpo@xilinx.com, lvivier@redhat.com, pabloc@xilinx.com,
	Parav Pandit <parav@nvidia.com>, Eli Cohen <elic@nvidia.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Xie Yongji <xieyongji@bytedance.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Zhang Min <zhang.min9@zte.com.cn>,
	Wu Zongyong <wuzongyong@linux.alibaba.com>,
	lulu@redhat.com, Zhu Lingshan <lingshan.zhu@intel.com>,
	Piotr.Uminski@intel.com, Si-Wei Liu <si-wei.liu@oracle.com>,
	ecree.xilinx@gmail.com, gautam.dawar@amd.com,
	habetsm.xilinx@gmail.com, tanuj.kamde@amd.com, hanand@xilinx.com,
	dinang@xilinx.com, Longpeng <longpeng2@huawei.com>
Subject: [PATCH v4 4/4] vdpa_sim: Implement stop vdpa op
Date: Thu, 26 May 2022 14:43:38 +0200	[thread overview]
Message-ID: <20220526124338.36247-5-eperezma@redhat.com> (raw)
In-Reply-To: <20220526124338.36247-1-eperezma@redhat.com>

Implement stop operation for vdpa_sim devices, so vhost-vdpa will offer
that backend feature and userspace can effectively stop the device.

This is a must before get virtqueue indexes (base) for live migration,
since the device could modify them after userland gets them. There are
individual ways to perform that action for some devices
(VHOST_NET_SET_BACKEND, VHOST_VSOCK_SET_RUNNING, ...) but there was no
way to perform it for any vhost device (and, in particular, vhost-vdpa).

Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
 drivers/vdpa/vdpa_sim/vdpa_sim.c     | 21 +++++++++++++++++++++
 drivers/vdpa/vdpa_sim/vdpa_sim.h     |  1 +
 drivers/vdpa/vdpa_sim/vdpa_sim_blk.c |  3 +++
 drivers/vdpa/vdpa_sim/vdpa_sim_net.c |  3 +++
 4 files changed, 28 insertions(+)

diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
index 50d721072beb..0515cf314bed 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
@@ -107,6 +107,7 @@ static void vdpasim_do_reset(struct vdpasim *vdpasim)
 	for (i = 0; i < vdpasim->dev_attr.nas; i++)
 		vhost_iotlb_reset(&vdpasim->iommu[i]);
 
+	vdpasim->running = true;
 	spin_unlock(&vdpasim->iommu_lock);
 
 	vdpasim->features = 0;
@@ -505,6 +506,24 @@ static int vdpasim_reset(struct vdpa_device *vdpa)
 	return 0;
 }
 
+static int vdpasim_stop(struct vdpa_device *vdpa, bool stop)
+{
+	struct vdpasim *vdpasim = vdpa_to_sim(vdpa);
+	int i;
+
+	spin_lock(&vdpasim->lock);
+	vdpasim->running = !stop;
+	if (vdpasim->running) {
+		/* Check for missed buffers */
+		for (i = 0; i < vdpasim->dev_attr.nvqs; ++i)
+			vdpasim_kick_vq(vdpa, i);
+
+	}
+	spin_unlock(&vdpasim->lock);
+
+	return 0;
+}
+
 static size_t vdpasim_get_config_size(struct vdpa_device *vdpa)
 {
 	struct vdpasim *vdpasim = vdpa_to_sim(vdpa);
@@ -694,6 +713,7 @@ static const struct vdpa_config_ops vdpasim_config_ops = {
 	.get_status             = vdpasim_get_status,
 	.set_status             = vdpasim_set_status,
 	.reset			= vdpasim_reset,
+	.stop			= vdpasim_stop,
 	.get_config_size        = vdpasim_get_config_size,
 	.get_config             = vdpasim_get_config,
 	.set_config             = vdpasim_set_config,
@@ -726,6 +746,7 @@ static const struct vdpa_config_ops vdpasim_batch_config_ops = {
 	.get_status             = vdpasim_get_status,
 	.set_status             = vdpasim_set_status,
 	.reset			= vdpasim_reset,
+	.stop			= vdpasim_stop,
 	.get_config_size        = vdpasim_get_config_size,
 	.get_config             = vdpasim_get_config,
 	.set_config             = vdpasim_set_config,
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.h b/drivers/vdpa/vdpa_sim/vdpa_sim.h
index 622782e92239..061986f30911 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim.h
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.h
@@ -66,6 +66,7 @@ struct vdpasim {
 	u32 generation;
 	u64 features;
 	u32 groups;
+	bool running;
 	/* spinlock to synchronize iommu table */
 	spinlock_t iommu_lock;
 };
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
index 42d401d43911..bcdb1982c378 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
@@ -204,6 +204,9 @@ static void vdpasim_blk_work(struct work_struct *work)
 	if (!(vdpasim->status & VIRTIO_CONFIG_S_DRIVER_OK))
 		goto out;
 
+	if (!vdpasim->running)
+		goto out;
+
 	for (i = 0; i < VDPASIM_BLK_VQ_NUM; i++) {
 		struct vdpasim_virtqueue *vq = &vdpasim->vqs[i];
 
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
index 5125976a4df8..886449e88502 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
@@ -154,6 +154,9 @@ static void vdpasim_net_work(struct work_struct *work)
 
 	spin_lock(&vdpasim->lock);
 
+	if (!vdpasim->running)
+		goto out;
+
 	if (!(vdpasim->status & VIRTIO_CONFIG_S_DRIVER_OK))
 		goto out;
 
-- 
2.31.1


  parent reply	other threads:[~2022-05-26 12:44 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26 12:43 [PATCH v4 0/4] Implement vdpasim stop operation Eugenio Pérez
2022-05-26 12:43 ` [PATCH v4 1/4] vdpa: Add " Eugenio Pérez
2022-05-26 14:23   ` Stefano Garzarella
2022-05-26 14:23     ` Stefano Garzarella
2022-05-26 15:32     ` Eugenio Perez Martin
2022-06-01  5:35   ` Eli Cohen
2022-06-01  6:53     ` Eugenio Perez Martin
2022-05-26 12:43 ` [PATCH v4 2/4] vhost-vdpa: introduce STOP backend feature bit Eugenio Pérez
2022-05-26 12:43 ` [PATCH v4 3/4] vhost-vdpa: uAPI to stop the device Eugenio Pérez
2022-06-01 11:03   ` Michael S. Tsirkin
2022-06-01 11:03     ` Michael S. Tsirkin
2022-06-01 11:15     ` Eugenio Perez Martin
2022-06-01 19:13       ` Parav Pandit via Virtualization
2022-06-01 19:13         ` Parav Pandit
2022-06-02  6:21         ` Eugenio Perez Martin
2022-05-26 12:43 ` Eugenio Pérez [this message]
2022-05-26 14:25   ` [PATCH v4 4/4] vdpa_sim: Implement stop vdpa op Stefano Garzarella
2022-05-26 14:25     ` Stefano Garzarella
2022-05-26 12:54 ` [PATCH v4 0/4] Implement vdpasim stop operation Parav Pandit
2022-05-26 12:54   ` Parav Pandit via Virtualization
2022-05-27  2:26   ` Jason Wang
2022-05-27  2:26     ` Jason Wang
2022-05-27  7:55     ` Eugenio Perez Martin
2022-05-31 20:26       ` Parav Pandit
2022-05-31 20:26         ` Parav Pandit via Virtualization
2022-06-01 10:48         ` Eugenio Perez Martin
2022-05-27 10:55   ` Michael S. Tsirkin
2022-05-27 10:55     ` Michael S. Tsirkin
2022-05-30  3:39     ` Jason Wang
2022-05-30  3:39       ` Jason Wang
2022-05-31  5:40       ` Michael S. Tsirkin
2022-05-31  5:40         ` Michael S. Tsirkin
2022-05-31  6:44         ` Jason Wang
2022-05-31  6:44           ` Jason Wang
2022-05-31 20:19       ` Parav Pandit
2022-05-31 20:19         ` Parav Pandit via Virtualization
2022-06-01  2:42         ` Jason Wang
2022-06-01  2:42           ` Jason Wang
2022-06-01 18:58           ` Parav Pandit via Virtualization
2022-06-01 18:58             ` Parav Pandit
2022-06-02  2:00             ` Jason Wang
2022-06-02  2:00               ` Jason Wang
2022-06-02  2:59               ` Parav Pandit
2022-06-02  2:59                 ` Parav Pandit via Virtualization
2022-06-02  3:53                 ` Jason Wang
2022-06-02  3:53                   ` Jason Wang
2022-06-15  0:10                   ` Parav Pandit
2022-06-15  0:10                     ` Parav Pandit via Virtualization
2022-06-15  1:28                     ` Jason Wang
2022-06-15  1:28                       ` Jason Wang
2022-06-16 19:36                       ` Parav Pandit
2022-06-16 19:36                         ` Parav Pandit via Virtualization
2022-06-17  1:15                         ` Jason Wang
2022-06-17  1:15                           ` Jason Wang
2022-06-17  2:42                           ` Parav Pandit
2022-06-17  2:42                             ` Parav Pandit via Virtualization
2022-06-02  8:57                 ` Eugenio Perez Martin
2022-06-01  9:49         ` Eugenio Perez Martin
2022-06-01 19:30           ` Parav Pandit via Virtualization
2022-06-01 19:30             ` Parav Pandit
2022-06-02  2:02             ` Jason Wang
2022-06-02  2:02               ` Jason Wang
2022-05-31  5:42 ` Michael S. Tsirkin
2022-05-31  5:42   ` Michael S. Tsirkin
2022-05-31  7:13   ` Eugenio Perez Martin
2022-05-31  9:23     ` Michael S. Tsirkin
2022-05-31  9:23       ` Michael S. Tsirkin
2022-06-02  2:08 ` Jason Wang
2022-06-02  2:08   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220526124338.36247-5-eperezma@redhat.com \
    --to=eperezma@redhat.com \
    --cc=Piotr.Uminski@intel.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dan.carpenter@oracle.com \
    --cc=dinang@xilinx.com \
    --cc=ecree.xilinx@gmail.com \
    --cc=elic@nvidia.com \
    --cc=gautam.dawar@amd.com \
    --cc=habetsm.xilinx@gmail.com \
    --cc=hanand@xilinx.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lingshan.zhu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longpeng2@huawei.com \
    --cc=lulu@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=martinh@xilinx.com \
    --cc=martinpo@xilinx.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabloc@xilinx.com \
    --cc=parav@nvidia.com \
    --cc=sgarzare@redhat.com \
    --cc=si-wei.liu@oracle.com \
    --cc=tanuj.kamde@amd.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wuzongyong@linux.alibaba.com \
    --cc=xieyongji@bytedance.com \
    --cc=zhang.min9@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.