From: Parav Pandit <parav@nvidia.com> To: "Eugenio Pérez" <eperezma@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Jason Wang" <jasowang@redhat.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org> Cc: "martinh@xilinx.com" <martinh@xilinx.com>, Stefano Garzarella <sgarzare@redhat.com>, "martinpo@xilinx.com" <martinpo@xilinx.com>, "lvivier@redhat.com" <lvivier@redhat.com>, "pabloc@xilinx.com" <pabloc@xilinx.com>, Eli Cohen <elic@nvidia.com>, Dan Carpenter <dan.carpenter@oracle.com>, Xie Yongji <xieyongji@bytedance.com>, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Zhang Min <zhang.min9@zte.com.cn>, Wu Zongyong <wuzongyong@linux.alibaba.com>, "lulu@redhat.com" <lulu@redhat.com>, Zhu Lingshan <lingshan.zhu@intel.com>, "Piotr.Uminski@intel.com" <Piotr.Uminski@intel.com>, Si-Wei Liu <si-wei.liu@oracle.com>, "ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>, "gautam.dawar@amd.com" <gautam.dawar@amd.com>, "habetsm.xilinx@gmail.com" <habetsm.xilinx@gmail.com>, "tanuj.kamde@amd.com" <tanuj.kamde@amd.com>, "hanand@xilinx.com" <hanand@xilinx.com>, "dinang@xilinx.com" <dinang@xilinx.com>, Longpeng <longpeng2@huawei.com> Subject: RE: [PATCH v4 0/4] Implement vdpasim stop operation Date: Thu, 26 May 2022 12:54:32 +0000 [thread overview] Message-ID: <PH0PR12MB54819C6C6DAF6572AEADC1AEDCD99@PH0PR12MB5481.namprd12.prod.outlook.com> (raw) In-Reply-To: <20220526124338.36247-1-eperezma@redhat.com> > From: Eugenio Pérez <eperezma@redhat.com> > Sent: Thursday, May 26, 2022 8:44 AM > Implement stop operation for vdpa_sim devices, so vhost-vdpa will offer > > that backend feature and userspace can effectively stop the device. > > > > This is a must before get virtqueue indexes (base) for live migration, > > since the device could modify them after userland gets them. There are > > individual ways to perform that action for some devices > > (VHOST_NET_SET_BACKEND, VHOST_VSOCK_SET_RUNNING, ...) but there > was no > > way to perform it for any vhost device (and, in particular, vhost-vdpa). > > > > After the return of ioctl with stop != 0, the device MUST finish any > > pending operations like in flight requests. It must also preserve all > > the necessary state (the virtqueue vring base plus the possible device > > specific states) that is required for restoring in the future. The > > device must not change its configuration after that point. > > > > After the return of ioctl with stop == 0, the device can continue > > processing buffers as long as typical conditions are met (vq is enabled, > > DRIVER_OK status bit is enabled, etc). Just to be clear, we are adding vdpa level new ioctl() that doesn’t map to any mechanism in the virtio spec. Why can't we use this ioctl() to indicate driver to start/stop the device instead of driving it through the driver_ok? This is in the context of other discussion we had in the LM series.
WARNING: multiple messages have this Message-ID (diff)
From: Parav Pandit via Virtualization <virtualization@lists.linux-foundation.org> To: "Eugenio Pérez" <eperezma@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Jason Wang" <jasowang@redhat.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org> Cc: "tanuj.kamde@amd.com" <tanuj.kamde@amd.com>, Wu Zongyong <wuzongyong@linux.alibaba.com>, Si-Wei Liu <si-wei.liu@oracle.com>, "pabloc@xilinx.com" <pabloc@xilinx.com>, Eli Cohen <elic@nvidia.com>, Zhang Min <zhang.min9@zte.com.cn>, "lulu@redhat.com" <lulu@redhat.com>, "Piotr.Uminski@intel.com" <Piotr.Uminski@intel.com>, "martinh@xilinx.com" <martinh@xilinx.com>, Xie Yongji <xieyongji@bytedance.com>, "dinang@xilinx.com" <dinang@xilinx.com>, "habetsm.xilinx@gmail.com" <habetsm.xilinx@gmail.com>, Longpeng <longpeng2@huawei.com>, Dan Carpenter <dan.carpenter@oracle.com>, "lvivier@redhat.com" <lvivier@redhat.com>, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, "gautam.dawar@amd.com" <gautam.dawar@amd.com>, "ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>, "hanand@xilinx.com" <hanand@xilinx.com>, "martinpo@xilinx.com" <martinpo@xilinx.com>, Zhu Lingshan <lingshan.zhu@intel.com> Subject: RE: [PATCH v4 0/4] Implement vdpasim stop operation Date: Thu, 26 May 2022 12:54:32 +0000 [thread overview] Message-ID: <PH0PR12MB54819C6C6DAF6572AEADC1AEDCD99@PH0PR12MB5481.namprd12.prod.outlook.com> (raw) In-Reply-To: <20220526124338.36247-1-eperezma@redhat.com> > From: Eugenio Pérez <eperezma@redhat.com> > Sent: Thursday, May 26, 2022 8:44 AM > Implement stop operation for vdpa_sim devices, so vhost-vdpa will offer > > that backend feature and userspace can effectively stop the device. > > > > This is a must before get virtqueue indexes (base) for live migration, > > since the device could modify them after userland gets them. There are > > individual ways to perform that action for some devices > > (VHOST_NET_SET_BACKEND, VHOST_VSOCK_SET_RUNNING, ...) but there > was no > > way to perform it for any vhost device (and, in particular, vhost-vdpa). > > > > After the return of ioctl with stop != 0, the device MUST finish any > > pending operations like in flight requests. It must also preserve all > > the necessary state (the virtqueue vring base plus the possible device > > specific states) that is required for restoring in the future. The > > device must not change its configuration after that point. > > > > After the return of ioctl with stop == 0, the device can continue > > processing buffers as long as typical conditions are met (vq is enabled, > > DRIVER_OK status bit is enabled, etc). Just to be clear, we are adding vdpa level new ioctl() that doesn’t map to any mechanism in the virtio spec. Why can't we use this ioctl() to indicate driver to start/stop the device instead of driving it through the driver_ok? This is in the context of other discussion we had in the LM series. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-05-26 12:54 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-26 12:43 [PATCH v4 0/4] Implement vdpasim stop operation Eugenio Pérez 2022-05-26 12:43 ` [PATCH v4 1/4] vdpa: Add " Eugenio Pérez 2022-05-26 14:23 ` Stefano Garzarella 2022-05-26 14:23 ` Stefano Garzarella 2022-05-26 15:32 ` Eugenio Perez Martin 2022-06-01 5:35 ` Eli Cohen 2022-06-01 6:53 ` Eugenio Perez Martin 2022-05-26 12:43 ` [PATCH v4 2/4] vhost-vdpa: introduce STOP backend feature bit Eugenio Pérez 2022-05-26 12:43 ` [PATCH v4 3/4] vhost-vdpa: uAPI to stop the device Eugenio Pérez 2022-06-01 11:03 ` Michael S. Tsirkin 2022-06-01 11:03 ` Michael S. Tsirkin 2022-06-01 11:15 ` Eugenio Perez Martin 2022-06-01 19:13 ` Parav Pandit via Virtualization 2022-06-01 19:13 ` Parav Pandit 2022-06-02 6:21 ` Eugenio Perez Martin 2022-05-26 12:43 ` [PATCH v4 4/4] vdpa_sim: Implement stop vdpa op Eugenio Pérez 2022-05-26 14:25 ` Stefano Garzarella 2022-05-26 14:25 ` Stefano Garzarella 2022-05-26 12:54 ` Parav Pandit [this message] 2022-05-26 12:54 ` [PATCH v4 0/4] Implement vdpasim stop operation Parav Pandit via Virtualization 2022-05-27 2:26 ` Jason Wang 2022-05-27 2:26 ` Jason Wang 2022-05-27 7:55 ` Eugenio Perez Martin 2022-05-31 20:26 ` Parav Pandit 2022-05-31 20:26 ` Parav Pandit via Virtualization 2022-06-01 10:48 ` Eugenio Perez Martin 2022-05-27 10:55 ` Michael S. Tsirkin 2022-05-27 10:55 ` Michael S. Tsirkin 2022-05-30 3:39 ` Jason Wang 2022-05-30 3:39 ` Jason Wang 2022-05-31 5:40 ` Michael S. Tsirkin 2022-05-31 5:40 ` Michael S. Tsirkin 2022-05-31 6:44 ` Jason Wang 2022-05-31 6:44 ` Jason Wang 2022-05-31 20:19 ` Parav Pandit 2022-05-31 20:19 ` Parav Pandit via Virtualization 2022-06-01 2:42 ` Jason Wang 2022-06-01 2:42 ` Jason Wang 2022-06-01 18:58 ` Parav Pandit via Virtualization 2022-06-01 18:58 ` Parav Pandit 2022-06-02 2:00 ` Jason Wang 2022-06-02 2:00 ` Jason Wang 2022-06-02 2:59 ` Parav Pandit 2022-06-02 2:59 ` Parav Pandit via Virtualization 2022-06-02 3:53 ` Jason Wang 2022-06-02 3:53 ` Jason Wang 2022-06-15 0:10 ` Parav Pandit 2022-06-15 0:10 ` Parav Pandit via Virtualization 2022-06-15 1:28 ` Jason Wang 2022-06-15 1:28 ` Jason Wang 2022-06-16 19:36 ` Parav Pandit 2022-06-16 19:36 ` Parav Pandit via Virtualization 2022-06-17 1:15 ` Jason Wang 2022-06-17 1:15 ` Jason Wang 2022-06-17 2:42 ` Parav Pandit 2022-06-17 2:42 ` Parav Pandit via Virtualization 2022-06-02 8:57 ` Eugenio Perez Martin 2022-06-01 9:49 ` Eugenio Perez Martin 2022-06-01 19:30 ` Parav Pandit via Virtualization 2022-06-01 19:30 ` Parav Pandit 2022-06-02 2:02 ` Jason Wang 2022-06-02 2:02 ` Jason Wang 2022-05-31 5:42 ` Michael S. Tsirkin 2022-05-31 5:42 ` Michael S. Tsirkin 2022-05-31 7:13 ` Eugenio Perez Martin 2022-05-31 9:23 ` Michael S. Tsirkin 2022-05-31 9:23 ` Michael S. Tsirkin 2022-06-02 2:08 ` Jason Wang 2022-06-02 2:08 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=PH0PR12MB54819C6C6DAF6572AEADC1AEDCD99@PH0PR12MB5481.namprd12.prod.outlook.com \ --to=parav@nvidia.com \ --cc=Piotr.Uminski@intel.com \ --cc=christophe.jaillet@wanadoo.fr \ --cc=dan.carpenter@oracle.com \ --cc=dinang@xilinx.com \ --cc=ecree.xilinx@gmail.com \ --cc=elic@nvidia.com \ --cc=eperezma@redhat.com \ --cc=gautam.dawar@amd.com \ --cc=habetsm.xilinx@gmail.com \ --cc=hanand@xilinx.com \ --cc=jasowang@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=lingshan.zhu@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=longpeng2@huawei.com \ --cc=lulu@redhat.com \ --cc=lvivier@redhat.com \ --cc=martinh@xilinx.com \ --cc=martinpo@xilinx.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=pabloc@xilinx.com \ --cc=sgarzare@redhat.com \ --cc=si-wei.liu@oracle.com \ --cc=tanuj.kamde@amd.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=wuzongyong@linux.alibaba.com \ --cc=xieyongji@bytedance.com \ --cc=zhang.min9@zte.com.cn \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.