From: Jason Wang <jasowang@redhat.com> To: mst@redhat.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: tglx@linutronix.de, peterz@infradead.org, paulmck@kernel.org, maz@kernel.org, pasic@linux.ibm.com, cohuck@redhat.com, eperezma@redhat.com, lulu@redhat.com, sgarzare@redhat.com, xuanzhuo@linux.alibaba.com Subject: [PATCH V6 0/9] rework on the IRQ hardening of virtio Date: Fri, 27 May 2022 14:01:11 +0800 [thread overview] Message-ID: <20220527060120.20964-1-jasowang@redhat.com> (raw) Hi All: This is a rework on the IRQ hardening for virtio which is done previously by the following commits are reverted: 9e35276a5344 ("virtio_pci: harden MSI-X interrupts") 080cd7c3ac87 ("virtio-pci: harden INTX interrupts") The reason is that it depends on the IRQF_NO_AUTOEN which may conflict with the assumption of the affinity managed IRQ that is used by some virtio drivers. And what's more, it is only done for virtio-pci but not other transports. In this rework, I try to implement a general virtio solution which borrows the idea of the INTX hardening by re-using per virtqueue boolean vq->broken and toggle it in virtio_device_ready() and virtio_reset_device(). Then we can simply reuse the existing checks in the vring_interrupt() and return early if the driver is not ready. Note that, I only did compile test on ccw and MMIO transport. Please review. Changes since V5: - Various tweaks on the comments Changes since V4: - use spin_lock_irq()/spin_unlock_irq() to synchronize with vring_interrupt() for ccw - use spin_lock()/spin_unlock() to protect vring_interrupt() for non airq - add comment to explain the ordering implications of set_status() for PCI, ccw and MMIO - various tweaks on the comments and changelogs Changes since V3: - Rename synchornize_vqs() to synchronize_cbs() - tweak the comment for synchronize_cbs() - switch to use a dedicated helper __virtio_unbreak_device() and document it should be only used for probing - switch to use rwlock to synchornize the non airq for ccw Changes since V2: - add ccw and MMIO support - rename synchronize_vqs() to synchronize_cbs() - switch to re-use vq->broken instead of introducing new device attributes for the future virtqueue reset support - remove unnecssary READ_ONCE()/WRITE_ONCE() - a new patch to remove device triggerable BUG_ON() - more tweaks on the comments Changes since v1: - Use transport specific irq synchronization method when possible - Drop the module parameter and enable the hardening unconditonally - Tweak the barrier/ordering facilities used in the code - Reanme irq_soft_enabled to driver_ready - Avoid unnecssary IRQ synchornization (e.g during boot) Jason Wang (8): virtio: use virtio_reset_device() when possible virtio: introduce config op to synchronize vring callbacks virtio-pci: implement synchronize_cbs() virtio-mmio: implement synchronize_cbs() virtio-ccw: implement synchronize_cbs() virtio: allow to unbreak virtqueue virtio: harden vring IRQ virtio: use WARN_ON() to warning illegal status value Stefano Garzarella (1): virtio: use virtio_device_ready() in virtio_device_restore() drivers/s390/virtio/virtio_ccw.c | 34 +++++++++++++++++++ drivers/virtio/virtio.c | 24 +++++++++---- drivers/virtio/virtio_mmio.c | 13 +++++++ drivers/virtio/virtio_pci_legacy.c | 1 + drivers/virtio/virtio_pci_modern.c | 2 ++ drivers/virtio/virtio_pci_modern_dev.c | 5 +++ drivers/virtio/virtio_ring.c | 33 +++++++++++++++--- include/linux/virtio.h | 1 + include/linux/virtio_config.h | 47 +++++++++++++++++++++++++- 9 files changed, 148 insertions(+), 12 deletions(-) -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: mst@redhat.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: lulu@redhat.com, paulmck@kernel.org, peterz@infradead.org, maz@kernel.org, cohuck@redhat.com, pasic@linux.ibm.com, eperezma@redhat.com, tglx@linutronix.de Subject: [PATCH V6 0/9] rework on the IRQ hardening of virtio Date: Fri, 27 May 2022 14:01:11 +0800 [thread overview] Message-ID: <20220527060120.20964-1-jasowang@redhat.com> (raw) Hi All: This is a rework on the IRQ hardening for virtio which is done previously by the following commits are reverted: 9e35276a5344 ("virtio_pci: harden MSI-X interrupts") 080cd7c3ac87 ("virtio-pci: harden INTX interrupts") The reason is that it depends on the IRQF_NO_AUTOEN which may conflict with the assumption of the affinity managed IRQ that is used by some virtio drivers. And what's more, it is only done for virtio-pci but not other transports. In this rework, I try to implement a general virtio solution which borrows the idea of the INTX hardening by re-using per virtqueue boolean vq->broken and toggle it in virtio_device_ready() and virtio_reset_device(). Then we can simply reuse the existing checks in the vring_interrupt() and return early if the driver is not ready. Note that, I only did compile test on ccw and MMIO transport. Please review. Changes since V5: - Various tweaks on the comments Changes since V4: - use spin_lock_irq()/spin_unlock_irq() to synchronize with vring_interrupt() for ccw - use spin_lock()/spin_unlock() to protect vring_interrupt() for non airq - add comment to explain the ordering implications of set_status() for PCI, ccw and MMIO - various tweaks on the comments and changelogs Changes since V3: - Rename synchornize_vqs() to synchronize_cbs() - tweak the comment for synchronize_cbs() - switch to use a dedicated helper __virtio_unbreak_device() and document it should be only used for probing - switch to use rwlock to synchornize the non airq for ccw Changes since V2: - add ccw and MMIO support - rename synchronize_vqs() to synchronize_cbs() - switch to re-use vq->broken instead of introducing new device attributes for the future virtqueue reset support - remove unnecssary READ_ONCE()/WRITE_ONCE() - a new patch to remove device triggerable BUG_ON() - more tweaks on the comments Changes since v1: - Use transport specific irq synchronization method when possible - Drop the module parameter and enable the hardening unconditonally - Tweak the barrier/ordering facilities used in the code - Reanme irq_soft_enabled to driver_ready - Avoid unnecssary IRQ synchornization (e.g during boot) Jason Wang (8): virtio: use virtio_reset_device() when possible virtio: introduce config op to synchronize vring callbacks virtio-pci: implement synchronize_cbs() virtio-mmio: implement synchronize_cbs() virtio-ccw: implement synchronize_cbs() virtio: allow to unbreak virtqueue virtio: harden vring IRQ virtio: use WARN_ON() to warning illegal status value Stefano Garzarella (1): virtio: use virtio_device_ready() in virtio_device_restore() drivers/s390/virtio/virtio_ccw.c | 34 +++++++++++++++++++ drivers/virtio/virtio.c | 24 +++++++++---- drivers/virtio/virtio_mmio.c | 13 +++++++ drivers/virtio/virtio_pci_legacy.c | 1 + drivers/virtio/virtio_pci_modern.c | 2 ++ drivers/virtio/virtio_pci_modern_dev.c | 5 +++ drivers/virtio/virtio_ring.c | 33 +++++++++++++++--- include/linux/virtio.h | 1 + include/linux/virtio_config.h | 47 +++++++++++++++++++++++++- 9 files changed, 148 insertions(+), 12 deletions(-) -- 2.25.1 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next reply other threads:[~2022-05-27 6:01 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-27 6:01 Jason Wang [this message] 2022-05-27 6:01 ` [PATCH V6 0/9] rework on the IRQ hardening of virtio Jason Wang 2022-05-27 6:01 ` [PATCH V6 1/9] virtio: use virtio_device_ready() in virtio_device_restore() Jason Wang 2022-05-27 6:01 ` Jason Wang 2022-05-27 7:29 ` Xuan Zhuo 2022-05-27 7:29 ` Xuan Zhuo 2022-05-27 6:01 ` [PATCH V6 2/9] virtio: use virtio_reset_device() when possible Jason Wang 2022-05-27 6:01 ` Jason Wang 2022-05-27 7:30 ` Xuan Zhuo 2022-05-27 7:30 ` Xuan Zhuo 2022-05-27 8:52 ` Eugenio Perez Martin 2022-05-27 10:34 ` Stefano Garzarella 2022-05-27 10:34 ` Stefano Garzarella 2022-05-27 6:01 ` [PATCH V6 3/9] virtio: introduce config op to synchronize vring callbacks Jason Wang 2022-05-27 6:01 ` Jason Wang 2022-05-27 7:30 ` Xuan Zhuo 2022-05-27 7:30 ` Xuan Zhuo 2022-05-27 10:36 ` Stefano Garzarella 2022-05-27 10:36 ` Stefano Garzarella 2022-05-27 6:01 ` [PATCH V6 4/9] virtio-pci: implement synchronize_cbs() Jason Wang 2022-05-27 6:01 ` Jason Wang 2022-05-27 7:31 ` Xuan Zhuo 2022-05-27 7:31 ` Xuan Zhuo 2022-05-27 6:01 ` [PATCH V6 5/9] virtio-mmio: " Jason Wang 2022-05-27 6:01 ` Jason Wang 2022-05-27 7:32 ` Xuan Zhuo 2022-05-27 7:32 ` Xuan Zhuo 2022-05-27 6:01 ` [PATCH V6 6/9] virtio-ccw: " Jason Wang 2022-05-27 6:01 ` Jason Wang 2022-05-30 15:12 ` Cornelia Huck 2022-05-30 15:12 ` Cornelia Huck 2022-05-27 6:01 ` [PATCH V6 7/9] virtio: allow to unbreak virtqueue Jason Wang 2022-05-27 6:01 ` Jason Wang 2022-05-27 7:33 ` Xuan Zhuo 2022-05-27 7:33 ` Xuan Zhuo 2022-05-30 15:15 ` Cornelia Huck 2022-05-30 15:15 ` Cornelia Huck 2022-05-27 6:01 ` [PATCH V6 8/9] virtio: harden vring IRQ Jason Wang 2022-05-27 6:01 ` Jason Wang 2022-05-27 7:49 ` Xuan Zhuo 2022-05-27 7:49 ` Xuan Zhuo 2022-05-30 15:18 ` Cornelia Huck 2022-05-30 15:18 ` Cornelia Huck 2022-06-11 5:12 ` Michael S. Tsirkin 2022-06-11 5:12 ` Michael S. Tsirkin 2022-06-13 5:26 ` Jason Wang 2022-06-13 5:26 ` Jason Wang 2022-06-13 7:23 ` Michael S. Tsirkin 2022-06-13 7:23 ` Michael S. Tsirkin 2022-06-13 8:07 ` Jason Wang 2022-06-13 8:07 ` Jason Wang 2022-06-13 8:19 ` Michael S. Tsirkin 2022-06-13 8:19 ` Michael S. Tsirkin 2022-06-13 8:51 ` Jason Wang 2022-06-13 8:51 ` Jason Wang 2022-06-13 8:59 ` Michael S. Tsirkin 2022-06-13 8:59 ` Michael S. Tsirkin 2022-06-13 9:08 ` Jason Wang 2022-06-13 9:08 ` Jason Wang 2022-06-13 9:14 ` Jason Wang 2022-06-13 9:14 ` Jason Wang 2022-06-13 9:27 ` Michael S. Tsirkin 2022-06-13 9:27 ` Michael S. Tsirkin 2022-06-14 7:40 ` Jason Wang 2022-06-14 7:40 ` Jason Wang 2022-06-14 13:50 ` Michael S. Tsirkin 2022-06-14 13:50 ` Michael S. Tsirkin 2022-06-15 1:32 ` Jason Wang 2022-06-15 1:32 ` Jason Wang 2022-06-14 15:49 ` Michael S. Tsirkin 2022-06-14 15:49 ` Michael S. Tsirkin 2022-06-15 1:38 ` Jason Wang 2022-06-15 1:38 ` Jason Wang 2022-06-16 17:11 ` Michael S. Tsirkin 2022-06-16 17:11 ` Michael S. Tsirkin 2022-06-17 1:24 ` Jason Wang 2022-06-17 1:24 ` Jason Wang 2022-06-17 5:36 ` Michael S. Tsirkin 2022-06-17 5:36 ` Michael S. Tsirkin 2022-06-17 7:26 ` Jason Wang 2022-06-17 7:26 ` Jason Wang 2022-06-17 14:33 ` Peter Zijlstra 2022-06-17 14:33 ` Peter Zijlstra 2022-06-14 16:46 ` Cristian Marussi 2022-06-15 1:41 ` Jason Wang 2022-06-15 1:41 ` Jason Wang 2022-06-15 18:24 ` Cristian Marussi 2022-06-17 3:14 ` Jason Wang 2022-06-17 3:14 ` Jason Wang 2022-06-13 9:26 ` Michael S. Tsirkin 2022-06-13 9:26 ` Michael S. Tsirkin 2022-06-14 7:19 ` Jason Wang 2022-06-14 7:19 ` Jason Wang 2022-07-05 11:06 ` chenxiang (M) 2022-07-05 12:56 ` Jason Wang 2022-07-05 12:56 ` Jason Wang 2022-05-27 6:01 ` [PATCH V6 9/9] virtio: use WARN_ON() to warning illegal status value Jason Wang 2022-05-27 6:01 ` Jason Wang 2022-05-27 7:49 ` Xuan Zhuo 2022-05-27 7:49 ` Xuan Zhuo 2022-05-27 10:35 ` Stefano Garzarella 2022-05-27 10:35 ` Stefano Garzarella 2022-05-27 10:50 ` Michael S. Tsirkin 2022-05-27 10:50 ` Michael S. Tsirkin 2022-05-30 3:48 ` Jason Wang 2022-05-30 3:48 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220527060120.20964-1-jasowang@redhat.com \ --to=jasowang@redhat.com \ --cc=cohuck@redhat.com \ --cc=eperezma@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lulu@redhat.com \ --cc=maz@kernel.org \ --cc=mst@redhat.com \ --cc=pasic@linux.ibm.com \ --cc=paulmck@kernel.org \ --cc=peterz@infradead.org \ --cc=sgarzare@redhat.com \ --cc=tglx@linutronix.de \ --cc=virtualization@lists.linux-foundation.org \ --cc=xuanzhuo@linux.alibaba.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.