All of lore.kernel.org
 help / color / mirror / Atom feed
From: Usman Tanveer <usman.tanveer@emumba.com>
To: dev@dpdk.org
Cc: Usman Tanveer <usman.tanveer@emumba.com>
Subject: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()
Date: Fri, 27 May 2022 11:42:44 +0500	[thread overview]
Message-ID: <20220527064244.10224-1-usman.tanveer@emumba.com> (raw)

There is a call to rte_eth_dev_stop() in rte_ethtool_net_open()
due to which user gets misleading message upon first open/start call.
It says that the
device is already stopped, which should not be the case. This patch
removes rte_eth_dev_stop() from rte_ethtool_net_open().

Signed-off-by: Usman Tanveer <usman.tanveer@emumba.com>
---
 examples/ethtool/lib/rte_ethtool.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c
index ffaad96498..0a000d0a7b 100644
--- a/examples/ethtool/lib/rte_ethtool.c
+++ b/examples/ethtool/lib/rte_ethtool.c
@@ -297,12 +297,6 @@ rte_ethtool_set_pauseparam(uint16_t port_id,
 int
 rte_ethtool_net_open(uint16_t port_id)
 {
-	int ret;
-
-	ret = rte_eth_dev_stop(port_id);
-	if (ret != 0)
-		return ret;
-
 	return rte_eth_dev_start(port_id);
 }
 
-- 
2.25.1


             reply	other threads:[~2022-05-27  6:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27  6:42 Usman Tanveer [this message]
2022-06-03 11:02 ` [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop() Usman Tanveer
2022-06-26 21:16 ` Thomas Monjalon
2022-07-06  9:49   ` Usman Tanveer
2022-08-18 10:18     ` Usman Tanveer
2023-07-03 22:31       ` Stephen Hemminger
2023-07-06 16:15         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220527064244.10224-1-usman.tanveer@emumba.com \
    --to=usman.tanveer@emumba.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.