Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: Usman Tanveer <usman.tanveer@emumba.com>,
	Huisong Li <lihuisong@huawei.com>,
	Chengwen Feng <fengchengwen@huawei.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Gargi Sau <gargi.sau@intel.com>,
	Qiming Yang <qiming.yang@intel.com>,
	andrew.rybchenko@oktetlabs.ru, ferruh.yigit@amd.com
Subject: Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()
Date: Sun, 26 Jun 2022 23:16:14 +0200	[thread overview]
Message-ID: <28911775.czjnFlTdjD@thomas> (raw)
In-Reply-To: <20220527064244.10224-1-usman.tanveer@emumba.com>

27/05/2022 08:42, Usman Tanveer:
> There is a call to rte_eth_dev_stop() in rte_ethtool_net_open()
> due to which user gets misleading message upon first open/start call.
> It says that the
> device is already stopped, which should not be the case. This patch
> removes rte_eth_dev_stop() from rte_ethtool_net_open().

Why was it there?
Any opinion? Is it safe to remove?

>  int
>  rte_ethtool_net_open(uint16_t port_id)
>  {
> -	int ret;
> -
> -	ret = rte_eth_dev_stop(port_id);
> -	if (ret != 0)
> -		return ret;
> -
>  	return rte_eth_dev_start(port_id);
>  }