From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v6 14/22] dma-buf: Introduce new locking convention
Date: Fri, 27 May 2022 20:21:30 +0800 [thread overview]
Message-ID: <202205272006.EZ53cUSD-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 13966 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
In-Reply-To: <20220526235040.678984-15-dmitry.osipenko@collabora.com>
References: <20220526235040.678984-15-dmitry.osipenko@collabora.com>
TO: Dmitry Osipenko <dmitry.osipenko@collabora.com>
TO: David Airlie <airlied@linux.ie>
TO: Gerd Hoffmann <kraxel@redhat.com>
TO: Gurchetan Singh <gurchetansingh@chromium.org>
TO: "Chia-I Wu" <olvaffe@gmail.com>
TO: Daniel Vetter <daniel@ffwll.ch>
TO: Daniel Almeida <daniel.almeida@collabora.com>
TO: Gert Wollny <gert.wollny@collabora.com>
TO: Gustavo Padovan <gustavo.padovan@collabora.com>
TO: Daniel Stone <daniel@fooishbar.org>
TO: Tomeu Vizoso <tomeu.vizoso@collabora.com>
TO: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
TO: Maxime Ripard <mripard@kernel.org>
TO: Thomas Zimmermann <tzimmermann@suse.de>
TO: Rob Herring <robh@kernel.org>
TO: Steven Price <steven.price@arm.com>
TO: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
TO: Rob Clark <robdclark@gmail.com>
TO: Emil Velikov <emil.l.velikov@gmail.com>
TO: Robin Murphy <robin.murphy@arm.com>
TO: Qiang Yu <yuq825@gmail.com>
TO: Sumit Semwal <sumit.semwal@linaro.org>
TO: "Christian König" <christian.koenig@amd.com>
TO: "Pan, Xinhui" <Xinhui.Pan@amd.com>
TO: Thierry Reding <thierry.reding@gmail.com>
TO: Tomasz Figa <tfiga@chromium.org>
TO: Marek Szyprowski <m.szyprowski@samsung.com>
TO: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
TO: Alex Deucher <alexander.deucher@amd.com>
TO: Jani Nikula <jani.nikula@linux.intel.com>
Hi Dmitry,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on next-20220527]
[cannot apply to drm/drm-next media-tree/master drm-intel/for-linux-next v5.18]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Osipenko/Add-generic-memory-shrinker-to-VirtIO-GPU-and-Panfrost-DRM-drivers/20220527-075717
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git cdeffe87f790dfd1baa193020411ce9a538446d7
:::::: branch date: 12 hours ago
:::::: commit date: 12 hours ago
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220527/202205272006.EZ53cUSD-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/dma-buf/dma-buf.c:791 dma_buf_dynamic_attach() warn: inconsistent returns 'dmabuf->resv'.
drivers/dma-buf/dma-buf.c:1339 dma_buf_vmap_locked() error: uninitialized symbol 'ret'.
Old smatch warnings:
drivers/dma-buf/dma-buf.c:576 dma_buf_export() warn: '&dmabuf->list_node' not removed from list
vim +791 drivers/dma-buf/dma-buf.c
84335675f2223c drivers/dma-buf/dma-buf.c Daniel Vetter 2021-01-15 691
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 692 /**
85804b70cca68d drivers/dma-buf/dma-buf.c Daniel Vetter 2020-12-11 693 * dma_buf_dynamic_attach - Add the device to dma_buf's attachments list
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 694 * @dmabuf: [in] buffer to attach device to.
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 695 * @dev: [in] device to be attached.
6f49c2515e2258 drivers/dma-buf/dma-buf.c Randy Dunlap 2020-04-07 696 * @importer_ops: [in] importer operations for the attachment
6f49c2515e2258 drivers/dma-buf/dma-buf.c Randy Dunlap 2020-04-07 697 * @importer_priv: [in] importer private pointer for the attachment
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 698 *
2904a8c1311f02 drivers/dma-buf/dma-buf.c Daniel Vetter 2016-12-09 699 * Returns struct dma_buf_attachment pointer for this attachment. Attachments
2904a8c1311f02 drivers/dma-buf/dma-buf.c Daniel Vetter 2016-12-09 700 * must be cleaned up by calling dma_buf_detach().
2904a8c1311f02 drivers/dma-buf/dma-buf.c Daniel Vetter 2016-12-09 701 *
85804b70cca68d drivers/dma-buf/dma-buf.c Daniel Vetter 2020-12-11 702 * Optionally this calls &dma_buf_ops.attach to allow device-specific attach
85804b70cca68d drivers/dma-buf/dma-buf.c Daniel Vetter 2020-12-11 703 * functionality.
85804b70cca68d drivers/dma-buf/dma-buf.c Daniel Vetter 2020-12-11 704 *
2904a8c1311f02 drivers/dma-buf/dma-buf.c Daniel Vetter 2016-12-09 705 * Returns:
2904a8c1311f02 drivers/dma-buf/dma-buf.c Daniel Vetter 2016-12-09 706 *
2904a8c1311f02 drivers/dma-buf/dma-buf.c Daniel Vetter 2016-12-09 707 * A pointer to newly created &dma_buf_attachment on success, or a negative
2904a8c1311f02 drivers/dma-buf/dma-buf.c Daniel Vetter 2016-12-09 708 * error code wrapped into a pointer on failure.
2904a8c1311f02 drivers/dma-buf/dma-buf.c Daniel Vetter 2016-12-09 709 *
2904a8c1311f02 drivers/dma-buf/dma-buf.c Daniel Vetter 2016-12-09 710 * Note that this can fail if the backing storage of @dmabuf is in a place not
2904a8c1311f02 drivers/dma-buf/dma-buf.c Daniel Vetter 2016-12-09 711 * accessible to @dev, and cannot be moved to a more suitable place. This is
2904a8c1311f02 drivers/dma-buf/dma-buf.c Daniel Vetter 2016-12-09 712 * indicated with the error code -EBUSY.
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 713 */
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 714 struct dma_buf_attachment *
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 715 dma_buf_dynamic_attach(struct dma_buf *dmabuf, struct device *dev,
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 716 const struct dma_buf_attach_ops *importer_ops,
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 717 void *importer_priv)
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 718 {
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 719 struct dma_buf_attachment *attach;
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 720 int ret;
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 721
d1aa06a1eaf5f7 drivers/base/dma-buf.c Laurent Pinchart 2012-01-26 722 if (WARN_ON(!dmabuf || !dev))
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 723 return ERR_PTR(-EINVAL);
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 724
4981cdb063e3e9 drivers/dma-buf/dma-buf.c Christian König 2020-02-19 725 if (WARN_ON(importer_ops && !importer_ops->move_notify))
4981cdb063e3e9 drivers/dma-buf/dma-buf.c Christian König 2020-02-19 726 return ERR_PTR(-EINVAL);
4981cdb063e3e9 drivers/dma-buf/dma-buf.c Christian König 2020-02-19 727
db7942b6292306 drivers/dma-buf/dma-buf.c Markus Elfring 2017-05-08 728 attach = kzalloc(sizeof(*attach), GFP_KERNEL);
34d84ec4881d13 drivers/dma-buf/dma-buf.c Markus Elfring 2017-05-08 729 if (!attach)
a9fbc3b73127ef drivers/base/dma-buf.c Laurent Pinchart 2012-01-26 730 return ERR_PTR(-ENOMEM);
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 731
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 732 attach->dev = dev;
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 733 attach->dmabuf = dmabuf;
09606b5446c25b drivers/dma-buf/dma-buf.c Christian König 2018-03-22 734 if (importer_ops)
09606b5446c25b drivers/dma-buf/dma-buf.c Christian König 2018-03-22 735 attach->peer2peer = importer_ops->allow_peer2peer;
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 736 attach->importer_ops = importer_ops;
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 737 attach->importer_priv = importer_priv;
2ed9201bdd9a8e drivers/base/dma-buf.c Laurent Pinchart 2012-01-26 738
97f090c47ec995 drivers/dma-buf/dma-buf.c Dmitry Osipenko 2022-05-27 739 dma_resv_lock(dmabuf->resv, NULL);
97f090c47ec995 drivers/dma-buf/dma-buf.c Dmitry Osipenko 2022-05-27 740
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 741 if (dmabuf->ops->attach) {
a19741e5e5a9f1 drivers/dma-buf/dma-buf.c Christian König 2018-05-28 742 ret = dmabuf->ops->attach(dmabuf, attach);
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 743 if (ret)
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 744 goto err_attach;
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 745 }
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 746 list_add(&attach->node, &dmabuf->attachments);
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 747
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 748 /* When either the importer or the exporter can't handle dynamic
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 749 * mappings we cache the mapping here to avoid issues with the
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 750 * reservation object lock.
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 751 */
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 752 if (dma_buf_attachment_is_dynamic(attach) !=
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 753 dma_buf_is_dynamic(dmabuf)) {
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 754 struct sg_table *sgt;
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 755
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 756 if (dma_buf_is_dynamic(attach->dmabuf)) {
7e008b02557cce drivers/dma-buf/dma-buf.c Christian König 2021-05-17 757 ret = dmabuf->ops->pin(attach);
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 758 if (ret)
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 759 goto err_unlock;
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 760 }
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 761
84335675f2223c drivers/dma-buf/dma-buf.c Daniel Vetter 2021-01-15 762 sgt = __map_dma_buf(attach, DMA_BIDIRECTIONAL);
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 763 if (!sgt)
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 764 sgt = ERR_PTR(-ENOMEM);
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 765 if (IS_ERR(sgt)) {
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 766 ret = PTR_ERR(sgt);
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 767 goto err_unpin;
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 768 }
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 769 attach->sgt = sgt;
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 770 attach->dir = DMA_BIDIRECTIONAL;
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 771 }
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 772
97f090c47ec995 drivers/dma-buf/dma-buf.c Dmitry Osipenko 2022-05-27 773 dma_resv_unlock(dmabuf->resv);
97f090c47ec995 drivers/dma-buf/dma-buf.c Dmitry Osipenko 2022-05-27 774
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 775 return attach;
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 776
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 777 err_attach:
97f090c47ec995 drivers/dma-buf/dma-buf.c Dmitry Osipenko 2022-05-27 778 dma_resv_unlock(attach->dmabuf->resv);
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 779 kfree(attach);
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 780 return ERR_PTR(ret);
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 781
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 782 err_unpin:
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 783 if (dma_buf_is_dynamic(attach->dmabuf))
7e008b02557cce drivers/dma-buf/dma-buf.c Christian König 2021-05-17 784 dmabuf->ops->unpin(attach);
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 785
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 786 err_unlock:
97f090c47ec995 drivers/dma-buf/dma-buf.c Dmitry Osipenko 2022-05-27 787 dma_resv_unlock(dmabuf->resv);
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 788
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 789 dma_buf_detach(dmabuf, attach);
97f090c47ec995 drivers/dma-buf/dma-buf.c Dmitry Osipenko 2022-05-27 790
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 @791 return ERR_PTR(ret);
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 792 }
16b0314aa746be drivers/dma-buf/dma-buf.c Greg Kroah-Hartman 2021-10-10 793 EXPORT_SYMBOL_NS_GPL(dma_buf_dynamic_attach, DMA_BUF);
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 794
--
0-DAY CI Kernel Test Service
https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v6 14/22] dma-buf: Introduce new locking convention
Date: Mon, 30 May 2022 10:05:49 +0300 [thread overview]
Message-ID: <202205272006.EZ53cUSD-lkp@intel.com> (raw)
In-Reply-To: <20220526235040.678984-15-dmitry.osipenko@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 9217 bytes --]
[ I trimmed the CC list -dan ]
Hi Dmitry,
url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Osipenko/Add-generic-memory-shrinker-to-VirtIO-GPU-and-Panfrost-DRM-drivers/20220527-075717
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git cdeffe87f790dfd1baa193020411ce9a538446d7
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220527/202205272006.EZ53cUSD-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/dma-buf/dma-buf.c:791 dma_buf_dynamic_attach() warn: inconsistent returns 'dmabuf->resv'.
drivers/dma-buf/dma-buf.c:1339 dma_buf_vmap_locked() error: uninitialized symbol 'ret'.
Old smatch warnings:
drivers/dma-buf/dma-buf.c:576 dma_buf_export() warn: '&dmabuf->list_node' not removed from list
vim +791 drivers/dma-buf/dma-buf.c
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 714 struct dma_buf_attachment *
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 715 dma_buf_dynamic_attach(struct dma_buf *dmabuf, struct device *dev,
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 716 const struct dma_buf_attach_ops *importer_ops,
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 717 void *importer_priv)
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 718 {
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 719 struct dma_buf_attachment *attach;
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 720 int ret;
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 721
d1aa06a1eaf5f7 drivers/base/dma-buf.c Laurent Pinchart 2012-01-26 722 if (WARN_ON(!dmabuf || !dev))
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 723 return ERR_PTR(-EINVAL);
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 724
4981cdb063e3e9 drivers/dma-buf/dma-buf.c Christian König 2020-02-19 725 if (WARN_ON(importer_ops && !importer_ops->move_notify))
4981cdb063e3e9 drivers/dma-buf/dma-buf.c Christian König 2020-02-19 726 return ERR_PTR(-EINVAL);
4981cdb063e3e9 drivers/dma-buf/dma-buf.c Christian König 2020-02-19 727
db7942b6292306 drivers/dma-buf/dma-buf.c Markus Elfring 2017-05-08 728 attach = kzalloc(sizeof(*attach), GFP_KERNEL);
34d84ec4881d13 drivers/dma-buf/dma-buf.c Markus Elfring 2017-05-08 729 if (!attach)
a9fbc3b73127ef drivers/base/dma-buf.c Laurent Pinchart 2012-01-26 730 return ERR_PTR(-ENOMEM);
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 731
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 732 attach->dev = dev;
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 733 attach->dmabuf = dmabuf;
09606b5446c25b drivers/dma-buf/dma-buf.c Christian König 2018-03-22 734 if (importer_ops)
09606b5446c25b drivers/dma-buf/dma-buf.c Christian König 2018-03-22 735 attach->peer2peer = importer_ops->allow_peer2peer;
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 736 attach->importer_ops = importer_ops;
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 737 attach->importer_priv = importer_priv;
2ed9201bdd9a8e drivers/base/dma-buf.c Laurent Pinchart 2012-01-26 738
97f090c47ec995 drivers/dma-buf/dma-buf.c Dmitry Osipenko 2022-05-27 739 dma_resv_lock(dmabuf->resv, NULL);
97f090c47ec995 drivers/dma-buf/dma-buf.c Dmitry Osipenko 2022-05-27 740
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 741 if (dmabuf->ops->attach) {
a19741e5e5a9f1 drivers/dma-buf/dma-buf.c Christian König 2018-05-28 742 ret = dmabuf->ops->attach(dmabuf, attach);
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 743 if (ret)
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 744 goto err_attach;
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 745 }
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 746 list_add(&attach->node, &dmabuf->attachments);
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 747
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 748 /* When either the importer or the exporter can't handle dynamic
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 749 * mappings we cache the mapping here to avoid issues with the
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 750 * reservation object lock.
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 751 */
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 752 if (dma_buf_attachment_is_dynamic(attach) !=
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 753 dma_buf_is_dynamic(dmabuf)) {
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 754 struct sg_table *sgt;
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 755
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 756 if (dma_buf_is_dynamic(attach->dmabuf)) {
7e008b02557cce drivers/dma-buf/dma-buf.c Christian König 2021-05-17 757 ret = dmabuf->ops->pin(attach);
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 758 if (ret)
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 759 goto err_unlock;
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 760 }
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 761
84335675f2223c drivers/dma-buf/dma-buf.c Daniel Vetter 2021-01-15 762 sgt = __map_dma_buf(attach, DMA_BIDIRECTIONAL);
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 763 if (!sgt)
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 764 sgt = ERR_PTR(-ENOMEM);
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 765 if (IS_ERR(sgt)) {
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 766 ret = PTR_ERR(sgt);
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 767 goto err_unpin;
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 768 }
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 769 attach->sgt = sgt;
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 770 attach->dir = DMA_BIDIRECTIONAL;
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 771 }
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 772
97f090c47ec995 drivers/dma-buf/dma-buf.c Dmitry Osipenko 2022-05-27 773 dma_resv_unlock(dmabuf->resv);
97f090c47ec995 drivers/dma-buf/dma-buf.c Dmitry Osipenko 2022-05-27 774
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 775 return attach;
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 776
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 777 err_attach:
97f090c47ec995 drivers/dma-buf/dma-buf.c Dmitry Osipenko 2022-05-27 778 dma_resv_unlock(attach->dmabuf->resv);
This is a false positive, but Smatch would prefer if the lock names
were the same everywhere:
dma_resv_unlock(dmabuf->resv);
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 779 kfree(attach);
d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 780 return ERR_PTR(ret);
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 781
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 782 err_unpin:
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 783 if (dma_buf_is_dynamic(attach->dmabuf))
7e008b02557cce drivers/dma-buf/dma-buf.c Christian König 2021-05-17 784 dmabuf->ops->unpin(attach);
bb42df4662a447 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 785
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 786 err_unlock:
97f090c47ec995 drivers/dma-buf/dma-buf.c Dmitry Osipenko 2022-05-27 787 dma_resv_unlock(dmabuf->resv);
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 788
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 789 dma_buf_detach(dmabuf, attach);
97f090c47ec995 drivers/dma-buf/dma-buf.c Dmitry Osipenko 2022-05-27 790
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 @791 return ERR_PTR(ret);
15fd552d186cb0 drivers/dma-buf/dma-buf.c Christian König 2018-07-03 792 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next reply other threads:[~2022-05-27 12:21 UTC|newest]
Thread overview: 206+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 12:21 kernel test robot [this message]
2022-05-30 7:05 ` [PATCH v6 14/22] dma-buf: Introduce new locking convention Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2022-05-27 22:08 kernel test robot
2022-05-30 3:25 ` kernel test robot
2022-05-27 14:03 [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker kernel test robot
2022-05-30 7:09 ` [kbuild] " Dan Carpenter
2022-05-30 7:09 ` Dan Carpenter
2022-05-30 13:27 ` Dmitry Osipenko
2022-05-30 13:27 ` Dmitry Osipenko
2022-05-26 23:50 [PATCH v6 00/22] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 01/22] drm/gem: Properly annotate WW context on drm_gem_lock_reservations() error Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-06-28 20:12 ` Thomas Hellström (Intel)
2022-06-28 20:12 ` Thomas Hellström (Intel)
2022-06-28 20:12 ` [Intel-gfx] " Thomas Hellström (Intel)
2022-06-29 8:23 ` Dmitry Osipenko
2022-06-29 8:23 ` [Intel-gfx] " Dmitry Osipenko
2022-06-29 8:23 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 02/22] drm/gem: Move mapping of imported dma-bufs to drm_gem_mmap_obj() Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-06-29 6:40 ` Thomas Hellström (Intel)
2022-06-29 6:40 ` [Intel-gfx] " Thomas Hellström (Intel)
2022-06-29 6:40 ` Thomas Hellström (Intel)
2022-06-29 8:22 ` Dmitry Osipenko
2022-06-29 8:22 ` [Intel-gfx] " Dmitry Osipenko
2022-06-29 8:22 ` Dmitry Osipenko
2022-06-29 8:22 ` Dmitry Osipenko
2022-06-29 8:43 ` Thomas Hellström (Intel)
2022-06-29 8:43 ` Thomas Hellström (Intel)
2022-06-29 8:43 ` [Intel-gfx] " Thomas Hellström (Intel)
2022-06-29 8:43 ` Thomas Hellström (Intel)
2022-06-29 23:06 ` Dmitry Osipenko
2022-06-29 23:06 ` [Intel-gfx] " Dmitry Osipenko
2022-06-29 23:06 ` Dmitry Osipenko
2022-06-29 23:06 ` Dmitry Osipenko
2022-07-04 12:33 ` [Linaro-mm-sig] " Christian König
2022-07-04 12:33 ` [Intel-gfx] " Christian König
2022-07-04 12:33 ` Christian König
2022-07-04 12:33 ` Christian König
2022-07-04 12:33 ` Christian König via Virtualization
2022-07-04 22:44 ` Dmitry Osipenko
2022-07-04 22:44 ` [Intel-gfx] " Dmitry Osipenko
2022-07-04 22:44 ` Dmitry Osipenko
2022-07-04 22:44 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 03/22] drm/panfrost: Put mapping instead of shmem obj on panfrost_mmu_map_fault_addr() error Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 04/22] drm/panfrost: Fix shrinker list corruption by madvise IOCTL Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-27 15:56 ` Alyssa Rosenzweig
2022-05-27 15:56 ` [Intel-gfx] " Alyssa Rosenzweig
2022-05-27 15:56 ` Alyssa Rosenzweig
2022-05-27 15:56 ` Alyssa Rosenzweig
2022-05-30 9:41 ` Steven Price
2022-05-30 9:41 ` [Intel-gfx] " Steven Price
2022-05-30 9:41 ` Steven Price
2022-05-26 23:50 ` [PATCH v6 05/22] drm/virtio: Correct drm_gem_shmem_get_sg_table() error handling Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 06/22] drm/virtio: Check whether transferred 2D BO is shmem Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 07/22] drm/virtio: Unlock reservations on virtio_gpu_object_shmem_init() error Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 08/22] drm/virtio: Unlock reservations on dma_resv_reserve_fences() error Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-06-29 6:43 ` Thomas Hellström (Intel)
2022-06-29 6:43 ` [Intel-gfx] " Thomas Hellström (Intel)
2022-06-29 6:43 ` Thomas Hellström (Intel)
2022-05-26 23:50 ` [PATCH v6 09/22] drm/virtio: Use appropriate atomic state in virtio_gpu_plane_cleanup_fb() Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 10/22] drm/shmem-helper: Add missing vunmap on error Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 11/22] drm/shmem-helper: Correct doc-comment of drm_gem_shmem_get_sg_table() Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 12/22] drm/virtio: Simplify error handling of virtio_gpu_object_create() Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 13/22] drm/virtio: Improve DMA API usage for shmem BOs Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 14/22] dma-buf: Introduce new locking convention Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-27 2:37 ` kernel test robot
2022-05-27 12:44 ` Dmitry Osipenko
2022-05-27 12:44 ` Dmitry Osipenko
2022-05-30 6:50 ` Christian König via Virtualization
2022-05-30 6:50 ` [Intel-gfx] " Christian König
2022-05-30 6:50 ` Christian König
2022-05-30 6:50 ` Christian König
2022-05-30 13:26 ` Dmitry Osipenko
2022-05-30 13:26 ` Dmitry Osipenko
2022-05-30 13:41 ` Christian König via Virtualization
2022-05-30 13:41 ` Christian König
2022-05-30 13:41 ` [Intel-gfx] " Christian König
2022-05-30 13:41 ` Christian König
2022-05-30 13:57 ` Dmitry Osipenko
2022-05-30 13:57 ` Dmitry Osipenko
2022-06-28 21:26 ` Thomas Hellström (Intel)
2022-06-28 21:26 ` Thomas Hellström (Intel)
2022-06-28 21:26 ` [Intel-gfx] " Thomas Hellström (Intel)
2022-07-01 10:43 ` Dmitry Osipenko
2022-07-01 10:43 ` [Intel-gfx] " Dmitry Osipenko
2022-07-01 10:43 ` Dmitry Osipenko
2022-07-04 22:38 ` Dmitry Osipenko
2022-07-04 22:38 ` [Intel-gfx] " Dmitry Osipenko
2022-07-04 22:38 ` Dmitry Osipenko
2022-07-04 22:38 ` Dmitry Osipenko
2022-07-05 10:52 ` Dmitry Osipenko
2022-07-05 10:52 ` [Intel-gfx] " Dmitry Osipenko
2022-07-05 10:52 ` Dmitry Osipenko
2022-07-05 10:52 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 15/22] drm/shmem-helper: Don't use vmap_use_count for dma-bufs Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 16/22] drm/shmem-helper: Use reservation lock Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-06-05 16:47 ` Daniel Vetter
2022-06-05 16:47 ` Daniel Vetter
2022-06-05 16:47 ` [Intel-gfx] " Daniel Vetter
2022-06-05 16:47 ` Daniel Vetter
2022-06-05 16:47 ` Daniel Vetter
2022-06-05 18:32 ` [Intel-gfx] " Rob Clark
2022-06-05 18:32 ` Rob Clark
2022-06-05 18:32 ` Rob Clark
2022-06-05 18:32 ` Rob Clark
2022-06-05 18:32 ` Rob Clark
2022-06-05 18:45 ` Daniel Vetter
2022-06-05 18:45 ` Daniel Vetter
2022-06-05 18:45 ` [Intel-gfx] " Daniel Vetter
2022-06-05 18:45 ` Daniel Vetter
2022-06-05 18:45 ` Daniel Vetter
2022-06-06 10:57 ` Christian König
2022-06-06 10:57 ` Christian König
2022-06-06 10:57 ` Christian König
2022-06-06 10:57 ` Christian König
2022-06-07 15:33 ` Dmitry Osipenko
2022-06-07 15:33 ` Dmitry Osipenko
2022-06-07 15:33 ` Dmitry Osipenko
2022-06-19 17:53 ` Rob Clark
2022-06-19 17:53 ` Rob Clark
2022-06-19 17:53 ` [Intel-gfx] " Rob Clark
2022-06-19 17:53 ` Rob Clark
2022-06-19 17:53 ` Rob Clark
2022-06-20 14:08 ` Dmitry Osipenko
2022-06-20 14:08 ` Dmitry Osipenko
2022-06-20 14:08 ` Dmitry Osipenko
2022-06-20 15:18 ` Rob Clark
2022-06-20 15:18 ` Rob Clark
2022-06-20 15:18 ` Rob Clark
2022-06-20 15:18 ` [Intel-gfx] " Rob Clark
2022-06-20 15:18 ` Rob Clark
2022-06-24 20:23 ` Daniel Vetter
2022-06-24 20:23 ` Daniel Vetter
2022-06-24 20:23 ` [Intel-gfx] " Daniel Vetter
2022-06-24 20:23 ` Daniel Vetter
2022-06-24 20:23 ` Daniel Vetter
2022-06-24 20:21 ` Daniel Vetter
2022-06-24 20:21 ` Daniel Vetter
2022-06-24 20:21 ` [Intel-gfx] " Daniel Vetter
2022-06-24 20:21 ` Daniel Vetter
2022-06-24 20:21 ` Daniel Vetter
2022-06-20 15:37 ` Rob Clark
2022-06-20 15:37 ` Rob Clark
2022-06-20 15:37 ` Rob Clark
2022-06-20 15:37 ` Rob Clark
2022-06-20 15:37 ` [Intel-gfx] " Rob Clark
2022-06-21 16:39 ` Dmitry Osipenko
2022-06-21 16:39 ` Dmitry Osipenko
2022-06-21 16:39 ` [Intel-gfx] " Dmitry Osipenko
2022-06-21 16:39 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 18/22] drm/gem: Add drm_gem_pin_unlocked() Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 19/22] drm/virtio: Support memory shrinking Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 20/22] drm/virtio: Use dev_is_pci() Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 21/22] drm/virtio: Return proper error codes instead of -1 Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-26 23:50 ` [PATCH v6 22/22] drm/panfrost: Switch to generic memory shrinker Dmitry Osipenko
2022-05-26 23:50 ` Dmitry Osipenko
2022-05-27 11:48 ` Alyssa Rosenzweig
2022-05-27 11:48 ` [Intel-gfx] " Alyssa Rosenzweig
2022-05-27 11:48 ` Alyssa Rosenzweig
2022-05-27 11:48 ` Alyssa Rosenzweig
2022-06-10 14:40 ` [PATCH v6 00/22] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers Dmitry Osipenko
2022-06-10 14:40 ` Dmitry Osipenko
2022-06-10 14:40 ` Dmitry Osipenko
2022-06-28 12:31 ` Robin Murphy
2022-06-28 12:31 ` Robin Murphy
2022-06-28 12:31 ` Robin Murphy
2022-06-28 12:50 ` Dmitry Osipenko
2022-06-28 12:50 ` [Intel-gfx] " Dmitry Osipenko
2022-06-28 12:50 ` Dmitry Osipenko
2022-06-28 16:48 ` Rob Clark
2022-06-28 16:48 ` Rob Clark
2022-06-28 16:48 ` Rob Clark
2022-06-28 16:48 ` [Intel-gfx] " Rob Clark
2022-06-28 16:48 ` Rob Clark
2022-06-28 23:11 ` Dmitry Osipenko
2022-06-28 23:11 ` [Intel-gfx] " Dmitry Osipenko
2022-06-28 23:11 ` Dmitry Osipenko
2022-06-28 23:11 ` Dmitry Osipenko
2022-06-28 12:51 ` Dmitry Osipenko
2022-06-28 12:51 ` [Intel-gfx] " Dmitry Osipenko
2022-06-28 12:51 ` Dmitry Osipenko
2022-06-28 13:11 ` Dmitry Osipenko
2022-06-28 13:11 ` [Intel-gfx] " Dmitry Osipenko
2022-06-28 13:11 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205272006.EZ53cUSD-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.