* [PATCH] dmaengine: altera-msgdma: correct mutex locking order
@ 2022-05-29 17:25 Nam Cao
0 siblings, 0 replies; only message in thread
From: Nam Cao @ 2022-05-29 17:25 UTC (permalink / raw)
To: olivier.dautricourt, vkoul, sr; +Cc: dmaengine, linux-kernel
The order of spin_unlock and spin_lock seems wrong. Correct it.
Signed-off-by: Nam Cao <namcaov@gmail.com>
---
drivers/dma/altera-msgdma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c
index 6f56dfd375e3..e35096c12abc 100644
--- a/drivers/dma/altera-msgdma.c
+++ b/drivers/dma/altera-msgdma.c
@@ -591,9 +591,9 @@ static void msgdma_chan_desc_cleanup(struct msgdma_device *mdev)
dmaengine_desc_get_callback(&desc->async_tx, &cb);
if (dmaengine_desc_callback_valid(&cb)) {
- spin_unlock(&mdev->lock);
- dmaengine_desc_callback_invoke(&cb, NULL);
spin_lock(&mdev->lock);
+ dmaengine_desc_callback_invoke(&cb, NULL);
+ spin_unlock(&mdev->lock);
}
/* Run any dependencies, then free the descriptor */
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-05-29 17:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-29 17:25 [PATCH] dmaengine: altera-msgdma: correct mutex locking order Nam Cao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.