* [PATCH] locking: Consistently append parentheses to pthread_cond_wait()
@ 2022-05-30 16:12 SeongJae Park
2022-05-30 17:47 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: SeongJae Park @ 2022-05-30 16:12 UTC (permalink / raw)
To: perfbook, paulmck; +Cc: SeongJae Park
Some of 'pthread_cond_wait()' mentions have '()' suffix, which indicates
it's a function, but some mentions don't. This commit adds the suffix
to all mentions to be consistent.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
locking/locking.tex | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/locking/locking.tex b/locking/locking.tex
index 14690b19..4ad5e4c4 100644
--- a/locking/locking.tex
+++ b/locking/locking.tex
@@ -528,8 +528,8 @@ prevents hangs due to lost wakeups.
Consider a program that acquires \co{mutex_a}, and then
\co{mutex_b}, in that order, and then passes \co{mutex_a}
- to \co{pthread_cond_wait}.
- Now, \co{pthread_cond_wait} will release \co{mutex_a}, but
+ to \co{pthread_cond_wait()}.
+ Now, \co{pthread_cond_wait()} will release \co{mutex_a}, but
will re-acquire it before returning.
If some other thread acquires \co{mutex_a} in the meantime
and then blocks on \co{mutex_b}, the program will deadlock.
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] locking: Consistently append parentheses to pthread_cond_wait()
2022-05-30 16:12 [PATCH] locking: Consistently append parentheses to pthread_cond_wait() SeongJae Park
@ 2022-05-30 17:47 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2022-05-30 17:47 UTC (permalink / raw)
To: SeongJae Park; +Cc: perfbook
On Mon, May 30, 2022 at 09:12:36AM -0700, SeongJae Park wrote:
> Some of 'pthread_cond_wait()' mentions have '()' suffix, which indicates
> it's a function, but some mentions don't. This commit adds the suffix
> to all mentions to be consistent.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
Good eyes! Queued and pushed, thank you!
Thanx, Paul
> ---
> locking/locking.tex | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/locking/locking.tex b/locking/locking.tex
> index 14690b19..4ad5e4c4 100644
> --- a/locking/locking.tex
> +++ b/locking/locking.tex
> @@ -528,8 +528,8 @@ prevents hangs due to lost wakeups.
>
> Consider a program that acquires \co{mutex_a}, and then
> \co{mutex_b}, in that order, and then passes \co{mutex_a}
> - to \co{pthread_cond_wait}.
> - Now, \co{pthread_cond_wait} will release \co{mutex_a}, but
> + to \co{pthread_cond_wait()}.
> + Now, \co{pthread_cond_wait()} will release \co{mutex_a}, but
> will re-acquire it before returning.
> If some other thread acquires \co{mutex_a} in the meantime
> and then blocks on \co{mutex_b}, the program will deadlock.
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-30 17:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-30 16:12 [PATCH] locking: Consistently append parentheses to pthread_cond_wait() SeongJae Park
2022-05-30 17:47 ` Paul E. McKenney
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.