[PATCH] drm/amdgpu: enable tmz by default for skyrim

[PATCH] drm/amdgpu: enable tmz by default for skyrim

[Sunil Khatri]

Enable tmz feature by default for skyrim
i.e IP GC 10.3.7

Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
index 798c56214a23..aebc384531ac 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
@@ -518,6 +518,8 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
 	case IP_VERSION(9, 1, 0):
 	/* RENOIR looks like RAVEN */
 	case IP_VERSION(9, 3, 0):
+	/* GC 10.3.7 */
+	case IP_VERSION(10, 3, 7):
 		if (amdgpu_tmz == 0) {
 			adev->gmc.tmz_enabled = false;
 			dev_info(adev->dev,
@@ -540,8 +542,6 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
 	case IP_VERSION(10, 3, 1):
 	/* YELLOW_CARP*/
 	case IP_VERSION(10, 3, 3):
-	/* GC 10.3.7 */
-	case IP_VERSION(10, 3, 7):
 		/* Don't enable it by default yet.
 		 */
 		if (amdgpu_tmz < 1) {
-- 
2.25.1

Re: [PATCH] drm/amdgpu: enable tmz by default for skyrim

[Ernst Sjöstrand]

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

Skyrim is maybe not the best code name ever for a GPU, perhaps not include
it upstream if it's not official?

Regards
//Ernst

Den mån 30 maj 2022 kl 20:03 skrev Sunil Khatri <sunil.khatri@amd.com>:

> Enable tmz feature by default for skyrim
> i.e IP GC 10.3.7
>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> index 798c56214a23..aebc384531ac 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> @@ -518,6 +518,8 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
>         case IP_VERSION(9, 1, 0):
>         /* RENOIR looks like RAVEN */
>         case IP_VERSION(9, 3, 0):
> +       /* GC 10.3.7 */
> +       case IP_VERSION(10, 3, 7):
>                 if (amdgpu_tmz == 0) {
>                         adev->gmc.tmz_enabled = false;
>                         dev_info(adev->dev,
> @@ -540,8 +542,6 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
>         case IP_VERSION(10, 3, 1):
>         /* YELLOW_CARP*/
>         case IP_VERSION(10, 3, 3):
> -       /* GC 10.3.7 */
> -       case IP_VERSION(10, 3, 7):
>                 /* Don't enable it by default yet.
>                  */
>                 if (amdgpu_tmz < 1) {
> --
> 2.25.1
>
>

[-- Attachment #2: Type: text/html, Size: 2314 bytes --]

RE: [PATCH] drm/amdgpu: enable tmz by default for skyrim

[Khatri, Sunil]

[-- Attachment #1: Type: text/plain, Size: 1936 bytes --]

[AMD Official Use Only - General]

@Ernst Sjöstrand<mailto:ernstp@gmail.com>
Make sense. Thanks for Review. Pushed another patch without any such names.

Regards
Sunil khatri

From: Ernst Sjöstrand <ernstp@gmail.com>
Sent: Tuesday, May 31, 2022 1:47 AM
To: Khatri, Sunil <Sunil.Khatri@amd.com>
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; amd-gfx mailing list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: enable tmz by default for skyrim

Skyrim is maybe not the best code name ever for a GPU, perhaps not include it upstream if it's not official?

Regards
//Ernst

Den mån 30 maj 2022 kl 20:03 skrev Sunil Khatri <sunil.khatri@amd.com<mailto:sunil.khatri@amd.com>>:
Enable tmz feature by default for skyrim
i.e IP GC 10.3.7

Signed-off-by: Sunil Khatri <sunil.khatri@amd.com<mailto:sunil.khatri@amd.com>>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
index 798c56214a23..aebc384531ac 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
@@ -518,6 +518,8 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
        case IP_VERSION(9, 1, 0):
        /* RENOIR looks like RAVEN */
        case IP_VERSION(9, 3, 0):
+       /* GC 10.3.7 */
+       case IP_VERSION(10, 3, 7):
                if (amdgpu_tmz == 0) {
                        adev->gmc.tmz_enabled = false;
                        dev_info(adev->dev,
@@ -540,8 +542,6 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
        case IP_VERSION(10, 3, 1):
        /* YELLOW_CARP*/
        case IP_VERSION(10, 3, 3):
-       /* GC 10.3.7 */
-       case IP_VERSION(10, 3, 7):
                /* Don't enable it by default yet.
                 */
                if (amdgpu_tmz < 1) {
--
2.25.1

[-- Attachment #2: Type: text/html, Size: 6000 bytes --]