* [PATCH] dma-debug: Make things less spammy under memory pressure
@ 2022-05-31 21:51 ` Rob Clark
0 siblings, 0 replies; 8+ messages in thread
From: Rob Clark @ 2022-05-31 21:51 UTC (permalink / raw)
To: linux-kernel
Cc: linux-arm-msm, Rob Clark, Christoph Hellwig, Marek Szyprowski,
Robin Murphy, open list:DMA MAPPING HELPERS
From: Rob Clark <robdclark@chromium.org>
Ratelimit the error msg to avoid flooding the console.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
kernel/dma/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
index f8ff598596b8..683966f0247b 100644
--- a/kernel/dma/debug.c
+++ b/kernel/dma/debug.c
@@ -564,7 +564,7 @@ static void add_dma_entry(struct dma_debug_entry *entry, unsigned long attrs)
rc = active_cacheline_insert(entry);
if (rc == -ENOMEM) {
- pr_err("cacheline tracking ENOMEM, dma-debug disabled\n");
+ pr_err_ratelimited("cacheline tracking ENOMEM, dma-debug disabled\n");
global_disable = true;
} else if (rc == -EEXIST && !(attrs & DMA_ATTR_SKIP_CPU_SYNC)) {
err_printk(entry->dev, entry,
--
2.36.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] dma-debug: Make things less spammy under memory pressure
@ 2022-05-31 21:51 ` Rob Clark
0 siblings, 0 replies; 8+ messages in thread
From: Rob Clark @ 2022-05-31 21:51 UTC (permalink / raw)
To: linux-kernel
Cc: Rob Clark, linux-arm-msm, open list:DMA MAPPING HELPERS,
Robin Murphy, Christoph Hellwig
From: Rob Clark <robdclark@chromium.org>
Ratelimit the error msg to avoid flooding the console.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
kernel/dma/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
index f8ff598596b8..683966f0247b 100644
--- a/kernel/dma/debug.c
+++ b/kernel/dma/debug.c
@@ -564,7 +564,7 @@ static void add_dma_entry(struct dma_debug_entry *entry, unsigned long attrs)
rc = active_cacheline_insert(entry);
if (rc == -ENOMEM) {
- pr_err("cacheline tracking ENOMEM, dma-debug disabled\n");
+ pr_err_ratelimited("cacheline tracking ENOMEM, dma-debug disabled\n");
global_disable = true;
} else if (rc == -EEXIST && !(attrs & DMA_ATTR_SKIP_CPU_SYNC)) {
err_printk(entry->dev, entry,
--
2.36.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] dma-debug: Make things less spammy under memory pressure
2022-05-31 21:51 ` Rob Clark
@ 2022-05-31 22:00 ` Robin Murphy
-1 siblings, 0 replies; 8+ messages in thread
From: Robin Murphy @ 2022-05-31 22:00 UTC (permalink / raw)
To: Rob Clark, linux-kernel
Cc: linux-arm-msm, Rob Clark, Christoph Hellwig, Marek Szyprowski,
open list:DMA MAPPING HELPERS
On 2022-05-31 22:51, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Ratelimit the error msg to avoid flooding the console.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> kernel/dma/debug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
> index f8ff598596b8..683966f0247b 100644
> --- a/kernel/dma/debug.c
> +++ b/kernel/dma/debug.c
> @@ -564,7 +564,7 @@ static void add_dma_entry(struct dma_debug_entry *entry, unsigned long attrs)
>
> rc = active_cacheline_insert(entry);
> if (rc == -ENOMEM) {
> - pr_err("cacheline tracking ENOMEM, dma-debug disabled\n");
> + pr_err_ratelimited("cacheline tracking ENOMEM, dma-debug disabled\n");
> global_disable = true;
Given that it's supposed to disable itself entirely if it ever gets
here, just how spammy is it exactly?
Thanks,
Robin.
> } else if (rc == -EEXIST && !(attrs & DMA_ATTR_SKIP_CPU_SYNC)) {
> err_printk(entry->dev, entry,
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] dma-debug: Make things less spammy under memory pressure
@ 2022-05-31 22:00 ` Robin Murphy
0 siblings, 0 replies; 8+ messages in thread
From: Robin Murphy @ 2022-05-31 22:00 UTC (permalink / raw)
To: Rob Clark, linux-kernel
Cc: Rob Clark, linux-arm-msm, open list:DMA MAPPING HELPERS,
Christoph Hellwig
On 2022-05-31 22:51, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Ratelimit the error msg to avoid flooding the console.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> kernel/dma/debug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
> index f8ff598596b8..683966f0247b 100644
> --- a/kernel/dma/debug.c
> +++ b/kernel/dma/debug.c
> @@ -564,7 +564,7 @@ static void add_dma_entry(struct dma_debug_entry *entry, unsigned long attrs)
>
> rc = active_cacheline_insert(entry);
> if (rc == -ENOMEM) {
> - pr_err("cacheline tracking ENOMEM, dma-debug disabled\n");
> + pr_err_ratelimited("cacheline tracking ENOMEM, dma-debug disabled\n");
> global_disable = true;
Given that it's supposed to disable itself entirely if it ever gets
here, just how spammy is it exactly?
Thanks,
Robin.
> } else if (rc == -EEXIST && !(attrs & DMA_ATTR_SKIP_CPU_SYNC)) {
> err_printk(entry->dev, entry,
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] dma-debug: Make things less spammy under memory pressure
2022-05-31 22:00 ` Robin Murphy
@ 2022-05-31 22:19 ` Rob Clark
-1 siblings, 0 replies; 8+ messages in thread
From: Rob Clark @ 2022-05-31 22:19 UTC (permalink / raw)
To: Robin Murphy
Cc: Linux Kernel Mailing List, linux-arm-msm, Rob Clark,
Christoph Hellwig, Marek Szyprowski,
open list:DMA MAPPING HELPERS
On Tue, May 31, 2022 at 3:00 PM Robin Murphy <robin.murphy@arm.com> wrote:
>
> On 2022-05-31 22:51, Rob Clark wrote:
> > From: Rob Clark <robdclark@chromium.org>
> >
> > Ratelimit the error msg to avoid flooding the console.
> >
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
> > ---
> > kernel/dma/debug.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
> > index f8ff598596b8..683966f0247b 100644
> > --- a/kernel/dma/debug.c
> > +++ b/kernel/dma/debug.c
> > @@ -564,7 +564,7 @@ static void add_dma_entry(struct dma_debug_entry *entry, unsigned long attrs)
> >
> > rc = active_cacheline_insert(entry);
> > if (rc == -ENOMEM) {
> > - pr_err("cacheline tracking ENOMEM, dma-debug disabled\n");
> > + pr_err_ratelimited("cacheline tracking ENOMEM, dma-debug disabled\n");
> > global_disable = true;
>
> Given that it's supposed to disable itself entirely if it ever gets
> here, just how spammy is it exactly?
um, quite.. tbf that was in the context of a WIP igt test for
shrinker which was trying to cycle thru ~2x RAM size worth of GEM
buffers on something like 72 threads. So it could just be threads
that had gotten past the dma_debug_disabled() check already before
global_disable was set to true?
I guess this could be pr_err_once() instead, then?
BR,
-R
> Thanks,
> Robin.
>
> > } else if (rc == -EEXIST && !(attrs & DMA_ATTR_SKIP_CPU_SYNC)) {
> > err_printk(entry->dev, entry,
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] dma-debug: Make things less spammy under memory pressure
@ 2022-05-31 22:19 ` Rob Clark
0 siblings, 0 replies; 8+ messages in thread
From: Rob Clark @ 2022-05-31 22:19 UTC (permalink / raw)
To: Robin Murphy
Cc: Rob Clark, linux-arm-msm, Linux Kernel Mailing List,
open list:DMA MAPPING HELPERS, Christoph Hellwig
On Tue, May 31, 2022 at 3:00 PM Robin Murphy <robin.murphy@arm.com> wrote:
>
> On 2022-05-31 22:51, Rob Clark wrote:
> > From: Rob Clark <robdclark@chromium.org>
> >
> > Ratelimit the error msg to avoid flooding the console.
> >
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
> > ---
> > kernel/dma/debug.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
> > index f8ff598596b8..683966f0247b 100644
> > --- a/kernel/dma/debug.c
> > +++ b/kernel/dma/debug.c
> > @@ -564,7 +564,7 @@ static void add_dma_entry(struct dma_debug_entry *entry, unsigned long attrs)
> >
> > rc = active_cacheline_insert(entry);
> > if (rc == -ENOMEM) {
> > - pr_err("cacheline tracking ENOMEM, dma-debug disabled\n");
> > + pr_err_ratelimited("cacheline tracking ENOMEM, dma-debug disabled\n");
> > global_disable = true;
>
> Given that it's supposed to disable itself entirely if it ever gets
> here, just how spammy is it exactly?
um, quite.. tbf that was in the context of a WIP igt test for
shrinker which was trying to cycle thru ~2x RAM size worth of GEM
buffers on something like 72 threads. So it could just be threads
that had gotten past the dma_debug_disabled() check already before
global_disable was set to true?
I guess this could be pr_err_once() instead, then?
BR,
-R
> Thanks,
> Robin.
>
> > } else if (rc == -EEXIST && !(attrs & DMA_ATTR_SKIP_CPU_SYNC)) {
> > err_printk(entry->dev, entry,
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] dma-debug: Make things less spammy under memory pressure
2022-05-31 22:19 ` Rob Clark
@ 2022-06-01 5:16 ` Christoph Hellwig
-1 siblings, 0 replies; 8+ messages in thread
From: Christoph Hellwig @ 2022-06-01 5:16 UTC (permalink / raw)
To: Rob Clark
Cc: Robin Murphy, Linux Kernel Mailing List, linux-arm-msm,
Rob Clark, Christoph Hellwig, Marek Szyprowski,
open list:DMA MAPPING HELPERS
On Tue, May 31, 2022 at 03:19:45PM -0700, Rob Clark wrote:
> um, quite.. tbf that was in the context of a WIP igt test for
> shrinker which was trying to cycle thru ~2x RAM size worth of GEM
> buffers on something like 72 threads. So it could just be threads
> that had gotten past the dma_debug_disabled() check already before
> global_disable was set to true?
>
> I guess this could be pr_err_once() instead, then?
Yes, we could use pr_err_once to reduce the chattyness while still
keeping global_disable to disable all the actual tracking.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dma-debug: Make things less spammy under memory pressure
@ 2022-06-01 5:16 ` Christoph Hellwig
0 siblings, 0 replies; 8+ messages in thread
From: Christoph Hellwig @ 2022-06-01 5:16 UTC (permalink / raw)
To: Rob Clark
Cc: Rob Clark, linux-arm-msm, Linux Kernel Mailing List,
open list:DMA MAPPING HELPERS, Robin Murphy, Christoph Hellwig
On Tue, May 31, 2022 at 03:19:45PM -0700, Rob Clark wrote:
> um, quite.. tbf that was in the context of a WIP igt test for
> shrinker which was trying to cycle thru ~2x RAM size worth of GEM
> buffers on something like 72 threads. So it could just be threads
> that had gotten past the dma_debug_disabled() check already before
> global_disable was set to true?
>
> I guess this could be pr_err_once() instead, then?
Yes, we could use pr_err_once to reduce the chattyness while still
keeping global_disable to disable all the actual tracking.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-06-01 5:16 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-31 21:51 [PATCH] dma-debug: Make things less spammy under memory pressure Rob Clark
2022-05-31 21:51 ` Rob Clark
2022-05-31 22:00 ` Robin Murphy
2022-05-31 22:00 ` Robin Murphy
2022-05-31 22:19 ` Rob Clark
2022-05-31 22:19 ` Rob Clark
2022-06-01 5:16 ` Christoph Hellwig
2022-06-01 5:16 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.