* [PATCH 2/4] dt-bindings: power: supply: qcom,pm8941: use regulator schema for child node
2022-06-01 7:19 [PATCH 1/4] dt-bindings: power: supply: bq24190: use regulator schema for child node Krzysztof Kozlowski
@ 2022-06-01 7:19 ` Krzysztof Kozlowski
2022-06-05 21:48 ` Rob Herring
2022-06-01 7:19 ` [PATCH 3/4] dt-bindings: power: supply: qcom,pm8941: document usb-charge-current-limit Krzysztof Kozlowski
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-01 7:19 UTC (permalink / raw)
To: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski,
David Heidelberg, Dmitry Osipenko, linux-pm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
The 'usb-otg-vbus' child node is a regulator so reference the regulator
schema for proper evaluation.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/power/supply/qcom,pm8941-charger.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-charger.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-charger.yaml
index caeff68c66d5..cd6364d65751 100644
--- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-charger.yaml
+++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-charger.yaml
@@ -121,7 +121,7 @@ properties:
description: Reference to the regulator supplying power to the USB_OTG_IN pin.
otg-vbus:
- type: object
+ $ref: /schemas/regulator/regulator.yaml#
description: |
This node defines a regulator used to control the direction of VBUS voltage.
Specifically whether to supply voltage to VBUS for host mode operation of the OTG port,
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/4] dt-bindings: power: supply: qcom,pm8941: use regulator schema for child node
2022-06-01 7:19 ` [PATCH 2/4] dt-bindings: power: supply: qcom,pm8941: " Krzysztof Kozlowski
@ 2022-06-05 21:48 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2022-06-05 21:48 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, devicetree, Sebastian Reichel,
Dmitry Osipenko, Rob Herring, linux-kernel, David Heidelberg,
linux-pm
On Wed, 01 Jun 2022 09:19:09 +0200, Krzysztof Kozlowski wrote:
> The 'usb-otg-vbus' child node is a regulator so reference the regulator
> schema for proper evaluation.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/power/supply/qcom,pm8941-charger.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/4] dt-bindings: power: supply: qcom,pm8941: document usb-charge-current-limit
2022-06-01 7:19 [PATCH 1/4] dt-bindings: power: supply: bq24190: use regulator schema for child node Krzysztof Kozlowski
2022-06-01 7:19 ` [PATCH 2/4] dt-bindings: power: supply: qcom,pm8941: " Krzysztof Kozlowski
@ 2022-06-01 7:19 ` Krzysztof Kozlowski
2022-06-05 22:26 ` Rob Herring
2022-06-01 7:19 ` [PATCH 4/4] dt-bindings: power: supply: summit,smb347: use absolute path to schema Krzysztof Kozlowski
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-01 7:19 UTC (permalink / raw)
To: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski,
David Heidelberg, Dmitry Osipenko, linux-pm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Document already used (in DTS and by driver) 'usb-charge-current-limit'
property:
arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dtb:
charger@1000: 'usb-charge-current-limit' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/power/supply/qcom,pm8941-charger.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-charger.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-charger.yaml
index cd6364d65751..cbac55d3cb92 100644
--- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-charger.yaml
+++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-charger.yaml
@@ -117,6 +117,13 @@ properties:
be done externally to fully comply with the JEITA safety guidelines if this flag
is set.
+ usb-charge-current-limit:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 100000
+ maximum: 2500000
+ description: |
+ Default USB charge current limit in uA.
+
usb-otg-in-supply:
description: Reference to the regulator supplying power to the USB_OTG_IN pin.
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 3/4] dt-bindings: power: supply: qcom,pm8941: document usb-charge-current-limit
2022-06-01 7:19 ` [PATCH 3/4] dt-bindings: power: supply: qcom,pm8941: document usb-charge-current-limit Krzysztof Kozlowski
@ 2022-06-05 22:26 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2022-06-05 22:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Dmitry Osipenko, Sebastian Reichel, Krzysztof Kozlowski,
David Heidelberg, devicetree, linux-kernel, Rob Herring,
linux-pm
On Wed, 01 Jun 2022 09:19:10 +0200, Krzysztof Kozlowski wrote:
> Document already used (in DTS and by driver) 'usb-charge-current-limit'
> property:
>
> arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dtb:
> charger@1000: 'usb-charge-current-limit' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/power/supply/qcom,pm8941-charger.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 4/4] dt-bindings: power: supply: summit,smb347: use absolute path to schema
2022-06-01 7:19 [PATCH 1/4] dt-bindings: power: supply: bq24190: use regulator schema for child node Krzysztof Kozlowski
2022-06-01 7:19 ` [PATCH 2/4] dt-bindings: power: supply: qcom,pm8941: " Krzysztof Kozlowski
2022-06-01 7:19 ` [PATCH 3/4] dt-bindings: power: supply: qcom,pm8941: document usb-charge-current-limit Krzysztof Kozlowski
@ 2022-06-01 7:19 ` Krzysztof Kozlowski
2022-06-02 15:47 ` David Heidelberg
2022-06-05 22:26 ` Rob Herring
2022-06-05 21:48 ` [PATCH 1/4] dt-bindings: power: supply: bq24190: use regulator schema for child node Rob Herring
2022-06-09 19:29 ` Sebastian Reichel
4 siblings, 2 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-01 7:19 UTC (permalink / raw)
To: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski,
David Heidelberg, Dmitry Osipenko, linux-pm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Reference regulator schema by absolute path, as expected by DT schema
coding style.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/power/supply/summit,smb347-charger.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
index 20862cdfc116..ce0bca4689f6 100644
--- a/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
+++ b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
@@ -82,7 +82,7 @@ properties:
- 1 # SMB3XX_SYSOK_INOK_ACTIVE_HIGH
usb-vbus:
- $ref: "../../regulator/regulator.yaml#"
+ $ref: /schemas/regulator/regulator.yaml#
type: object
properties:
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 4/4] dt-bindings: power: supply: summit,smb347: use absolute path to schema
2022-06-01 7:19 ` [PATCH 4/4] dt-bindings: power: supply: summit,smb347: use absolute path to schema Krzysztof Kozlowski
@ 2022-06-02 15:47 ` David Heidelberg
2022-06-05 22:26 ` Rob Herring
1 sibling, 0 replies; 10+ messages in thread
From: David Heidelberg @ 2022-06-02 15:47 UTC (permalink / raw)
To: Krzysztof Kozlowski, Sebastian Reichel, Rob Herring,
Krzysztof Kozlowski, Dmitry Osipenko, linux-pm, devicetree,
linux-kernel
Reviewed-by: David Heidelberg <david@ixit.cz>
On 01/06/2022 09:19, Krzysztof Kozlowski wrote:
> Reference regulator schema by absolute path, as expected by DT schema
> coding style.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/power/supply/summit,smb347-charger.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> index 20862cdfc116..ce0bca4689f6 100644
> --- a/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> @@ -82,7 +82,7 @@ properties:
> - 1 # SMB3XX_SYSOK_INOK_ACTIVE_HIGH
>
> usb-vbus:
> - $ref: "../../regulator/regulator.yaml#"
> + $ref: /schemas/regulator/regulator.yaml#
> type: object
>
> properties:
--
David Heidelberg
Consultant Software Engineer
Matrix: @okias:matrix.org
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4/4] dt-bindings: power: supply: summit,smb347: use absolute path to schema
2022-06-01 7:19 ` [PATCH 4/4] dt-bindings: power: supply: summit,smb347: use absolute path to schema Krzysztof Kozlowski
2022-06-02 15:47 ` David Heidelberg
@ 2022-06-05 22:26 ` Rob Herring
1 sibling, 0 replies; 10+ messages in thread
From: Rob Herring @ 2022-06-05 22:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: David Heidelberg, Rob Herring, devicetree, Sebastian Reichel,
Dmitry Osipenko, Krzysztof Kozlowski, linux-kernel, linux-pm
On Wed, 01 Jun 2022 09:19:11 +0200, Krzysztof Kozlowski wrote:
> Reference regulator schema by absolute path, as expected by DT schema
> coding style.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/power/supply/summit,smb347-charger.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] dt-bindings: power: supply: bq24190: use regulator schema for child node
2022-06-01 7:19 [PATCH 1/4] dt-bindings: power: supply: bq24190: use regulator schema for child node Krzysztof Kozlowski
` (2 preceding siblings ...)
2022-06-01 7:19 ` [PATCH 4/4] dt-bindings: power: supply: summit,smb347: use absolute path to schema Krzysztof Kozlowski
@ 2022-06-05 21:48 ` Rob Herring
2022-06-09 19:29 ` Sebastian Reichel
4 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2022-06-05 21:48 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-kernel, Rob Herring, Sebastian Reichel, devicetree,
Dmitry Osipenko, David Heidelberg, Krzysztof Kozlowski, linux-pm
On Wed, 01 Jun 2022 09:19:08 +0200, Krzysztof Kozlowski wrote:
> The 'usb-otg-vbus' child node is a regulator so reference the regulator
> schema for proper evaluation.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/power/supply/bq24190.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/4] dt-bindings: power: supply: bq24190: use regulator schema for child node
2022-06-01 7:19 [PATCH 1/4] dt-bindings: power: supply: bq24190: use regulator schema for child node Krzysztof Kozlowski
` (3 preceding siblings ...)
2022-06-05 21:48 ` [PATCH 1/4] dt-bindings: power: supply: bq24190: use regulator schema for child node Rob Herring
@ 2022-06-09 19:29 ` Sebastian Reichel
4 siblings, 0 replies; 10+ messages in thread
From: Sebastian Reichel @ 2022-06-09 19:29 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, David Heidelberg,
Dmitry Osipenko, linux-pm, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]
Hi,
On Wed, Jun 01, 2022 at 09:19:08AM +0200, Krzysztof Kozlowski wrote:
> The 'usb-otg-vbus' child node is a regulator so reference the regulator
> schema for proper evaluation.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Thanks, I applied all 4 patches to power-supply's for-next branch.
-- Sebastian
> Documentation/devicetree/bindings/power/supply/bq24190.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq24190.yaml b/Documentation/devicetree/bindings/power/supply/bq24190.yaml
> index 0d7cbbdf808b..402d9d2ed2b9 100644
> --- a/Documentation/devicetree/bindings/power/supply/bq24190.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/bq24190.yaml
> @@ -28,7 +28,7 @@ properties:
> maxItems: 1
>
> usb-otg-vbus:
> - type: object
> + $ref: /schemas/regulator/regulator.yaml#
> description: |
> Regulator that is used to control the VBUS voltage direction for
> either USB host mode or for charging on the OTG port
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread