All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: net: adin: Escape a trailing ":"
@ 2022-06-02  1:28 Palmer Dabbelt
  2022-06-02 14:29 ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Palmer Dabbelt @ 2022-06-02  1:28 UTC (permalink / raw)
  To: kuba
  Cc: michael.hennerich, davem, edumazet, pabeni, robh+dt,
	krzysztof.kozlowski+dt, alexandru.ardelean, netdev, devicetree,
	linux-kernel, linux, Palmer Dabbelt

From: Palmer Dabbelt <palmer@rivosinc.com>

1f77204e11f8 ("dt-bindings: net: adin: document phy clock output
properties") added a line with a ":" at the end, which is tripping up my
attempts to run the DT schema checks due to this being invalid YAML
syntax.  I get a schema check failure with the following error

    ruamel.yaml.scanner.ScannerError: mapping values are not allowed in this context

This just escapes the line in question, so it can parse.

Fixes: 1f77204e11f8 ("dt-bindings: net: adin: document phy clock output properties")
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
---
 Documentation/devicetree/bindings/net/adi,adin.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/adi,adin.yaml b/Documentation/devicetree/bindings/net/adi,adin.yaml
index 77750df0c2c4..88611720545d 100644
--- a/Documentation/devicetree/bindings/net/adi,adin.yaml
+++ b/Documentation/devicetree/bindings/net/adi,adin.yaml
@@ -37,7 +37,8 @@ properties:
     default: 8
 
   adi,phy-output-clock:
-    description: Select clock output on GP_CLK pin. Two clocks are available:
+    description: |
+      Select clock output on GP_CLK pin. Two clocks are available:
       A 25MHz reference and a free-running 125MHz.
       The phy can alternatively automatically switch between the reference and
       the 125MHz clocks based on its internal state.
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: net: adin: Escape a trailing ":"
  2022-06-02  1:28 [PATCH] dt-bindings: net: adin: Escape a trailing ":" Palmer Dabbelt
@ 2022-06-02 14:29 ` Rob Herring
  2022-06-02 14:38   ` Palmer Dabbelt
  0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2022-06-02 14:29 UTC (permalink / raw)
  To: Palmer Dabbelt
  Cc: kuba, michael.hennerich, davem, edumazet, pabeni,
	krzysztof.kozlowski+dt, alexandru.ardelean, netdev, devicetree,
	linux-kernel, linux

On Wed, Jun 01, 2022 at 06:28:09PM -0700, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmer@rivosinc.com>
> 
> 1f77204e11f8 ("dt-bindings: net: adin: document phy clock output
> properties") added a line with a ":" at the end, which is tripping up my
> attempts to run the DT schema checks due to this being invalid YAML
> syntax.  I get a schema check failure with the following error
> 
>     ruamel.yaml.scanner.ScannerError: mapping values are not allowed in this context
> 
> This just escapes the line in question, so it can parse.
> 
> Fixes: 1f77204e11f8 ("dt-bindings: net: adin: document phy clock output properties")
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---
>  Documentation/devicetree/bindings/net/adi,adin.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Already have a fix queued in netdev.

Rob

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: net: adin: Escape a trailing ":"
  2022-06-02 14:29 ` Rob Herring
@ 2022-06-02 14:38   ` Palmer Dabbelt
  0 siblings, 0 replies; 3+ messages in thread
From: Palmer Dabbelt @ 2022-06-02 14:38 UTC (permalink / raw)
  To: Rob Herring
  Cc: kuba, michael.hennerich, davem, edumazet, pabeni,
	krzysztof.kozlowski+dt, alexandru.ardelean, netdev, devicetree,
	linux-kernel, linux

On Thu, 02 Jun 2022 07:29:17 PDT (-0700), Rob Herring wrote:
> On Wed, Jun 01, 2022 at 06:28:09PM -0700, Palmer Dabbelt wrote:
>> From: Palmer Dabbelt <palmer@rivosinc.com>
>>
>> 1f77204e11f8 ("dt-bindings: net: adin: document phy clock output
>> properties") added a line with a ":" at the end, which is tripping up my
>> attempts to run the DT schema checks due to this being invalid YAML
>> syntax.  I get a schema check failure with the following error
>>
>>     ruamel.yaml.scanner.ScannerError: mapping values are not allowed in this context
>>
>> This just escapes the line in question, so it can parse.
>>
>> Fixes: 1f77204e11f8 ("dt-bindings: net: adin: document phy clock output properties")
>> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
>> ---
>>  Documentation/devicetree/bindings/net/adi,adin.yaml | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Already have a fix queued in netdev.

OK, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-06-02 14:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-02  1:28 [PATCH] dt-bindings: net: adin: Escape a trailing ":" Palmer Dabbelt
2022-06-02 14:29 ` Rob Herring
2022-06-02 14:38   ` Palmer Dabbelt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.