From: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com> To: kernel test robot <lkp@intel.com> Cc: "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Linux Memory Management List <linux-mm@kvack.org> Subject: Re: [akpm-mm:mm-unstable 154/159] mm/memory-failure.c:1538:9: error: implicit declaration of function 'hugetlb_set_page_hwpoison' Date: Fri, 3 Jun 2022 02:10:43 +0000 [thread overview] Message-ID: <20220603021042.GA1205503@hori.linux.bs1.fc.nec.co.jp> (raw) In-Reply-To: <202206030829.0eS2kZa0-lkp@intel.com> On Fri, Jun 03, 2022 at 08:27:50AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable > head: 1bdf44dbc966e31c635199d413ee064a7d320844 > commit: d4edf38ab95397f32ae017848deeeb3b6d2c5bb7 [154/159] mm, hwpoison, hugetlb: introduce SUBPAGE_INDEX_HWPOISON to save raw error page > config: x86_64-kexec (https://download.01.org/0day-ci/archive/20220603/202206030829.0eS2kZa0-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.3.0-1) 11.3.0 > reproduce (this is a W=1 build): > # https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?id=d4edf38ab95397f32ae017848deeeb3b6d2c5bb7 > git remote add akpm-mm https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git > git fetch --no-tags akpm-mm mm-unstable > git checkout d4edf38ab95397f32ae017848deeeb3b6d2c5bb7 > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot <lkp@intel.com> Thank you! > > All errors (new ones prefixed by >>): > > mm/memory-failure.c: In function '__get_huge_page_for_hwpoison': > >> mm/memory-failure.c:1538:9: error: implicit declaration of function 'hugetlb_set_page_hwpoison' [-Werror=implicit-function-declaration] > 1538 | hugetlb_set_page_hwpoison(head, page); > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors __get_huge_page_for_hwpoison() is not needed when CONFIG_HUGETLB_PAGE is n, so extending "#ifdef CONFIG_HUGETLB_PAG" to cover __get_huge_page_for_hwpoison() would be a simple resolution. diff --git a/mm/memory-failure.c b/mm/memory-failure.c index ced033a99e19..31d7eff35acf 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1501,6 +1501,7 @@ static int try_to_split_thp_page(struct page *page, const char *msg) return 0; } +#ifdef CONFIG_HUGETLB_PAGE /* * Called from hugetlb code with hugetlb_lock held. * @@ -1550,7 +1551,6 @@ int __get_huge_page_for_hwpoison(unsigned long pfn, int flags) return ret; } -#ifdef CONFIG_HUGETLB_PAGE /* * Taking refcount of hugetlb pages needs extra care about race conditions * with basic operations like hugepage allocation/free/demotion. Thanks, Naoya Horiguchi
WARNING: multiple messages have this Message-ID (diff)
From: HORIGUCHI NAOYA(堀口 直也) <naoya.horiguchi@nec.com> To: kbuild-all@lists.01.org Subject: Re: [akpm-mm:mm-unstable 154/159] mm/memory-failure.c:1538:9: error: implicit declaration of function 'hugetlb_set_page_hwpoison' Date: Fri, 03 Jun 2022 02:10:43 +0000 [thread overview] Message-ID: <20220603021042.GA1205503@hori.linux.bs1.fc.nec.co.jp> (raw) In-Reply-To: <202206030829.0eS2kZa0-lkp@intel.com> [-- Attachment #1: Type: text/plain, Size: 2453 bytes --] On Fri, Jun 03, 2022 at 08:27:50AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable > head: 1bdf44dbc966e31c635199d413ee064a7d320844 > commit: d4edf38ab95397f32ae017848deeeb3b6d2c5bb7 [154/159] mm, hwpoison, hugetlb: introduce SUBPAGE_INDEX_HWPOISON to save raw error page > config: x86_64-kexec (https://download.01.org/0day-ci/archive/20220603/202206030829.0eS2kZa0-lkp(a)intel.com/config) > compiler: gcc-11 (Debian 11.3.0-1) 11.3.0 > reproduce (this is a W=1 build): > # https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?id=d4edf38ab95397f32ae017848deeeb3b6d2c5bb7 > git remote add akpm-mm https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git > git fetch --no-tags akpm-mm mm-unstable > git checkout d4edf38ab95397f32ae017848deeeb3b6d2c5bb7 > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot <lkp@intel.com> Thank you! > > All errors (new ones prefixed by >>): > > mm/memory-failure.c: In function '__get_huge_page_for_hwpoison': > >> mm/memory-failure.c:1538:9: error: implicit declaration of function 'hugetlb_set_page_hwpoison' [-Werror=implicit-function-declaration] > 1538 | hugetlb_set_page_hwpoison(head, page); > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors __get_huge_page_for_hwpoison() is not needed when CONFIG_HUGETLB_PAGE is n, so extending "#ifdef CONFIG_HUGETLB_PAG" to cover __get_huge_page_for_hwpoison() would be a simple resolution. diff --git a/mm/memory-failure.c b/mm/memory-failure.c index ced033a99e19..31d7eff35acf 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1501,6 +1501,7 @@ static int try_to_split_thp_page(struct page *page, const char *msg) return 0; } +#ifdef CONFIG_HUGETLB_PAGE /* * Called from hugetlb code with hugetlb_lock held. * @@ -1550,7 +1551,6 @@ int __get_huge_page_for_hwpoison(unsigned long pfn, int flags) return ret; } -#ifdef CONFIG_HUGETLB_PAGE /* * Taking refcount of hugetlb pages needs extra care about race conditions * with basic operations like hugepage allocation/free/demotion. Thanks, Naoya Horiguchi
next prev parent reply other threads:[~2022-06-03 2:10 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-03 0:27 [akpm-mm:mm-unstable 154/159] mm/memory-failure.c:1538:9: error: implicit declaration of function 'hugetlb_set_page_hwpoison' kernel test robot 2022-06-03 2:10 ` HORIGUCHI NAOYA(堀口 直也) [this message] 2022-06-03 2:10 ` HORIGUCHI NAOYA
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220603021042.GA1205503@hori.linux.bs1.fc.nec.co.jp \ --to=naoya.horiguchi@nec.com \ --cc=akpm@linux-foundation.org \ --cc=kbuild-all@lists.01.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=lkp@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.