All of lore.kernel.org
 help / color / mirror / Atom feed
* [ammarfaizi2-block:google/android/kernel/common/android12-5.4 6455/9999] drivers/dma-buf/dma-buf.c:728 dma_buf_attach() warn: ignoring unreachable code.
@ 2022-06-06 12:18 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-06-03  4:13 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 7009 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
TO: Ammar Faizi <ammarfaizi2@gnuweeb.org>

tree:   https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android12-5.4
head:   61c005f0f1663789612bbe039932620f51779526
commit: e618a51f562f1f038f31b6a4b4a250c062d70eab [6455/9999] ANDROID: Delete the DMA-BUF attachment sysfs statistics
:::::: branch date: 9 weeks ago
:::::: commit date: 11 months ago
config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220603/202206031201.CrArhQ6a-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/dma-buf/dma-buf.c:728 dma_buf_attach() warn: ignoring unreachable code.

vim +728 drivers/dma-buf/dma-buf.c

d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  677  
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  678  /**
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  679   * dma_buf_attach - Add the device to dma_buf's attachments list; optionally,
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  680   * calls attach() of dma_buf_ops to allow device-specific attach functionality
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  681   * @dmabuf:	[in]	buffer to attach device to.
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  682   * @dev:	[in]	device to be attached.
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  683   *
2904a8c1311f028 drivers/dma-buf/dma-buf.c Daniel Vetter    2016-12-09  684   * Returns struct dma_buf_attachment pointer for this attachment. Attachments
2904a8c1311f028 drivers/dma-buf/dma-buf.c Daniel Vetter    2016-12-09  685   * must be cleaned up by calling dma_buf_detach().
2904a8c1311f028 drivers/dma-buf/dma-buf.c Daniel Vetter    2016-12-09  686   *
2904a8c1311f028 drivers/dma-buf/dma-buf.c Daniel Vetter    2016-12-09  687   * Returns:
2904a8c1311f028 drivers/dma-buf/dma-buf.c Daniel Vetter    2016-12-09  688   *
2904a8c1311f028 drivers/dma-buf/dma-buf.c Daniel Vetter    2016-12-09  689   * A pointer to newly created &dma_buf_attachment on success, or a negative
2904a8c1311f028 drivers/dma-buf/dma-buf.c Daniel Vetter    2016-12-09  690   * error code wrapped into a pointer on failure.
2904a8c1311f028 drivers/dma-buf/dma-buf.c Daniel Vetter    2016-12-09  691   *
2904a8c1311f028 drivers/dma-buf/dma-buf.c Daniel Vetter    2016-12-09  692   * Note that this can fail if the backing storage of @dmabuf is in a place not
2904a8c1311f028 drivers/dma-buf/dma-buf.c Daniel Vetter    2016-12-09  693   * accessible to @dev, and cannot be moved to a more suitable place. This is
2904a8c1311f028 drivers/dma-buf/dma-buf.c Daniel Vetter    2016-12-09  694   * indicated with the error code -EBUSY.
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  695   */
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  696  struct dma_buf_attachment *dma_buf_attach(struct dma_buf *dmabuf,
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  697  					  struct device *dev)
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  698  {
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  699  	struct dma_buf_attachment *attach;
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  700  	int ret;
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  701  
d1aa06a1eaf5f75 drivers/base/dma-buf.c    Laurent Pinchart 2012-01-26  702  	if (WARN_ON(!dmabuf || !dev))
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  703  		return ERR_PTR(-EINVAL);
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  704  
db7942b6292306a drivers/dma-buf/dma-buf.c Markus Elfring   2017-05-08  705  	attach = kzalloc(sizeof(*attach), GFP_KERNEL);
34d84ec4881d134 drivers/dma-buf/dma-buf.c Markus Elfring   2017-05-08  706  	if (!attach)
a9fbc3b73127efb drivers/base/dma-buf.c    Laurent Pinchart 2012-01-26  707  		return ERR_PTR(-ENOMEM);
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  708  
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  709  	attach->dev = dev;
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  710  	attach->dmabuf = dmabuf;
2ed9201bdd9a8e4 drivers/base/dma-buf.c    Laurent Pinchart 2012-01-26  711  
2ed9201bdd9a8e4 drivers/base/dma-buf.c    Laurent Pinchart 2012-01-26  712  	mutex_lock(&dmabuf->lock);
2ed9201bdd9a8e4 drivers/base/dma-buf.c    Laurent Pinchart 2012-01-26  713  
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  714  	if (dmabuf->ops->attach) {
a19741e5e5a9f1f drivers/dma-buf/dma-buf.c Christian König  2018-05-28  715  		ret = dmabuf->ops->attach(dmabuf, attach);
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  716  		if (ret)
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  717  			goto err_attach;
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  718  	}
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  719  	list_add(&attach->node, &dmabuf->attachments);
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  720  
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  721  	return attach;
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  722  
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  723  err_attach:
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  724  	kfree(attach);
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  725  	mutex_unlock(&dmabuf->lock);
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  726  	return ERR_PTR(ret);
90935b28546d2cf drivers/dma-buf/dma-buf.c Hridya Valsaraju 2021-02-01  727  
90935b28546d2cf drivers/dma-buf/dma-buf.c Hridya Valsaraju 2021-02-01 @728  	dma_buf_detach(dmabuf, attach);
90935b28546d2cf drivers/dma-buf/dma-buf.c Hridya Valsaraju 2021-02-01  729  	return ERR_PTR(ret);
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  730  }
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  731  EXPORT_SYMBOL_GPL(dma_buf_attach);
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  732  

:::::: The code at line 728 was first introduced by commit
:::::: 90935b28546d2cfb7541d76c71e749496f77968b BACKPORT: FROMLIST: dmabuf: Add the capability to expose DMA-BUF stats in sysfs

:::::: TO: Hridya Valsaraju <hridya@google.com>
:::::: CC: Suren Baghdasaryan <surenb@google.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [ammarfaizi2-block:google/android/kernel/common/android12-5.4 6455/9999] drivers/dma-buf/dma-buf.c:728 dma_buf_attach() warn: ignoring unreachable code.
@ 2022-06-06 12:18 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2022-06-06 12:18 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 4294 bytes --]

tree:   https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android12-5.4
head:   61c005f0f1663789612bbe039932620f51779526
commit: e618a51f562f1f038f31b6a4b4a250c062d70eab [6455/9999] ANDROID: Delete the DMA-BUF attachment sysfs statistics
config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220603/202206031201.CrArhQ6a-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/dma-buf/dma-buf.c:728 dma_buf_attach() warn: ignoring unreachable code.

vim +728 drivers/dma-buf/dma-buf.c

d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  696  struct dma_buf_attachment *dma_buf_attach(struct dma_buf *dmabuf,
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  697  					  struct device *dev)
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  698  {
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  699  	struct dma_buf_attachment *attach;
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  700  	int ret;
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  701  
d1aa06a1eaf5f75 drivers/base/dma-buf.c    Laurent Pinchart 2012-01-26  702  	if (WARN_ON(!dmabuf || !dev))
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  703  		return ERR_PTR(-EINVAL);
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  704  
db7942b6292306a drivers/dma-buf/dma-buf.c Markus Elfring   2017-05-08  705  	attach = kzalloc(sizeof(*attach), GFP_KERNEL);
34d84ec4881d134 drivers/dma-buf/dma-buf.c Markus Elfring   2017-05-08  706  	if (!attach)
a9fbc3b73127efb drivers/base/dma-buf.c    Laurent Pinchart 2012-01-26  707  		return ERR_PTR(-ENOMEM);
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  708  
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  709  	attach->dev = dev;
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  710  	attach->dmabuf = dmabuf;
2ed9201bdd9a8e4 drivers/base/dma-buf.c    Laurent Pinchart 2012-01-26  711  
2ed9201bdd9a8e4 drivers/base/dma-buf.c    Laurent Pinchart 2012-01-26  712  	mutex_lock(&dmabuf->lock);
2ed9201bdd9a8e4 drivers/base/dma-buf.c    Laurent Pinchart 2012-01-26  713  
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  714  	if (dmabuf->ops->attach) {
a19741e5e5a9f1f drivers/dma-buf/dma-buf.c Christian König  2018-05-28  715  		ret = dmabuf->ops->attach(dmabuf, attach);
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  716  		if (ret)
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  717  			goto err_attach;
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  718  	}
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  719  	list_add(&attach->node, &dmabuf->attachments);
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  720  
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  721  	return attach;
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  722  
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  723  err_attach:
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  724  	kfree(attach);
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  725  	mutex_unlock(&dmabuf->lock);
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  726  	return ERR_PTR(ret);
                                                                                ^^^^^^^^^^^^^^^^^^^
90935b28546d2cf drivers/dma-buf/dma-buf.c Hridya Valsaraju 2021-02-01  727  
90935b28546d2cf drivers/dma-buf/dma-buf.c Hridya Valsaraju 2021-02-01 @728  	dma_buf_detach(dmabuf, attach);

Unreachable

90935b28546d2cf drivers/dma-buf/dma-buf.c Hridya Valsaraju 2021-02-01  729  	return ERR_PTR(ret);
d15bd7ee445d070 drivers/base/dma-buf.c    Sumit Semwal     2011-12-26  730  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-06 12:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-03  4:13 [ammarfaizi2-block:google/android/kernel/common/android12-5.4 6455/9999] drivers/dma-buf/dma-buf.c:728 dma_buf_attach() warn: ignoring unreachable code kernel test robot
2022-06-06 12:18 ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.