* [PATCH] ARM: cns3xxx: Fix refcount leak in cns3xxx_init
@ 2022-06-05 7:58 ` Miaoqian Lin
0 siblings, 0 replies; 6+ messages in thread
From: Miaoqian Lin @ 2022-06-05 7:58 UTC (permalink / raw)
To: Krzysztof Halasa, Russell King, Arnd Bergmann, linux-arm-kernel,
linux-kernel
Cc: linmq006
of_find_compatible_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.
Fixes: 415f59142d9d ("ARM: cns3xxx: initial DT support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
arch/arm/mach-cns3xxx/core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-cns3xxx/core.c b/arch/arm/mach-cns3xxx/core.c
index e4f4b20b83a2..3fc4ec830e3a 100644
--- a/arch/arm/mach-cns3xxx/core.c
+++ b/arch/arm/mach-cns3xxx/core.c
@@ -372,6 +372,7 @@ static void __init cns3xxx_init(void)
/* De-Asscer SATA Reset */
cns3xxx_pwr_soft_rst(CNS3XXX_PWR_SOFTWARE_RST(SATA));
}
+ of_node_put(dn);
dn = of_find_compatible_node(NULL, NULL, "cavium,cns3420-sdhci");
if (of_device_is_available(dn)) {
@@ -385,6 +386,7 @@ static void __init cns3xxx_init(void)
cns3xxx_pwr_clk_en(CNS3XXX_PWR_CLK_EN(SDIO));
cns3xxx_pwr_soft_rst(CNS3XXX_PWR_SOFTWARE_RST(SDIO));
}
+ of_node_put(dn);
pm_power_off = cns3xxx_power_off;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: cns3xxx: Fix refcount leak in cns3xxx_init
@ 2022-06-05 7:58 ` Miaoqian Lin
0 siblings, 0 replies; 6+ messages in thread
From: Miaoqian Lin @ 2022-06-05 7:58 UTC (permalink / raw)
To: Krzysztof Halasa, Russell King, Arnd Bergmann, linux-arm-kernel,
linux-kernel
Cc: linmq006
of_find_compatible_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.
Fixes: 415f59142d9d ("ARM: cns3xxx: initial DT support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
arch/arm/mach-cns3xxx/core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-cns3xxx/core.c b/arch/arm/mach-cns3xxx/core.c
index e4f4b20b83a2..3fc4ec830e3a 100644
--- a/arch/arm/mach-cns3xxx/core.c
+++ b/arch/arm/mach-cns3xxx/core.c
@@ -372,6 +372,7 @@ static void __init cns3xxx_init(void)
/* De-Asscer SATA Reset */
cns3xxx_pwr_soft_rst(CNS3XXX_PWR_SOFTWARE_RST(SATA));
}
+ of_node_put(dn);
dn = of_find_compatible_node(NULL, NULL, "cavium,cns3420-sdhci");
if (of_device_is_available(dn)) {
@@ -385,6 +386,7 @@ static void __init cns3xxx_init(void)
cns3xxx_pwr_clk_en(CNS3XXX_PWR_CLK_EN(SDIO));
cns3xxx_pwr_soft_rst(CNS3XXX_PWR_SOFTWARE_RST(SDIO));
}
+ of_node_put(dn);
pm_power_off = cns3xxx_power_off;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: cns3xxx: Fix refcount leak in cns3xxx_init
2022-06-05 7:58 ` Miaoqian Lin
@ 2022-06-23 8:36 ` Krzysztof Hałasa
-1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Hałasa @ 2022-06-23 8:36 UTC (permalink / raw)
To: Miaoqian Lin; +Cc: Russell King, Arnd Bergmann, linux-arm-kernel, linux-kernel
Miaoqian Lin <linmq006@gmail.com> writes:
> of_find_compatible_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 415f59142d9d ("ARM: cns3xxx: initial DT support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Acked-by: Krzysztof Halasa <khalasa@piap.pl>
Arnd, I guess you are in the best position to pick this patch up?
Thanks to both of you.
> ---
> arch/arm/mach-cns3xxx/core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-cns3xxx/core.c b/arch/arm/mach-cns3xxx/core.c
> index e4f4b20b83a2..3fc4ec830e3a 100644
> --- a/arch/arm/mach-cns3xxx/core.c
> +++ b/arch/arm/mach-cns3xxx/core.c
> @@ -372,6 +372,7 @@ static void __init cns3xxx_init(void)
> /* De-Asscer SATA Reset */
> cns3xxx_pwr_soft_rst(CNS3XXX_PWR_SOFTWARE_RST(SATA));
> }
> + of_node_put(dn);
>
> dn = of_find_compatible_node(NULL, NULL, "cavium,cns3420-sdhci");
> if (of_device_is_available(dn)) {
> @@ -385,6 +386,7 @@ static void __init cns3xxx_init(void)
> cns3xxx_pwr_clk_en(CNS3XXX_PWR_CLK_EN(SDIO));
> cns3xxx_pwr_soft_rst(CNS3XXX_PWR_SOFTWARE_RST(SDIO));
> }
> + of_node_put(dn);
>
> pm_power_off = cns3xxx_power_off;
--
Krzysztof "Chris" Hałasa
Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: cns3xxx: Fix refcount leak in cns3xxx_init
@ 2022-06-23 8:36 ` Krzysztof Hałasa
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Hałasa @ 2022-06-23 8:36 UTC (permalink / raw)
To: Miaoqian Lin; +Cc: Russell King, Arnd Bergmann, linux-arm-kernel, linux-kernel
Miaoqian Lin <linmq006@gmail.com> writes:
> of_find_compatible_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 415f59142d9d ("ARM: cns3xxx: initial DT support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Acked-by: Krzysztof Halasa <khalasa@piap.pl>
Arnd, I guess you are in the best position to pick this patch up?
Thanks to both of you.
> ---
> arch/arm/mach-cns3xxx/core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-cns3xxx/core.c b/arch/arm/mach-cns3xxx/core.c
> index e4f4b20b83a2..3fc4ec830e3a 100644
> --- a/arch/arm/mach-cns3xxx/core.c
> +++ b/arch/arm/mach-cns3xxx/core.c
> @@ -372,6 +372,7 @@ static void __init cns3xxx_init(void)
> /* De-Asscer SATA Reset */
> cns3xxx_pwr_soft_rst(CNS3XXX_PWR_SOFTWARE_RST(SATA));
> }
> + of_node_put(dn);
>
> dn = of_find_compatible_node(NULL, NULL, "cavium,cns3420-sdhci");
> if (of_device_is_available(dn)) {
> @@ -385,6 +386,7 @@ static void __init cns3xxx_init(void)
> cns3xxx_pwr_clk_en(CNS3XXX_PWR_CLK_EN(SDIO));
> cns3xxx_pwr_soft_rst(CNS3XXX_PWR_SOFTWARE_RST(SDIO));
> }
> + of_node_put(dn);
>
> pm_power_off = cns3xxx_power_off;
--
Krzysztof "Chris" Hałasa
Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: cns3xxx: Fix refcount leak in cns3xxx_init
2022-06-23 8:36 ` Krzysztof Hałasa
@ 2022-06-24 15:11 ` Arnd Bergmann
-1 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2022-06-24 15:11 UTC (permalink / raw)
To: Krzysztof Hałasa
Cc: Miaoqian Lin, Russell King, Arnd Bergmann, Linux ARM,
Linux Kernel Mailing List
On Thu, Jun 23, 2022 at 10:36 AM Krzysztof Hałasa <khalasa@piap.pl> wrote:
>
> Miaoqian Lin <linmq006@gmail.com> writes:
>
> > of_find_compatible_node() returns a node pointer with refcount
> > incremented, we should use of_node_put() on it when done.
> > Add missing of_node_put() to avoid refcount leak.
> >
> > Fixes: 415f59142d9d ("ARM: cns3xxx: initial DT support")
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
>
> Acked-by: Krzysztof Halasa <khalasa@piap.pl>
>
> Arnd, I guess you are in the best position to pick this patch up?
> Thanks to both of you.
Done now, thanks!
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: cns3xxx: Fix refcount leak in cns3xxx_init
@ 2022-06-24 15:11 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2022-06-24 15:11 UTC (permalink / raw)
To: Krzysztof Hałasa
Cc: Miaoqian Lin, Russell King, Arnd Bergmann, Linux ARM,
Linux Kernel Mailing List
On Thu, Jun 23, 2022 at 10:36 AM Krzysztof Hałasa <khalasa@piap.pl> wrote:
>
> Miaoqian Lin <linmq006@gmail.com> writes:
>
> > of_find_compatible_node() returns a node pointer with refcount
> > incremented, we should use of_node_put() on it when done.
> > Add missing of_node_put() to avoid refcount leak.
> >
> > Fixes: 415f59142d9d ("ARM: cns3xxx: initial DT support")
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
>
> Acked-by: Krzysztof Halasa <khalasa@piap.pl>
>
> Arnd, I guess you are in the best position to pick this patch up?
> Thanks to both of you.
Done now, thanks!
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-24 15:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-05 7:58 [PATCH] ARM: cns3xxx: Fix refcount leak in cns3xxx_init Miaoqian Lin
2022-06-05 7:58 ` Miaoqian Lin
2022-06-23 8:36 ` Krzysztof Hałasa
2022-06-23 8:36 ` Krzysztof Hałasa
2022-06-24 15:11 ` Arnd Bergmann
2022-06-24 15:11 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.