* drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
@ 2022-06-05 14:01 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2022-06-05 14:01 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 9925 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Anilkumar Kolli <akolli@codeaurora.org>
CC: Kalle Valo <kvalo@codeaurora.org>
CC: Jouni Malinen <jouni@codeaurora.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 952923ddc01120190dcf671e7b354364ce1d1362
commit: 336e7b53c82fc74d261024773a0fab43623a94fb ath11k: clean up BDF download functions
date: 8 months ago
:::::: branch date: 12 hours ago
:::::: commit date: 8 months ago
config: microblaze-randconfig-m031-20220605 (https://download.01.org/0day-ci/archive/20220605/202206052100.Ro5RcEQG-lkp(a)intel.com/config)
compiler: microblaze-linux-gcc (GCC) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
vim +/ret +2031 drivers/net/wireless/ath/ath11k/qmi.c
d5c65159f28953 Kalle Valo 2019-11-23 1919
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1920 static int ath11k_qmi_load_file_target_mem(struct ath11k_base *ab,
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1921 const u8 *data, u32 len, u8 type)
d5c65159f28953 Kalle Valo 2019-11-23 1922 {
d5c65159f28953 Kalle Valo 2019-11-23 1923 struct qmi_wlanfw_bdf_download_req_msg_v01 *req;
d5c65159f28953 Kalle Valo 2019-11-23 1924 struct qmi_wlanfw_bdf_download_resp_msg_v01 resp;
d5c65159f28953 Kalle Valo 2019-11-23 1925 struct qmi_txn txn = {};
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1926 const u8 *temp = data;
d5c65159f28953 Kalle Valo 2019-11-23 1927 void __iomem *bdf_addr = NULL;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1928 int ret;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1929 u32 remaining = len;
d5c65159f28953 Kalle Valo 2019-11-23 1930
d5c65159f28953 Kalle Valo 2019-11-23 1931 req = kzalloc(sizeof(*req), GFP_KERNEL);
d5c65159f28953 Kalle Valo 2019-11-23 1932 if (!req)
d5c65159f28953 Kalle Valo 2019-11-23 1933 return -ENOMEM;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1934
d5c65159f28953 Kalle Valo 2019-11-23 1935 memset(&resp, 0, sizeof(resp));
d5c65159f28953 Kalle Valo 2019-11-23 1936
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1937 if (ab->bus_params.fixed_bdf_addr) {
c72aa32d6d1c04 Anilkumar Kolli 2021-09-28 1938 bdf_addr = ioremap(ab->hw_params.bdf_addr, ab->hw_params.fw.board_size);
d5c65159f28953 Kalle Valo 2019-11-23 1939 if (!bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1940 ath11k_warn(ab, "qmi ioremap error for bdf_addr\n");
d5c65159f28953 Kalle Valo 2019-11-23 1941 ret = -EIO;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1942 goto err_free_req;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1943 }
d5c65159f28953 Kalle Valo 2019-11-23 1944 }
d5c65159f28953 Kalle Valo 2019-11-23 1945
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1946 while (remaining) {
d5c65159f28953 Kalle Valo 2019-11-23 1947 req->valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1948 req->file_id_valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1949 req->file_id = ab->qmi.target.board_id;
d5c65159f28953 Kalle Valo 2019-11-23 1950 req->total_size_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1951 req->total_size = remaining;
d5c65159f28953 Kalle Valo 2019-11-23 1952 req->seg_id_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1953 req->data_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1954 req->bdf_type = type;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1955 req->bdf_type_valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1956 req->end_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1957 req->end = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1958
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1959 if (remaining > QMI_WLANFW_MAX_DATA_SIZE_V01) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1960 req->data_len = QMI_WLANFW_MAX_DATA_SIZE_V01;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1961 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1962 req->data_len = remaining;
d5c65159f28953 Kalle Valo 2019-11-23 1963 req->end = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1964 }
d5c65159f28953 Kalle Valo 2019-11-23 1965
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1966 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1967 req->data_valid = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1968 req->end = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1969 req->data_len = ATH11K_QMI_MAX_BDF_FILE_NAME_SIZE;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1970 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1971 memcpy(req->data, temp, req->data_len);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1972 }
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1973
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1974 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1975 if (type == ATH11K_QMI_FILE_TYPE_CALDATA)
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1976 bdf_addr += ab->hw_params.fw.cal_offset;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1977
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1978 memcpy_toio(bdf_addr, temp, len);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1979 }
d5c65159f28953 Kalle Valo 2019-11-23 1980
d5c65159f28953 Kalle Valo 2019-11-23 1981 ret = qmi_txn_init(&ab->qmi.handle, &txn,
d5c65159f28953 Kalle Valo 2019-11-23 1982 qmi_wlanfw_bdf_download_resp_msg_v01_ei,
d5c65159f28953 Kalle Valo 2019-11-23 1983 &resp);
d5c65159f28953 Kalle Valo 2019-11-23 1984 if (ret < 0)
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1985 goto err_iounmap;
d5c65159f28953 Kalle Valo 2019-11-23 1986
bf458d79cfc46f Kalle Valo 2021-02-22 1987 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download req fixed addr type %d\n",
bf458d79cfc46f Kalle Valo 2021-02-22 1988 type);
bf458d79cfc46f Kalle Valo 2021-02-22 1989
d5c65159f28953 Kalle Valo 2019-11-23 1990 ret = qmi_send_request(&ab->qmi.handle, NULL, &txn,
d5c65159f28953 Kalle Valo 2019-11-23 1991 QMI_WLANFW_BDF_DOWNLOAD_REQ_V01,
d5c65159f28953 Kalle Valo 2019-11-23 1992 QMI_WLANFW_BDF_DOWNLOAD_REQ_MSG_V01_MAX_LEN,
d5c65159f28953 Kalle Valo 2019-11-23 1993 qmi_wlanfw_bdf_download_req_msg_v01_ei, req);
d5c65159f28953 Kalle Valo 2019-11-23 1994 if (ret < 0) {
d5c65159f28953 Kalle Valo 2019-11-23 1995 qmi_txn_cancel(&txn);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1996 goto err_iounmap;
d5c65159f28953 Kalle Valo 2019-11-23 1997 }
d5c65159f28953 Kalle Valo 2019-11-23 1998
d5c65159f28953 Kalle Valo 2019-11-23 1999 ret = qmi_txn_wait(&txn, msecs_to_jiffies(ATH11K_QMI_WLANFW_TIMEOUT_MS));
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2000 if (ret < 0) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2001 ath11k_warn(ab, "failed to wait board file download request: %d\n",
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2002 ret);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2003 goto err_iounmap;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2004 }
d5c65159f28953 Kalle Valo 2019-11-23 2005
d5c65159f28953 Kalle Valo 2019-11-23 2006 if (resp.resp.result != QMI_RESULT_SUCCESS_V01) {
097e9f0714555e Kalle Valo 2021-02-22 2007 ath11k_warn(ab, "board file download request failed: %d %d\n",
d5c65159f28953 Kalle Valo 2019-11-23 2008 resp.resp.result, resp.resp.error);
d5c65159f28953 Kalle Valo 2019-11-23 2009 ret = -EINVAL;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2010 goto err_iounmap;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2011 }
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2012
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2013 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2014 remaining = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2015 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2016 remaining -= req->data_len;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2017 temp += req->data_len;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2018 req->seg_id++;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2019 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download request remaining %i\n",
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2020 remaining);
d5c65159f28953 Kalle Valo 2019-11-23 2021 }
d5c65159f28953 Kalle Valo 2019-11-23 2022 }
d5c65159f28953 Kalle Valo 2019-11-23 2023
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2024 err_iounmap:
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2025 if (ab->bus_params.fixed_bdf_addr)
d5c65159f28953 Kalle Valo 2019-11-23 2026 iounmap(bdf_addr);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2027
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2028 err_free_req:
d5c65159f28953 Kalle Valo 2019-11-23 2029 kfree(req);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2030
d5c65159f28953 Kalle Valo 2019-11-23 @2031 return ret;
d5c65159f28953 Kalle Valo 2019-11-23 2032 }
d5c65159f28953 Kalle Valo 2019-11-23 2033
:::::: The code at line 2031 was first introduced by commit
:::::: d5c65159f2895379e11ca13f62feabe93278985d ath11k: driver for Qualcomm IEEE 802.11ax devices
:::::: TO: Kalle Valo <kvalo@codeaurora.org>
:::::: CC: Kalle Valo <kvalo@codeaurora.org>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 9+ messages in thread
* drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
@ 2022-05-04 19:28 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2022-05-04 19:28 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 10031 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Anilkumar Kolli <akolli@codeaurora.org>
CC: Kalle Valo <kvalo@codeaurora.org>
CC: Jouni Malinen <jouni@codeaurora.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 107c948d1d3e61d10aee9d0f7c3d81bbee9842af
commit: 336e7b53c82fc74d261024773a0fab43623a94fb ath11k: clean up BDF download functions
date: 7 months ago
:::::: branch date: 21 hours ago
:::::: commit date: 7 months ago
config: i386-randconfig-m021-20220502 (https://download.01.org/0day-ci/archive/20220505/202205050335.jiOxLS8m-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
vim +/ret +2031 drivers/net/wireless/ath/ath11k/qmi.c
d5c65159f289537 Kalle Valo 2019-11-23 1919
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1920 static int ath11k_qmi_load_file_target_mem(struct ath11k_base *ab,
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1921 const u8 *data, u32 len, u8 type)
d5c65159f289537 Kalle Valo 2019-11-23 1922 {
d5c65159f289537 Kalle Valo 2019-11-23 1923 struct qmi_wlanfw_bdf_download_req_msg_v01 *req;
d5c65159f289537 Kalle Valo 2019-11-23 1924 struct qmi_wlanfw_bdf_download_resp_msg_v01 resp;
d5c65159f289537 Kalle Valo 2019-11-23 1925 struct qmi_txn txn = {};
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1926 const u8 *temp = data;
d5c65159f289537 Kalle Valo 2019-11-23 1927 void __iomem *bdf_addr = NULL;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1928 int ret;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1929 u32 remaining = len;
d5c65159f289537 Kalle Valo 2019-11-23 1930
d5c65159f289537 Kalle Valo 2019-11-23 1931 req = kzalloc(sizeof(*req), GFP_KERNEL);
d5c65159f289537 Kalle Valo 2019-11-23 1932 if (!req)
d5c65159f289537 Kalle Valo 2019-11-23 1933 return -ENOMEM;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1934
d5c65159f289537 Kalle Valo 2019-11-23 1935 memset(&resp, 0, sizeof(resp));
d5c65159f289537 Kalle Valo 2019-11-23 1936
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1937 if (ab->bus_params.fixed_bdf_addr) {
c72aa32d6d1c04f Anilkumar Kolli 2021-09-28 1938 bdf_addr = ioremap(ab->hw_params.bdf_addr, ab->hw_params.fw.board_size);
d5c65159f289537 Kalle Valo 2019-11-23 1939 if (!bdf_addr) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1940 ath11k_warn(ab, "qmi ioremap error for bdf_addr\n");
d5c65159f289537 Kalle Valo 2019-11-23 1941 ret = -EIO;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1942 goto err_free_req;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1943 }
d5c65159f289537 Kalle Valo 2019-11-23 1944 }
d5c65159f289537 Kalle Valo 2019-11-23 1945
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1946 while (remaining) {
d5c65159f289537 Kalle Valo 2019-11-23 1947 req->valid = 1;
d5c65159f289537 Kalle Valo 2019-11-23 1948 req->file_id_valid = 1;
d5c65159f289537 Kalle Valo 2019-11-23 1949 req->file_id = ab->qmi.target.board_id;
d5c65159f289537 Kalle Valo 2019-11-23 1950 req->total_size_valid = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1951 req->total_size = remaining;
d5c65159f289537 Kalle Valo 2019-11-23 1952 req->seg_id_valid = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1953 req->data_valid = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1954 req->bdf_type = type;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1955 req->bdf_type_valid = 1;
d5c65159f289537 Kalle Valo 2019-11-23 1956 req->end_valid = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1957 req->end = 0;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1958
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1959 if (remaining > QMI_WLANFW_MAX_DATA_SIZE_V01) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1960 req->data_len = QMI_WLANFW_MAX_DATA_SIZE_V01;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1961 } else {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1962 req->data_len = remaining;
d5c65159f289537 Kalle Valo 2019-11-23 1963 req->end = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1964 }
d5c65159f289537 Kalle Valo 2019-11-23 1965
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1966 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1967 req->data_valid = 0;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1968 req->end = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1969 req->data_len = ATH11K_QMI_MAX_BDF_FILE_NAME_SIZE;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1970 } else {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1971 memcpy(req->data, temp, req->data_len);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1972 }
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1973
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1974 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1975 if (type == ATH11K_QMI_FILE_TYPE_CALDATA)
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1976 bdf_addr += ab->hw_params.fw.cal_offset;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1977
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1978 memcpy_toio(bdf_addr, temp, len);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1979 }
d5c65159f289537 Kalle Valo 2019-11-23 1980
d5c65159f289537 Kalle Valo 2019-11-23 1981 ret = qmi_txn_init(&ab->qmi.handle, &txn,
d5c65159f289537 Kalle Valo 2019-11-23 1982 qmi_wlanfw_bdf_download_resp_msg_v01_ei,
d5c65159f289537 Kalle Valo 2019-11-23 1983 &resp);
d5c65159f289537 Kalle Valo 2019-11-23 1984 if (ret < 0)
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1985 goto err_iounmap;
d5c65159f289537 Kalle Valo 2019-11-23 1986
bf458d79cfc46f7 Kalle Valo 2021-02-22 1987 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download req fixed addr type %d\n",
bf458d79cfc46f7 Kalle Valo 2021-02-22 1988 type);
bf458d79cfc46f7 Kalle Valo 2021-02-22 1989
d5c65159f289537 Kalle Valo 2019-11-23 1990 ret = qmi_send_request(&ab->qmi.handle, NULL, &txn,
d5c65159f289537 Kalle Valo 2019-11-23 1991 QMI_WLANFW_BDF_DOWNLOAD_REQ_V01,
d5c65159f289537 Kalle Valo 2019-11-23 1992 QMI_WLANFW_BDF_DOWNLOAD_REQ_MSG_V01_MAX_LEN,
d5c65159f289537 Kalle Valo 2019-11-23 1993 qmi_wlanfw_bdf_download_req_msg_v01_ei, req);
d5c65159f289537 Kalle Valo 2019-11-23 1994 if (ret < 0) {
d5c65159f289537 Kalle Valo 2019-11-23 1995 qmi_txn_cancel(&txn);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1996 goto err_iounmap;
d5c65159f289537 Kalle Valo 2019-11-23 1997 }
d5c65159f289537 Kalle Valo 2019-11-23 1998
d5c65159f289537 Kalle Valo 2019-11-23 1999 ret = qmi_txn_wait(&txn, msecs_to_jiffies(ATH11K_QMI_WLANFW_TIMEOUT_MS));
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2000 if (ret < 0) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2001 ath11k_warn(ab, "failed to wait board file download request: %d\n",
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2002 ret);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2003 goto err_iounmap;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2004 }
d5c65159f289537 Kalle Valo 2019-11-23 2005
d5c65159f289537 Kalle Valo 2019-11-23 2006 if (resp.resp.result != QMI_RESULT_SUCCESS_V01) {
097e9f0714555e5 Kalle Valo 2021-02-22 2007 ath11k_warn(ab, "board file download request failed: %d %d\n",
d5c65159f289537 Kalle Valo 2019-11-23 2008 resp.resp.result, resp.resp.error);
d5c65159f289537 Kalle Valo 2019-11-23 2009 ret = -EINVAL;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2010 goto err_iounmap;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2011 }
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2012
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2013 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2014 remaining = 0;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2015 } else {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2016 remaining -= req->data_len;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2017 temp += req->data_len;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2018 req->seg_id++;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2019 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download request remaining %i\n",
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2020 remaining);
d5c65159f289537 Kalle Valo 2019-11-23 2021 }
d5c65159f289537 Kalle Valo 2019-11-23 2022 }
d5c65159f289537 Kalle Valo 2019-11-23 2023
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2024 err_iounmap:
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2025 if (ab->bus_params.fixed_bdf_addr)
d5c65159f289537 Kalle Valo 2019-11-23 2026 iounmap(bdf_addr);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2027
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2028 err_free_req:
d5c65159f289537 Kalle Valo 2019-11-23 2029 kfree(req);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2030
d5c65159f289537 Kalle Valo 2019-11-23 @2031 return ret;
d5c65159f289537 Kalle Valo 2019-11-23 2032 }
d5c65159f289537 Kalle Valo 2019-11-23 2033
:::::: The code at line 2031 was first introduced by commit
:::::: d5c65159f2895379e11ca13f62feabe93278985d ath11k: driver for Qualcomm IEEE 802.11ax devices
:::::: TO: Kalle Valo <kvalo@codeaurora.org>
:::::: CC: Kalle Valo <kvalo@codeaurora.org>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 9+ messages in thread
* drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
@ 2022-04-23 18:32 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2022-04-23 18:32 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 9918 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Anilkumar Kolli <akolli@codeaurora.org>
CC: Kalle Valo <kvalo@codeaurora.org>
CC: Jouni Malinen <jouni@codeaurora.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c00c5e1d157bec0ef0b0b59aa5482eb8dc7e8e49
commit: 336e7b53c82fc74d261024773a0fab43623a94fb ath11k: clean up BDF download functions
date: 7 months ago
:::::: branch date: 17 hours ago
:::::: commit date: 7 months ago
config: x86_64-randconfig-m001-20220418 (https://download.01.org/0day-ci/archive/20220424/202204240236.baxv7BU0-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
vim +/ret +2031 drivers/net/wireless/ath/ath11k/qmi.c
d5c65159f28953 Kalle Valo 2019-11-23 1919
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1920 static int ath11k_qmi_load_file_target_mem(struct ath11k_base *ab,
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1921 const u8 *data, u32 len, u8 type)
d5c65159f28953 Kalle Valo 2019-11-23 1922 {
d5c65159f28953 Kalle Valo 2019-11-23 1923 struct qmi_wlanfw_bdf_download_req_msg_v01 *req;
d5c65159f28953 Kalle Valo 2019-11-23 1924 struct qmi_wlanfw_bdf_download_resp_msg_v01 resp;
d5c65159f28953 Kalle Valo 2019-11-23 1925 struct qmi_txn txn = {};
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1926 const u8 *temp = data;
d5c65159f28953 Kalle Valo 2019-11-23 1927 void __iomem *bdf_addr = NULL;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1928 int ret;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1929 u32 remaining = len;
d5c65159f28953 Kalle Valo 2019-11-23 1930
d5c65159f28953 Kalle Valo 2019-11-23 1931 req = kzalloc(sizeof(*req), GFP_KERNEL);
d5c65159f28953 Kalle Valo 2019-11-23 1932 if (!req)
d5c65159f28953 Kalle Valo 2019-11-23 1933 return -ENOMEM;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1934
d5c65159f28953 Kalle Valo 2019-11-23 1935 memset(&resp, 0, sizeof(resp));
d5c65159f28953 Kalle Valo 2019-11-23 1936
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1937 if (ab->bus_params.fixed_bdf_addr) {
c72aa32d6d1c04 Anilkumar Kolli 2021-09-28 1938 bdf_addr = ioremap(ab->hw_params.bdf_addr, ab->hw_params.fw.board_size);
d5c65159f28953 Kalle Valo 2019-11-23 1939 if (!bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1940 ath11k_warn(ab, "qmi ioremap error for bdf_addr\n");
d5c65159f28953 Kalle Valo 2019-11-23 1941 ret = -EIO;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1942 goto err_free_req;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1943 }
d5c65159f28953 Kalle Valo 2019-11-23 1944 }
d5c65159f28953 Kalle Valo 2019-11-23 1945
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1946 while (remaining) {
d5c65159f28953 Kalle Valo 2019-11-23 1947 req->valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1948 req->file_id_valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1949 req->file_id = ab->qmi.target.board_id;
d5c65159f28953 Kalle Valo 2019-11-23 1950 req->total_size_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1951 req->total_size = remaining;
d5c65159f28953 Kalle Valo 2019-11-23 1952 req->seg_id_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1953 req->data_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1954 req->bdf_type = type;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1955 req->bdf_type_valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1956 req->end_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1957 req->end = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1958
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1959 if (remaining > QMI_WLANFW_MAX_DATA_SIZE_V01) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1960 req->data_len = QMI_WLANFW_MAX_DATA_SIZE_V01;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1961 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1962 req->data_len = remaining;
d5c65159f28953 Kalle Valo 2019-11-23 1963 req->end = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1964 }
d5c65159f28953 Kalle Valo 2019-11-23 1965
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1966 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1967 req->data_valid = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1968 req->end = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1969 req->data_len = ATH11K_QMI_MAX_BDF_FILE_NAME_SIZE;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1970 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1971 memcpy(req->data, temp, req->data_len);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1972 }
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1973
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1974 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1975 if (type == ATH11K_QMI_FILE_TYPE_CALDATA)
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1976 bdf_addr += ab->hw_params.fw.cal_offset;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1977
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1978 memcpy_toio(bdf_addr, temp, len);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1979 }
d5c65159f28953 Kalle Valo 2019-11-23 1980
d5c65159f28953 Kalle Valo 2019-11-23 1981 ret = qmi_txn_init(&ab->qmi.handle, &txn,
d5c65159f28953 Kalle Valo 2019-11-23 1982 qmi_wlanfw_bdf_download_resp_msg_v01_ei,
d5c65159f28953 Kalle Valo 2019-11-23 1983 &resp);
d5c65159f28953 Kalle Valo 2019-11-23 1984 if (ret < 0)
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1985 goto err_iounmap;
d5c65159f28953 Kalle Valo 2019-11-23 1986
bf458d79cfc46f Kalle Valo 2021-02-22 1987 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download req fixed addr type %d\n",
bf458d79cfc46f Kalle Valo 2021-02-22 1988 type);
bf458d79cfc46f Kalle Valo 2021-02-22 1989
d5c65159f28953 Kalle Valo 2019-11-23 1990 ret = qmi_send_request(&ab->qmi.handle, NULL, &txn,
d5c65159f28953 Kalle Valo 2019-11-23 1991 QMI_WLANFW_BDF_DOWNLOAD_REQ_V01,
d5c65159f28953 Kalle Valo 2019-11-23 1992 QMI_WLANFW_BDF_DOWNLOAD_REQ_MSG_V01_MAX_LEN,
d5c65159f28953 Kalle Valo 2019-11-23 1993 qmi_wlanfw_bdf_download_req_msg_v01_ei, req);
d5c65159f28953 Kalle Valo 2019-11-23 1994 if (ret < 0) {
d5c65159f28953 Kalle Valo 2019-11-23 1995 qmi_txn_cancel(&txn);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1996 goto err_iounmap;
d5c65159f28953 Kalle Valo 2019-11-23 1997 }
d5c65159f28953 Kalle Valo 2019-11-23 1998
d5c65159f28953 Kalle Valo 2019-11-23 1999 ret = qmi_txn_wait(&txn, msecs_to_jiffies(ATH11K_QMI_WLANFW_TIMEOUT_MS));
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2000 if (ret < 0) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2001 ath11k_warn(ab, "failed to wait board file download request: %d\n",
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2002 ret);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2003 goto err_iounmap;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2004 }
d5c65159f28953 Kalle Valo 2019-11-23 2005
d5c65159f28953 Kalle Valo 2019-11-23 2006 if (resp.resp.result != QMI_RESULT_SUCCESS_V01) {
097e9f0714555e Kalle Valo 2021-02-22 2007 ath11k_warn(ab, "board file download request failed: %d %d\n",
d5c65159f28953 Kalle Valo 2019-11-23 2008 resp.resp.result, resp.resp.error);
d5c65159f28953 Kalle Valo 2019-11-23 2009 ret = -EINVAL;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2010 goto err_iounmap;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2011 }
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2012
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2013 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2014 remaining = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2015 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2016 remaining -= req->data_len;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2017 temp += req->data_len;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2018 req->seg_id++;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2019 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download request remaining %i\n",
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2020 remaining);
d5c65159f28953 Kalle Valo 2019-11-23 2021 }
d5c65159f28953 Kalle Valo 2019-11-23 2022 }
d5c65159f28953 Kalle Valo 2019-11-23 2023
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2024 err_iounmap:
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2025 if (ab->bus_params.fixed_bdf_addr)
d5c65159f28953 Kalle Valo 2019-11-23 2026 iounmap(bdf_addr);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2027
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2028 err_free_req:
d5c65159f28953 Kalle Valo 2019-11-23 2029 kfree(req);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2030
d5c65159f28953 Kalle Valo 2019-11-23 @2031 return ret;
d5c65159f28953 Kalle Valo 2019-11-23 2032 }
d5c65159f28953 Kalle Valo 2019-11-23 2033
:::::: The code at line 2031 was first introduced by commit
:::::: d5c65159f2895379e11ca13f62feabe93278985d ath11k: driver for Qualcomm IEEE 802.11ax devices
:::::: TO: Kalle Valo <kvalo@codeaurora.org>
:::::: CC: Kalle Valo <kvalo@codeaurora.org>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 9+ messages in thread
* drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
@ 2022-04-22 13:23 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2022-04-22 13:23 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 9918 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Anilkumar Kolli <akolli@codeaurora.org>
CC: Kalle Valo <kvalo@codeaurora.org>
CC: Jouni Malinen <jouni@codeaurora.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d569e86915b7f2f9795588591c8d5ea0b66481cb
commit: 336e7b53c82fc74d261024773a0fab43623a94fb ath11k: clean up BDF download functions
date: 7 months ago
:::::: branch date: 10 hours ago
:::::: commit date: 7 months ago
config: x86_64-randconfig-m001-20220418 (https://download.01.org/0day-ci/archive/20220422/202204222152.12xKevFw-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
vim +/ret +2031 drivers/net/wireless/ath/ath11k/qmi.c
d5c65159f28953 Kalle Valo 2019-11-23 1919
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1920 static int ath11k_qmi_load_file_target_mem(struct ath11k_base *ab,
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1921 const u8 *data, u32 len, u8 type)
d5c65159f28953 Kalle Valo 2019-11-23 1922 {
d5c65159f28953 Kalle Valo 2019-11-23 1923 struct qmi_wlanfw_bdf_download_req_msg_v01 *req;
d5c65159f28953 Kalle Valo 2019-11-23 1924 struct qmi_wlanfw_bdf_download_resp_msg_v01 resp;
d5c65159f28953 Kalle Valo 2019-11-23 1925 struct qmi_txn txn = {};
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1926 const u8 *temp = data;
d5c65159f28953 Kalle Valo 2019-11-23 1927 void __iomem *bdf_addr = NULL;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1928 int ret;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1929 u32 remaining = len;
d5c65159f28953 Kalle Valo 2019-11-23 1930
d5c65159f28953 Kalle Valo 2019-11-23 1931 req = kzalloc(sizeof(*req), GFP_KERNEL);
d5c65159f28953 Kalle Valo 2019-11-23 1932 if (!req)
d5c65159f28953 Kalle Valo 2019-11-23 1933 return -ENOMEM;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1934
d5c65159f28953 Kalle Valo 2019-11-23 1935 memset(&resp, 0, sizeof(resp));
d5c65159f28953 Kalle Valo 2019-11-23 1936
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1937 if (ab->bus_params.fixed_bdf_addr) {
c72aa32d6d1c04 Anilkumar Kolli 2021-09-28 1938 bdf_addr = ioremap(ab->hw_params.bdf_addr, ab->hw_params.fw.board_size);
d5c65159f28953 Kalle Valo 2019-11-23 1939 if (!bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1940 ath11k_warn(ab, "qmi ioremap error for bdf_addr\n");
d5c65159f28953 Kalle Valo 2019-11-23 1941 ret = -EIO;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1942 goto err_free_req;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1943 }
d5c65159f28953 Kalle Valo 2019-11-23 1944 }
d5c65159f28953 Kalle Valo 2019-11-23 1945
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1946 while (remaining) {
d5c65159f28953 Kalle Valo 2019-11-23 1947 req->valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1948 req->file_id_valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1949 req->file_id = ab->qmi.target.board_id;
d5c65159f28953 Kalle Valo 2019-11-23 1950 req->total_size_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1951 req->total_size = remaining;
d5c65159f28953 Kalle Valo 2019-11-23 1952 req->seg_id_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1953 req->data_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1954 req->bdf_type = type;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1955 req->bdf_type_valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1956 req->end_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1957 req->end = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1958
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1959 if (remaining > QMI_WLANFW_MAX_DATA_SIZE_V01) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1960 req->data_len = QMI_WLANFW_MAX_DATA_SIZE_V01;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1961 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1962 req->data_len = remaining;
d5c65159f28953 Kalle Valo 2019-11-23 1963 req->end = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1964 }
d5c65159f28953 Kalle Valo 2019-11-23 1965
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1966 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1967 req->data_valid = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1968 req->end = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1969 req->data_len = ATH11K_QMI_MAX_BDF_FILE_NAME_SIZE;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1970 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1971 memcpy(req->data, temp, req->data_len);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1972 }
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1973
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1974 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1975 if (type == ATH11K_QMI_FILE_TYPE_CALDATA)
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1976 bdf_addr += ab->hw_params.fw.cal_offset;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1977
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1978 memcpy_toio(bdf_addr, temp, len);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1979 }
d5c65159f28953 Kalle Valo 2019-11-23 1980
d5c65159f28953 Kalle Valo 2019-11-23 1981 ret = qmi_txn_init(&ab->qmi.handle, &txn,
d5c65159f28953 Kalle Valo 2019-11-23 1982 qmi_wlanfw_bdf_download_resp_msg_v01_ei,
d5c65159f28953 Kalle Valo 2019-11-23 1983 &resp);
d5c65159f28953 Kalle Valo 2019-11-23 1984 if (ret < 0)
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1985 goto err_iounmap;
d5c65159f28953 Kalle Valo 2019-11-23 1986
bf458d79cfc46f Kalle Valo 2021-02-22 1987 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download req fixed addr type %d\n",
bf458d79cfc46f Kalle Valo 2021-02-22 1988 type);
bf458d79cfc46f Kalle Valo 2021-02-22 1989
d5c65159f28953 Kalle Valo 2019-11-23 1990 ret = qmi_send_request(&ab->qmi.handle, NULL, &txn,
d5c65159f28953 Kalle Valo 2019-11-23 1991 QMI_WLANFW_BDF_DOWNLOAD_REQ_V01,
d5c65159f28953 Kalle Valo 2019-11-23 1992 QMI_WLANFW_BDF_DOWNLOAD_REQ_MSG_V01_MAX_LEN,
d5c65159f28953 Kalle Valo 2019-11-23 1993 qmi_wlanfw_bdf_download_req_msg_v01_ei, req);
d5c65159f28953 Kalle Valo 2019-11-23 1994 if (ret < 0) {
d5c65159f28953 Kalle Valo 2019-11-23 1995 qmi_txn_cancel(&txn);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1996 goto err_iounmap;
d5c65159f28953 Kalle Valo 2019-11-23 1997 }
d5c65159f28953 Kalle Valo 2019-11-23 1998
d5c65159f28953 Kalle Valo 2019-11-23 1999 ret = qmi_txn_wait(&txn, msecs_to_jiffies(ATH11K_QMI_WLANFW_TIMEOUT_MS));
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2000 if (ret < 0) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2001 ath11k_warn(ab, "failed to wait board file download request: %d\n",
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2002 ret);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2003 goto err_iounmap;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2004 }
d5c65159f28953 Kalle Valo 2019-11-23 2005
d5c65159f28953 Kalle Valo 2019-11-23 2006 if (resp.resp.result != QMI_RESULT_SUCCESS_V01) {
097e9f0714555e Kalle Valo 2021-02-22 2007 ath11k_warn(ab, "board file download request failed: %d %d\n",
d5c65159f28953 Kalle Valo 2019-11-23 2008 resp.resp.result, resp.resp.error);
d5c65159f28953 Kalle Valo 2019-11-23 2009 ret = -EINVAL;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2010 goto err_iounmap;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2011 }
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2012
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2013 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2014 remaining = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2015 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2016 remaining -= req->data_len;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2017 temp += req->data_len;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2018 req->seg_id++;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2019 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download request remaining %i\n",
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2020 remaining);
d5c65159f28953 Kalle Valo 2019-11-23 2021 }
d5c65159f28953 Kalle Valo 2019-11-23 2022 }
d5c65159f28953 Kalle Valo 2019-11-23 2023
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2024 err_iounmap:
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2025 if (ab->bus_params.fixed_bdf_addr)
d5c65159f28953 Kalle Valo 2019-11-23 2026 iounmap(bdf_addr);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2027
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2028 err_free_req:
d5c65159f28953 Kalle Valo 2019-11-23 2029 kfree(req);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2030
d5c65159f28953 Kalle Valo 2019-11-23 @2031 return ret;
d5c65159f28953 Kalle Valo 2019-11-23 2032 }
d5c65159f28953 Kalle Valo 2019-11-23 2033
:::::: The code at line 2031 was first introduced by commit
:::::: d5c65159f2895379e11ca13f62feabe93278985d ath11k: driver for Qualcomm IEEE 802.11ax devices
:::::: TO: Kalle Valo <kvalo@codeaurora.org>
:::::: CC: Kalle Valo <kvalo@codeaurora.org>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 9+ messages in thread
* drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
@ 2022-04-21 7:28 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2022-04-21 7:28 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 10033 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Anilkumar Kolli <akolli@codeaurora.org>
CC: Kalle Valo <kvalo@codeaurora.org>
CC: Jouni Malinen <jouni@codeaurora.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b253435746d9a4a701b5f09211b9c14d3370d0da
commit: 336e7b53c82fc74d261024773a0fab43623a94fb ath11k: clean up BDF download functions
date: 7 months ago
:::::: branch date: 12 hours ago
:::::: commit date: 7 months ago
config: x86_64-randconfig-m001-20220418 (https://download.01.org/0day-ci/archive/20220421/202204211519.wpw4Zz0V-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
vim +/ret +2031 drivers/net/wireless/ath/ath11k/qmi.c
d5c65159f289537 Kalle Valo 2019-11-23 1919
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1920 static int ath11k_qmi_load_file_target_mem(struct ath11k_base *ab,
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1921 const u8 *data, u32 len, u8 type)
d5c65159f289537 Kalle Valo 2019-11-23 1922 {
d5c65159f289537 Kalle Valo 2019-11-23 1923 struct qmi_wlanfw_bdf_download_req_msg_v01 *req;
d5c65159f289537 Kalle Valo 2019-11-23 1924 struct qmi_wlanfw_bdf_download_resp_msg_v01 resp;
d5c65159f289537 Kalle Valo 2019-11-23 1925 struct qmi_txn txn = {};
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1926 const u8 *temp = data;
d5c65159f289537 Kalle Valo 2019-11-23 1927 void __iomem *bdf_addr = NULL;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1928 int ret;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1929 u32 remaining = len;
d5c65159f289537 Kalle Valo 2019-11-23 1930
d5c65159f289537 Kalle Valo 2019-11-23 1931 req = kzalloc(sizeof(*req), GFP_KERNEL);
d5c65159f289537 Kalle Valo 2019-11-23 1932 if (!req)
d5c65159f289537 Kalle Valo 2019-11-23 1933 return -ENOMEM;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1934
d5c65159f289537 Kalle Valo 2019-11-23 1935 memset(&resp, 0, sizeof(resp));
d5c65159f289537 Kalle Valo 2019-11-23 1936
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1937 if (ab->bus_params.fixed_bdf_addr) {
c72aa32d6d1c04f Anilkumar Kolli 2021-09-28 1938 bdf_addr = ioremap(ab->hw_params.bdf_addr, ab->hw_params.fw.board_size);
d5c65159f289537 Kalle Valo 2019-11-23 1939 if (!bdf_addr) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1940 ath11k_warn(ab, "qmi ioremap error for bdf_addr\n");
d5c65159f289537 Kalle Valo 2019-11-23 1941 ret = -EIO;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1942 goto err_free_req;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1943 }
d5c65159f289537 Kalle Valo 2019-11-23 1944 }
d5c65159f289537 Kalle Valo 2019-11-23 1945
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1946 while (remaining) {
d5c65159f289537 Kalle Valo 2019-11-23 1947 req->valid = 1;
d5c65159f289537 Kalle Valo 2019-11-23 1948 req->file_id_valid = 1;
d5c65159f289537 Kalle Valo 2019-11-23 1949 req->file_id = ab->qmi.target.board_id;
d5c65159f289537 Kalle Valo 2019-11-23 1950 req->total_size_valid = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1951 req->total_size = remaining;
d5c65159f289537 Kalle Valo 2019-11-23 1952 req->seg_id_valid = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1953 req->data_valid = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1954 req->bdf_type = type;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1955 req->bdf_type_valid = 1;
d5c65159f289537 Kalle Valo 2019-11-23 1956 req->end_valid = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1957 req->end = 0;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1958
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1959 if (remaining > QMI_WLANFW_MAX_DATA_SIZE_V01) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1960 req->data_len = QMI_WLANFW_MAX_DATA_SIZE_V01;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1961 } else {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1962 req->data_len = remaining;
d5c65159f289537 Kalle Valo 2019-11-23 1963 req->end = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1964 }
d5c65159f289537 Kalle Valo 2019-11-23 1965
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1966 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1967 req->data_valid = 0;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1968 req->end = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1969 req->data_len = ATH11K_QMI_MAX_BDF_FILE_NAME_SIZE;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1970 } else {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1971 memcpy(req->data, temp, req->data_len);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1972 }
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1973
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1974 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1975 if (type == ATH11K_QMI_FILE_TYPE_CALDATA)
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1976 bdf_addr += ab->hw_params.fw.cal_offset;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1977
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1978 memcpy_toio(bdf_addr, temp, len);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1979 }
d5c65159f289537 Kalle Valo 2019-11-23 1980
d5c65159f289537 Kalle Valo 2019-11-23 1981 ret = qmi_txn_init(&ab->qmi.handle, &txn,
d5c65159f289537 Kalle Valo 2019-11-23 1982 qmi_wlanfw_bdf_download_resp_msg_v01_ei,
d5c65159f289537 Kalle Valo 2019-11-23 1983 &resp);
d5c65159f289537 Kalle Valo 2019-11-23 1984 if (ret < 0)
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1985 goto err_iounmap;
d5c65159f289537 Kalle Valo 2019-11-23 1986
bf458d79cfc46f7 Kalle Valo 2021-02-22 1987 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download req fixed addr type %d\n",
bf458d79cfc46f7 Kalle Valo 2021-02-22 1988 type);
bf458d79cfc46f7 Kalle Valo 2021-02-22 1989
d5c65159f289537 Kalle Valo 2019-11-23 1990 ret = qmi_send_request(&ab->qmi.handle, NULL, &txn,
d5c65159f289537 Kalle Valo 2019-11-23 1991 QMI_WLANFW_BDF_DOWNLOAD_REQ_V01,
d5c65159f289537 Kalle Valo 2019-11-23 1992 QMI_WLANFW_BDF_DOWNLOAD_REQ_MSG_V01_MAX_LEN,
d5c65159f289537 Kalle Valo 2019-11-23 1993 qmi_wlanfw_bdf_download_req_msg_v01_ei, req);
d5c65159f289537 Kalle Valo 2019-11-23 1994 if (ret < 0) {
d5c65159f289537 Kalle Valo 2019-11-23 1995 qmi_txn_cancel(&txn);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1996 goto err_iounmap;
d5c65159f289537 Kalle Valo 2019-11-23 1997 }
d5c65159f289537 Kalle Valo 2019-11-23 1998
d5c65159f289537 Kalle Valo 2019-11-23 1999 ret = qmi_txn_wait(&txn, msecs_to_jiffies(ATH11K_QMI_WLANFW_TIMEOUT_MS));
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2000 if (ret < 0) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2001 ath11k_warn(ab, "failed to wait board file download request: %d\n",
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2002 ret);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2003 goto err_iounmap;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2004 }
d5c65159f289537 Kalle Valo 2019-11-23 2005
d5c65159f289537 Kalle Valo 2019-11-23 2006 if (resp.resp.result != QMI_RESULT_SUCCESS_V01) {
097e9f0714555e5 Kalle Valo 2021-02-22 2007 ath11k_warn(ab, "board file download request failed: %d %d\n",
d5c65159f289537 Kalle Valo 2019-11-23 2008 resp.resp.result, resp.resp.error);
d5c65159f289537 Kalle Valo 2019-11-23 2009 ret = -EINVAL;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2010 goto err_iounmap;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2011 }
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2012
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2013 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2014 remaining = 0;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2015 } else {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2016 remaining -= req->data_len;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2017 temp += req->data_len;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2018 req->seg_id++;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2019 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download request remaining %i\n",
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2020 remaining);
d5c65159f289537 Kalle Valo 2019-11-23 2021 }
d5c65159f289537 Kalle Valo 2019-11-23 2022 }
d5c65159f289537 Kalle Valo 2019-11-23 2023
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2024 err_iounmap:
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2025 if (ab->bus_params.fixed_bdf_addr)
d5c65159f289537 Kalle Valo 2019-11-23 2026 iounmap(bdf_addr);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2027
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2028 err_free_req:
d5c65159f289537 Kalle Valo 2019-11-23 2029 kfree(req);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2030
d5c65159f289537 Kalle Valo 2019-11-23 @2031 return ret;
d5c65159f289537 Kalle Valo 2019-11-23 2032 }
d5c65159f289537 Kalle Valo 2019-11-23 2033
:::::: The code at line 2031 was first introduced by commit
:::::: d5c65159f2895379e11ca13f62feabe93278985d ath11k: driver for Qualcomm IEEE 802.11ax devices
:::::: TO: Kalle Valo <kvalo@codeaurora.org>
:::::: CC: Kalle Valo <kvalo@codeaurora.org>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 9+ messages in thread
* drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
@ 2022-04-18 13:37 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2022-04-18 13:37 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 9918 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Anilkumar Kolli <akolli@codeaurora.org>
CC: Kalle Valo <kvalo@codeaurora.org>
CC: Jouni Malinen <jouni@codeaurora.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b2d229d4ddb17db541098b83524d901257e93845
commit: 336e7b53c82fc74d261024773a0fab43623a94fb ath11k: clean up BDF download functions
date: 7 months ago
:::::: branch date: 17 hours ago
:::::: commit date: 7 months ago
config: x86_64-randconfig-m001-20220418 (https://download.01.org/0day-ci/archive/20220418/202204182123.fRP4p1Si-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
vim +/ret +2031 drivers/net/wireless/ath/ath11k/qmi.c
d5c65159f28953 Kalle Valo 2019-11-23 1919
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1920 static int ath11k_qmi_load_file_target_mem(struct ath11k_base *ab,
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1921 const u8 *data, u32 len, u8 type)
d5c65159f28953 Kalle Valo 2019-11-23 1922 {
d5c65159f28953 Kalle Valo 2019-11-23 1923 struct qmi_wlanfw_bdf_download_req_msg_v01 *req;
d5c65159f28953 Kalle Valo 2019-11-23 1924 struct qmi_wlanfw_bdf_download_resp_msg_v01 resp;
d5c65159f28953 Kalle Valo 2019-11-23 1925 struct qmi_txn txn = {};
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1926 const u8 *temp = data;
d5c65159f28953 Kalle Valo 2019-11-23 1927 void __iomem *bdf_addr = NULL;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1928 int ret;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1929 u32 remaining = len;
d5c65159f28953 Kalle Valo 2019-11-23 1930
d5c65159f28953 Kalle Valo 2019-11-23 1931 req = kzalloc(sizeof(*req), GFP_KERNEL);
d5c65159f28953 Kalle Valo 2019-11-23 1932 if (!req)
d5c65159f28953 Kalle Valo 2019-11-23 1933 return -ENOMEM;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1934
d5c65159f28953 Kalle Valo 2019-11-23 1935 memset(&resp, 0, sizeof(resp));
d5c65159f28953 Kalle Valo 2019-11-23 1936
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1937 if (ab->bus_params.fixed_bdf_addr) {
c72aa32d6d1c04 Anilkumar Kolli 2021-09-28 1938 bdf_addr = ioremap(ab->hw_params.bdf_addr, ab->hw_params.fw.board_size);
d5c65159f28953 Kalle Valo 2019-11-23 1939 if (!bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1940 ath11k_warn(ab, "qmi ioremap error for bdf_addr\n");
d5c65159f28953 Kalle Valo 2019-11-23 1941 ret = -EIO;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1942 goto err_free_req;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1943 }
d5c65159f28953 Kalle Valo 2019-11-23 1944 }
d5c65159f28953 Kalle Valo 2019-11-23 1945
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1946 while (remaining) {
d5c65159f28953 Kalle Valo 2019-11-23 1947 req->valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1948 req->file_id_valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1949 req->file_id = ab->qmi.target.board_id;
d5c65159f28953 Kalle Valo 2019-11-23 1950 req->total_size_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1951 req->total_size = remaining;
d5c65159f28953 Kalle Valo 2019-11-23 1952 req->seg_id_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1953 req->data_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1954 req->bdf_type = type;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1955 req->bdf_type_valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1956 req->end_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1957 req->end = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1958
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1959 if (remaining > QMI_WLANFW_MAX_DATA_SIZE_V01) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1960 req->data_len = QMI_WLANFW_MAX_DATA_SIZE_V01;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1961 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1962 req->data_len = remaining;
d5c65159f28953 Kalle Valo 2019-11-23 1963 req->end = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1964 }
d5c65159f28953 Kalle Valo 2019-11-23 1965
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1966 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1967 req->data_valid = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1968 req->end = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1969 req->data_len = ATH11K_QMI_MAX_BDF_FILE_NAME_SIZE;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1970 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1971 memcpy(req->data, temp, req->data_len);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1972 }
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1973
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1974 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1975 if (type == ATH11K_QMI_FILE_TYPE_CALDATA)
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1976 bdf_addr += ab->hw_params.fw.cal_offset;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1977
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1978 memcpy_toio(bdf_addr, temp, len);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1979 }
d5c65159f28953 Kalle Valo 2019-11-23 1980
d5c65159f28953 Kalle Valo 2019-11-23 1981 ret = qmi_txn_init(&ab->qmi.handle, &txn,
d5c65159f28953 Kalle Valo 2019-11-23 1982 qmi_wlanfw_bdf_download_resp_msg_v01_ei,
d5c65159f28953 Kalle Valo 2019-11-23 1983 &resp);
d5c65159f28953 Kalle Valo 2019-11-23 1984 if (ret < 0)
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1985 goto err_iounmap;
d5c65159f28953 Kalle Valo 2019-11-23 1986
bf458d79cfc46f Kalle Valo 2021-02-22 1987 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download req fixed addr type %d\n",
bf458d79cfc46f Kalle Valo 2021-02-22 1988 type);
bf458d79cfc46f Kalle Valo 2021-02-22 1989
d5c65159f28953 Kalle Valo 2019-11-23 1990 ret = qmi_send_request(&ab->qmi.handle, NULL, &txn,
d5c65159f28953 Kalle Valo 2019-11-23 1991 QMI_WLANFW_BDF_DOWNLOAD_REQ_V01,
d5c65159f28953 Kalle Valo 2019-11-23 1992 QMI_WLANFW_BDF_DOWNLOAD_REQ_MSG_V01_MAX_LEN,
d5c65159f28953 Kalle Valo 2019-11-23 1993 qmi_wlanfw_bdf_download_req_msg_v01_ei, req);
d5c65159f28953 Kalle Valo 2019-11-23 1994 if (ret < 0) {
d5c65159f28953 Kalle Valo 2019-11-23 1995 qmi_txn_cancel(&txn);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1996 goto err_iounmap;
d5c65159f28953 Kalle Valo 2019-11-23 1997 }
d5c65159f28953 Kalle Valo 2019-11-23 1998
d5c65159f28953 Kalle Valo 2019-11-23 1999 ret = qmi_txn_wait(&txn, msecs_to_jiffies(ATH11K_QMI_WLANFW_TIMEOUT_MS));
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2000 if (ret < 0) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2001 ath11k_warn(ab, "failed to wait board file download request: %d\n",
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2002 ret);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2003 goto err_iounmap;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2004 }
d5c65159f28953 Kalle Valo 2019-11-23 2005
d5c65159f28953 Kalle Valo 2019-11-23 2006 if (resp.resp.result != QMI_RESULT_SUCCESS_V01) {
097e9f0714555e Kalle Valo 2021-02-22 2007 ath11k_warn(ab, "board file download request failed: %d %d\n",
d5c65159f28953 Kalle Valo 2019-11-23 2008 resp.resp.result, resp.resp.error);
d5c65159f28953 Kalle Valo 2019-11-23 2009 ret = -EINVAL;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2010 goto err_iounmap;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2011 }
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2012
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2013 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2014 remaining = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2015 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2016 remaining -= req->data_len;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2017 temp += req->data_len;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2018 req->seg_id++;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2019 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download request remaining %i\n",
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2020 remaining);
d5c65159f28953 Kalle Valo 2019-11-23 2021 }
d5c65159f28953 Kalle Valo 2019-11-23 2022 }
d5c65159f28953 Kalle Valo 2019-11-23 2023
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2024 err_iounmap:
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2025 if (ab->bus_params.fixed_bdf_addr)
d5c65159f28953 Kalle Valo 2019-11-23 2026 iounmap(bdf_addr);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2027
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2028 err_free_req:
d5c65159f28953 Kalle Valo 2019-11-23 2029 kfree(req);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2030
d5c65159f28953 Kalle Valo 2019-11-23 @2031 return ret;
d5c65159f28953 Kalle Valo 2019-11-23 2032 }
d5c65159f28953 Kalle Valo 2019-11-23 2033
:::::: The code at line 2031 was first introduced by commit
:::::: d5c65159f2895379e11ca13f62feabe93278985d ath11k: driver for Qualcomm IEEE 802.11ax devices
:::::: TO: Kalle Valo <kvalo@codeaurora.org>
:::::: CC: Kalle Valo <kvalo@codeaurora.org>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 9+ messages in thread
* drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
@ 2022-01-27 7:51 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2022-01-27 7:51 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 10077 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Anilkumar Kolli <akolli@codeaurora.org>
CC: Kalle Valo <kvalo@codeaurora.org>
CC: Jouni Malinen <jouni@codeaurora.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0280e3c58f92b2fe0e8fbbdf8d386449168de4a8
commit: 336e7b53c82fc74d261024773a0fab43623a94fb ath11k: clean up BDF download functions
date: 4 months ago
:::::: branch date: 2 days ago
:::::: commit date: 4 months ago
config: microblaze-randconfig-m031-20220127 (https://download.01.org/0day-ci/archive/20220127/202201271555.orgxsjdC-lkp(a)intel.com/config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
vim +/ret +2031 drivers/net/wireless/ath/ath11k/qmi.c
d5c65159f289537 Kalle Valo 2019-11-23 1919
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1920 static int ath11k_qmi_load_file_target_mem(struct ath11k_base *ab,
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1921 const u8 *data, u32 len, u8 type)
d5c65159f289537 Kalle Valo 2019-11-23 1922 {
d5c65159f289537 Kalle Valo 2019-11-23 1923 struct qmi_wlanfw_bdf_download_req_msg_v01 *req;
d5c65159f289537 Kalle Valo 2019-11-23 1924 struct qmi_wlanfw_bdf_download_resp_msg_v01 resp;
d5c65159f289537 Kalle Valo 2019-11-23 1925 struct qmi_txn txn = {};
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1926 const u8 *temp = data;
d5c65159f289537 Kalle Valo 2019-11-23 1927 void __iomem *bdf_addr = NULL;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1928 int ret;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1929 u32 remaining = len;
d5c65159f289537 Kalle Valo 2019-11-23 1930
d5c65159f289537 Kalle Valo 2019-11-23 1931 req = kzalloc(sizeof(*req), GFP_KERNEL);
d5c65159f289537 Kalle Valo 2019-11-23 1932 if (!req)
d5c65159f289537 Kalle Valo 2019-11-23 1933 return -ENOMEM;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1934
d5c65159f289537 Kalle Valo 2019-11-23 1935 memset(&resp, 0, sizeof(resp));
d5c65159f289537 Kalle Valo 2019-11-23 1936
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1937 if (ab->bus_params.fixed_bdf_addr) {
c72aa32d6d1c04f Anilkumar Kolli 2021-09-28 1938 bdf_addr = ioremap(ab->hw_params.bdf_addr, ab->hw_params.fw.board_size);
d5c65159f289537 Kalle Valo 2019-11-23 1939 if (!bdf_addr) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1940 ath11k_warn(ab, "qmi ioremap error for bdf_addr\n");
d5c65159f289537 Kalle Valo 2019-11-23 1941 ret = -EIO;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1942 goto err_free_req;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1943 }
d5c65159f289537 Kalle Valo 2019-11-23 1944 }
d5c65159f289537 Kalle Valo 2019-11-23 1945
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1946 while (remaining) {
d5c65159f289537 Kalle Valo 2019-11-23 1947 req->valid = 1;
d5c65159f289537 Kalle Valo 2019-11-23 1948 req->file_id_valid = 1;
d5c65159f289537 Kalle Valo 2019-11-23 1949 req->file_id = ab->qmi.target.board_id;
d5c65159f289537 Kalle Valo 2019-11-23 1950 req->total_size_valid = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1951 req->total_size = remaining;
d5c65159f289537 Kalle Valo 2019-11-23 1952 req->seg_id_valid = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1953 req->data_valid = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1954 req->bdf_type = type;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1955 req->bdf_type_valid = 1;
d5c65159f289537 Kalle Valo 2019-11-23 1956 req->end_valid = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1957 req->end = 0;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1958
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1959 if (remaining > QMI_WLANFW_MAX_DATA_SIZE_V01) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1960 req->data_len = QMI_WLANFW_MAX_DATA_SIZE_V01;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1961 } else {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1962 req->data_len = remaining;
d5c65159f289537 Kalle Valo 2019-11-23 1963 req->end = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1964 }
d5c65159f289537 Kalle Valo 2019-11-23 1965
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1966 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1967 req->data_valid = 0;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1968 req->end = 1;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1969 req->data_len = ATH11K_QMI_MAX_BDF_FILE_NAME_SIZE;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1970 } else {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1971 memcpy(req->data, temp, req->data_len);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1972 }
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1973
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1974 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1975 if (type == ATH11K_QMI_FILE_TYPE_CALDATA)
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1976 bdf_addr += ab->hw_params.fw.cal_offset;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1977
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1978 memcpy_toio(bdf_addr, temp, len);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1979 }
d5c65159f289537 Kalle Valo 2019-11-23 1980
d5c65159f289537 Kalle Valo 2019-11-23 1981 ret = qmi_txn_init(&ab->qmi.handle, &txn,
d5c65159f289537 Kalle Valo 2019-11-23 1982 qmi_wlanfw_bdf_download_resp_msg_v01_ei,
d5c65159f289537 Kalle Valo 2019-11-23 1983 &resp);
d5c65159f289537 Kalle Valo 2019-11-23 1984 if (ret < 0)
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1985 goto err_iounmap;
d5c65159f289537 Kalle Valo 2019-11-23 1986
bf458d79cfc46f7 Kalle Valo 2021-02-22 1987 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download req fixed addr type %d\n",
bf458d79cfc46f7 Kalle Valo 2021-02-22 1988 type);
bf458d79cfc46f7 Kalle Valo 2021-02-22 1989
d5c65159f289537 Kalle Valo 2019-11-23 1990 ret = qmi_send_request(&ab->qmi.handle, NULL, &txn,
d5c65159f289537 Kalle Valo 2019-11-23 1991 QMI_WLANFW_BDF_DOWNLOAD_REQ_V01,
d5c65159f289537 Kalle Valo 2019-11-23 1992 QMI_WLANFW_BDF_DOWNLOAD_REQ_MSG_V01_MAX_LEN,
d5c65159f289537 Kalle Valo 2019-11-23 1993 qmi_wlanfw_bdf_download_req_msg_v01_ei, req);
d5c65159f289537 Kalle Valo 2019-11-23 1994 if (ret < 0) {
d5c65159f289537 Kalle Valo 2019-11-23 1995 qmi_txn_cancel(&txn);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 1996 goto err_iounmap;
d5c65159f289537 Kalle Valo 2019-11-23 1997 }
d5c65159f289537 Kalle Valo 2019-11-23 1998
d5c65159f289537 Kalle Valo 2019-11-23 1999 ret = qmi_txn_wait(&txn, msecs_to_jiffies(ATH11K_QMI_WLANFW_TIMEOUT_MS));
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2000 if (ret < 0) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2001 ath11k_warn(ab, "failed to wait board file download request: %d\n",
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2002 ret);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2003 goto err_iounmap;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2004 }
d5c65159f289537 Kalle Valo 2019-11-23 2005
d5c65159f289537 Kalle Valo 2019-11-23 2006 if (resp.resp.result != QMI_RESULT_SUCCESS_V01) {
097e9f0714555e5 Kalle Valo 2021-02-22 2007 ath11k_warn(ab, "board file download request failed: %d %d\n",
d5c65159f289537 Kalle Valo 2019-11-23 2008 resp.resp.result, resp.resp.error);
d5c65159f289537 Kalle Valo 2019-11-23 2009 ret = -EINVAL;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2010 goto err_iounmap;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2011 }
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2012
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2013 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2014 remaining = 0;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2015 } else {
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2016 remaining -= req->data_len;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2017 temp += req->data_len;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2018 req->seg_id++;
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2019 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download request remaining %i\n",
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2020 remaining);
d5c65159f289537 Kalle Valo 2019-11-23 2021 }
d5c65159f289537 Kalle Valo 2019-11-23 2022 }
d5c65159f289537 Kalle Valo 2019-11-23 2023
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2024 err_iounmap:
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2025 if (ab->bus_params.fixed_bdf_addr)
d5c65159f289537 Kalle Valo 2019-11-23 2026 iounmap(bdf_addr);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2027
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2028 err_free_req:
d5c65159f289537 Kalle Valo 2019-11-23 2029 kfree(req);
336e7b53c82fc74 Anilkumar Kolli 2021-09-28 2030
d5c65159f289537 Kalle Valo 2019-11-23 @2031 return ret;
d5c65159f289537 Kalle Valo 2019-11-23 2032 }
d5c65159f289537 Kalle Valo 2019-11-23 2033
:::::: The code at line 2031 was first introduced by commit
:::::: d5c65159f2895379e11ca13f62feabe93278985d ath11k: driver for Qualcomm IEEE 802.11ax devices
:::::: TO: Kalle Valo <kvalo@codeaurora.org>
:::::: CC: Kalle Valo <kvalo@codeaurora.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 9+ messages in thread
* drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
@ 2021-11-29 1:35 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2021-11-29 1:35 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 9955 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Anilkumar Kolli <akolli@codeaurora.org>
CC: Kalle Valo <kvalo@codeaurora.org>
CC: Jouni Malinen <jouni@codeaurora.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d58071a8a76d779eedab38033ae4c821c30295a5
commit: 336e7b53c82fc74d261024773a0fab43623a94fb ath11k: clean up BDF download functions
date: 9 weeks ago
:::::: branch date: 3 hours ago
:::::: commit date: 9 weeks ago
config: arm-randconfig-m031-20211128 (https://download.01.org/0day-ci/archive/20211129/202111290925.JxpT7V2f-lkp(a)intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
vim +/ret +2031 drivers/net/wireless/ath/ath11k/qmi.c
d5c65159f28953 Kalle Valo 2019-11-23 1919
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1920 static int ath11k_qmi_load_file_target_mem(struct ath11k_base *ab,
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1921 const u8 *data, u32 len, u8 type)
d5c65159f28953 Kalle Valo 2019-11-23 1922 {
d5c65159f28953 Kalle Valo 2019-11-23 1923 struct qmi_wlanfw_bdf_download_req_msg_v01 *req;
d5c65159f28953 Kalle Valo 2019-11-23 1924 struct qmi_wlanfw_bdf_download_resp_msg_v01 resp;
d5c65159f28953 Kalle Valo 2019-11-23 1925 struct qmi_txn txn = {};
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1926 const u8 *temp = data;
d5c65159f28953 Kalle Valo 2019-11-23 1927 void __iomem *bdf_addr = NULL;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1928 int ret;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1929 u32 remaining = len;
d5c65159f28953 Kalle Valo 2019-11-23 1930
d5c65159f28953 Kalle Valo 2019-11-23 1931 req = kzalloc(sizeof(*req), GFP_KERNEL);
d5c65159f28953 Kalle Valo 2019-11-23 1932 if (!req)
d5c65159f28953 Kalle Valo 2019-11-23 1933 return -ENOMEM;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1934
d5c65159f28953 Kalle Valo 2019-11-23 1935 memset(&resp, 0, sizeof(resp));
d5c65159f28953 Kalle Valo 2019-11-23 1936
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1937 if (ab->bus_params.fixed_bdf_addr) {
c72aa32d6d1c04 Anilkumar Kolli 2021-09-28 1938 bdf_addr = ioremap(ab->hw_params.bdf_addr, ab->hw_params.fw.board_size);
d5c65159f28953 Kalle Valo 2019-11-23 1939 if (!bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1940 ath11k_warn(ab, "qmi ioremap error for bdf_addr\n");
d5c65159f28953 Kalle Valo 2019-11-23 1941 ret = -EIO;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1942 goto err_free_req;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1943 }
d5c65159f28953 Kalle Valo 2019-11-23 1944 }
d5c65159f28953 Kalle Valo 2019-11-23 1945
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1946 while (remaining) {
d5c65159f28953 Kalle Valo 2019-11-23 1947 req->valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1948 req->file_id_valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1949 req->file_id = ab->qmi.target.board_id;
d5c65159f28953 Kalle Valo 2019-11-23 1950 req->total_size_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1951 req->total_size = remaining;
d5c65159f28953 Kalle Valo 2019-11-23 1952 req->seg_id_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1953 req->data_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1954 req->bdf_type = type;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1955 req->bdf_type_valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1956 req->end_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1957 req->end = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1958
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1959 if (remaining > QMI_WLANFW_MAX_DATA_SIZE_V01) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1960 req->data_len = QMI_WLANFW_MAX_DATA_SIZE_V01;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1961 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1962 req->data_len = remaining;
d5c65159f28953 Kalle Valo 2019-11-23 1963 req->end = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1964 }
d5c65159f28953 Kalle Valo 2019-11-23 1965
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1966 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1967 req->data_valid = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1968 req->end = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1969 req->data_len = ATH11K_QMI_MAX_BDF_FILE_NAME_SIZE;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1970 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1971 memcpy(req->data, temp, req->data_len);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1972 }
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1973
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1974 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1975 if (type == ATH11K_QMI_FILE_TYPE_CALDATA)
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1976 bdf_addr += ab->hw_params.fw.cal_offset;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1977
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1978 memcpy_toio(bdf_addr, temp, len);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1979 }
d5c65159f28953 Kalle Valo 2019-11-23 1980
d5c65159f28953 Kalle Valo 2019-11-23 1981 ret = qmi_txn_init(&ab->qmi.handle, &txn,
d5c65159f28953 Kalle Valo 2019-11-23 1982 qmi_wlanfw_bdf_download_resp_msg_v01_ei,
d5c65159f28953 Kalle Valo 2019-11-23 1983 &resp);
d5c65159f28953 Kalle Valo 2019-11-23 1984 if (ret < 0)
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1985 goto err_iounmap;
d5c65159f28953 Kalle Valo 2019-11-23 1986
bf458d79cfc46f Kalle Valo 2021-02-22 1987 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download req fixed addr type %d\n",
bf458d79cfc46f Kalle Valo 2021-02-22 1988 type);
bf458d79cfc46f Kalle Valo 2021-02-22 1989
d5c65159f28953 Kalle Valo 2019-11-23 1990 ret = qmi_send_request(&ab->qmi.handle, NULL, &txn,
d5c65159f28953 Kalle Valo 2019-11-23 1991 QMI_WLANFW_BDF_DOWNLOAD_REQ_V01,
d5c65159f28953 Kalle Valo 2019-11-23 1992 QMI_WLANFW_BDF_DOWNLOAD_REQ_MSG_V01_MAX_LEN,
d5c65159f28953 Kalle Valo 2019-11-23 1993 qmi_wlanfw_bdf_download_req_msg_v01_ei, req);
d5c65159f28953 Kalle Valo 2019-11-23 1994 if (ret < 0) {
d5c65159f28953 Kalle Valo 2019-11-23 1995 qmi_txn_cancel(&txn);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1996 goto err_iounmap;
d5c65159f28953 Kalle Valo 2019-11-23 1997 }
d5c65159f28953 Kalle Valo 2019-11-23 1998
d5c65159f28953 Kalle Valo 2019-11-23 1999 ret = qmi_txn_wait(&txn, msecs_to_jiffies(ATH11K_QMI_WLANFW_TIMEOUT_MS));
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2000 if (ret < 0) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2001 ath11k_warn(ab, "failed to wait board file download request: %d\n",
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2002 ret);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2003 goto err_iounmap;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2004 }
d5c65159f28953 Kalle Valo 2019-11-23 2005
d5c65159f28953 Kalle Valo 2019-11-23 2006 if (resp.resp.result != QMI_RESULT_SUCCESS_V01) {
097e9f0714555e Kalle Valo 2021-02-22 2007 ath11k_warn(ab, "board file download request failed: %d %d\n",
d5c65159f28953 Kalle Valo 2019-11-23 2008 resp.resp.result, resp.resp.error);
d5c65159f28953 Kalle Valo 2019-11-23 2009 ret = -EINVAL;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2010 goto err_iounmap;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2011 }
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2012
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2013 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2014 remaining = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2015 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2016 remaining -= req->data_len;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2017 temp += req->data_len;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2018 req->seg_id++;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2019 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download request remaining %i\n",
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2020 remaining);
d5c65159f28953 Kalle Valo 2019-11-23 2021 }
d5c65159f28953 Kalle Valo 2019-11-23 2022 }
d5c65159f28953 Kalle Valo 2019-11-23 2023
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2024 err_iounmap:
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2025 if (ab->bus_params.fixed_bdf_addr)
d5c65159f28953 Kalle Valo 2019-11-23 2026 iounmap(bdf_addr);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2027
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2028 err_free_req:
d5c65159f28953 Kalle Valo 2019-11-23 2029 kfree(req);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2030
d5c65159f28953 Kalle Valo 2019-11-23 @2031 return ret;
d5c65159f28953 Kalle Valo 2019-11-23 2032 }
d5c65159f28953 Kalle Valo 2019-11-23 2033
:::::: The code at line 2031 was first introduced by commit
:::::: d5c65159f2895379e11ca13f62feabe93278985d ath11k: driver for Qualcomm IEEE 802.11ax devices
:::::: TO: Kalle Valo <kvalo@codeaurora.org>
:::::: CC: Kalle Valo <kvalo@codeaurora.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 9+ messages in thread
* drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
@ 2021-11-17 23:02 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2021-11-17 23:02 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 9883 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Anilkumar Kolli <akolli@codeaurora.org>
CC: Kalle Valo <kvalo@codeaurora.org>
CC: Jouni Malinen <jouni@codeaurora.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ee1703cda8dc777e937dec172da55beaf1a74919
commit: 336e7b53c82fc74d261024773a0fab43623a94fb ath11k: clean up BDF download functions
date: 7 weeks ago
:::::: branch date: 6 hours ago
:::::: commit date: 7 weeks ago
config: arm-randconfig-m031-20211104 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
vim +/ret +2031 drivers/net/wireless/ath/ath11k/qmi.c
d5c65159f28953 Kalle Valo 2019-11-23 1919
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1920 static int ath11k_qmi_load_file_target_mem(struct ath11k_base *ab,
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1921 const u8 *data, u32 len, u8 type)
d5c65159f28953 Kalle Valo 2019-11-23 1922 {
d5c65159f28953 Kalle Valo 2019-11-23 1923 struct qmi_wlanfw_bdf_download_req_msg_v01 *req;
d5c65159f28953 Kalle Valo 2019-11-23 1924 struct qmi_wlanfw_bdf_download_resp_msg_v01 resp;
d5c65159f28953 Kalle Valo 2019-11-23 1925 struct qmi_txn txn = {};
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1926 const u8 *temp = data;
d5c65159f28953 Kalle Valo 2019-11-23 1927 void __iomem *bdf_addr = NULL;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1928 int ret;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1929 u32 remaining = len;
d5c65159f28953 Kalle Valo 2019-11-23 1930
d5c65159f28953 Kalle Valo 2019-11-23 1931 req = kzalloc(sizeof(*req), GFP_KERNEL);
d5c65159f28953 Kalle Valo 2019-11-23 1932 if (!req)
d5c65159f28953 Kalle Valo 2019-11-23 1933 return -ENOMEM;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1934
d5c65159f28953 Kalle Valo 2019-11-23 1935 memset(&resp, 0, sizeof(resp));
d5c65159f28953 Kalle Valo 2019-11-23 1936
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1937 if (ab->bus_params.fixed_bdf_addr) {
c72aa32d6d1c04 Anilkumar Kolli 2021-09-28 1938 bdf_addr = ioremap(ab->hw_params.bdf_addr, ab->hw_params.fw.board_size);
d5c65159f28953 Kalle Valo 2019-11-23 1939 if (!bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1940 ath11k_warn(ab, "qmi ioremap error for bdf_addr\n");
d5c65159f28953 Kalle Valo 2019-11-23 1941 ret = -EIO;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1942 goto err_free_req;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1943 }
d5c65159f28953 Kalle Valo 2019-11-23 1944 }
d5c65159f28953 Kalle Valo 2019-11-23 1945
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1946 while (remaining) {
d5c65159f28953 Kalle Valo 2019-11-23 1947 req->valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1948 req->file_id_valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1949 req->file_id = ab->qmi.target.board_id;
d5c65159f28953 Kalle Valo 2019-11-23 1950 req->total_size_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1951 req->total_size = remaining;
d5c65159f28953 Kalle Valo 2019-11-23 1952 req->seg_id_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1953 req->data_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1954 req->bdf_type = type;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1955 req->bdf_type_valid = 1;
d5c65159f28953 Kalle Valo 2019-11-23 1956 req->end_valid = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1957 req->end = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1958
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1959 if (remaining > QMI_WLANFW_MAX_DATA_SIZE_V01) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1960 req->data_len = QMI_WLANFW_MAX_DATA_SIZE_V01;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1961 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1962 req->data_len = remaining;
d5c65159f28953 Kalle Valo 2019-11-23 1963 req->end = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1964 }
d5c65159f28953 Kalle Valo 2019-11-23 1965
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1966 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1967 req->data_valid = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1968 req->end = 1;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1969 req->data_len = ATH11K_QMI_MAX_BDF_FILE_NAME_SIZE;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1970 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1971 memcpy(req->data, temp, req->data_len);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1972 }
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1973
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1974 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1975 if (type == ATH11K_QMI_FILE_TYPE_CALDATA)
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1976 bdf_addr += ab->hw_params.fw.cal_offset;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1977
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1978 memcpy_toio(bdf_addr, temp, len);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1979 }
d5c65159f28953 Kalle Valo 2019-11-23 1980
d5c65159f28953 Kalle Valo 2019-11-23 1981 ret = qmi_txn_init(&ab->qmi.handle, &txn,
d5c65159f28953 Kalle Valo 2019-11-23 1982 qmi_wlanfw_bdf_download_resp_msg_v01_ei,
d5c65159f28953 Kalle Valo 2019-11-23 1983 &resp);
d5c65159f28953 Kalle Valo 2019-11-23 1984 if (ret < 0)
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1985 goto err_iounmap;
d5c65159f28953 Kalle Valo 2019-11-23 1986
bf458d79cfc46f Kalle Valo 2021-02-22 1987 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download req fixed addr type %d\n",
bf458d79cfc46f Kalle Valo 2021-02-22 1988 type);
bf458d79cfc46f Kalle Valo 2021-02-22 1989
d5c65159f28953 Kalle Valo 2019-11-23 1990 ret = qmi_send_request(&ab->qmi.handle, NULL, &txn,
d5c65159f28953 Kalle Valo 2019-11-23 1991 QMI_WLANFW_BDF_DOWNLOAD_REQ_V01,
d5c65159f28953 Kalle Valo 2019-11-23 1992 QMI_WLANFW_BDF_DOWNLOAD_REQ_MSG_V01_MAX_LEN,
d5c65159f28953 Kalle Valo 2019-11-23 1993 qmi_wlanfw_bdf_download_req_msg_v01_ei, req);
d5c65159f28953 Kalle Valo 2019-11-23 1994 if (ret < 0) {
d5c65159f28953 Kalle Valo 2019-11-23 1995 qmi_txn_cancel(&txn);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 1996 goto err_iounmap;
d5c65159f28953 Kalle Valo 2019-11-23 1997 }
d5c65159f28953 Kalle Valo 2019-11-23 1998
d5c65159f28953 Kalle Valo 2019-11-23 1999 ret = qmi_txn_wait(&txn, msecs_to_jiffies(ATH11K_QMI_WLANFW_TIMEOUT_MS));
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2000 if (ret < 0) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2001 ath11k_warn(ab, "failed to wait board file download request: %d\n",
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2002 ret);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2003 goto err_iounmap;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2004 }
d5c65159f28953 Kalle Valo 2019-11-23 2005
d5c65159f28953 Kalle Valo 2019-11-23 2006 if (resp.resp.result != QMI_RESULT_SUCCESS_V01) {
097e9f0714555e Kalle Valo 2021-02-22 2007 ath11k_warn(ab, "board file download request failed: %d %d\n",
d5c65159f28953 Kalle Valo 2019-11-23 2008 resp.resp.result, resp.resp.error);
d5c65159f28953 Kalle Valo 2019-11-23 2009 ret = -EINVAL;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2010 goto err_iounmap;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2011 }
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2012
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2013 if (ab->bus_params.fixed_bdf_addr) {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2014 remaining = 0;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2015 } else {
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2016 remaining -= req->data_len;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2017 temp += req->data_len;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2018 req->seg_id++;
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2019 ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi bdf download request remaining %i\n",
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2020 remaining);
d5c65159f28953 Kalle Valo 2019-11-23 2021 }
d5c65159f28953 Kalle Valo 2019-11-23 2022 }
d5c65159f28953 Kalle Valo 2019-11-23 2023
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2024 err_iounmap:
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2025 if (ab->bus_params.fixed_bdf_addr)
d5c65159f28953 Kalle Valo 2019-11-23 2026 iounmap(bdf_addr);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2027
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2028 err_free_req:
d5c65159f28953 Kalle Valo 2019-11-23 2029 kfree(req);
336e7b53c82fc7 Anilkumar Kolli 2021-09-28 2030
d5c65159f28953 Kalle Valo 2019-11-23 @2031 return ret;
d5c65159f28953 Kalle Valo 2019-11-23 2032 }
d5c65159f28953 Kalle Valo 2019-11-23 2033
:::::: The code at line 2031 was first introduced by commit
:::::: d5c65159f2895379e11ca13f62feabe93278985d ath11k: driver for Qualcomm IEEE 802.11ax devices
:::::: TO: Kalle Valo <kvalo@codeaurora.org>
:::::: CC: Kalle Valo <kvalo@codeaurora.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36790 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-06-05 14:01 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-05 14:01 drivers/net/wireless/ath/ath11k/qmi.c:2031 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-05-04 19:28 kernel test robot
2022-04-23 18:32 kernel test robot
2022-04-22 13:23 kernel test robot
2022-04-21 7:28 kernel test robot
2022-04-18 13:37 kernel test robot
2022-01-27 7:51 kernel test robot
2021-11-29 1:35 kernel test robot
2021-11-17 23:02 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.