* [igt-dev] [PATCH i-g-t 0/4] tests/kms_sysfs_edid_timing: rework thresholds
@ 2022-06-07 7:42 Luca Coelho
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 1/4] tests/kms_sysfs_edid_timing: increase max time thresholds Luca Coelho
` (5 more replies)
0 siblings, 6 replies; 17+ messages in thread
From: Luca Coelho @ 2022-06-07 7:42 UTC (permalink / raw)
To: igt-dev
From: Luca Coelho <luciano.coelho@intel.com>
Hi,
There were a few issues with the kms_sysfs_edid_timing test:
* The per connector threshold was too short;
* A warning was issued when the test should actually fail;
* The test description was cryptic;
* Total probing mean was proposed but not implemented.
Address all these issues by reworking the way we test the time it
takes to probe single connectors, mean of single connectors and add a
check for a mean of all connectors.
Please review.
--
Cheers,
Luca.
Luca Coelho (4):
tests/kms_sysfs_edid_timing: increase max time thresholds
tests/kms_sysfs_edid_timing: fail if probing a single connector takes
too long
tests/kms_sysfs_edid_timing: clarify test description and thresholds
tests/kms_sysfs_edid_timing: add total mean assertion threshold
tests/kms_sysfs_edid_timing.c | 48 +++++++++++++++++++++--------------
1 file changed, 29 insertions(+), 19 deletions(-)
--
2.36.1
^ permalink raw reply [flat|nested] 17+ messages in thread
* [igt-dev] [PATCH i-g-t 1/4] tests/kms_sysfs_edid_timing: increase max time thresholds
2022-06-07 7:42 [igt-dev] [PATCH i-g-t 0/4] tests/kms_sysfs_edid_timing: rework thresholds Luca Coelho
@ 2022-06-07 7:42 ` Luca Coelho
2022-06-08 9:03 ` Kahola, Mika
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 2/4] tests/kms_sysfs_edid_timing: fail if probing a single connector takes too long Luca Coelho
` (4 subsequent siblings)
5 siblings, 1 reply; 17+ messages in thread
From: Luca Coelho @ 2022-06-07 7:42 UTC (permalink / raw)
To: igt-dev
From: Luca Coelho <luciano.coelho@intel.com>
Currently, some connectors take longer than 10ms to reprobe, so we're
getting warnings that they take too long. The times chosen for this
test seems to have been arbitrary, and it turns out that now they're
too short.
Increase both the per connector threshold and the total time
threshold to avoid unwarranted warnings.
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
tests/kms_sysfs_edid_timing.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
index 12013881b200..028a5323c0b2 100644
--- a/tests/kms_sysfs_edid_timing.c
+++ b/tests/kms_sysfs_edid_timing.c
@@ -26,8 +26,8 @@
#include <fcntl.h>
#include <sys/stat.h>
-#define THRESHOLD_PER_CONNECTOR 10
-#define THRESHOLD_TOTAL 50
+#define THRESHOLD_PER_CONNECTOR 50
+#define THRESHOLD_TOTAL 150
#define CHECK_TIMES 15
IGT_TEST_DESCRIPTION("This check the time we take to read the content of all "
@@ -82,15 +82,14 @@ igt_simple_main
mean.mean, mean.mean / 1e3, mean.mean / 1e6);
if (mean.max > (THRESHOLD_PER_CONNECTOR * 1e6)) {
- igt_warn("%s: probe time exceed 10ms, "
- "max=%.2fms, avg=%.2fms\n", de->d_name,
+ igt_warn("%s: probe time exceed %dms, max=%.2fms, avg=%.2fms\n",
+ de->d_name, THRESHOLD_PER_CONNECTOR,
mean.max / 1e6, mean.mean / 1e6);
}
igt_assert_f(mean.mean < (THRESHOLD_TOTAL * 1e6),
- "%s: average probe time exceeded 50ms, "
- "max=%.2fms, avg=%.2fms\n", de->d_name,
+ "%s: average probe time exceeded %dms, max=%.2fms, avg=%.2fms\n",
+ de->d_name, THRESHOLD_TOTAL,
mean.max / 1e6, mean.mean / 1e6);
-
}
closedir(dirp);
--
2.36.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [igt-dev] [PATCH i-g-t 2/4] tests/kms_sysfs_edid_timing: fail if probing a single connector takes too long
2022-06-07 7:42 [igt-dev] [PATCH i-g-t 0/4] tests/kms_sysfs_edid_timing: rework thresholds Luca Coelho
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 1/4] tests/kms_sysfs_edid_timing: increase max time thresholds Luca Coelho
@ 2022-06-07 7:42 ` Luca Coelho
2022-06-08 9:03 ` Kahola, Mika
2022-06-09 7:32 ` Petri Latvala
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 3/4] tests/kms_sysfs_edid_timing: clarify test description and thresholds Luca Coelho
` (3 subsequent siblings)
5 siblings, 2 replies; 17+ messages in thread
From: Luca Coelho @ 2022-06-07 7:42 UTC (permalink / raw)
To: igt-dev
From: Luca Coelho <luciano.coelho@intel.com>
There's no point in just warning if probing a single connector takes
too long. If a test finds any issues, it should just fail.
Convert the warning into an assertion.
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
tests/kms_sysfs_edid_timing.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
index 028a5323c0b2..ea0e169e6ed9 100644
--- a/tests/kms_sysfs_edid_timing.c
+++ b/tests/kms_sysfs_edid_timing.c
@@ -81,11 +81,11 @@ igt_simple_main
mean.max, mean.max / 1e3, mean.max / 1e6,
mean.mean, mean.mean / 1e3, mean.mean / 1e6);
- if (mean.max > (THRESHOLD_PER_CONNECTOR * 1e6)) {
- igt_warn("%s: probe time exceed %dms, max=%.2fms, avg=%.2fms\n",
- de->d_name, THRESHOLD_PER_CONNECTOR,
- mean.max / 1e6, mean.mean / 1e6);
- }
+ igt_assert_f(mean.max < THRESHOLD_PER_CONNECTOR * 1e6,
+ "%s: probe time exceed %dms, max=%.2fms, avg=%.2fms\n",
+ de->d_name, THRESHOLD_PER_CONNECTOR,
+ mean.max / 1e6, mean.mean / 1e6);
+
igt_assert_f(mean.mean < (THRESHOLD_TOTAL * 1e6),
"%s: average probe time exceeded %dms, max=%.2fms, avg=%.2fms\n",
de->d_name, THRESHOLD_TOTAL,
--
2.36.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [igt-dev] [PATCH i-g-t 3/4] tests/kms_sysfs_edid_timing: clarify test description and thresholds
2022-06-07 7:42 [igt-dev] [PATCH i-g-t 0/4] tests/kms_sysfs_edid_timing: rework thresholds Luca Coelho
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 1/4] tests/kms_sysfs_edid_timing: increase max time thresholds Luca Coelho
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 2/4] tests/kms_sysfs_edid_timing: fail if probing a single connector takes too long Luca Coelho
@ 2022-06-07 7:42 ` Luca Coelho
2022-06-08 9:06 ` Kahola, Mika
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 4/4] tests/kms_sysfs_edid_timing: add total mean assertion threshold Luca Coelho
` (2 subsequent siblings)
5 siblings, 1 reply; 17+ messages in thread
From: Luca Coelho @ 2022-06-07 7:42 UTC (permalink / raw)
To: igt-dev
From: Luca Coelho <luciano.coelho@intel.com>
The description of this test was cryptic, mentioning a very old patch
and so on. Clarify what the test actually does.
While at it, improve the assertion messages and clarify the threshold
macro names.
Additionally, change the mean time threshold per connector to
something shorter than the threshold per probe, since the former
cannot happen without the latter already causing an assertion failure.
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
tests/kms_sysfs_edid_timing.c | 24 +++++++++++-------------
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
index ea0e169e6ed9..4255cae3be17 100644
--- a/tests/kms_sysfs_edid_timing.c
+++ b/tests/kms_sysfs_edid_timing.c
@@ -26,16 +26,14 @@
#include <fcntl.h>
#include <sys/stat.h>
-#define THRESHOLD_PER_CONNECTOR 50
-#define THRESHOLD_TOTAL 150
-#define CHECK_TIMES 15
-
-IGT_TEST_DESCRIPTION("This check the time we take to read the content of all "
- "the possible connectors. Without the edid -ENXIO patch "
- "(http://permalink.gmane.org/gmane.comp.video.dri.devel/62083), "
- "we sometimes take a *really* long time. "
- "So let's just check for some reasonable timing here");
+#define THRESHOLD_PER_CONNECTOR 50
+#define THRESHOLD_PER_CONNECTOR_MEAN 40
+#define CHECK_TIMES 15
+IGT_TEST_DESCRIPTION("This test checks the time it takes to reprobe each "
+ "connector and fails if either the time it takes for "
+ "one reprobe is too long or if the mean time it takes "
+ "to reprode one connector is too long.");
igt_simple_main
{
@@ -82,13 +80,13 @@ igt_simple_main
mean.mean, mean.mean / 1e3, mean.mean / 1e6);
igt_assert_f(mean.max < THRESHOLD_PER_CONNECTOR * 1e6,
- "%s: probe time exceed %dms, max=%.2fms, avg=%.2fms\n",
+ "%s: single probe time exceeded %dms, max=%.2fms, avg=%.2fms\n",
de->d_name, THRESHOLD_PER_CONNECTOR,
mean.max / 1e6, mean.mean / 1e6);
- igt_assert_f(mean.mean < (THRESHOLD_TOTAL * 1e6),
- "%s: average probe time exceeded %dms, max=%.2fms, avg=%.2fms\n",
- de->d_name, THRESHOLD_TOTAL,
+ igt_assert_f(mean.mean < (THRESHOLD_PER_CONNECTOR_MEAN * 1e6),
+ "%s: mean probe time exceeded %dms, max=%.2fms, avg=%.2fms\n",
+ de->d_name, THRESHOLD_PER_CONNECTOR_MEAN,
mean.max / 1e6, mean.mean / 1e6);
}
closedir(dirp);
--
2.36.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [igt-dev] [PATCH i-g-t 4/4] tests/kms_sysfs_edid_timing: add total mean assertion threshold
2022-06-07 7:42 [igt-dev] [PATCH i-g-t 0/4] tests/kms_sysfs_edid_timing: rework thresholds Luca Coelho
` (2 preceding siblings ...)
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 3/4] tests/kms_sysfs_edid_timing: clarify test description and thresholds Luca Coelho
@ 2022-06-07 7:42 ` Luca Coelho
2022-06-08 9:07 ` Kahola, Mika
2022-06-09 7:28 ` Petri Latvala
2022-06-07 9:27 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_sysfs_edid_timing: rework thresholds Patchwork
2022-06-07 11:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
5 siblings, 2 replies; 17+ messages in thread
From: Luca Coelho @ 2022-06-07 7:42 UTC (permalink / raw)
To: igt-dev
From: Luca Coelho <luciano.coelho@intel.com>
Add an assertion to make sure that the mean time it takes to probe all
connectors doesn't exceed 30 ms. This is an arbitrary but reasonable
amount of time.
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
tests/kms_sysfs_edid_timing.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
index 4255cae3be17..680e4ef5985e 100644
--- a/tests/kms_sysfs_edid_timing.c
+++ b/tests/kms_sysfs_edid_timing.c
@@ -28,21 +28,27 @@
#define THRESHOLD_PER_CONNECTOR 50
#define THRESHOLD_PER_CONNECTOR_MEAN 40
+#define THRESHOLD_ALL_CONNECTORS_MEAN 30
#define CHECK_TIMES 15
IGT_TEST_DESCRIPTION("This test checks the time it takes to reprobe each "
"connector and fails if either the time it takes for "
"one reprobe is too long or if the mean time it takes "
- "to reprode one connector is too long.");
+ "to reprode one connector is too long. Additionally, "
+ "make sure that the mean time for all connectors is "
+ "not too long.");
igt_simple_main
{
DIR *dirp;
struct dirent *de;
+ struct igt_mean all_mean;
dirp = opendir("/sys/class/drm");
igt_assert(dirp != NULL);
+ igt_mean_init(&all_mean);
+
while ((de = readdir(dirp))) {
struct igt_mean mean = {};
struct stat st;
@@ -88,7 +94,14 @@ igt_simple_main
"%s: mean probe time exceeded %dms, max=%.2fms, avg=%.2fms\n",
de->d_name, THRESHOLD_PER_CONNECTOR_MEAN,
mean.max / 1e6, mean.mean / 1e6);
+
+ igt_mean_add(&all_mean, mean.mean);
}
- closedir(dirp);
+ igt_assert_f(all_mean.mean < THRESHOLD_ALL_CONNECTORS_MEAN * 1e6,
+ "Mean of all connector means exceeds %dms, max=%.2fms, mean=%.2fms\n",
+ THRESHOLD_ALL_CONNECTORS_MEAN, all_mean.max / 1e6,
+ all_mean.mean / 1e6);
+
+ closedir(dirp);
}
--
2.36.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_sysfs_edid_timing: rework thresholds
2022-06-07 7:42 [igt-dev] [PATCH i-g-t 0/4] tests/kms_sysfs_edid_timing: rework thresholds Luca Coelho
` (3 preceding siblings ...)
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 4/4] tests/kms_sysfs_edid_timing: add total mean assertion threshold Luca Coelho
@ 2022-06-07 9:27 ` Patchwork
2022-06-07 11:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
5 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2022-06-07 9:27 UTC (permalink / raw)
To: Luca Coelho; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 7827 bytes --]
== Series Details ==
Series: tests/kms_sysfs_edid_timing: rework thresholds
URL : https://patchwork.freedesktop.org/series/104802/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11730 -> IGTPW_7242
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/index.html
Participating hosts (42 -> 40)
------------------------------
Additional (1): fi-rkl-11600
Missing (3): bat-adln-1 fi-icl-u2 fi-bdw-samus
Known issues
------------
Here are the changes found in IGTPW_7242 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][1] ([i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-rkl-11600: NOTRUN -> [SKIP][2] ([i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-rkl-11600/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#3282])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-rkl-11600/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#3012])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][5] -> [INCOMPLETE][6] ([i915#3921])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- fi-blb-e6850: [PASS][7] -> [DMESG-FAIL][8] ([i915#4528])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/fi-blb-e6850/igt@i915_selftest@live@requests.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-blb-e6850/igt@i915_selftest@live@requests.html
- fi-pnv-d510: [PASS][9] -> [DMESG-FAIL][10] ([i915#4528])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/fi-pnv-d510/igt@i915_selftest@live@requests.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@vma:
- fi-bdw-5557u: [PASS][11] -> [INCOMPLETE][12] ([i915#5681])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/fi-bdw-5557u/igt@i915_selftest@live@vma.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-bdw-5557u/igt@i915_selftest@live@vma.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][13] ([i915#5982])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-rkl-11600: NOTRUN -> [SKIP][14] ([fdo#111827]) +7 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-rkl-11600/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-rkl-11600: NOTRUN -> [SKIP][15] ([i915#4070] / [i915#4103]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][16] ([fdo#109285] / [i915#4098])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-rkl-11600: NOTRUN -> [SKIP][17] ([i915#4070] / [i915#533])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-rkl-11600/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@sprite_plane_onoff:
- fi-rkl-11600: NOTRUN -> [SKIP][18] ([i915#1072]) +3 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-rkl-11600/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][19] ([i915#3555] / [i915#4098])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][20] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-rkl-11600/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-userptr:
- fi-rkl-11600: NOTRUN -> [SKIP][21] ([fdo#109295] / [i915#3301] / [i915#3708])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-rkl-11600/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {fi-ehl-2}: [DMESG-WARN][22] ([i915#5122]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/fi-ehl-2/igt@gem_exec_suspend@basic-s0@smem.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-ehl-2/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_hangman@error-state-basic:
- fi-skl-guc: [DMESG-WARN][24] -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/fi-skl-guc/igt@i915_hangman@error-state-basic.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/fi-skl-guc/igt@i915_hangman@error-state-basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5681]: https://gitlab.freedesktop.org/drm/intel/issues/5681
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6510 -> IGTPW_7242
CI-20190529: 20190529
CI_DRM_11730: 5e7f37992081d4600d6329a745ab7edb2ee42bcd @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7242: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/index.html
IGT_6510: dacfa80158d586cd0fe322f25f5275f224a946dd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/index.html
[-- Attachment #2: Type: text/html, Size: 9231 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_sysfs_edid_timing: rework thresholds
2022-06-07 7:42 [igt-dev] [PATCH i-g-t 0/4] tests/kms_sysfs_edid_timing: rework thresholds Luca Coelho
` (4 preceding siblings ...)
2022-06-07 9:27 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_sysfs_edid_timing: rework thresholds Patchwork
@ 2022-06-07 11:54 ` Patchwork
5 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2022-06-07 11:54 UTC (permalink / raw)
To: Luca Coelho; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 50292 bytes --]
== Series Details ==
Series: tests/kms_sysfs_edid_timing: rework thresholds
URL : https://patchwork.freedesktop.org/series/104802/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11730_full -> IGTPW_7242_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_7242_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_7242_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/index.html
Participating hosts (10 -> 10)
------------------------------
Additional (3): shard-rkl shard-dg1 shard-tglu
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_7242_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_sysfs_edid_timing:
- shard-glk: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-glk8/igt@kms_sysfs_edid_timing.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-glk9/igt@kms_sysfs_edid_timing.html
#### Warnings ####
* igt@kms_sysfs_edid_timing:
- shard-kbl: [FAIL][3] ([IGT#2]) -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@kms_sysfs_edid_timing.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl4/igt@kms_sysfs_edid_timing.html
- shard-apl: [FAIL][5] ([IGT#2]) -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-apl8/igt@kms_sysfs_edid_timing.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-apl4/igt@kms_sysfs_edid_timing.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled:
- {shard-dg1}: NOTRUN -> [FAIL][7] +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-dg1-12/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
* igt@kms_lease@lease-uevent:
- {shard-dg1}: NOTRUN -> [WARN][8]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-dg1-12/igt@kms_lease@lease-uevent.html
Known issues
------------
Here are the changes found in IGTPW_7242_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ccs@ctrl-surf-copy:
- shard-tglb: NOTRUN -> [SKIP][9] ([i915#3555] / [i915#5325])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb1/igt@gem_ccs@ctrl-surf-copy.html
- shard-iclb: NOTRUN -> [SKIP][10] ([i915#5327])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb6/igt@gem_ccs@ctrl-surf-copy.html
* igt@gem_ctx_persistence@hostile:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#1099])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-snb6/igt@gem_ctx_persistence@hostile.html
* igt@gem_eio@in-flight-contexts-immediate:
- shard-glk: [PASS][12] -> [TIMEOUT][13] ([i915#3063])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-glk3/igt@gem_eio@in-flight-contexts-immediate.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-glk7/igt@gem_eio@in-flight-contexts-immediate.html
* igt@gem_eio@unwedge-stress:
- shard-snb: NOTRUN -> [FAIL][14] ([i915#3354])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-snb2/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [PASS][15] -> [SKIP][16] ([i915#4525]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb4/igt@gem_exec_balancer@parallel-bb-first.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb5/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][17] -> [FAIL][18] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb2/igt@gem_exec_fair@basic-none-share@rcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-tglb: [PASS][19] -> [FAIL][20] ([i915#2842]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-tglb6/igt@gem_exec_fair@basic-none-vip@rcs0.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb6/igt@gem_exec_fair@basic-none-vip@rcs0.html
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#2842]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-glk5/igt@gem_exec_fair@basic-none-vip@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-glk5/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][23] ([i915#2842])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb2/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: NOTRUN -> [FAIL][24] ([i915#2842])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [PASS][25] -> [FAIL][26] ([i915#2842]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl4/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_params@secure-non-root:
- shard-iclb: NOTRUN -> [SKIP][27] ([fdo#112283])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb2/igt@gem_exec_params@secure-non-root.html
* igt@gem_exec_schedule@thriceslice:
- shard-snb: NOTRUN -> [SKIP][28] ([fdo#109271]) +33 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-snb7/igt@gem_exec_schedule@thriceslice.html
* igt@gem_lmem_swapping@smem-oom:
- shard-kbl: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#4613])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl1/igt@gem_lmem_swapping@smem-oom.html
* igt@gem_pxp@verify-pxp-stale-buf-execution:
- shard-iclb: NOTRUN -> [SKIP][30] ([i915#4270])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb4/igt@gem_pxp@verify-pxp-stale-buf-execution.html
* igt@gem_render_copy@yf-tiled-to-vebox-y-tiled:
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#768]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb2/igt@gem_render_copy@yf-tiled-to-vebox-y-tiled.html
* igt@gen9_exec_parse@bb-chained:
- shard-tglb: NOTRUN -> [SKIP][32] ([i915#2527] / [i915#2856])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb7/igt@gen9_exec_parse@bb-chained.html
- shard-iclb: NOTRUN -> [SKIP][33] ([i915#2856])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb5/igt@gen9_exec_parse@bb-chained.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][34] -> [FAIL][35] ([i915#454])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb5/igt@i915_pm_dc@dc6-psr.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][36] -> [SKIP][37] ([fdo#109271])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-apl7/igt@i915_pm_dc@dc9-dpms.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-apl3/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_query@query-topology-known-pci-ids:
- shard-tglb: NOTRUN -> [SKIP][38] ([fdo#109303])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb5/igt@i915_query@query-topology-known-pci-ids.html
- shard-iclb: NOTRUN -> [SKIP][39] ([fdo#109303])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb5/igt@i915_query@query-topology-known-pci-ids.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][40] -> [INCOMPLETE][41] ([i915#3921])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-snb4/igt@i915_selftest@live@hangcheck.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-snb6/igt@i915_selftest@live@hangcheck.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-snb: [PASS][42] -> [FAIL][43] ([i915#2521])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-snb7/igt@kms_async_flips@alternate-sync-async-flip.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-snb7/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-glk: NOTRUN -> [SKIP][44] ([fdo#109271]) +23 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-glk9/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
- shard-tglb: NOTRUN -> [SKIP][45] ([i915#5286])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb3/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-iclb: NOTRUN -> [SKIP][46] ([i915#5286]) +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb5/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-iclb: NOTRUN -> [SKIP][47] ([fdo#110723])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb8/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109278]) +10 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb3/igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][49] ([fdo#111615] / [i915#3689])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb6/igt@kms_ccs@pipe-a-missing-ccs-buffer-yf_tiled_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#3886]) +4 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl1/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][51] ([i915#3689]) +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb2/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#3886])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-apl4/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][53] ([i915#6095])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb3/igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs.html
* igt@kms_chamelium@dp-audio:
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109284] / [fdo#111827]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb6/igt@kms_chamelium@dp-audio.html
* igt@kms_color_chamelium@pipe-a-ctm-0-25:
- shard-snb: NOTRUN -> [SKIP][55] ([fdo#109271] / [fdo#111827]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-snb5/igt@kms_color_chamelium@pipe-a-ctm-0-25.html
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [fdo#111827]) +5 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-apl3/igt@kms_color_chamelium@pipe-a-ctm-0-25.html
- shard-tglb: NOTRUN -> [SKIP][57] ([fdo#109284] / [fdo#111827]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb2/igt@kms_color_chamelium@pipe-a-ctm-0-25.html
- shard-glk: NOTRUN -> [SKIP][58] ([fdo#109271] / [fdo#111827]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-glk6/igt@kms_color_chamelium@pipe-a-ctm-0-25.html
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-kbl: NOTRUN -> [SKIP][59] ([fdo#109271] / [fdo#111827]) +11 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl6/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> [TIMEOUT][60] ([i915#1319])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-apl3/igt@kms_content_protection@atomic.html
- shard-kbl: NOTRUN -> [TIMEOUT][61] ([i915#1319])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl1/igt@kms_content_protection@atomic.html
* igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding:
- shard-tglb: NOTRUN -> [SKIP][62] ([fdo#109279] / [i915#3359])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb5/igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding.html
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109278] / [fdo#109279])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb5/igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding.html
* igt@kms_cursor_crc@pipe-c-cursor-32x10-offscreen:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#92]) +2 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-32x10-offscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-32x10-onscreen:
- shard-tglb: NOTRUN -> [SKIP][65] ([i915#3359]) +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb2/igt@kms_cursor_crc@pipe-c-cursor-32x10-onscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-max-size-onscreen:
- shard-kbl: NOTRUN -> [SKIP][66] ([fdo#109271]) +146 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-max-size-onscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-128x42-rapid-movement:
- shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271]) +53 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-apl4/igt@kms_cursor_crc@pipe-d-cursor-128x42-rapid-movement.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- shard-tglb: NOTRUN -> [SKIP][68] ([i915#4103]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#533])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-apl3/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#109274]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb3/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
- shard-tglb: NOTRUN -> [SKIP][71] ([fdo#109274] / [fdo#111825])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1:
- shard-glk: [PASS][72] -> [FAIL][73] ([i915#79])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-glk7/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-glk3/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-apl: [PASS][74] -> [DMESG-WARN][75] ([i915#180]) +3 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html
* igt@kms_flip@plain-flip-ts-check@b-hdmi-a2:
- shard-glk: [PASS][76] -> [FAIL][77] ([i915#2122])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-glk2/igt@kms_flip@plain-flip-ts-check@b-hdmi-a2.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-glk9/igt@kms_flip@plain-flip-ts-check@b-hdmi-a2.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling:
- shard-glk: [PASS][78] -> [FAIL][79] ([i915#4911])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-glk4/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu:
- shard-kbl: [PASS][80] -> [DMESG-WARN][81] ([i915#62] / [i915#92]) +2 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][82] -> [INCOMPLETE][83] ([i915#3614])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-onoff:
- shard-tglb: NOTRUN -> [SKIP][84] ([fdo#109280] / [fdo#111825])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-onoff.html
- shard-iclb: NOTRUN -> [SKIP][85] ([fdo#109280]) +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-onoff.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][86] ([fdo#108145] / [i915#265])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl6/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [PASS][87] -> [SKIP][88] ([fdo#109642] / [fdo#111068] / [i915#658])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb2/igt@kms_psr2_su@frontbuffer-xrgb8888.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb4/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr2_su@page_flip-p010:
- shard-kbl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#658]) +4 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl3/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#658])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-apl7/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109441]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb4/igt@kms_psr@psr2_cursor_blt.html
- shard-tglb: NOTRUN -> [FAIL][92] ([i915#132] / [i915#3467])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb3/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-iclb: [PASS][93] -> [SKIP][94] ([fdo#109441]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb2/igt@kms_psr@psr2_sprite_plane_onoff.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb6/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-iclb: [PASS][95] -> [SKIP][96] ([i915#5519])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb5/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb6/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
* igt@kms_rmfb@rmfb-ioctl:
- shard-kbl: [PASS][97] -> [DMESG-WARN][98] ([i915#180] / [i915#62] / [i915#92]) +7 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl4/igt@kms_rmfb@rmfb-ioctl.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl3/igt@kms_rmfb@rmfb-ioctl.html
* igt@kms_rotation_crc@primary-4-tiled-reflect-x-180:
- shard-iclb: NOTRUN -> [SKIP][99] ([i915#5289])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb4/igt@kms_rotation_crc@primary-4-tiled-reflect-x-180.html
- shard-tglb: NOTRUN -> [SKIP][100] ([i915#5289])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb2/igt@kms_rotation_crc@primary-4-tiled-reflect-x-180.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][101] -> [DMESG-WARN][102] ([i915#180]) +4 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-kbl: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#533]) +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl1/igt@kms_vblank@pipe-d-wait-idle.html
* igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame:
- shard-tglb: NOTRUN -> [SKIP][104] ([i915#2530])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb7/igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame.html
- shard-iclb: NOTRUN -> [SKIP][105] ([i915#2530])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb8/igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame.html
* igt@perf_pmu@rc6-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][106] ([i915#180])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl4/igt@perf_pmu@rc6-suspend.html
* igt@prime_nv_pcopy@test_semaphore:
- shard-tglb: NOTRUN -> [SKIP][107] ([fdo#109291])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb3/igt@prime_nv_pcopy@test_semaphore.html
- shard-iclb: NOTRUN -> [SKIP][108] ([fdo#109291])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb3/igt@prime_nv_pcopy@test_semaphore.html
* igt@sw_sync@sync_merge_same:
- shard-kbl: NOTRUN -> [FAIL][109] ([i915#6140])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl4/igt@sw_sync@sync_merge_same.html
* igt@sysfs_clients@fair-0:
- shard-iclb: NOTRUN -> [SKIP][110] ([i915#2994])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb1/igt@sysfs_clients@fair-0.html
* igt@sysfs_clients@fair-3:
- shard-kbl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#2994])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl7/igt@sysfs_clients@fair-3.html
#### Possible fixes ####
* igt@drm_read@short-buffer-block:
- shard-kbl: [DMESG-WARN][112] ([i915#62] / [i915#92]) -> [PASS][113] +18 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@drm_read@short-buffer-block.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl7/igt@drm_read@short-buffer-block.html
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][114] ([i915#658]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb7/igt@feature_discovery@psr2.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_eio@kms:
- shard-tglb: [FAIL][116] ([i915#5784]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-tglb3/igt@gem_eio@kms.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb7/igt@gem_eio@kms.html
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][118] ([i915#4525]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb7/igt@gem_exec_balancer@parallel-out-fence.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb1/igt@gem_exec_balancer@parallel-out-fence.html
* igt@gem_exec_capture@pi@rcs0:
- shard-iclb: [INCOMPLETE][120] ([i915#3371]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb6/igt@gem_exec_capture@pi@rcs0.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb8/igt@gem_exec_capture@pi@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [FAIL][122] ([i915#2842]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-glk3/igt@gem_exec_fair@basic-none-share@rcs0.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-glk2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-iclb: [FAIL][124] ([i915#2842]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb8/igt@gem_exec_fair@basic-pace@bcs0.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb7/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [FAIL][126] ([i915#2842]) -> [PASS][127] +1 similar issue
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-tglb1/igt@gem_exec_fair@basic-pace@vecs0.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb6/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][128] ([i915#2849]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb5/igt@gem_exec_fair@basic-throttle@rcs0.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_flush@basic-wb-prw-default:
- shard-snb: [SKIP][130] ([fdo#109271]) -> [PASS][131] +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-snb6/igt@gem_exec_flush@basic-wb-prw-default.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-snb7/igt@gem_exec_flush@basic-wb-prw-default.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][132] ([i915#454]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb5/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [SKIP][134] ([i915#4281]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb8/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_selftest@live@hangcheck:
- shard-tglb: [DMESG-WARN][136] ([i915#5591]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-tglb5/igt@i915_selftest@live@hangcheck.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-tglb3/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@forcewake:
- shard-kbl: [DMESG-WARN][138] ([i915#180]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl1/igt@i915_suspend@forcewake.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl3/igt@i915_suspend@forcewake.html
* igt@kms_flip@flip-vs-suspend@b-dp1:
- shard-apl: [DMESG-WARN][140] ([i915#180]) -> [PASS][141]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-apl8/igt@kms_flip@flip-vs-suspend@b-dp1.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-apl2/igt@kms_flip@flip-vs-suspend@b-dp1.html
- shard-kbl: [INCOMPLETE][142] ([i915#3614]) -> [PASS][143]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@kms_flip@flip-vs-suspend@b-dp1.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl3/igt@kms_flip@flip-vs-suspend@b-dp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][144] ([i915#1982] / [i915#62] / [i915#92]) -> [PASS][145]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@kms_flip@plain-flip-ts-check-interruptible@a-dp1.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl1/igt@kms_flip@plain-flip-ts-check-interruptible@a-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling:
- shard-iclb: [SKIP][146] ([i915#3701]) -> [PASS][147] +1 similar issue
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb6/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html
* igt@kms_plane_scaling@planes-downscale-factor-0-75@pipe-b-dp-1:
- shard-kbl: [SKIP][148] ([fdo#109271]) -> [PASS][149]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@kms_plane_scaling@planes-downscale-factor-0-75@pipe-b-dp-1.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl1/igt@kms_plane_scaling@planes-downscale-factor-0-75@pipe-b-dp-1.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][150] ([fdo#109441]) -> [PASS][151] +2 similar issues
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb4/igt@kms_psr@psr2_sprite_render.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [SKIP][152] ([i915#5519]) -> [PASS][153]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb4/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb1/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][154] ([i915#6117]) -> [SKIP][155] ([i915#4525])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb1/igt@gem_exec_balancer@parallel-ordering.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb6/igt@gem_exec_balancer@parallel-ordering.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: [SKIP][156] ([fdo#109271] / [i915#1937]) -> [SKIP][157] ([fdo#109271] / [i915#1937] / [i915#92])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl1/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl3/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-yf_tiled_ccs:
- shard-kbl: [SKIP][158] ([fdo#109271] / [i915#92]) -> [SKIP][159] ([fdo#109271]) +12 similar issues
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@kms_ccs@pipe-c-missing-ccs-buffer-yf_tiled_ccs.html
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl3/igt@kms_ccs@pipe-c-missing-ccs-buffer-yf_tiled_ccs.html
* igt@kms_color_chamelium@pipe-c-ctm-green-to-red:
- shard-kbl: [SKIP][160] ([fdo#109271] / [fdo#111827] / [i915#92]) -> [SKIP][161] ([fdo#109271] / [fdo#111827])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@kms_color_chamelium@pipe-c-ctm-green-to-red.html
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl4/igt@kms_color_chamelium@pipe-c-ctm-green-to-red.html
* igt@kms_content_protection@dp-mst-type-0:
- shard-kbl: [SKIP][162] ([fdo#109271]) -> [SKIP][163] ([fdo#109271] / [i915#92]) +9 similar issues
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl6/igt@kms_content_protection@dp-mst-type-0.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl3/igt@kms_content_protection@dp-mst-type-0.html
* igt@kms_content_protection@srm:
- shard-kbl: [SKIP][164] ([fdo#109271] / [i915#92]) -> [TIMEOUT][165] ([i915#1319])
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@kms_content_protection@srm.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl6/igt@kms_content_protection@srm.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][166] ([i915#2920]) -> [SKIP][167] ([fdo#111068] / [i915#658])
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb6/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][168] ([fdo#111068] / [i915#658]) -> [SKIP][169] ([i915#2920])
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb6/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110254]: https://bugs.freedesktop.org/show_bug.cgi?id=110254
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112022]: https://bugs.freedesktop.org/show_bug.cgi?id=112022
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3354]: https://gitlab.freedesktop.org/drm/intel/issues/3354
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3371]: https://gitlab.freedesktop.org/drm/intel/issues/3371
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3464]: https://gitlab.freedesktop.org/drm/intel/issues/3464
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3614]: https://gitlab.freedesktop.org/drm/intel/issues/3614
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3963]: https://gitlab.freedesktop.org/drm/intel/issues/3963
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4016]: https://gitlab.freedesktop.org/drm/intel/issues/4016
[i915#4032]: https://gitlab.freedesktop.org/drm/intel/issues/4032
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4241]: https://gitlab.freedesktop.org/drm/intel/issues/4241
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4278]: https://gitlab.freedesktop.org/drm/intel/issues/4278
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4807]: https://gitlab.freedesktop.org/drm/intel/issues/4807
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4842]: https://gitlab.freedesktop.org/drm/intel/issues/4842
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4853]: https://gitlab.freedesktop.org/drm/intel/issues/4853
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4855]: https://gitlab.freedesktop.org/drm/intel/issues/4855
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4874]: https://gitlab.freedesktop.org/drm/intel/issues/4874
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4893]: https://gitlab.freedesktop.org/drm/intel/issues/4893
[i915#4904]: https://gitlab.freedesktop.org/drm/intel/issues/4904
[i915#4911]: https://gitlab.freedesktop.org/drm/intel/issues/4911
[i915#4929]: https://gitlab.freedesktop.org/drm/intel/issues/4929
[i915#4941]: https://gitlab.freedesktop.org/drm/intel/issues/4941
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5264]: https://gitlab.freedesktop.org/drm/intel/issues/5264
[i915#5266]: https://gitlab.freedesktop.org/drm/intel/issues/5266
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5303]: https://gitlab.freedesktop.org/drm/intel/issues/5303
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5357]: https://gitlab.freedesktop.org/drm/intel/issues/5357
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#5721]: https://gitlab.freedesktop.org/drm/intel/issues/5721
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6140]: https://gitlab.freedesktop.org/drm/intel/issues/6140
[i915#6141]: https://gitlab.freedesktop.org/drm/intel/issues/6141
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6510 -> IGTPW_7242
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_11730: 5e7f37992081d4600d6329a745ab7edb2ee42bcd @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7242: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/index.html
IGT_6510: dacfa80158d586cd0fe322f25f5275f224a946dd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/index.html
[-- Attachment #2: Type: text/html, Size: 50166 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/4] tests/kms_sysfs_edid_timing: increase max time thresholds
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 1/4] tests/kms_sysfs_edid_timing: increase max time thresholds Luca Coelho
@ 2022-06-08 9:03 ` Kahola, Mika
0 siblings, 0 replies; 17+ messages in thread
From: Kahola, Mika @ 2022-06-08 9:03 UTC (permalink / raw)
To: Luca Coelho, igt-dev
> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Luca
> Coelho
> Sent: Tuesday, June 7, 2022 10:43 AM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t 1/4] tests/kms_sysfs_edid_timing: increase max
> time thresholds
>
> From: Luca Coelho <luciano.coelho@intel.com>
>
> Currently, some connectors take longer than 10ms to reprobe, so we're getting
> warnings that they take too long. The times chosen for this test seems to have
> been arbitrary, and it turns out that now they're too short.
>
> Increase both the per connector threshold and the total time threshold to avoid
> unwarranted warnings.
>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
> tests/kms_sysfs_edid_timing.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> index 12013881b200..028a5323c0b2 100644
> --- a/tests/kms_sysfs_edid_timing.c
> +++ b/tests/kms_sysfs_edid_timing.c
> @@ -26,8 +26,8 @@
> #include <fcntl.h>
> #include <sys/stat.h>
>
> -#define THRESHOLD_PER_CONNECTOR 10
> -#define THRESHOLD_TOTAL 50
> +#define THRESHOLD_PER_CONNECTOR 50
> +#define THRESHOLD_TOTAL 150
> #define CHECK_TIMES 15
>
> IGT_TEST_DESCRIPTION("This check the time we take to read the content of all
> "
> @@ -82,15 +82,14 @@ igt_simple_main
> mean.mean, mean.mean / 1e3, mean.mean / 1e6);
>
> if (mean.max > (THRESHOLD_PER_CONNECTOR * 1e6)) {
> - igt_warn("%s: probe time exceed 10ms, "
> - "max=%.2fms, avg=%.2fms\n", de->d_name,
> + igt_warn("%s: probe time exceed %dms, max=%.2fms,
> avg=%.2fms\n",
> + de->d_name, THRESHOLD_PER_CONNECTOR,
> mean.max / 1e6, mean.mean / 1e6);
> }
> igt_assert_f(mean.mean < (THRESHOLD_TOTAL * 1e6),
> - "%s: average probe time exceeded 50ms, "
> - "max=%.2fms, avg=%.2fms\n", de->d_name,
> + "%s: average probe time exceeded %dms,
> max=%.2fms, avg=%.2fms\n",
> + de->d_name, THRESHOLD_TOTAL,
> mean.max / 1e6, mean.mean / 1e6);
> -
> }
> closedir(dirp);
>
> --
> 2.36.1
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/4] tests/kms_sysfs_edid_timing: fail if probing a single connector takes too long
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 2/4] tests/kms_sysfs_edid_timing: fail if probing a single connector takes too long Luca Coelho
@ 2022-06-08 9:03 ` Kahola, Mika
2022-06-09 7:32 ` Petri Latvala
1 sibling, 0 replies; 17+ messages in thread
From: Kahola, Mika @ 2022-06-08 9:03 UTC (permalink / raw)
To: Luca Coelho, igt-dev
> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Luca
> Coelho
> Sent: Tuesday, June 7, 2022 10:43 AM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t 2/4] tests/kms_sysfs_edid_timing: fail if probing a
> single connector takes too long
>
> From: Luca Coelho <luciano.coelho@intel.com>
>
> There's no point in just warning if probing a single connector takes too long. If a
> test finds any issues, it should just fail.
>
> Convert the warning into an assertion.
>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
> tests/kms_sysfs_edid_timing.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> index 028a5323c0b2..ea0e169e6ed9 100644
> --- a/tests/kms_sysfs_edid_timing.c
> +++ b/tests/kms_sysfs_edid_timing.c
> @@ -81,11 +81,11 @@ igt_simple_main
> mean.max, mean.max / 1e3, mean.max / 1e6,
> mean.mean, mean.mean / 1e3, mean.mean / 1e6);
>
> - if (mean.max > (THRESHOLD_PER_CONNECTOR * 1e6)) {
> - igt_warn("%s: probe time exceed %dms, max=%.2fms,
> avg=%.2fms\n",
> - de->d_name, THRESHOLD_PER_CONNECTOR,
> - mean.max / 1e6, mean.mean / 1e6);
> - }
> + igt_assert_f(mean.max < THRESHOLD_PER_CONNECTOR * 1e6,
> + "%s: probe time exceed %dms, max=%.2fms,
> avg=%.2fms\n",
> + de->d_name, THRESHOLD_PER_CONNECTOR,
> + mean.max / 1e6, mean.mean / 1e6);
> +
> igt_assert_f(mean.mean < (THRESHOLD_TOTAL * 1e6),
> "%s: average probe time exceeded %dms,
> max=%.2fms, avg=%.2fms\n",
> de->d_name, THRESHOLD_TOTAL,
> --
> 2.36.1
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/4] tests/kms_sysfs_edid_timing: clarify test description and thresholds
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 3/4] tests/kms_sysfs_edid_timing: clarify test description and thresholds Luca Coelho
@ 2022-06-08 9:06 ` Kahola, Mika
0 siblings, 0 replies; 17+ messages in thread
From: Kahola, Mika @ 2022-06-08 9:06 UTC (permalink / raw)
To: Luca Coelho, igt-dev
> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Luca
> Coelho
> Sent: Tuesday, June 7, 2022 10:43 AM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t 3/4] tests/kms_sysfs_edid_timing: clarify test
> description and thresholds
>
> From: Luca Coelho <luciano.coelho@intel.com>
>
> The description of this test was cryptic, mentioning a very old patch and so on.
> Clarify what the test actually does.
>
> While at it, improve the assertion messages and clarify the threshold macro
> names.
>
> Additionally, change the mean time threshold per connector to something
> shorter than the threshold per probe, since the former cannot happen without
> the latter already causing an assertion failure.
>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
> tests/kms_sysfs_edid_timing.c | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
>
> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> index ea0e169e6ed9..4255cae3be17 100644
> --- a/tests/kms_sysfs_edid_timing.c
> +++ b/tests/kms_sysfs_edid_timing.c
> @@ -26,16 +26,14 @@
> #include <fcntl.h>
> #include <sys/stat.h>
>
> -#define THRESHOLD_PER_CONNECTOR 50
> -#define THRESHOLD_TOTAL 150
> -#define CHECK_TIMES 15
> -
> -IGT_TEST_DESCRIPTION("This check the time we take to read the content of all
> "
> - "the possible connectors. Without the edid -ENXIO patch "
> -
> "(http://permalink.gmane.org/gmane.comp.video.dri.devel/62083), "
> - "we sometimes take a *really* long time. "
> - "So let's just check for some reasonable timing here");
> +#define THRESHOLD_PER_CONNECTOR 50
> +#define THRESHOLD_PER_CONNECTOR_MEAN 40
> +#define CHECK_TIMES 15
>
> +IGT_TEST_DESCRIPTION("This test checks the time it takes to reprobe each "
> + "connector and fails if either the time it takes for "
> + "one reprobe is too long or if the mean time it takes "
> + "to reprode one connector is too long.");
s/reprode/reprobe perhaps?
Otherwise,
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
>
> igt_simple_main
> {
> @@ -82,13 +80,13 @@ igt_simple_main
> mean.mean, mean.mean / 1e3, mean.mean / 1e6);
>
> igt_assert_f(mean.max < THRESHOLD_PER_CONNECTOR * 1e6,
> - "%s: probe time exceed %dms, max=%.2fms,
> avg=%.2fms\n",
> + "%s: single probe time exceeded %dms,
> max=%.2fms,
> +avg=%.2fms\n",
> de->d_name, THRESHOLD_PER_CONNECTOR,
> mean.max / 1e6, mean.mean / 1e6);
>
> - igt_assert_f(mean.mean < (THRESHOLD_TOTAL * 1e6),
> - "%s: average probe time exceeded %dms,
> max=%.2fms, avg=%.2fms\n",
> - de->d_name, THRESHOLD_TOTAL,
> + igt_assert_f(mean.mean <
> (THRESHOLD_PER_CONNECTOR_MEAN * 1e6),
> + "%s: mean probe time exceeded %dms,
> max=%.2fms, avg=%.2fms\n",
> + de->d_name,
> THRESHOLD_PER_CONNECTOR_MEAN,
> mean.max / 1e6, mean.mean / 1e6);
> }
> closedir(dirp);
> --
> 2.36.1
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 4/4] tests/kms_sysfs_edid_timing: add total mean assertion threshold
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 4/4] tests/kms_sysfs_edid_timing: add total mean assertion threshold Luca Coelho
@ 2022-06-08 9:07 ` Kahola, Mika
2022-06-09 7:28 ` Petri Latvala
1 sibling, 0 replies; 17+ messages in thread
From: Kahola, Mika @ 2022-06-08 9:07 UTC (permalink / raw)
To: Luca Coelho, igt-dev
> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Luca
> Coelho
> Sent: Tuesday, June 7, 2022 10:43 AM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t 4/4] tests/kms_sysfs_edid_timing: add total mean
> assertion threshold
>
> From: Luca Coelho <luciano.coelho@intel.com>
>
> Add an assertion to make sure that the mean time it takes to probe all
> connectors doesn't exceed 30 ms. This is an arbitrary but reasonable amount of
> time.
>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
> tests/kms_sysfs_edid_timing.c | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> index 4255cae3be17..680e4ef5985e 100644
> --- a/tests/kms_sysfs_edid_timing.c
> +++ b/tests/kms_sysfs_edid_timing.c
> @@ -28,21 +28,27 @@
>
> #define THRESHOLD_PER_CONNECTOR 50
> #define THRESHOLD_PER_CONNECTOR_MEAN 40
> +#define THRESHOLD_ALL_CONNECTORS_MEAN 30
> #define CHECK_TIMES 15
>
> IGT_TEST_DESCRIPTION("This test checks the time it takes to reprobe each "
> "connector and fails if either the time it takes for "
> "one reprobe is too long or if the mean time it takes "
> - "to reprode one connector is too long.");
> + "to reprode one connector is too long. Additionally, "
> + "make sure that the mean time for all connectors is "
> + "not too long.");
>
> igt_simple_main
> {
> DIR *dirp;
> struct dirent *de;
> + struct igt_mean all_mean;
>
> dirp = opendir("/sys/class/drm");
> igt_assert(dirp != NULL);
>
> + igt_mean_init(&all_mean);
> +
> while ((de = readdir(dirp))) {
> struct igt_mean mean = {};
> struct stat st;
> @@ -88,7 +94,14 @@ igt_simple_main
> "%s: mean probe time exceeded %dms,
> max=%.2fms, avg=%.2fms\n",
> de->d_name,
> THRESHOLD_PER_CONNECTOR_MEAN,
> mean.max / 1e6, mean.mean / 1e6);
> +
> + igt_mean_add(&all_mean, mean.mean);
> }
> - closedir(dirp);
>
> + igt_assert_f(all_mean.mean < THRESHOLD_ALL_CONNECTORS_MEAN *
> 1e6,
> + "Mean of all connector means exceeds %dms, max=%.2fms,
> mean=%.2fms\n",
> + THRESHOLD_ALL_CONNECTORS_MEAN, all_mean.max /
> 1e6,
> + all_mean.mean / 1e6);
> +
> + closedir(dirp);
> }
> --
> 2.36.1
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 4/4] tests/kms_sysfs_edid_timing: add total mean assertion threshold
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 4/4] tests/kms_sysfs_edid_timing: add total mean assertion threshold Luca Coelho
2022-06-08 9:07 ` Kahola, Mika
@ 2022-06-09 7:28 ` Petri Latvala
1 sibling, 0 replies; 17+ messages in thread
From: Petri Latvala @ 2022-06-09 7:28 UTC (permalink / raw)
To: Luca Coelho; +Cc: igt-dev
On Tue, Jun 07, 2022 at 10:42:40AM +0300, Luca Coelho wrote:
> From: Luca Coelho <luciano.coelho@intel.com>
>
> Add an assertion to make sure that the mean time it takes to probe all
> connectors doesn't exceed 30 ms. This is an arbitrary but reasonable
> amount of time.
>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
37ms on GLK:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-glk9/igt@kms_sysfs_edid_timing.html
--
Petri Latvala
> ---
> tests/kms_sysfs_edid_timing.c | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> index 4255cae3be17..680e4ef5985e 100644
> --- a/tests/kms_sysfs_edid_timing.c
> +++ b/tests/kms_sysfs_edid_timing.c
> @@ -28,21 +28,27 @@
>
> #define THRESHOLD_PER_CONNECTOR 50
> #define THRESHOLD_PER_CONNECTOR_MEAN 40
> +#define THRESHOLD_ALL_CONNECTORS_MEAN 30
> #define CHECK_TIMES 15
>
> IGT_TEST_DESCRIPTION("This test checks the time it takes to reprobe each "
> "connector and fails if either the time it takes for "
> "one reprobe is too long or if the mean time it takes "
> - "to reprode one connector is too long.");
> + "to reprode one connector is too long. Additionally, "
> + "make sure that the mean time for all connectors is "
> + "not too long.");
>
> igt_simple_main
> {
> DIR *dirp;
> struct dirent *de;
> + struct igt_mean all_mean;
>
> dirp = opendir("/sys/class/drm");
> igt_assert(dirp != NULL);
>
> + igt_mean_init(&all_mean);
> +
> while ((de = readdir(dirp))) {
> struct igt_mean mean = {};
> struct stat st;
> @@ -88,7 +94,14 @@ igt_simple_main
> "%s: mean probe time exceeded %dms, max=%.2fms, avg=%.2fms\n",
> de->d_name, THRESHOLD_PER_CONNECTOR_MEAN,
> mean.max / 1e6, mean.mean / 1e6);
> +
> + igt_mean_add(&all_mean, mean.mean);
> }
> - closedir(dirp);
>
> + igt_assert_f(all_mean.mean < THRESHOLD_ALL_CONNECTORS_MEAN * 1e6,
> + "Mean of all connector means exceeds %dms, max=%.2fms, mean=%.2fms\n",
> + THRESHOLD_ALL_CONNECTORS_MEAN, all_mean.max / 1e6,
> + all_mean.mean / 1e6);
> +
> + closedir(dirp);
> }
> --
> 2.36.1
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/4] tests/kms_sysfs_edid_timing: fail if probing a single connector takes too long
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 2/4] tests/kms_sysfs_edid_timing: fail if probing a single connector takes too long Luca Coelho
2022-06-08 9:03 ` Kahola, Mika
@ 2022-06-09 7:32 ` Petri Latvala
2022-06-09 8:49 ` Luca Coelho
1 sibling, 1 reply; 17+ messages in thread
From: Petri Latvala @ 2022-06-09 7:32 UTC (permalink / raw)
To: Luca Coelho; +Cc: igt-dev
On Tue, Jun 07, 2022 at 10:42:38AM +0300, Luca Coelho wrote:
> From: Luca Coelho <luciano.coelho@intel.com>
>
> There's no point in just warning if probing a single connector takes
> too long. If a test finds any issues, it should just fail.
>
> Convert the warning into an assertion.
>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
> tests/kms_sysfs_edid_timing.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> index 028a5323c0b2..ea0e169e6ed9 100644
> --- a/tests/kms_sysfs_edid_timing.c
> +++ b/tests/kms_sysfs_edid_timing.c
> @@ -81,11 +81,11 @@ igt_simple_main
> mean.max, mean.max / 1e3, mean.max / 1e6,
> mean.mean, mean.mean / 1e3, mean.mean / 1e6);
>
> - if (mean.max > (THRESHOLD_PER_CONNECTOR * 1e6)) {
> - igt_warn("%s: probe time exceed %dms, max=%.2fms, avg=%.2fms\n",
> - de->d_name, THRESHOLD_PER_CONNECTOR,
> - mean.max / 1e6, mean.mean / 1e6);
> - }
> + igt_assert_f(mean.max < THRESHOLD_PER_CONNECTOR * 1e6,
> + "%s: probe time exceed %dms, max=%.2fms, avg=%.2fms\n",
> + de->d_name, THRESHOLD_PER_CONNECTOR,
> + mean.max / 1e6, mean.mean / 1e6);
> +
120ms on KBL:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl4/igt@kms_sysfs_edid_timing.html
80-ish ms on APL:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-apl4/igt@kms_sysfs_edid_timing.html
As for whether that makes this IGT patch an acceptable change, depends
on whether those times are considered anomalies that someone plans to
fix somehow...
--
Petri Latvala
> igt_assert_f(mean.mean < (THRESHOLD_TOTAL * 1e6),
> "%s: average probe time exceeded %dms, max=%.2fms, avg=%.2fms\n",
> de->d_name, THRESHOLD_TOTAL,
> --
> 2.36.1
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/4] tests/kms_sysfs_edid_timing: fail if probing a single connector takes too long
2022-06-09 7:32 ` Petri Latvala
@ 2022-06-09 8:49 ` Luca Coelho
2022-06-09 9:55 ` Petri Latvala
0 siblings, 1 reply; 17+ messages in thread
From: Luca Coelho @ 2022-06-09 8:49 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
On Thu, 2022-06-09 at 10:32 +0300, Petri Latvala wrote:
> On Tue, Jun 07, 2022 at 10:42:38AM +0300, Luca Coelho wrote:
> > From: Luca Coelho <luciano.coelho@intel.com>
> >
> > There's no point in just warning if probing a single connector takes
> > too long. If a test finds any issues, it should just fail.
> >
> > Convert the warning into an assertion.
> >
> > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> > ---
> > tests/kms_sysfs_edid_timing.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> > index 028a5323c0b2..ea0e169e6ed9 100644
> > --- a/tests/kms_sysfs_edid_timing.c
> > +++ b/tests/kms_sysfs_edid_timing.c
> > @@ -81,11 +81,11 @@ igt_simple_main
> > mean.max, mean.max / 1e3, mean.max / 1e6,
> > mean.mean, mean.mean / 1e3, mean.mean / 1e6);
> >
> > - if (mean.max > (THRESHOLD_PER_CONNECTOR * 1e6)) {
> > - igt_warn("%s: probe time exceed %dms, max=%.2fms, avg=%.2fms\n",
> > - de->d_name, THRESHOLD_PER_CONNECTOR,
> > - mean.max / 1e6, mean.mean / 1e6);
> > - }
> > + igt_assert_f(mean.max < THRESHOLD_PER_CONNECTOR * 1e6,
> > + "%s: probe time exceed %dms, max=%.2fms, avg=%.2fms\n",
> > + de->d_name, THRESHOLD_PER_CONNECTOR,
> > + mean.max / 1e6, mean.mean / 1e6);
> > +
>
>
> 120ms on KBL:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl4/igt@kms_sysfs_edid_timing.html
>
>
> 80-ish ms on APL:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-apl4/igt@kms_sysfs_edid_timing.html
Thanks for checking these values IRL.
> As for whether that makes this IGT patch an acceptable change, depends
> on whether those times are considered anomalies that someone plans to
> fix somehow...
I don't really know what is considered a reasonable time for this. We
used to have 10 ms which was not enough for almost any platform,
AFAICT. So the tests were already failing (with warnings).
I think it doesn't make sense to differentiate between warning and
assertion failures if both cause the tests to fail. It is just
confusing. Is a warning a failure or not? Can it be ignored? IMHO a
test results should be black and white: fails or doesn't fail.
In any case, I agree that we should find reasonable values that will
work with all platforms. 120 ms sounds really high to me, though. But
I don't really know if this can be fixed.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/4] tests/kms_sysfs_edid_timing: fail if probing a single connector takes too long
2022-06-09 8:49 ` Luca Coelho
@ 2022-06-09 9:55 ` Petri Latvala
2022-06-15 10:49 ` Luca Coelho
0 siblings, 1 reply; 17+ messages in thread
From: Petri Latvala @ 2022-06-09 9:55 UTC (permalink / raw)
To: Luca Coelho, Mika Kahola; +Cc: igt-dev
On Thu, Jun 09, 2022 at 11:49:47AM +0300, Luca Coelho wrote:
> On Thu, 2022-06-09 at 10:32 +0300, Petri Latvala wrote:
> > On Tue, Jun 07, 2022 at 10:42:38AM +0300, Luca Coelho wrote:
> > > From: Luca Coelho <luciano.coelho@intel.com>
> > >
> > > There's no point in just warning if probing a single connector takes
> > > too long. If a test finds any issues, it should just fail.
> > >
> > > Convert the warning into an assertion.
> > >
> > > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> > > ---
> > > tests/kms_sysfs_edid_timing.c | 10 +++++-----
> > > 1 file changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> > > index 028a5323c0b2..ea0e169e6ed9 100644
> > > --- a/tests/kms_sysfs_edid_timing.c
> > > +++ b/tests/kms_sysfs_edid_timing.c
> > > @@ -81,11 +81,11 @@ igt_simple_main
> > > mean.max, mean.max / 1e3, mean.max / 1e6,
> > > mean.mean, mean.mean / 1e3, mean.mean / 1e6);
> > >
> > > - if (mean.max > (THRESHOLD_PER_CONNECTOR * 1e6)) {
> > > - igt_warn("%s: probe time exceed %dms, max=%.2fms, avg=%.2fms\n",
> > > - de->d_name, THRESHOLD_PER_CONNECTOR,
> > > - mean.max / 1e6, mean.mean / 1e6);
> > > - }
> > > + igt_assert_f(mean.max < THRESHOLD_PER_CONNECTOR * 1e6,
> > > + "%s: probe time exceed %dms, max=%.2fms, avg=%.2fms\n",
> > > + de->d_name, THRESHOLD_PER_CONNECTOR,
> > > + mean.max / 1e6, mean.mean / 1e6);
> > > +
> >
> >
> > 120ms on KBL:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl4/igt@kms_sysfs_edid_timing.html
> >
> >
> > 80-ish ms on APL:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-apl4/igt@kms_sysfs_edid_timing.html
>
> Thanks for checking these values IRL.
>
>
> > As for whether that makes this IGT patch an acceptable change, depends
> > on whether those times are considered anomalies that someone plans to
> > fix somehow...
>
> I don't really know what is considered a reasonable time for this. We
> used to have 10 ms which was not enough for almost any platform,
> AFAICT. So the tests were already failing (with warnings).
>
> I think it doesn't make sense to differentiate between warning and
> assertion failures if both cause the tests to fail. It is just
> confusing. Is a warning a failure or not? Can it be ignored? IMHO a
> test results should be black and white: fails or doesn't fail.
>
> In any case, I agree that we should find reasonable values that will
> work with all platforms. 120 ms sounds really high to me, though. But
> I don't really know if this can be fixed.
Fair assessment. Mika, do you remember the history of this test enough
to judge? Or have any insight on selecting a "reasonable" time.
--
Petri Latvala
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/4] tests/kms_sysfs_edid_timing: fail if probing a single connector takes too long
2022-06-09 9:55 ` Petri Latvala
@ 2022-06-15 10:49 ` Luca Coelho
2022-06-15 13:20 ` Kahola, Mika
0 siblings, 1 reply; 17+ messages in thread
From: Luca Coelho @ 2022-06-15 10:49 UTC (permalink / raw)
To: Petri Latvala, Mika Kahola; +Cc: igt-dev
On Thu, 2022-06-09 at 12:55 +0300, Petri Latvala wrote:
> On Thu, Jun 09, 2022 at 11:49:47AM +0300, Luca Coelho wrote:
> > On Thu, 2022-06-09 at 10:32 +0300, Petri Latvala wrote:
> > > On Tue, Jun 07, 2022 at 10:42:38AM +0300, Luca Coelho wrote:
> > > > From: Luca Coelho <luciano.coelho@intel.com>
> > > >
> > > > There's no point in just warning if probing a single connector takes
> > > > too long. If a test finds any issues, it should just fail.
> > > >
> > > > Convert the warning into an assertion.
> > > >
> > > > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> > > > ---
> > > > tests/kms_sysfs_edid_timing.c | 10 +++++-----
> > > > 1 file changed, 5 insertions(+), 5 deletions(-)
> > > >
> > > > diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> > > > index 028a5323c0b2..ea0e169e6ed9 100644
> > > > --- a/tests/kms_sysfs_edid_timing.c
> > > > +++ b/tests/kms_sysfs_edid_timing.c
> > > > @@ -81,11 +81,11 @@ igt_simple_main
> > > > mean.max, mean.max / 1e3, mean.max / 1e6,
> > > > mean.mean, mean.mean / 1e3, mean.mean / 1e6);
> > > >
> > > > - if (mean.max > (THRESHOLD_PER_CONNECTOR * 1e6)) {
> > > > - igt_warn("%s: probe time exceed %dms, max=%.2fms, avg=%.2fms\n",
> > > > - de->d_name, THRESHOLD_PER_CONNECTOR,
> > > > - mean.max / 1e6, mean.mean / 1e6);
> > > > - }
> > > > + igt_assert_f(mean.max < THRESHOLD_PER_CONNECTOR * 1e6,
> > > > + "%s: probe time exceed %dms, max=%.2fms, avg=%.2fms\n",
> > > > + de->d_name, THRESHOLD_PER_CONNECTOR,
> > > > + mean.max / 1e6, mean.mean / 1e6);
> > > > +
> > >
> > >
> > > 120ms on KBL:
> > > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl4/igt@kms_sysfs_edid_timing.html
> > >
> > >
> > > 80-ish ms on APL:
> > > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-apl4/igt@kms_sysfs_edid_timing.html
> >
> > Thanks for checking these values IRL.
> >
> >
> > > As for whether that makes this IGT patch an acceptable change, depends
> > > on whether those times are considered anomalies that someone plans to
> > > fix somehow...
> >
> > I don't really know what is considered a reasonable time for this. We
> > used to have 10 ms which was not enough for almost any platform,
> > AFAICT. So the tests were already failing (with warnings).
> >
> > I think it doesn't make sense to differentiate between warning and
> > assertion failures if both cause the tests to fail. It is just
> > confusing. Is a warning a failure or not? Can it be ignored? IMHO a
> > test results should be black and white: fails or doesn't fail.
> >
> > In any case, I agree that we should find reasonable values that will
> > work with all platforms. 120 ms sounds really high to me, though. But
> > I don't really know if this can be fixed.
>
>
> Fair assessment. Mika, do you remember the history of this test enough
> to judge? Or have any insight on selecting a "reasonable" time.
Mika, any input?
In any case, let's set the threshold to 130 ms for now, so we can at
least be sure it will pass in all the platforms already tested?
It sounds like a huge amount of time to me, but I guess there can be a
lot of external influence as well, such as the time the display takes
to respond or other external issues?
For now, I'll just update my patches to use 130 ms and other higher
thresholds to match what's happening in real life.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/4] tests/kms_sysfs_edid_timing: fail if probing a single connector takes too long
2022-06-15 10:49 ` Luca Coelho
@ 2022-06-15 13:20 ` Kahola, Mika
0 siblings, 0 replies; 17+ messages in thread
From: Kahola, Mika @ 2022-06-15 13:20 UTC (permalink / raw)
To: Luca Coelho, Latvala, Petri; +Cc: igt-dev
> -----Original Message-----
> From: Luca Coelho <luca@coelho.fi>
> Sent: Wednesday, June 15, 2022 1:50 PM
> To: Latvala, Petri <petri.latvala@intel.com>; Kahola, Mika
> <mika.kahola@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t 2/4] tests/kms_sysfs_edid_timing: fail if
> probing a single connector takes too long
>
> On Thu, 2022-06-09 at 12:55 +0300, Petri Latvala wrote:
> > On Thu, Jun 09, 2022 at 11:49:47AM +0300, Luca Coelho wrote:
> > > On Thu, 2022-06-09 at 10:32 +0300, Petri Latvala wrote:
> > > > On Tue, Jun 07, 2022 at 10:42:38AM +0300, Luca Coelho wrote:
> > > > > From: Luca Coelho <luciano.coelho@intel.com>
> > > > >
> > > > > There's no point in just warning if probing a single connector
> > > > > takes too long. If a test finds any issues, it should just fail.
> > > > >
> > > > > Convert the warning into an assertion.
> > > > >
> > > > > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> > > > > ---
> > > > > tests/kms_sysfs_edid_timing.c | 10 +++++-----
> > > > > 1 file changed, 5 insertions(+), 5 deletions(-)
> > > > >
> > > > > diff --git a/tests/kms_sysfs_edid_timing.c
> > > > > b/tests/kms_sysfs_edid_timing.c index 028a5323c0b2..ea0e169e6ed9
> > > > > 100644
> > > > > --- a/tests/kms_sysfs_edid_timing.c
> > > > > +++ b/tests/kms_sysfs_edid_timing.c
> > > > > @@ -81,11 +81,11 @@ igt_simple_main
> > > > > mean.max, mean.max / 1e3, mean.max / 1e6,
> > > > > mean.mean, mean.mean / 1e3, mean.mean / 1e6);
> > > > >
> > > > > - if (mean.max > (THRESHOLD_PER_CONNECTOR * 1e6)) {
> > > > > - igt_warn("%s: probe time exceed %dms, max=%.2fms,
> avg=%.2fms\n",
> > > > > - de->d_name, THRESHOLD_PER_CONNECTOR,
> > > > > - mean.max / 1e6, mean.mean / 1e6);
> > > > > - }
> > > > > + igt_assert_f(mean.max <
> THRESHOLD_PER_CONNECTOR * 1e6,
> > > > > + "%s: probe time exceed %dms, max=%.2fms,
> avg=%.2fms\n",
> > > > > + de->d_name,
> THRESHOLD_PER_CONNECTOR,
> > > > > + mean.max / 1e6, mean.mean / 1e6);
> > > > > +
> > > >
> > > >
> > > > 120ms on KBL:
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-kbl4/igt
> > > > @kms_sysfs_edid_timing.html
> > > >
> > > >
> > > > 80-ish ms on APL:
> > > > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7242/shard-apl4/igt
> > > > @kms_sysfs_edid_timing.html
> > >
> > > Thanks for checking these values IRL.
> > >
> > >
> > > > As for whether that makes this IGT patch an acceptable change,
> > > > depends on whether those times are considered anomalies that
> > > > someone plans to fix somehow...
> > >
> > > I don't really know what is considered a reasonable time for this.
> > > We used to have 10 ms which was not enough for almost any platform,
> > > AFAICT. So the tests were already failing (with warnings).
> > >
> > > I think it doesn't make sense to differentiate between warning and
> > > assertion failures if both cause the tests to fail. It is just
> > > confusing. Is a warning a failure or not? Can it be ignored? IMHO a
> > > test results should be black and white: fails or doesn't fail.
> > >
> > > In any case, I agree that we should find reasonable values that will
> > > work with all platforms. 120 ms sounds really high to me, though.
> > > But I don't really know if this can be fixed.
> >
> >
> > Fair assessment. Mika, do you remember the history of this test enough
> > to judge? Or have any insight on selecting a "reasonable" time.
>
> Mika, any input?
Well, I don't have any better knowledge what the "reasonable" time might be. I remember these to be more or less "trial and error" based guesses.
-Mika-
>
> In any case, let's set the threshold to 130 ms for now, so we can at least be sure
> it will pass in all the platforms already tested?
>
> It sounds like a huge amount of time to me, but I guess there can be a lot of
> external influence as well, such as the time the display takes to respond or other
> external issues?
>
> For now, I'll just update my patches to use 130 ms and other higher thresholds to
> match what's happening in real life.
>
> --
> Cheers,
> Luca.
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2022-06-15 13:20 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-07 7:42 [igt-dev] [PATCH i-g-t 0/4] tests/kms_sysfs_edid_timing: rework thresholds Luca Coelho
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 1/4] tests/kms_sysfs_edid_timing: increase max time thresholds Luca Coelho
2022-06-08 9:03 ` Kahola, Mika
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 2/4] tests/kms_sysfs_edid_timing: fail if probing a single connector takes too long Luca Coelho
2022-06-08 9:03 ` Kahola, Mika
2022-06-09 7:32 ` Petri Latvala
2022-06-09 8:49 ` Luca Coelho
2022-06-09 9:55 ` Petri Latvala
2022-06-15 10:49 ` Luca Coelho
2022-06-15 13:20 ` Kahola, Mika
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 3/4] tests/kms_sysfs_edid_timing: clarify test description and thresholds Luca Coelho
2022-06-08 9:06 ` Kahola, Mika
2022-06-07 7:42 ` [igt-dev] [PATCH i-g-t 4/4] tests/kms_sysfs_edid_timing: add total mean assertion threshold Luca Coelho
2022-06-08 9:07 ` Kahola, Mika
2022-06-09 7:28 ` Petri Latvala
2022-06-07 9:27 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_sysfs_edid_timing: rework thresholds Patchwork
2022-06-07 11:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.