All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org,
	linux-nilfs@vger.kernel.org
Subject: Re: [PATCH 00/10] Convert to filemap_get_folios()
Date: Tue, 7 Jun 2022 13:37:16 +0200	[thread overview]
Message-ID: <20220607113716.aec2o7onzu3re2o4@wittgenstein> (raw)
In-Reply-To: <20220605193854.2371230-1-willy@infradead.org>

On Sun, Jun 05, 2022 at 08:38:44PM +0100, Matthew Wilcox wrote:
> This patch series removes find_get_pages_range(), pagevec_lookup()
> and pagevec_lookup_range(), converting all callers to use the new
> filemap_get_folios().  I've only run xfstests over ext4 ... some other
> testing might be appropriate.
> 
> Matthew Wilcox (Oracle) (10):
>   filemap: Add filemap_get_folios()
>   buffer: Convert clean_bdev_aliases() to use filemap_get_folios()
>   ext4: Convert mpage_release_unused_pages() to use filemap_get_folios()
>   ext4: Convert mpage_map_and_submit_buffers() to use
>     filemap_get_folios()
>   f2fs: Convert f2fs_invalidate_compress_pages() to use
>     filemap_get_folios()
>   hugetlbfs: Convert remove_inode_hugepages() to use
>     filemap_get_folios()
>   nilfs2: Convert nilfs_copy_back_pages() to use filemap_get_folios()
>   vmscan: Add check_move_unevictable_folios()
>   shmem: Convert shmem_unlock_mapping() to use filemap_get_folios()
>   filemap: Remove find_get_pages_range() and associated functions
> 
>  fs/buffer.c             | 26 +++++++--------
>  fs/ext4/inode.c         | 40 ++++++++++++-----------
>  fs/f2fs/compress.c      | 35 +++++++++-----------
>  fs/hugetlbfs/inode.c    | 44 ++++++++-----------------
>  fs/nilfs2/page.c        | 60 +++++++++++++++++-----------------
>  include/linux/pagemap.h |  5 ++-
>  include/linux/pagevec.h | 10 ------
>  include/linux/swap.h    |  3 +-
>  mm/filemap.c            | 72 +++++++++++++++++------------------------
>  mm/shmem.c              | 13 ++++----
>  mm/swap.c               | 29 -----------------
>  mm/vmscan.c             | 55 ++++++++++++++++++-------------
>  12 files changed, 166 insertions(+), 226 deletions(-)

The conversion seems fairly straightforward, so looks good to me.
Acked-by: Christian Brauner (Microsoft) <brauner@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Christian Brauner <brauner@kernel.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 00/10] Convert to filemap_get_folios()
Date: Tue, 7 Jun 2022 13:37:16 +0200	[thread overview]
Message-ID: <20220607113716.aec2o7onzu3re2o4@wittgenstein> (raw)
In-Reply-To: <20220605193854.2371230-1-willy@infradead.org>

On Sun, Jun 05, 2022 at 08:38:44PM +0100, Matthew Wilcox wrote:
> This patch series removes find_get_pages_range(), pagevec_lookup()
> and pagevec_lookup_range(), converting all callers to use the new
> filemap_get_folios().  I've only run xfstests over ext4 ... some other
> testing might be appropriate.
> 
> Matthew Wilcox (Oracle) (10):
>   filemap: Add filemap_get_folios()
>   buffer: Convert clean_bdev_aliases() to use filemap_get_folios()
>   ext4: Convert mpage_release_unused_pages() to use filemap_get_folios()
>   ext4: Convert mpage_map_and_submit_buffers() to use
>     filemap_get_folios()
>   f2fs: Convert f2fs_invalidate_compress_pages() to use
>     filemap_get_folios()
>   hugetlbfs: Convert remove_inode_hugepages() to use
>     filemap_get_folios()
>   nilfs2: Convert nilfs_copy_back_pages() to use filemap_get_folios()
>   vmscan: Add check_move_unevictable_folios()
>   shmem: Convert shmem_unlock_mapping() to use filemap_get_folios()
>   filemap: Remove find_get_pages_range() and associated functions
> 
>  fs/buffer.c             | 26 +++++++--------
>  fs/ext4/inode.c         | 40 ++++++++++++-----------
>  fs/f2fs/compress.c      | 35 +++++++++-----------
>  fs/hugetlbfs/inode.c    | 44 ++++++++-----------------
>  fs/nilfs2/page.c        | 60 +++++++++++++++++-----------------
>  include/linux/pagemap.h |  5 ++-
>  include/linux/pagevec.h | 10 ------
>  include/linux/swap.h    |  3 +-
>  mm/filemap.c            | 72 +++++++++++++++++------------------------
>  mm/shmem.c              | 13 ++++----
>  mm/swap.c               | 29 -----------------
>  mm/vmscan.c             | 55 ++++++++++++++++++-------------
>  12 files changed, 166 insertions(+), 226 deletions(-)

The conversion seems fairly straightforward, so looks good to me.
Acked-by: Christian Brauner (Microsoft) <brauner@kernel.org>


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Christian Brauner <brauner-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "Matthew Wilcox (Oracle)"
	<willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-f2fs-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 00/10] Convert to filemap_get_folios()
Date: Tue, 7 Jun 2022 13:37:16 +0200	[thread overview]
Message-ID: <20220607113716.aec2o7onzu3re2o4@wittgenstein> (raw)
In-Reply-To: <20220605193854.2371230-1-willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>

On Sun, Jun 05, 2022 at 08:38:44PM +0100, Matthew Wilcox wrote:
> This patch series removes find_get_pages_range(), pagevec_lookup()
> and pagevec_lookup_range(), converting all callers to use the new
> filemap_get_folios().  I've only run xfstests over ext4 ... some other
> testing might be appropriate.
> 
> Matthew Wilcox (Oracle) (10):
>   filemap: Add filemap_get_folios()
>   buffer: Convert clean_bdev_aliases() to use filemap_get_folios()
>   ext4: Convert mpage_release_unused_pages() to use filemap_get_folios()
>   ext4: Convert mpage_map_and_submit_buffers() to use
>     filemap_get_folios()
>   f2fs: Convert f2fs_invalidate_compress_pages() to use
>     filemap_get_folios()
>   hugetlbfs: Convert remove_inode_hugepages() to use
>     filemap_get_folios()
>   nilfs2: Convert nilfs_copy_back_pages() to use filemap_get_folios()
>   vmscan: Add check_move_unevictable_folios()
>   shmem: Convert shmem_unlock_mapping() to use filemap_get_folios()
>   filemap: Remove find_get_pages_range() and associated functions
> 
>  fs/buffer.c             | 26 +++++++--------
>  fs/ext4/inode.c         | 40 ++++++++++++-----------
>  fs/f2fs/compress.c      | 35 +++++++++-----------
>  fs/hugetlbfs/inode.c    | 44 ++++++++-----------------
>  fs/nilfs2/page.c        | 60 +++++++++++++++++-----------------
>  include/linux/pagemap.h |  5 ++-
>  include/linux/pagevec.h | 10 ------
>  include/linux/swap.h    |  3 +-
>  mm/filemap.c            | 72 +++++++++++++++++------------------------
>  mm/shmem.c              | 13 ++++----
>  mm/swap.c               | 29 -----------------
>  mm/vmscan.c             | 55 ++++++++++++++++++-------------
>  12 files changed, 166 insertions(+), 226 deletions(-)

The conversion seems fairly straightforward, so looks good to me.
Acked-by: Christian Brauner (Microsoft) <brauner-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

  parent reply	other threads:[~2022-06-07 11:37 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-05 19:38 [PATCH 00/10] Convert to filemap_get_folios() Matthew Wilcox (Oracle)
2022-06-05 19:38 ` Matthew Wilcox (Oracle)
2022-06-05 19:38 ` [f2fs-dev] " Matthew Wilcox (Oracle)
2022-06-05 19:38 ` [PATCH 01/10] filemap: Add filemap_get_folios() Matthew Wilcox (Oracle)
2022-06-05 19:38   ` [f2fs-dev] " Matthew Wilcox (Oracle)
2022-06-08  8:00   ` Christoph Hellwig
2022-06-08  8:00     ` Christoph Hellwig
2022-06-08  8:00     ` [f2fs-dev] " Christoph Hellwig
2022-06-05 19:38 ` [PATCH 02/10] buffer: Convert clean_bdev_aliases() to use filemap_get_folios() Matthew Wilcox (Oracle)
2022-06-05 19:38   ` [f2fs-dev] " Matthew Wilcox (Oracle)
2022-06-08  8:01   ` Christoph Hellwig
2022-06-08  8:01     ` Christoph Hellwig
2022-06-08  8:01     ` [f2fs-dev] " Christoph Hellwig
2022-06-05 19:38 ` [PATCH 03/10] ext4: Convert mpage_release_unused_pages() " Matthew Wilcox (Oracle)
2022-06-05 19:38   ` Matthew Wilcox (Oracle)
2022-06-05 19:38   ` [f2fs-dev] " Matthew Wilcox (Oracle)
2022-06-08  8:02   ` Christoph Hellwig
2022-06-08  8:02     ` Christoph Hellwig
2022-06-08  8:02     ` [f2fs-dev] " Christoph Hellwig
2022-06-08 16:02     ` Matthew Wilcox
2022-06-08 16:02       ` Matthew Wilcox
2022-06-08 16:02       ` [f2fs-dev] " Matthew Wilcox
2022-06-09  3:55       ` Christoph Hellwig
2022-06-09  3:55         ` Christoph Hellwig
2022-06-09  3:55         ` [f2fs-dev] " Christoph Hellwig
2022-06-05 19:38 ` [PATCH 04/10] ext4: Convert mpage_map_and_submit_buffers() " Matthew Wilcox (Oracle)
2022-06-05 19:38   ` [f2fs-dev] " Matthew Wilcox (Oracle)
2022-06-08  8:03   ` Christoph Hellwig
2022-06-08  8:03     ` Christoph Hellwig
2022-06-08  8:03     ` [f2fs-dev] " Christoph Hellwig
2022-06-05 19:38 ` [f2fs-dev] [PATCH 05/10] f2fs: Convert f2fs_invalidate_compress_pages() " Matthew Wilcox (Oracle)
2022-06-05 19:38   ` Matthew Wilcox (Oracle)
2022-06-05 19:38   ` Matthew Wilcox (Oracle)
2022-06-08  8:03   ` Christoph Hellwig
2022-06-08  8:03     ` Christoph Hellwig
2022-06-08  8:03     ` [f2fs-dev] " Christoph Hellwig
2022-06-15  8:14   ` Chao Yu
2022-06-15  8:14     ` Chao Yu
2022-06-05 19:38 ` [PATCH 06/10] hugetlbfs: Convert remove_inode_hugepages() " Matthew Wilcox (Oracle)
2022-06-05 19:38   ` [f2fs-dev] " Matthew Wilcox (Oracle)
2022-06-08  8:04   ` Christoph Hellwig
2022-06-08  8:04     ` Christoph Hellwig
2022-06-08  8:04     ` [f2fs-dev] " Christoph Hellwig
2022-06-10 15:52   ` Sumanth Korikkar
2022-06-10 15:52     ` Sumanth Korikkar
2022-06-10 15:52     ` [f2fs-dev] " Sumanth Korikkar
2022-06-10 18:35     ` Gerald Schaefer
2022-06-10 18:35       ` Gerald Schaefer
2022-06-10 18:35       ` [f2fs-dev] " Gerald Schaefer
2022-06-10 21:17     ` Matthew Wilcox
2022-06-10 21:17       ` [f2fs-dev] " Matthew Wilcox
2022-06-10 21:56       ` Mike Kravetz
2022-06-10 21:56         ` Mike Kravetz
2022-06-10 21:56         ` [f2fs-dev] " Mike Kravetz
2022-06-13  6:56       ` Sumanth Korikkar
2022-06-13  6:56         ` Sumanth Korikkar
2022-06-13  6:56         ` [f2fs-dev] " Sumanth Korikkar
2022-06-05 19:38 ` [PATCH 07/10] nilfs2: Convert nilfs_copy_back_pages() " Matthew Wilcox (Oracle)
2022-06-05 19:38   ` [f2fs-dev] " Matthew Wilcox (Oracle)
2022-06-07 16:10   ` Ryusuke Konishi
2022-06-07 16:10     ` [f2fs-dev] " Ryusuke Konishi
2022-06-08  8:04   ` Christoph Hellwig
2022-06-08  8:04     ` Christoph Hellwig
2022-06-08  8:04     ` [f2fs-dev] " Christoph Hellwig
2022-06-05 19:38 ` [f2fs-dev] [PATCH 08/10] vmscan: Add check_move_unevictable_folios() Matthew Wilcox (Oracle)
2022-06-05 19:38   ` Matthew Wilcox (Oracle)
2022-06-05 19:38   ` Matthew Wilcox (Oracle)
2022-06-08  8:07   ` Christoph Hellwig
2022-06-08  8:07     ` Christoph Hellwig
2022-06-08  8:07     ` [f2fs-dev] " Christoph Hellwig
2022-06-08 16:32     ` Matthew Wilcox
2022-06-08 16:32       ` Matthew Wilcox
2022-06-08 16:32       ` [f2fs-dev] " Matthew Wilcox
2022-06-09  3:56       ` Christoph Hellwig
2022-06-09  3:56         ` Christoph Hellwig
2022-06-09  3:56         ` [f2fs-dev] " Christoph Hellwig
2022-06-08 15:33   ` [vmscan] bc9eb0d5ef: BUG:KASAN:stack-out-of-bounds_in_check_move_unevictable_pages kernel test robot
2022-06-08 15:33     ` kernel test robot
2022-06-05 19:38 ` [PATCH 09/10] shmem: Convert shmem_unlock_mapping() to use filemap_get_folios() Matthew Wilcox (Oracle)
2022-06-05 19:38   ` Matthew Wilcox (Oracle)
2022-06-05 19:38   ` [f2fs-dev] " Matthew Wilcox (Oracle)
2022-06-08  8:08   ` Christoph Hellwig
2022-06-08  8:08     ` Christoph Hellwig
2022-06-08  8:08     ` [f2fs-dev] " Christoph Hellwig
2022-06-05 19:38 ` [PATCH 10/10] filemap: Remove find_get_pages_range() and associated functions Matthew Wilcox (Oracle)
2022-06-05 19:38   ` Matthew Wilcox (Oracle)
2022-06-05 19:38   ` [f2fs-dev] " Matthew Wilcox (Oracle)
2022-06-08  8:08   ` Christoph Hellwig
2022-06-08  8:08     ` Christoph Hellwig
2022-06-08  8:08     ` [f2fs-dev] " Christoph Hellwig
2022-06-07 11:37 ` Christian Brauner [this message]
2022-06-07 11:37   ` [PATCH 00/10] Convert to filemap_get_folios() Christian Brauner
2022-06-07 11:37   ` [f2fs-dev] " Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220607113716.aec2o7onzu3re2o4@wittgenstein \
    --to=brauner@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nilfs@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.