* [PATCH net-next repost] nfp: Remove kernel.h when not needed
@ 2022-06-07 12:51 Simon Horman
2022-06-08 17:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Simon Horman @ 2022-06-07 12:51 UTC (permalink / raw)
To: David Miller, Jakub Kicinski
Cc: netdev, oss-drivers, Christophe JAILLET, Simon Horman
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.
Remove kernel.h when it is not needed.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Simon Horman <simon.horman@corigine.com>
---
drivers/net/ethernet/netronome/nfp/nfpcore/crc32.h | 1 -
1 file changed, 1 deletion(-)
Reposting now that net-next has re-opened
diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/crc32.h b/drivers/net/ethernet/netronome/nfp/nfpcore/crc32.h
index afab6f0fc564..6ad43c7cefe6 100644
--- a/drivers/net/ethernet/netronome/nfp/nfpcore/crc32.h
+++ b/drivers/net/ethernet/netronome/nfp/nfpcore/crc32.h
@@ -4,7 +4,6 @@
#ifndef NFP_CRC32_H
#define NFP_CRC32_H
-#include <linux/kernel.h>
#include <linux/crc32.h>
/**
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next repost] nfp: Remove kernel.h when not needed
2022-06-07 12:51 [PATCH net-next repost] nfp: Remove kernel.h when not needed Simon Horman
@ 2022-06-08 17:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-06-08 17:20 UTC (permalink / raw)
To: Simon Horman; +Cc: davem, kuba, netdev, oss-drivers, christophe.jaillet
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 7 Jun 2022 14:51:03 +0200 you wrote:
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
>
> Remove kernel.h when it is not needed.
>
> [...]
Here is the summary with links:
- [net-next,repost] nfp: Remove kernel.h when not needed
https://git.kernel.org/netdev/net-next/c/17e9157c4ed0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-08 17:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-07 12:51 [PATCH net-next repost] nfp: Remove kernel.h when not needed Simon Horman
2022-06-08 17:20 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.