All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm: bcm2711-rpi-4-b: Add gpio offsets to line name array
@ 2021-11-30 16:11 Uwe Kleine-König
  2021-12-01 11:40 ` nicolas saenz julienne
  0 siblings, 1 reply; 7+ messages in thread
From: Uwe Kleine-König @ 2021-11-30 16:11 UTC (permalink / raw)
  To: Nicolas Saenz Julienne
  Cc: Rob Herring, devicetree, bcm-kernel-feedback-list,
	linux-rpi-kernel, kernel

this helps human readers considerably to determine the line name for a
given offset or vice versa.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 28 +++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
index 631dd5baf68d..4432412044de 100644
--- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
+++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
@@ -65,12 +65,12 @@ &ddc1 {
 };
 
 &expgpio {
-	gpio-line-names = "BT_ON",
+	gpio-line-names = "BT_ON",		/*  0 */
 			  "WL_ON",
 			  "PWR_LED_OFF",
 			  "GLOBAL_RESET",
 			  "VDD_SD_IO_SEL",
-			  "CAM_GPIO",
+			  "CAM_GPIO",		/*  5 */
 			  "SD_PWR_ON",
 			  "";
 };
@@ -84,66 +84,66 @@ &gpio {
 	 * "FOO" = GPIO line named "FOO" on the schematic
 	 * "FOO_N" = GPIO line named "FOO" on schematic, active low
 	 */
-	gpio-line-names = "ID_SDA",
+	gpio-line-names = "ID_SDA",		/*  0 */
 			  "ID_SCL",
 			  "SDA1",
 			  "SCL1",
 			  "GPIO_GCLK",
-			  "GPIO5",
+			  "GPIO5",		/*  5 */
 			  "GPIO6",
 			  "SPI_CE1_N",
 			  "SPI_CE0_N",
 			  "SPI_MISO",
-			  "SPI_MOSI",
+			  "SPI_MOSI",		/* 10 */
 			  "SPI_SCLK",
 			  "GPIO12",
 			  "GPIO13",
 			  /* Serial port */
 			  "TXD1",
-			  "RXD1",
+			  "RXD1",		/* 15 */
 			  "GPIO16",
 			  "GPIO17",
 			  "GPIO18",
 			  "GPIO19",
-			  "GPIO20",
+			  "GPIO20",		/* 20 */
 			  "GPIO21",
 			  "GPIO22",
 			  "GPIO23",
 			  "GPIO24",
-			  "GPIO25",
+			  "GPIO25",		/* 25 */
 			  "GPIO26",
 			  "GPIO27",
 			  "RGMII_MDIO",
 			  "RGMIO_MDC",
 			  /* Used by BT module */
-			  "CTS0",
+			  "CTS0",		/* 30 */
 			  "RTS0",
 			  "TXD0",
 			  "RXD0",
 			  /* Used by Wifi */
 			  "SD1_CLK",
-			  "SD1_CMD",
+			  "SD1_CMD",		/* 35 */
 			  "SD1_DATA0",
 			  "SD1_DATA1",
 			  "SD1_DATA2",
 			  "SD1_DATA3",
 			  /* Shared with SPI flash */
-			  "PWM0_MISO",
+			  "PWM0_MISO",		/* 40 */
 			  "PWM1_MOSI",
 			  "STATUS_LED_G_CLK",
 			  "SPIFLASH_CE_N",
 			  "SDA0",
-			  "SCL0",
+			  "SCL0",		/* 45 */
 			  "RGMII_RXCLK",
 			  "RGMII_RXCTL",
 			  "RGMII_RXD0",
 			  "RGMII_RXD1",
-			  "RGMII_RXD2",
+			  "RGMII_RXD2",		/* 50 */
 			  "RGMII_RXD3",
 			  "RGMII_TXCLK",
 			  "RGMII_TXCTL",
 			  "RGMII_TXD0",
-			  "RGMII_TXD1",
+			  "RGMII_TXD1",		/* 55 */
 			  "RGMII_TXD2",
 			  "RGMII_TXD3";
 };

base-commit: fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] arm: bcm2711-rpi-4-b: Add gpio offsets to line name array
  2021-11-30 16:11 [PATCH] arm: bcm2711-rpi-4-b: Add gpio offsets to line name array Uwe Kleine-König
@ 2021-12-01 11:40 ` nicolas saenz julienne
  2021-12-01 22:16   ` Florian Fainelli
  0 siblings, 1 reply; 7+ messages in thread
From: nicolas saenz julienne @ 2021-12-01 11:40 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Rob Herring, devicetree, bcm-kernel-feedback-list,
	linux-rpi-kernel, kernel

On Tue, 2021-11-30 at 17:11 +0100, Uwe Kleine-König wrote:
> this helps human readers considerably to determine the line name for a
> given offset or vice versa.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---

Applied for next.

Thanks!
Nicolas

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] arm: bcm2711-rpi-4-b: Add gpio offsets to line name array
  2021-12-01 11:40 ` nicolas saenz julienne
@ 2021-12-01 22:16   ` Florian Fainelli
  2021-12-02  8:21     ` nicolas saenz julienne
  0 siblings, 1 reply; 7+ messages in thread
From: Florian Fainelli @ 2021-12-01 22:16 UTC (permalink / raw)
  To: nicolas saenz julienne, Uwe Kleine-König
  Cc: Rob Herring, devicetree, bcm-kernel-feedback-list,
	linux-rpi-kernel, kernel

On 12/1/21 3:40 AM, nicolas saenz julienne wrote:
> On Tue, 2021-11-30 at 17:11 +0100, Uwe Kleine-König wrote:
>> this helps human readers considerably to determine the line name for a
>> given offset or vice versa.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> ---
> 
> Applied for next.

Subject should be:

ARM: dts: bcm2711-rpi-4-b: Add gpio offsets to line name array

Can you fix that up before sending this to me as a pull request? Thanks
-- 
Florian

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] arm: bcm2711-rpi-4-b: Add gpio offsets to line name array
  2021-12-01 22:16   ` Florian Fainelli
@ 2021-12-02  8:21     ` nicolas saenz julienne
  2022-06-08  7:13       ` Uwe Kleine-König
  0 siblings, 1 reply; 7+ messages in thread
From: nicolas saenz julienne @ 2021-12-02  8:21 UTC (permalink / raw)
  To: Florian Fainelli, Uwe Kleine-König
  Cc: Rob Herring, devicetree, bcm-kernel-feedback-list,
	linux-rpi-kernel, kernel

On Wed, 2021-12-01 at 14:16 -0800, Florian Fainelli wrote:
> On 12/1/21 3:40 AM, nicolas saenz julienne wrote:
> > On Tue, 2021-11-30 at 17:11 +0100, Uwe Kleine-König wrote:
> > > this helps human readers considerably to determine the line name for a
> > > given offset or vice versa.
> > > 
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > ---
> > 
> > Applied for next.
> 
> Subject should be:
> 
> ARM: dts: bcm2711-rpi-4-b: Add gpio offsets to line name array
> 
> Can you fix that up before sending this to me as a pull request? Thanks

Done, thanks for catching that one.

Nicolas

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] arm: bcm2711-rpi-4-b: Add gpio offsets to line name array
  2021-12-02  8:21     ` nicolas saenz julienne
@ 2022-06-08  7:13       ` Uwe Kleine-König
  2022-06-08  8:13         ` Florian Fainelli
  0 siblings, 1 reply; 7+ messages in thread
From: Uwe Kleine-König @ 2022-06-08  7:13 UTC (permalink / raw)
  To: nicolas saenz julienne
  Cc: Florian Fainelli, devicetree, Rob Herring,
	bcm-kernel-feedback-list, linux-rpi-kernel, kernel

[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]

Hello Nicolas,

On Thu, Dec 02, 2021 at 09:21:53AM +0100, nicolas saenz julienne wrote:
> On Wed, 2021-12-01 at 14:16 -0800, Florian Fainelli wrote:
> > On 12/1/21 3:40 AM, nicolas saenz julienne wrote:
> > > On Tue, 2021-11-30 at 17:11 +0100, Uwe Kleine-König wrote:
> > > > this helps human readers considerably to determine the line name for a
> > > > given offset or vice versa.
> > > > 
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > > ---
> > > 
> > > Applied for next.
> > 
> > Subject should be:
> > 
> > ARM: dts: bcm2711-rpi-4-b: Add gpio offsets to line name array
> > 
> > Can you fix that up before sending this to me as a pull request? Thanks
> 
> Done, thanks for catching that one.

This patch is in next since 2021-12-16 as ce94980d2970, but didn't hit
mainline yet. What's wrong here?

(Some more digging: Before it was 98aed89336d2 (next-20211213),
0b8152b86818 (next-20211203), 0aa3215c315a (with wrong capitalisation,
next-20211202))

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] arm: bcm2711-rpi-4-b: Add gpio offsets to line name array
  2022-06-08  7:13       ` Uwe Kleine-König
@ 2022-06-08  8:13         ` Florian Fainelli
  2022-06-08 10:50           ` Uwe Kleine-König
  0 siblings, 1 reply; 7+ messages in thread
From: Florian Fainelli @ 2022-06-08  8:13 UTC (permalink / raw)
  To: Uwe Kleine-König, nicolas saenz julienne
  Cc: Florian Fainelli, devicetree, Rob Herring,
	bcm-kernel-feedback-list, linux-rpi-kernel, kernel



On 6/8/2022 9:13 AM, Uwe Kleine-König wrote:
> Hello Nicolas,
> 
> On Thu, Dec 02, 2021 at 09:21:53AM +0100, nicolas saenz julienne wrote:
>> On Wed, 2021-12-01 at 14:16 -0800, Florian Fainelli wrote:
>>> On 12/1/21 3:40 AM, nicolas saenz julienne wrote:
>>>> On Tue, 2021-11-30 at 17:11 +0100, Uwe Kleine-König wrote:
>>>>> this helps human readers considerably to determine the line name for a
>>>>> given offset or vice versa.
>>>>>
>>>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>>>> ---
>>>>
>>>> Applied for next.
>>>
>>> Subject should be:
>>>
>>> ARM: dts: bcm2711-rpi-4-b: Add gpio offsets to line name array
>>>
>>> Can you fix that up before sending this to me as a pull request? Thanks
>>
>> Done, thanks for catching that one.
> 
> This patch is in next since 2021-12-16 as ce94980d2970, but didn't hit
> mainline yet. What's wrong here?

It's there:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5e8c1bf1a0a5c728cee2b6c2162348a9dfddf1bf
-- 
Florian

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] arm: bcm2711-rpi-4-b: Add gpio offsets to line name array
  2022-06-08  8:13         ` Florian Fainelli
@ 2022-06-08 10:50           ` Uwe Kleine-König
  0 siblings, 0 replies; 7+ messages in thread
From: Uwe Kleine-König @ 2022-06-08 10:50 UTC (permalink / raw)
  To: Florian Fainelli
  Cc: nicolas saenz julienne, devicetree, Rob Herring,
	bcm-kernel-feedback-list, linux-rpi-kernel, kernel

[-- Attachment #1: Type: text/plain, Size: 1540 bytes --]

On Wed, Jun 08, 2022 at 10:13:20AM +0200, Florian Fainelli wrote:
> 
> 
> On 6/8/2022 9:13 AM, Uwe Kleine-König wrote:
> > Hello Nicolas,
> > 
> > On Thu, Dec 02, 2021 at 09:21:53AM +0100, nicolas saenz julienne wrote:
> > > On Wed, 2021-12-01 at 14:16 -0800, Florian Fainelli wrote:
> > > > On 12/1/21 3:40 AM, nicolas saenz julienne wrote:
> > > > > On Tue, 2021-11-30 at 17:11 +0100, Uwe Kleine-König wrote:
> > > > > > this helps human readers considerably to determine the line name for a
> > > > > > given offset or vice versa.
> > > > > > 
> > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > > > > ---
> > > > > 
> > > > > Applied for next.
> > > > 
> > > > Subject should be:
> > > > 
> > > > ARM: dts: bcm2711-rpi-4-b: Add gpio offsets to line name array
> > > > 
> > > > Can you fix that up before sending this to me as a pull request? Thanks
> > > 
> > > Done, thanks for catching that one.
> > 
> > This patch is in next since 2021-12-16 as ce94980d2970, but didn't hit
> > mainline yet. What's wrong here?
> 
> It's there:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5e8c1bf1a0a5c728cee2b6c2162348a9dfddf1bf

Thanks, so it's just that the for-next branch in
git://git.kernel.org/pub/scm/linux/kernel/git/nsaenz/linux-rpi.git needs
a rebase.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-06-08 10:50 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-30 16:11 [PATCH] arm: bcm2711-rpi-4-b: Add gpio offsets to line name array Uwe Kleine-König
2021-12-01 11:40 ` nicolas saenz julienne
2021-12-01 22:16   ` Florian Fainelli
2021-12-02  8:21     ` nicolas saenz julienne
2022-06-08  7:13       ` Uwe Kleine-König
2022-06-08  8:13         ` Florian Fainelli
2022-06-08 10:50           ` Uwe Kleine-König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.