All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Stephen Kitt <steve@sk2.org>
Cc: Lee Jones <lee.jones@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] backlight: aat2870: Use backlight helper
Date: Wed, 8 Jun 2022 15:32:33 +0100	[thread overview]
Message-ID: <20220608143233.l5pbopafqc4n6uwq@maple.lan> (raw)
In-Reply-To: <20220607190925.1134737-2-steve@sk2.org>

On Tue, Jun 07, 2022 at 09:09:22PM +0200, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
> 
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> Cc: Helge Deller <deller@gmx.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>


Daniel.

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Stephen Kitt <steve@sk2.org>
Cc: linux-fbdev@vger.kernel.org, Jingoo Han <jingoohan1@gmail.com>,
	Helge Deller <deller@gmx.de>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 1/4] backlight: aat2870: Use backlight helper
Date: Wed, 8 Jun 2022 15:32:33 +0100	[thread overview]
Message-ID: <20220608143233.l5pbopafqc4n6uwq@maple.lan> (raw)
In-Reply-To: <20220607190925.1134737-2-steve@sk2.org>

On Tue, Jun 07, 2022 at 09:09:22PM +0200, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
> 
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> Cc: Helge Deller <deller@gmx.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>


Daniel.

  reply	other threads:[~2022-06-08 14:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 19:09 [PATCH 0/4] video/backlight: Use backlight helpers Stephen Kitt
2022-06-07 19:09 ` Stephen Kitt
2022-06-07 19:09 ` [PATCH 1/4] backlight: aat2870: Use backlight helper Stephen Kitt
2022-06-07 19:09   ` Stephen Kitt
2022-06-08 14:32   ` Daniel Thompson [this message]
2022-06-08 14:32     ` Daniel Thompson
2022-06-07 19:09 ` [PATCH 2/4] backlight: arcxcnn: " Stephen Kitt
2022-06-07 19:09   ` Stephen Kitt
2022-06-08 14:33   ` Daniel Thompson
2022-06-08 14:33     ` Daniel Thompson
2022-06-07 19:09 ` [PATCH 3/4] backlight: ipaq_micro: " Stephen Kitt
2022-06-07 19:09   ` Stephen Kitt
2022-06-08 14:34   ` Daniel Thompson
2022-06-08 14:34     ` Daniel Thompson
2022-06-07 19:09 ` [PATCH 4/4] backlight: tosa: " Stephen Kitt
2022-06-07 19:09   ` Stephen Kitt
2022-06-08 14:36   ` Daniel Thompson
2022-06-08 14:36     ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220608143233.l5pbopafqc4n6uwq@maple.lan \
    --to=daniel.thompson@linaro.org \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steve@sk2.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.