* [PATCH v2 0/3] Add MT8186 ADSP dt-binding
@ 2022-06-09 8:30 ` Tinghan Shen
0 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-09 8:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger, Tinghan Shen,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
v1 -> v2:
1. Change mbox-names from mbox0/mbox1 to rep/req for both mt8186 and mt8195.
2. rename clock-names and remove unused headers
Tinghan Shen (3):
dt-bindings: dsp: mediatek: Use meaningful names for mbox
firmware: mediatek: Use meaningful names for mbox
dt-bindings: dsp: mediatek: add mt8186 dsp document
.../bindings/dsp/mediatek,mt8186-dsp.yaml | 91 +++++++++++++++++++
.../bindings/dsp/mediatek,mt8195-dsp.yaml | 6 +-
drivers/firmware/mtk-adsp-ipc.c | 6 +-
3 files changed, 99 insertions(+), 4 deletions(-)
create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
--
2.18.0
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 0/3] Add MT8186 ADSP dt-binding
@ 2022-06-09 8:30 ` Tinghan Shen
0 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-09 8:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger, Tinghan Shen,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
v1 -> v2:
1. Change mbox-names from mbox0/mbox1 to rep/req for both mt8186 and mt8195.
2. rename clock-names and remove unused headers
Tinghan Shen (3):
dt-bindings: dsp: mediatek: Use meaningful names for mbox
firmware: mediatek: Use meaningful names for mbox
dt-bindings: dsp: mediatek: add mt8186 dsp document
.../bindings/dsp/mediatek,mt8186-dsp.yaml | 91 +++++++++++++++++++
.../bindings/dsp/mediatek,mt8195-dsp.yaml | 6 +-
drivers/firmware/mtk-adsp-ipc.c | 6 +-
3 files changed, 99 insertions(+), 4 deletions(-)
create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 0/3] Add MT8186 ADSP dt-binding
@ 2022-06-09 8:30 ` Tinghan Shen
0 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-09 8:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger, Tinghan Shen,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
v1 -> v2:
1. Change mbox-names from mbox0/mbox1 to rep/req for both mt8186 and mt8195.
2. rename clock-names and remove unused headers
Tinghan Shen (3):
dt-bindings: dsp: mediatek: Use meaningful names for mbox
firmware: mediatek: Use meaningful names for mbox
dt-bindings: dsp: mediatek: add mt8186 dsp document
.../bindings/dsp/mediatek,mt8186-dsp.yaml | 91 +++++++++++++++++++
.../bindings/dsp/mediatek,mt8195-dsp.yaml | 6 +-
drivers/firmware/mtk-adsp-ipc.c | 6 +-
3 files changed, 99 insertions(+), 4 deletions(-)
create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 1/3] dt-bindings: dsp: mediatek: Use meaningful names for mbox
2022-06-09 8:30 ` Tinghan Shen
(?)
@ 2022-06-09 8:30 ` Tinghan Shen
-1 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-09 8:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger, Tinghan Shen,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Rename mbox according to action instead of 'mbox0' and 'mbox1'.
Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
---
.../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
index b7e68b0dfa13..6cedd6868cc5 100644
--- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
+++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
@@ -55,8 +55,8 @@ properties:
mbox-names:
items:
- - const: mbox0
- - const: mbox1
+ - const: rep
+ - const: req
memory-region:
items:
@@ -100,6 +100,6 @@ examples:
memory-region = <&adsp_dma_mem_reserved>,
<&adsp_mem_reserved>;
power-domains = <&spm 6>; //MT8195_POWER_DOMAIN_ADSP
- mbox-names = "mbox0", "mbox1";
+ mbox-names = "rep", "req";
mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
};
--
2.18.0
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 1/3] dt-bindings: dsp: mediatek: Use meaningful names for mbox
@ 2022-06-09 8:30 ` Tinghan Shen
0 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-09 8:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger, Tinghan Shen,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Rename mbox according to action instead of 'mbox0' and 'mbox1'.
Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
---
.../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
index b7e68b0dfa13..6cedd6868cc5 100644
--- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
+++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
@@ -55,8 +55,8 @@ properties:
mbox-names:
items:
- - const: mbox0
- - const: mbox1
+ - const: rep
+ - const: req
memory-region:
items:
@@ -100,6 +100,6 @@ examples:
memory-region = <&adsp_dma_mem_reserved>,
<&adsp_mem_reserved>;
power-domains = <&spm 6>; //MT8195_POWER_DOMAIN_ADSP
- mbox-names = "mbox0", "mbox1";
+ mbox-names = "rep", "req";
mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
};
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 1/3] dt-bindings: dsp: mediatek: Use meaningful names for mbox
@ 2022-06-09 8:30 ` Tinghan Shen
0 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-09 8:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger, Tinghan Shen,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Rename mbox according to action instead of 'mbox0' and 'mbox1'.
Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
---
.../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
index b7e68b0dfa13..6cedd6868cc5 100644
--- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
+++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
@@ -55,8 +55,8 @@ properties:
mbox-names:
items:
- - const: mbox0
- - const: mbox1
+ - const: rep
+ - const: req
memory-region:
items:
@@ -100,6 +100,6 @@ examples:
memory-region = <&adsp_dma_mem_reserved>,
<&adsp_mem_reserved>;
power-domains = <&spm 6>; //MT8195_POWER_DOMAIN_ADSP
- mbox-names = "mbox0", "mbox1";
+ mbox-names = "rep", "req";
mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
};
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 2/3] firmware: mediatek: Use meaningful names for mbox
2022-06-09 8:30 ` Tinghan Shen
(?)
@ 2022-06-09 8:31 ` Tinghan Shen
-1 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-09 8:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger, Tinghan Shen,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Rename mbox according to action instead of 'mbox0' and 'mbox1'
Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
---
drivers/firmware/mtk-adsp-ipc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/mtk-adsp-ipc.c b/drivers/firmware/mtk-adsp-ipc.c
index cb255a99170c..3de94765d659 100644
--- a/drivers/firmware/mtk-adsp-ipc.c
+++ b/drivers/firmware/mtk-adsp-ipc.c
@@ -83,7 +83,11 @@ static int mtk_adsp_ipc_probe(struct platform_device *pdev)
return -ENOMEM;
for (i = 0; i < MTK_ADSP_MBOX_NUM; i++) {
- chan_name = kasprintf(GFP_KERNEL, "mbox%d", i);
+ if (i < MTK_ADSP_MBOX_NUM / 2)
+ chan_name = kasprintf(GFP_KERNEL, "rep");
+ else
+ chan_name = kasprintf(GFP_KERNEL, "req");
+
if (!chan_name) {
ret = -ENOMEM;
goto out;
--
2.18.0
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 2/3] firmware: mediatek: Use meaningful names for mbox
@ 2022-06-09 8:31 ` Tinghan Shen
0 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-09 8:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger, Tinghan Shen,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Rename mbox according to action instead of 'mbox0' and 'mbox1'
Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
---
drivers/firmware/mtk-adsp-ipc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/mtk-adsp-ipc.c b/drivers/firmware/mtk-adsp-ipc.c
index cb255a99170c..3de94765d659 100644
--- a/drivers/firmware/mtk-adsp-ipc.c
+++ b/drivers/firmware/mtk-adsp-ipc.c
@@ -83,7 +83,11 @@ static int mtk_adsp_ipc_probe(struct platform_device *pdev)
return -ENOMEM;
for (i = 0; i < MTK_ADSP_MBOX_NUM; i++) {
- chan_name = kasprintf(GFP_KERNEL, "mbox%d", i);
+ if (i < MTK_ADSP_MBOX_NUM / 2)
+ chan_name = kasprintf(GFP_KERNEL, "rep");
+ else
+ chan_name = kasprintf(GFP_KERNEL, "req");
+
if (!chan_name) {
ret = -ENOMEM;
goto out;
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 2/3] firmware: mediatek: Use meaningful names for mbox
@ 2022-06-09 8:31 ` Tinghan Shen
0 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-09 8:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger, Tinghan Shen,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Rename mbox according to action instead of 'mbox0' and 'mbox1'
Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
---
drivers/firmware/mtk-adsp-ipc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/mtk-adsp-ipc.c b/drivers/firmware/mtk-adsp-ipc.c
index cb255a99170c..3de94765d659 100644
--- a/drivers/firmware/mtk-adsp-ipc.c
+++ b/drivers/firmware/mtk-adsp-ipc.c
@@ -83,7 +83,11 @@ static int mtk_adsp_ipc_probe(struct platform_device *pdev)
return -ENOMEM;
for (i = 0; i < MTK_ADSP_MBOX_NUM; i++) {
- chan_name = kasprintf(GFP_KERNEL, "mbox%d", i);
+ if (i < MTK_ADSP_MBOX_NUM / 2)
+ chan_name = kasprintf(GFP_KERNEL, "rep");
+ else
+ chan_name = kasprintf(GFP_KERNEL, "req");
+
if (!chan_name) {
ret = -ENOMEM;
goto out;
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 3/3] dt-bindings: dsp: mediatek: add mt8186 dsp document
2022-06-09 8:30 ` Tinghan Shen
(?)
@ 2022-06-09 8:31 ` Tinghan Shen
-1 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-09 8:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger, Tinghan Shen,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
This patch adds mt8186 dsp document. The dsp is used for Sound Open
Firmware driver node. It includes registers, clocks, memory regions,
and mailbox for dsp.
Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
---
.../bindings/dsp/mediatek,mt8186-dsp.yaml | 91 +++++++++++++++++++
1 file changed, 91 insertions(+)
create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
new file mode 100644
index 000000000000..33c78f89d296
--- /dev/null
+++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
@@ -0,0 +1,91 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/dsp/mediatek,mt8186-dsp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek mt8186 DSP core
+
+maintainers:
+ - Tinghan Shen <tinghan.shen@mediatek.com>
+
+description: |
+ MediaTek mt8186 SoC contains a DSP core used for
+ advanced pre- and post- audio processing.
+
+properties:
+ compatible:
+ const: mediatek,mt8186-dsp
+
+ reg:
+ items:
+ - description: Address and size of the DSP config registers
+ - description: Address and size of the DSP SRAM
+ - description: Address and size of the DSP secure registers
+ - description: Address and size of the DSP bus registers
+
+ reg-names:
+ items:
+ - const: cfg
+ - const: sram
+ - const: sec
+ - const: bus
+
+ clocks:
+ items:
+ - description: mux for audio dsp clock
+ - description: mux for audio dsp local bus
+
+ clock-names:
+ items:
+ - const: audiodsp
+ - const: adsp_bus
+
+ power-domains:
+ maxItems: 1
+
+ mboxes:
+ items:
+ - description: ipc reply between host and audio DSP.
+ - description: ipc request between host and audio DSP.
+
+ mbox-names:
+ items:
+ - const: rep
+ - const: req
+
+ memory-region:
+ items:
+ - description: dma buffer between host and DSP.
+ - description: DSP system memory.
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - clocks
+ - clock-names
+ - power-domains
+ - mbox-names
+ - mboxes
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/mt8186-clk.h>
+ dsp@10680000 {
+ compatible = "mediatek,mt8186-dsp";
+ reg = <0x10680000 0x2000>,
+ <0x10800000 0x100000>,
+ <0x1068b000 0x100>,
+ <0x1068f000 0x1000>;
+ reg-names = "cfg", "sram", "sec", "bus";
+ clocks = <&topckgen CLK_TOP_AUDIODSP>,
+ <&topckgen CLK_TOP_ADSP_BUS>;
+ clock-names = "audiodsp",
+ "adsp_bus";
+ power-domains = <&spm 6>;
+ mbox-names = "rep", "req";
+ mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
+ };
--
2.18.0
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 3/3] dt-bindings: dsp: mediatek: add mt8186 dsp document
@ 2022-06-09 8:31 ` Tinghan Shen
0 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-09 8:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger, Tinghan Shen,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
This patch adds mt8186 dsp document. The dsp is used for Sound Open
Firmware driver node. It includes registers, clocks, memory regions,
and mailbox for dsp.
Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
---
.../bindings/dsp/mediatek,mt8186-dsp.yaml | 91 +++++++++++++++++++
1 file changed, 91 insertions(+)
create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
new file mode 100644
index 000000000000..33c78f89d296
--- /dev/null
+++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
@@ -0,0 +1,91 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/dsp/mediatek,mt8186-dsp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek mt8186 DSP core
+
+maintainers:
+ - Tinghan Shen <tinghan.shen@mediatek.com>
+
+description: |
+ MediaTek mt8186 SoC contains a DSP core used for
+ advanced pre- and post- audio processing.
+
+properties:
+ compatible:
+ const: mediatek,mt8186-dsp
+
+ reg:
+ items:
+ - description: Address and size of the DSP config registers
+ - description: Address and size of the DSP SRAM
+ - description: Address and size of the DSP secure registers
+ - description: Address and size of the DSP bus registers
+
+ reg-names:
+ items:
+ - const: cfg
+ - const: sram
+ - const: sec
+ - const: bus
+
+ clocks:
+ items:
+ - description: mux for audio dsp clock
+ - description: mux for audio dsp local bus
+
+ clock-names:
+ items:
+ - const: audiodsp
+ - const: adsp_bus
+
+ power-domains:
+ maxItems: 1
+
+ mboxes:
+ items:
+ - description: ipc reply between host and audio DSP.
+ - description: ipc request between host and audio DSP.
+
+ mbox-names:
+ items:
+ - const: rep
+ - const: req
+
+ memory-region:
+ items:
+ - description: dma buffer between host and DSP.
+ - description: DSP system memory.
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - clocks
+ - clock-names
+ - power-domains
+ - mbox-names
+ - mboxes
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/mt8186-clk.h>
+ dsp@10680000 {
+ compatible = "mediatek,mt8186-dsp";
+ reg = <0x10680000 0x2000>,
+ <0x10800000 0x100000>,
+ <0x1068b000 0x100>,
+ <0x1068f000 0x1000>;
+ reg-names = "cfg", "sram", "sec", "bus";
+ clocks = <&topckgen CLK_TOP_AUDIODSP>,
+ <&topckgen CLK_TOP_ADSP_BUS>;
+ clock-names = "audiodsp",
+ "adsp_bus";
+ power-domains = <&spm 6>;
+ mbox-names = "rep", "req";
+ mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
+ };
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 3/3] dt-bindings: dsp: mediatek: add mt8186 dsp document
@ 2022-06-09 8:31 ` Tinghan Shen
0 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-09 8:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger, Tinghan Shen,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
This patch adds mt8186 dsp document. The dsp is used for Sound Open
Firmware driver node. It includes registers, clocks, memory regions,
and mailbox for dsp.
Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
---
.../bindings/dsp/mediatek,mt8186-dsp.yaml | 91 +++++++++++++++++++
1 file changed, 91 insertions(+)
create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
new file mode 100644
index 000000000000..33c78f89d296
--- /dev/null
+++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
@@ -0,0 +1,91 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/dsp/mediatek,mt8186-dsp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek mt8186 DSP core
+
+maintainers:
+ - Tinghan Shen <tinghan.shen@mediatek.com>
+
+description: |
+ MediaTek mt8186 SoC contains a DSP core used for
+ advanced pre- and post- audio processing.
+
+properties:
+ compatible:
+ const: mediatek,mt8186-dsp
+
+ reg:
+ items:
+ - description: Address and size of the DSP config registers
+ - description: Address and size of the DSP SRAM
+ - description: Address and size of the DSP secure registers
+ - description: Address and size of the DSP bus registers
+
+ reg-names:
+ items:
+ - const: cfg
+ - const: sram
+ - const: sec
+ - const: bus
+
+ clocks:
+ items:
+ - description: mux for audio dsp clock
+ - description: mux for audio dsp local bus
+
+ clock-names:
+ items:
+ - const: audiodsp
+ - const: adsp_bus
+
+ power-domains:
+ maxItems: 1
+
+ mboxes:
+ items:
+ - description: ipc reply between host and audio DSP.
+ - description: ipc request between host and audio DSP.
+
+ mbox-names:
+ items:
+ - const: rep
+ - const: req
+
+ memory-region:
+ items:
+ - description: dma buffer between host and DSP.
+ - description: DSP system memory.
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - clocks
+ - clock-names
+ - power-domains
+ - mbox-names
+ - mboxes
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/mt8186-clk.h>
+ dsp@10680000 {
+ compatible = "mediatek,mt8186-dsp";
+ reg = <0x10680000 0x2000>,
+ <0x10800000 0x100000>,
+ <0x1068b000 0x100>,
+ <0x1068f000 0x1000>;
+ reg-names = "cfg", "sram", "sec", "bus";
+ clocks = <&topckgen CLK_TOP_AUDIODSP>,
+ <&topckgen CLK_TOP_ADSP_BUS>;
+ clock-names = "audiodsp",
+ "adsp_bus";
+ power-domains = <&spm 6>;
+ mbox-names = "rep", "req";
+ mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
+ };
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/3] firmware: mediatek: Use meaningful names for mbox
2022-06-09 8:31 ` Tinghan Shen
(?)
@ 2022-06-13 12:37 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 27+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-06-13 12:37 UTC (permalink / raw)
To: Tinghan Shen, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Il 09/06/22 10:31, Tinghan Shen ha scritto:
> Rename mbox according to action instead of 'mbox0' and 'mbox1'
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> drivers/firmware/mtk-adsp-ipc.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/mtk-adsp-ipc.c b/drivers/firmware/mtk-adsp-ipc.c
> index cb255a99170c..3de94765d659 100644
> --- a/drivers/firmware/mtk-adsp-ipc.c
> +++ b/drivers/firmware/mtk-adsp-ipc.c
> @@ -83,7 +83,11 @@ static int mtk_adsp_ipc_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> for (i = 0; i < MTK_ADSP_MBOX_NUM; i++) {
> - chan_name = kasprintf(GFP_KERNEL, "mbox%d", i);
> + if (i < MTK_ADSP_MBOX_NUM / 2)
> + chan_name = kasprintf(GFP_KERNEL, "rep");
> + else
> + chan_name = kasprintf(GFP_KERNEL, "req");
> +
> if (!chan_name) {
> ret = -ENOMEM;
> goto out;
At this point, just call them "reply" and "request", as that simply provides a
perfectly clear explanation.
Besides, I'm sorry but I really don't like this code, it's really too much
fragile and will have to be changed entirely if a third mbox is introduced.
I can suggest a cooler way:
static const char * const adsp_mbox_ch_names[MTK_ADSP_MBOX_NUM] = { "rep", "req" };
for (i = 0; i < ARRAY_SIZE(adsp_mbox_ch_names); i++) {
/* we can delete chan_name and also avoid a kfree if we do... */
.... code ....
adsp_chan->ch = mbox_request_channel_byname(cl, adsp_mbox_ch_names[i]);
... etc etc ...
}
Cheers,
Angelo
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/3] firmware: mediatek: Use meaningful names for mbox
@ 2022-06-13 12:37 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 27+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-06-13 12:37 UTC (permalink / raw)
To: Tinghan Shen, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Il 09/06/22 10:31, Tinghan Shen ha scritto:
> Rename mbox according to action instead of 'mbox0' and 'mbox1'
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> drivers/firmware/mtk-adsp-ipc.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/mtk-adsp-ipc.c b/drivers/firmware/mtk-adsp-ipc.c
> index cb255a99170c..3de94765d659 100644
> --- a/drivers/firmware/mtk-adsp-ipc.c
> +++ b/drivers/firmware/mtk-adsp-ipc.c
> @@ -83,7 +83,11 @@ static int mtk_adsp_ipc_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> for (i = 0; i < MTK_ADSP_MBOX_NUM; i++) {
> - chan_name = kasprintf(GFP_KERNEL, "mbox%d", i);
> + if (i < MTK_ADSP_MBOX_NUM / 2)
> + chan_name = kasprintf(GFP_KERNEL, "rep");
> + else
> + chan_name = kasprintf(GFP_KERNEL, "req");
> +
> if (!chan_name) {
> ret = -ENOMEM;
> goto out;
At this point, just call them "reply" and "request", as that simply provides a
perfectly clear explanation.
Besides, I'm sorry but I really don't like this code, it's really too much
fragile and will have to be changed entirely if a third mbox is introduced.
I can suggest a cooler way:
static const char * const adsp_mbox_ch_names[MTK_ADSP_MBOX_NUM] = { "rep", "req" };
for (i = 0; i < ARRAY_SIZE(adsp_mbox_ch_names); i++) {
/* we can delete chan_name and also avoid a kfree if we do... */
.... code ....
adsp_chan->ch = mbox_request_channel_byname(cl, adsp_mbox_ch_names[i]);
... etc etc ...
}
Cheers,
Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/3] firmware: mediatek: Use meaningful names for mbox
@ 2022-06-13 12:37 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 27+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-06-13 12:37 UTC (permalink / raw)
To: Tinghan Shen, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Il 09/06/22 10:31, Tinghan Shen ha scritto:
> Rename mbox according to action instead of 'mbox0' and 'mbox1'
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> drivers/firmware/mtk-adsp-ipc.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/mtk-adsp-ipc.c b/drivers/firmware/mtk-adsp-ipc.c
> index cb255a99170c..3de94765d659 100644
> --- a/drivers/firmware/mtk-adsp-ipc.c
> +++ b/drivers/firmware/mtk-adsp-ipc.c
> @@ -83,7 +83,11 @@ static int mtk_adsp_ipc_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> for (i = 0; i < MTK_ADSP_MBOX_NUM; i++) {
> - chan_name = kasprintf(GFP_KERNEL, "mbox%d", i);
> + if (i < MTK_ADSP_MBOX_NUM / 2)
> + chan_name = kasprintf(GFP_KERNEL, "rep");
> + else
> + chan_name = kasprintf(GFP_KERNEL, "req");
> +
> if (!chan_name) {
> ret = -ENOMEM;
> goto out;
At this point, just call them "reply" and "request", as that simply provides a
perfectly clear explanation.
Besides, I'm sorry but I really don't like this code, it's really too much
fragile and will have to be changed entirely if a third mbox is introduced.
I can suggest a cooler way:
static const char * const adsp_mbox_ch_names[MTK_ADSP_MBOX_NUM] = { "rep", "req" };
for (i = 0; i < ARRAY_SIZE(adsp_mbox_ch_names); i++) {
/* we can delete chan_name and also avoid a kfree if we do... */
.... code ....
adsp_chan->ch = mbox_request_channel_byname(cl, adsp_mbox_ch_names[i]);
... etc etc ...
}
Cheers,
Angelo
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: dsp: mediatek: Use meaningful names for mbox
2022-06-09 8:30 ` Tinghan Shen
(?)
@ 2022-06-13 12:41 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 27+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-06-13 12:41 UTC (permalink / raw)
To: Tinghan Shen, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Il 09/06/22 10:30, Tinghan Shen ha scritto:
> Rename mbox according to action instead of 'mbox0' and 'mbox1'.
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> index b7e68b0dfa13..6cedd6868cc5 100644
> --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> @@ -55,8 +55,8 @@ properties:
>
> mbox-names:
> items:
> - - const: mbox0
> - - const: mbox1
> + - const: rep
> + - const: req
"reply", "request" - as said on patch [2/3]....
P.S.: Adding context for anyone else reading this patch, mt8195 devicetrees didn't
get any dsp node yet.
>
> memory-region:
> items:
> @@ -100,6 +100,6 @@ examples:
> memory-region = <&adsp_dma_mem_reserved>,
> <&adsp_mem_reserved>;
> power-domains = <&spm 6>; //MT8195_POWER_DOMAIN_ADSP
> - mbox-names = "mbox0", "mbox1";
> + mbox-names = "rep", "req";
> mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
> };
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: dsp: mediatek: Use meaningful names for mbox
@ 2022-06-13 12:41 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 27+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-06-13 12:41 UTC (permalink / raw)
To: Tinghan Shen, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Il 09/06/22 10:30, Tinghan Shen ha scritto:
> Rename mbox according to action instead of 'mbox0' and 'mbox1'.
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> index b7e68b0dfa13..6cedd6868cc5 100644
> --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> @@ -55,8 +55,8 @@ properties:
>
> mbox-names:
> items:
> - - const: mbox0
> - - const: mbox1
> + - const: rep
> + - const: req
"reply", "request" - as said on patch [2/3]....
P.S.: Adding context for anyone else reading this patch, mt8195 devicetrees didn't
get any dsp node yet.
>
> memory-region:
> items:
> @@ -100,6 +100,6 @@ examples:
> memory-region = <&adsp_dma_mem_reserved>,
> <&adsp_mem_reserved>;
> power-domains = <&spm 6>; //MT8195_POWER_DOMAIN_ADSP
> - mbox-names = "mbox0", "mbox1";
> + mbox-names = "rep", "req";
> mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
> };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: dsp: mediatek: Use meaningful names for mbox
@ 2022-06-13 12:41 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 27+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-06-13 12:41 UTC (permalink / raw)
To: Tinghan Shen, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Il 09/06/22 10:30, Tinghan Shen ha scritto:
> Rename mbox according to action instead of 'mbox0' and 'mbox1'.
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> index b7e68b0dfa13..6cedd6868cc5 100644
> --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> @@ -55,8 +55,8 @@ properties:
>
> mbox-names:
> items:
> - - const: mbox0
> - - const: mbox1
> + - const: rep
> + - const: req
"reply", "request" - as said on patch [2/3]....
P.S.: Adding context for anyone else reading this patch, mt8195 devicetrees didn't
get any dsp node yet.
>
> memory-region:
> items:
> @@ -100,6 +100,6 @@ examples:
> memory-region = <&adsp_dma_mem_reserved>,
> <&adsp_mem_reserved>;
> power-domains = <&spm 6>; //MT8195_POWER_DOMAIN_ADSP
> - mbox-names = "mbox0", "mbox1";
> + mbox-names = "rep", "req";
> mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
> };
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/3] firmware: mediatek: Use meaningful names for mbox
2022-06-13 12:37 ` AngeloGioacchino Del Regno
(?)
@ 2022-06-15 3:22 ` Tinghan Shen
-1 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-15 3:22 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger, Mark Brown, YC Hung, Curtis Malainey,
Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Hi Angelo,
On Mon, 2022-06-13 at 14:37 +0200, AngeloGioacchino Del Regno wrote:
> Il 09/06/22 10:31, Tinghan Shen ha scritto:
> > Rename mbox according to action instead of 'mbox0' and 'mbox1'
> >
> > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> > ---
> > drivers/firmware/mtk-adsp-ipc.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/mtk-adsp-ipc.c b/drivers/firmware/mtk-adsp-ipc.c
> > index cb255a99170c..3de94765d659 100644
> > --- a/drivers/firmware/mtk-adsp-ipc.c
> > +++ b/drivers/firmware/mtk-adsp-ipc.c
> > @@ -83,7 +83,11 @@ static int mtk_adsp_ipc_probe(struct platform_device *pdev)
> > return -ENOMEM;
> >
> > for (i = 0; i < MTK_ADSP_MBOX_NUM; i++) {
> > - chan_name = kasprintf(GFP_KERNEL, "mbox%d", i);
> > + if (i < MTK_ADSP_MBOX_NUM / 2)
> > + chan_name = kasprintf(GFP_KERNEL, "rep");
> > + else
> > + chan_name = kasprintf(GFP_KERNEL, "req");
> > +
> > if (!chan_name) {
> > ret = -ENOMEM;
> > goto out;
>
> At this point, just call them "reply" and "request", as that simply provides a
> perfectly clear explanation.
>
> Besides, I'm sorry but I really don't like this code, it's really too much
> fragile and will have to be changed entirely if a third mbox is introduced.
>
> I can suggest a cooler way:
>
> static const char * const adsp_mbox_ch_names[MTK_ADSP_MBOX_NUM] = { "rep", "req" };
>
> for (i = 0; i < ARRAY_SIZE(adsp_mbox_ch_names); i++) {
> /* we can delete chan_name and also avoid a kfree if we do... */
>
> .... code ....
>
> adsp_chan->ch = mbox_request_channel_byname(cl, adsp_mbox_ch_names[i]);
>
> ... etc etc ...
> }
>
> Cheers,
> Angelo
Ok, I'll update in the next version.
Thank you!
Best regards,
TingHan
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/3] firmware: mediatek: Use meaningful names for mbox
@ 2022-06-15 3:22 ` Tinghan Shen
0 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-15 3:22 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger, Mark Brown, YC Hung, Curtis Malainey,
Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Hi Angelo,
On Mon, 2022-06-13 at 14:37 +0200, AngeloGioacchino Del Regno wrote:
> Il 09/06/22 10:31, Tinghan Shen ha scritto:
> > Rename mbox according to action instead of 'mbox0' and 'mbox1'
> >
> > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> > ---
> > drivers/firmware/mtk-adsp-ipc.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/mtk-adsp-ipc.c b/drivers/firmware/mtk-adsp-ipc.c
> > index cb255a99170c..3de94765d659 100644
> > --- a/drivers/firmware/mtk-adsp-ipc.c
> > +++ b/drivers/firmware/mtk-adsp-ipc.c
> > @@ -83,7 +83,11 @@ static int mtk_adsp_ipc_probe(struct platform_device *pdev)
> > return -ENOMEM;
> >
> > for (i = 0; i < MTK_ADSP_MBOX_NUM; i++) {
> > - chan_name = kasprintf(GFP_KERNEL, "mbox%d", i);
> > + if (i < MTK_ADSP_MBOX_NUM / 2)
> > + chan_name = kasprintf(GFP_KERNEL, "rep");
> > + else
> > + chan_name = kasprintf(GFP_KERNEL, "req");
> > +
> > if (!chan_name) {
> > ret = -ENOMEM;
> > goto out;
>
> At this point, just call them "reply" and "request", as that simply provides a
> perfectly clear explanation.
>
> Besides, I'm sorry but I really don't like this code, it's really too much
> fragile and will have to be changed entirely if a third mbox is introduced.
>
> I can suggest a cooler way:
>
> static const char * const adsp_mbox_ch_names[MTK_ADSP_MBOX_NUM] = { "rep", "req" };
>
> for (i = 0; i < ARRAY_SIZE(adsp_mbox_ch_names); i++) {
> /* we can delete chan_name and also avoid a kfree if we do... */
>
> .... code ....
>
> adsp_chan->ch = mbox_request_channel_byname(cl, adsp_mbox_ch_names[i]);
>
> ... etc etc ...
> }
>
> Cheers,
> Angelo
Ok, I'll update in the next version.
Thank you!
Best regards,
TingHan
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/3] firmware: mediatek: Use meaningful names for mbox
@ 2022-06-15 3:22 ` Tinghan Shen
0 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-15 3:22 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger, Mark Brown, YC Hung, Curtis Malainey,
Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Hi Angelo,
On Mon, 2022-06-13 at 14:37 +0200, AngeloGioacchino Del Regno wrote:
> Il 09/06/22 10:31, Tinghan Shen ha scritto:
> > Rename mbox according to action instead of 'mbox0' and 'mbox1'
> >
> > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> > ---
> > drivers/firmware/mtk-adsp-ipc.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/mtk-adsp-ipc.c b/drivers/firmware/mtk-adsp-ipc.c
> > index cb255a99170c..3de94765d659 100644
> > --- a/drivers/firmware/mtk-adsp-ipc.c
> > +++ b/drivers/firmware/mtk-adsp-ipc.c
> > @@ -83,7 +83,11 @@ static int mtk_adsp_ipc_probe(struct platform_device *pdev)
> > return -ENOMEM;
> >
> > for (i = 0; i < MTK_ADSP_MBOX_NUM; i++) {
> > - chan_name = kasprintf(GFP_KERNEL, "mbox%d", i);
> > + if (i < MTK_ADSP_MBOX_NUM / 2)
> > + chan_name = kasprintf(GFP_KERNEL, "rep");
> > + else
> > + chan_name = kasprintf(GFP_KERNEL, "req");
> > +
> > if (!chan_name) {
> > ret = -ENOMEM;
> > goto out;
>
> At this point, just call them "reply" and "request", as that simply provides a
> perfectly clear explanation.
>
> Besides, I'm sorry but I really don't like this code, it's really too much
> fragile and will have to be changed entirely if a third mbox is introduced.
>
> I can suggest a cooler way:
>
> static const char * const adsp_mbox_ch_names[MTK_ADSP_MBOX_NUM] = { "rep", "req" };
>
> for (i = 0; i < ARRAY_SIZE(adsp_mbox_ch_names); i++) {
> /* we can delete chan_name and also avoid a kfree if we do... */
>
> .... code ....
>
> adsp_chan->ch = mbox_request_channel_byname(cl, adsp_mbox_ch_names[i]);
>
> ... etc etc ...
> }
>
> Cheers,
> Angelo
Ok, I'll update in the next version.
Thank you!
Best regards,
TingHan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: dsp: mediatek: Use meaningful names for mbox
2022-06-09 8:30 ` Tinghan Shen
@ 2022-06-15 17:30 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 27+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-15 17:30 UTC (permalink / raw)
To: Tinghan Shen, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
On 09/06/2022 01:30, Tinghan Shen wrote:
> Rename mbox according to action instead of 'mbox0' and 'mbox1'.
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> index b7e68b0dfa13..6cedd6868cc5 100644
> --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> @@ -55,8 +55,8 @@ properties:
>
> mbox-names:
> items:
> - - const: mbox0
> - - const: mbox1
> + - const: rep
> + - const: req
>
More common is rx/tx, which I proposed last time.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: dsp: mediatek: Use meaningful names for mbox
@ 2022-06-15 17:30 ` Krzysztof Kozlowski
0 siblings, 0 replies; 27+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-15 17:30 UTC (permalink / raw)
To: Tinghan Shen, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
On 09/06/2022 01:30, Tinghan Shen wrote:
> Rename mbox according to action instead of 'mbox0' and 'mbox1'.
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> index b7e68b0dfa13..6cedd6868cc5 100644
> --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> @@ -55,8 +55,8 @@ properties:
>
> mbox-names:
> items:
> - - const: mbox0
> - - const: mbox1
> + - const: rep
> + - const: req
>
More common is rx/tx, which I proposed last time.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: dsp: mediatek: add mt8186 dsp document
2022-06-09 8:31 ` Tinghan Shen
@ 2022-06-15 17:32 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 27+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-15 17:32 UTC (permalink / raw)
To: Tinghan Shen, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
On 09/06/2022 01:31, Tinghan Shen wrote:
> This patch adds mt8186 dsp document. The dsp is used for Sound Open
> Firmware driver node. It includes registers, clocks, memory regions,
> and mailbox for dsp.
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> .../bindings/dsp/mediatek,mt8186-dsp.yaml | 91 +++++++++++++++++++
> 1 file changed, 91 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
>
> diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
> new file mode 100644
> index 000000000000..33c78f89d296
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
> @@ -0,0 +1,91 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dsp/mediatek,mt8186-dsp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek mt8186 DSP core
> +
> +maintainers:
> + - Tinghan Shen <tinghan.shen@mediatek.com>
> +
> +description: |
> + MediaTek mt8186 SoC contains a DSP core used for
> + advanced pre- and post- audio processing.
> +
> +properties:
> + compatible:
> + const: mediatek,mt8186-dsp
> +
> + reg:
> + items:
> + - description: Address and size of the DSP config registers
> + - description: Address and size of the DSP SRAM
> + - description: Address and size of the DSP secure registers
> + - description: Address and size of the DSP bus registers
> +
> + reg-names:
> + items:
> + - const: cfg
> + - const: sram
> + - const: sec
> + - const: bus
> +
> + clocks:
> + items:
> + - description: mux for audio dsp clock
> + - description: mux for audio dsp local bus
> +
> + clock-names:
> + items:
> + - const: audiodsp
> + - const: adsp_bus
> +
> + power-domains:
> + maxItems: 1
> +
> + mboxes:
> + items:
> + - description: ipc reply between host and audio DSP.
> + - description: ipc request between host and audio DSP.
"IPC request between" does not specify who sends the request. Host or DSP?
See existing bindings for some better examples, e.g.:
Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.yaml
which clearly states who receives from who.
> +
> + mbox-names:
> + items:
> + - const: rep
> + - const: req
tx/rx
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: dsp: mediatek: add mt8186 dsp document
@ 2022-06-15 17:32 ` Krzysztof Kozlowski
0 siblings, 0 replies; 27+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-15 17:32 UTC (permalink / raw)
To: Tinghan Shen, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Mark Brown, YC Hung, Curtis Malainey, Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
On 09/06/2022 01:31, Tinghan Shen wrote:
> This patch adds mt8186 dsp document. The dsp is used for Sound Open
> Firmware driver node. It includes registers, clocks, memory regions,
> and mailbox for dsp.
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> .../bindings/dsp/mediatek,mt8186-dsp.yaml | 91 +++++++++++++++++++
> 1 file changed, 91 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
>
> diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
> new file mode 100644
> index 000000000000..33c78f89d296
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
> @@ -0,0 +1,91 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dsp/mediatek,mt8186-dsp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek mt8186 DSP core
> +
> +maintainers:
> + - Tinghan Shen <tinghan.shen@mediatek.com>
> +
> +description: |
> + MediaTek mt8186 SoC contains a DSP core used for
> + advanced pre- and post- audio processing.
> +
> +properties:
> + compatible:
> + const: mediatek,mt8186-dsp
> +
> + reg:
> + items:
> + - description: Address and size of the DSP config registers
> + - description: Address and size of the DSP SRAM
> + - description: Address and size of the DSP secure registers
> + - description: Address and size of the DSP bus registers
> +
> + reg-names:
> + items:
> + - const: cfg
> + - const: sram
> + - const: sec
> + - const: bus
> +
> + clocks:
> + items:
> + - description: mux for audio dsp clock
> + - description: mux for audio dsp local bus
> +
> + clock-names:
> + items:
> + - const: audiodsp
> + - const: adsp_bus
> +
> + power-domains:
> + maxItems: 1
> +
> + mboxes:
> + items:
> + - description: ipc reply between host and audio DSP.
> + - description: ipc request between host and audio DSP.
"IPC request between" does not specify who sends the request. Host or DSP?
See existing bindings for some better examples, e.g.:
Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.yaml
which clearly states who receives from who.
> +
> + mbox-names:
> + items:
> + - const: rep
> + - const: req
tx/rx
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: dsp: mediatek: add mt8186 dsp document
2022-06-15 17:32 ` Krzysztof Kozlowski
@ 2022-06-16 7:34 ` Tinghan Shen
-1 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-16 7:34 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger, Mark Brown, YC Hung, Curtis Malainey,
Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Hi Krzysztof,
On Wed, 2022-06-15 at 10:32 -0700, Krzysztof Kozlowski wrote:
> On 09/06/2022 01:31, Tinghan Shen wrote:
> > This patch adds mt8186 dsp document. The dsp is used for Sound Open
> > Firmware driver node. It includes registers, clocks, memory regions,
> > and mailbox for dsp.
> >
> > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> > ---
> > .../bindings/dsp/mediatek,mt8186-dsp.yaml | 91 +++++++++++++++++++
> > 1 file changed, 91 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
> > b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
> > new file mode 100644
> > index 000000000000..33c78f89d296
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
> > @@ -0,0 +1,91 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/dsp/mediatek,mt8186-dsp.yaml*__;Iw!!CTRNKA9wMg0ARbw!0iJc3XTOVoKM_s-soALULRxog7f0GZLppKL0FCcIrYfh91fW2HmlpzSUZjVmoUR5PrasY2BmVGvmvv_IwZtlmOdXYw$
> >
> > +$schema:
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!0iJc3XTOVoKM_s-soALULRxog7f0GZLppKL0FCcIrYfh91fW2HmlpzSUZjVmoUR5PrasY2BmVGvmvv_IwZujnl7wMw$
> >
> > +
> > +title: MediaTek mt8186 DSP core
> > +
> > +maintainers:
> > + - Tinghan Shen <tinghan.shen@mediatek.com>
> > +
> > +description: |
> > + MediaTek mt8186 SoC contains a DSP core used for
> > + advanced pre- and post- audio processing.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt8186-dsp
> > +
> > + reg:
> > + items:
> > + - description: Address and size of the DSP config registers
> > + - description: Address and size of the DSP SRAM
> > + - description: Address and size of the DSP secure registers
> > + - description: Address and size of the DSP bus registers
> > +
> > + reg-names:
> > + items:
> > + - const: cfg
> > + - const: sram
> > + - const: sec
> > + - const: bus
> > +
> > + clocks:
> > + items:
> > + - description: mux for audio dsp clock
> > + - description: mux for audio dsp local bus
> > +
> > + clock-names:
> > + items:
> > + - const: audiodsp
> > + - const: adsp_bus
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + mboxes:
> > + items:
> > + - description: ipc reply between host and audio DSP.
> > + - description: ipc request between host and audio DSP.
>
> "IPC request between" does not specify who sends the request. Host or DSP?
>
> See existing bindings for some better examples, e.g.:
> Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.yaml
> which clearly states who receives from who.
>
> > +
> > + mbox-names:
> > + items:
> > + - const: rep
> > + - const: req
>
> tx/rx
>
>
>
>
> Best regards,
> Krzysztof
OK. I'll update in the next version.
Thanks,
TingHan
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: dsp: mediatek: add mt8186 dsp document
@ 2022-06-16 7:34 ` Tinghan Shen
0 siblings, 0 replies; 27+ messages in thread
From: Tinghan Shen @ 2022-06-16 7:34 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger, Mark Brown, YC Hung, Curtis Malainey,
Allen-KH Cheng
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Hi Krzysztof,
On Wed, 2022-06-15 at 10:32 -0700, Krzysztof Kozlowski wrote:
> On 09/06/2022 01:31, Tinghan Shen wrote:
> > This patch adds mt8186 dsp document. The dsp is used for Sound Open
> > Firmware driver node. It includes registers, clocks, memory regions,
> > and mailbox for dsp.
> >
> > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> > ---
> > .../bindings/dsp/mediatek,mt8186-dsp.yaml | 91 +++++++++++++++++++
> > 1 file changed, 91 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
> > b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
> > new file mode 100644
> > index 000000000000..33c78f89d296
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml
> > @@ -0,0 +1,91 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/dsp/mediatek,mt8186-dsp.yaml*__;Iw!!CTRNKA9wMg0ARbw!0iJc3XTOVoKM_s-soALULRxog7f0GZLppKL0FCcIrYfh91fW2HmlpzSUZjVmoUR5PrasY2BmVGvmvv_IwZtlmOdXYw$
> >
> > +$schema:
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!0iJc3XTOVoKM_s-soALULRxog7f0GZLppKL0FCcIrYfh91fW2HmlpzSUZjVmoUR5PrasY2BmVGvmvv_IwZujnl7wMw$
> >
> > +
> > +title: MediaTek mt8186 DSP core
> > +
> > +maintainers:
> > + - Tinghan Shen <tinghan.shen@mediatek.com>
> > +
> > +description: |
> > + MediaTek mt8186 SoC contains a DSP core used for
> > + advanced pre- and post- audio processing.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt8186-dsp
> > +
> > + reg:
> > + items:
> > + - description: Address and size of the DSP config registers
> > + - description: Address and size of the DSP SRAM
> > + - description: Address and size of the DSP secure registers
> > + - description: Address and size of the DSP bus registers
> > +
> > + reg-names:
> > + items:
> > + - const: cfg
> > + - const: sram
> > + - const: sec
> > + - const: bus
> > +
> > + clocks:
> > + items:
> > + - description: mux for audio dsp clock
> > + - description: mux for audio dsp local bus
> > +
> > + clock-names:
> > + items:
> > + - const: audiodsp
> > + - const: adsp_bus
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + mboxes:
> > + items:
> > + - description: ipc reply between host and audio DSP.
> > + - description: ipc request between host and audio DSP.
>
> "IPC request between" does not specify who sends the request. Host or DSP?
>
> See existing bindings for some better examples, e.g.:
> Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.yaml
> which clearly states who receives from who.
>
> > +
> > + mbox-names:
> > + items:
> > + - const: rep
> > + - const: req
>
> tx/rx
>
>
>
>
> Best regards,
> Krzysztof
OK. I'll update in the next version.
Thanks,
TingHan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 27+ messages in thread
end of thread, other threads:[~2022-06-16 7:45 UTC | newest]
Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-09 8:30 [PATCH v2 0/3] Add MT8186 ADSP dt-binding Tinghan Shen
2022-06-09 8:30 ` Tinghan Shen
2022-06-09 8:30 ` Tinghan Shen
2022-06-09 8:30 ` [PATCH v2 1/3] dt-bindings: dsp: mediatek: Use meaningful names for mbox Tinghan Shen
2022-06-09 8:30 ` Tinghan Shen
2022-06-09 8:30 ` Tinghan Shen
2022-06-13 12:41 ` AngeloGioacchino Del Regno
2022-06-13 12:41 ` AngeloGioacchino Del Regno
2022-06-13 12:41 ` AngeloGioacchino Del Regno
2022-06-15 17:30 ` Krzysztof Kozlowski
2022-06-15 17:30 ` Krzysztof Kozlowski
2022-06-09 8:31 ` [PATCH v2 2/3] firmware: " Tinghan Shen
2022-06-09 8:31 ` Tinghan Shen
2022-06-09 8:31 ` Tinghan Shen
2022-06-13 12:37 ` AngeloGioacchino Del Regno
2022-06-13 12:37 ` AngeloGioacchino Del Regno
2022-06-13 12:37 ` AngeloGioacchino Del Regno
2022-06-15 3:22 ` Tinghan Shen
2022-06-15 3:22 ` Tinghan Shen
2022-06-15 3:22 ` Tinghan Shen
2022-06-09 8:31 ` [PATCH v2 3/3] dt-bindings: dsp: mediatek: add mt8186 dsp document Tinghan Shen
2022-06-09 8:31 ` Tinghan Shen
2022-06-09 8:31 ` Tinghan Shen
2022-06-15 17:32 ` Krzysztof Kozlowski
2022-06-15 17:32 ` Krzysztof Kozlowski
2022-06-16 7:34 ` Tinghan Shen
2022-06-16 7:34 ` Tinghan Shen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.