* [PATCH] usbredir: avoid queuing hello packet on snapshot restore
@ 2022-05-07 4:18 Joelle van Dyne
2022-06-09 10:03 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: Joelle van Dyne @ 2022-05-07 4:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Joelle van Dyne, Gerd Hoffmann
When launching QEMU with "-loadvm", usbredir_create_parser() should avoid
setting up the hello packet (just as with "-incoming". On the latest version
of libusbredir, usbredirparser_unserialize() will return error if the parser
is not "pristine."
Signed-off-by: Joelle van Dyne <j@getutm.app>
---
hw/usb/redirect.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index 3bc4dee7fe..f8bec9b292 100644
--- a/hw/usb/redirect.c
+++ b/hw/usb/redirect.c
@@ -1280,7 +1280,8 @@ static void usbredir_create_parser(USBRedirDevice *dev)
}
#endif
- if (runstate_check(RUN_STATE_INMIGRATE)) {
+ if (runstate_check(RUN_STATE_INMIGRATE) ||
+ runstate_check(RUN_STATE_PRELAUNCH)) {
flags |= usbredirparser_fl_no_hello;
}
usbredirparser_init(dev->parser, VERSION, caps, USB_REDIR_CAPS_SIZE,
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usbredir: avoid queuing hello packet on snapshot restore
2022-05-07 4:18 [PATCH] usbredir: avoid queuing hello packet on snapshot restore Joelle van Dyne
@ 2022-06-09 10:03 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2022-06-09 10:03 UTC (permalink / raw)
To: Joelle van Dyne; +Cc: qemu-devel
On Fri, May 06, 2022 at 09:18:50PM -0700, Joelle van Dyne wrote:
> When launching QEMU with "-loadvm", usbredir_create_parser() should avoid
> setting up the hello packet (just as with "-incoming". On the latest version
> of libusbredir, usbredirparser_unserialize() will return error if the parser
> is not "pristine."
>
> Signed-off-by: Joelle van Dyne <j@getutm.app>
Patch queued up.
thanks,
Gerd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-09 12:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-07 4:18 [PATCH] usbredir: avoid queuing hello packet on snapshot restore Joelle van Dyne
2022-06-09 10:03 ` Gerd Hoffmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.