* [RESEND V2] mmc: mediatek: wait dma stop bit reset to 0
@ 2022-06-09 11:22 Mengqi Zhang
2022-06-15 17:32 ` Ulf Hansson
0 siblings, 1 reply; 3+ messages in thread
From: Mengqi Zhang @ 2022-06-09 11:22 UTC (permalink / raw)
To: chaotian.jing, ulf.hansson, matthias.bgg
Cc: linux-mmc, linux-arm-kernel, linux-mediatek, linux-kernel,
wenbin.mei, Mengqi Zhang
MediaTek IP requires that after dma stop, it need to wait this dma stop
bit auto-reset to 0. When bus is in high loading state, it will take a
while for the dma stop complete. If there is no waiting operation here,
when program runs to clear fifo and reset, bus will hang.
In addition, there should be no return in msdc_data_xfer_next() if
there is data need be transferred, because no matter what error occurs
here, it should continue to excute to the following mmc_request_done.
Otherwise the core layer may wait complete forever.
Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com>
---
drivers/mmc/host/mtk-sd.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 195dc897188b..9da4489dc345 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -1356,7 +1356,7 @@ static void msdc_data_xfer_next(struct msdc_host *host, struct mmc_request *mrq)
msdc_request_done(host, mrq);
}
-static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
+static void msdc_data_xfer_done(struct msdc_host *host, u32 events,
struct mmc_request *mrq, struct mmc_data *data)
{
struct mmc_command *stop;
@@ -1376,7 +1376,7 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
spin_unlock_irqrestore(&host->lock, flags);
if (done)
- return true;
+ return;
stop = data->stop;
if (check_data || (stop && stop->error)) {
@@ -1385,12 +1385,15 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
sdr_set_field(host->base + MSDC_DMA_CTRL, MSDC_DMA_CTRL_STOP,
1);
+ ret = readl_poll_timeout_atomic(host->base + MSDC_DMA_CTRL, val,
+ !(val & MSDC_DMA_CTRL_STOP), 1, 20000);
+ if (ret)
+ dev_dbg(host->dev, "DMA stop timed out\n");
+
ret = readl_poll_timeout_atomic(host->base + MSDC_DMA_CFG, val,
!(val & MSDC_DMA_CFG_STS), 1, 20000);
- if (ret) {
- dev_dbg(host->dev, "DMA stop timed out\n");
- return false;
- }
+ if (ret)
+ dev_dbg(host->dev, "DMA inactive timed out\n");
sdr_clr_bits(host->base + MSDC_INTEN, data_ints_mask);
dev_dbg(host->dev, "DMA stop\n");
@@ -1415,9 +1418,7 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
}
msdc_data_xfer_next(host, mrq);
- done = true;
}
- return done;
}
static void msdc_set_buswidth(struct msdc_host *host, u32 width)
@@ -2416,6 +2417,9 @@ static void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
if (recovery) {
sdr_set_field(host->base + MSDC_DMA_CTRL,
MSDC_DMA_CTRL_STOP, 1);
+ if (WARN_ON(readl_poll_timeout(host->base + MSDC_DMA_CTRL, val,
+ !(val & MSDC_DMA_CTRL_STOP), 1, 3000)))
+ return;
if (WARN_ON(readl_poll_timeout(host->base + MSDC_DMA_CFG, val,
!(val & MSDC_DMA_CFG_STS), 1, 3000)))
return;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND V2] mmc: mediatek: wait dma stop bit reset to 0
2022-06-09 11:22 [RESEND V2] mmc: mediatek: wait dma stop bit reset to 0 Mengqi Zhang
@ 2022-06-15 17:32 ` Ulf Hansson
0 siblings, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2022-06-15 17:32 UTC (permalink / raw)
To: Mengqi Zhang
Cc: chaotian.jing, matthias.bgg, linux-mmc, linux-arm-kernel,
linux-mediatek, linux-kernel, wenbin.mei
On Thu, 9 Jun 2022 at 04:22, Mengqi Zhang <mengqi.zhang@mediatek.com> wrote:
>
> MediaTek IP requires that after dma stop, it need to wait this dma stop
> bit auto-reset to 0. When bus is in high loading state, it will take a
> while for the dma stop complete. If there is no waiting operation here,
> when program runs to clear fifo and reset, bus will hang.
>
> In addition, there should be no return in msdc_data_xfer_next() if
> there is data need be transferred, because no matter what error occurs
> here, it should continue to excute to the following mmc_request_done.
> Otherwise the core layer may wait complete forever.
>
> Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com>
Applied for fixes and by adding a stable tag, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/mtk-sd.c | 20 ++++++++++++--------
> 1 file changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 195dc897188b..9da4489dc345 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1356,7 +1356,7 @@ static void msdc_data_xfer_next(struct msdc_host *host, struct mmc_request *mrq)
> msdc_request_done(host, mrq);
> }
>
> -static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
> +static void msdc_data_xfer_done(struct msdc_host *host, u32 events,
> struct mmc_request *mrq, struct mmc_data *data)
> {
> struct mmc_command *stop;
> @@ -1376,7 +1376,7 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
> spin_unlock_irqrestore(&host->lock, flags);
>
> if (done)
> - return true;
> + return;
> stop = data->stop;
>
> if (check_data || (stop && stop->error)) {
> @@ -1385,12 +1385,15 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
> sdr_set_field(host->base + MSDC_DMA_CTRL, MSDC_DMA_CTRL_STOP,
> 1);
>
> + ret = readl_poll_timeout_atomic(host->base + MSDC_DMA_CTRL, val,
> + !(val & MSDC_DMA_CTRL_STOP), 1, 20000);
> + if (ret)
> + dev_dbg(host->dev, "DMA stop timed out\n");
> +
> ret = readl_poll_timeout_atomic(host->base + MSDC_DMA_CFG, val,
> !(val & MSDC_DMA_CFG_STS), 1, 20000);
> - if (ret) {
> - dev_dbg(host->dev, "DMA stop timed out\n");
> - return false;
> - }
> + if (ret)
> + dev_dbg(host->dev, "DMA inactive timed out\n");
>
> sdr_clr_bits(host->base + MSDC_INTEN, data_ints_mask);
> dev_dbg(host->dev, "DMA stop\n");
> @@ -1415,9 +1418,7 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
> }
>
> msdc_data_xfer_next(host, mrq);
> - done = true;
> }
> - return done;
> }
>
> static void msdc_set_buswidth(struct msdc_host *host, u32 width)
> @@ -2416,6 +2417,9 @@ static void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
> if (recovery) {
> sdr_set_field(host->base + MSDC_DMA_CTRL,
> MSDC_DMA_CTRL_STOP, 1);
> + if (WARN_ON(readl_poll_timeout(host->base + MSDC_DMA_CTRL, val,
> + !(val & MSDC_DMA_CTRL_STOP), 1, 3000)))
> + return;
> if (WARN_ON(readl_poll_timeout(host->base + MSDC_DMA_CFG, val,
> !(val & MSDC_DMA_CFG_STS), 1, 3000)))
> return;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND V2] mmc: mediatek: wait dma stop bit reset to 0
@ 2022-06-15 17:32 ` Ulf Hansson
0 siblings, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2022-06-15 17:32 UTC (permalink / raw)
To: Mengqi Zhang
Cc: chaotian.jing, matthias.bgg, linux-mmc, linux-arm-kernel,
linux-mediatek, linux-kernel, wenbin.mei
On Thu, 9 Jun 2022 at 04:22, Mengqi Zhang <mengqi.zhang@mediatek.com> wrote:
>
> MediaTek IP requires that after dma stop, it need to wait this dma stop
> bit auto-reset to 0. When bus is in high loading state, it will take a
> while for the dma stop complete. If there is no waiting operation here,
> when program runs to clear fifo and reset, bus will hang.
>
> In addition, there should be no return in msdc_data_xfer_next() if
> there is data need be transferred, because no matter what error occurs
> here, it should continue to excute to the following mmc_request_done.
> Otherwise the core layer may wait complete forever.
>
> Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com>
Applied for fixes and by adding a stable tag, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/mtk-sd.c | 20 ++++++++++++--------
> 1 file changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 195dc897188b..9da4489dc345 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1356,7 +1356,7 @@ static void msdc_data_xfer_next(struct msdc_host *host, struct mmc_request *mrq)
> msdc_request_done(host, mrq);
> }
>
> -static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
> +static void msdc_data_xfer_done(struct msdc_host *host, u32 events,
> struct mmc_request *mrq, struct mmc_data *data)
> {
> struct mmc_command *stop;
> @@ -1376,7 +1376,7 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
> spin_unlock_irqrestore(&host->lock, flags);
>
> if (done)
> - return true;
> + return;
> stop = data->stop;
>
> if (check_data || (stop && stop->error)) {
> @@ -1385,12 +1385,15 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
> sdr_set_field(host->base + MSDC_DMA_CTRL, MSDC_DMA_CTRL_STOP,
> 1);
>
> + ret = readl_poll_timeout_atomic(host->base + MSDC_DMA_CTRL, val,
> + !(val & MSDC_DMA_CTRL_STOP), 1, 20000);
> + if (ret)
> + dev_dbg(host->dev, "DMA stop timed out\n");
> +
> ret = readl_poll_timeout_atomic(host->base + MSDC_DMA_CFG, val,
> !(val & MSDC_DMA_CFG_STS), 1, 20000);
> - if (ret) {
> - dev_dbg(host->dev, "DMA stop timed out\n");
> - return false;
> - }
> + if (ret)
> + dev_dbg(host->dev, "DMA inactive timed out\n");
>
> sdr_clr_bits(host->base + MSDC_INTEN, data_ints_mask);
> dev_dbg(host->dev, "DMA stop\n");
> @@ -1415,9 +1418,7 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
> }
>
> msdc_data_xfer_next(host, mrq);
> - done = true;
> }
> - return done;
> }
>
> static void msdc_set_buswidth(struct msdc_host *host, u32 width)
> @@ -2416,6 +2417,9 @@ static void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
> if (recovery) {
> sdr_set_field(host->base + MSDC_DMA_CTRL,
> MSDC_DMA_CTRL_STOP, 1);
> + if (WARN_ON(readl_poll_timeout(host->base + MSDC_DMA_CTRL, val,
> + !(val & MSDC_DMA_CTRL_STOP), 1, 3000)))
> + return;
> if (WARN_ON(readl_poll_timeout(host->base + MSDC_DMA_CFG, val,
> !(val & MSDC_DMA_CFG_STS), 1, 3000)))
> return;
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-15 17:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-09 11:22 [RESEND V2] mmc: mediatek: wait dma stop bit reset to 0 Mengqi Zhang
2022-06-15 17:32 ` Ulf Hansson
2022-06-15 17:32 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.