* [dm-devel] [PATCH] multipath-tools: tests: fix hwtable test
@ 2022-06-09 10:13 mwilck
2022-06-09 15:22 ` Benjamin Marzinski
0 siblings, 1 reply; 2+ messages in thread
From: mwilck @ 2022-06-09 10:13 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
After "libmultipath: hwtable: new defaults for NVMe", we need to fix
the unit tests.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
tests/hwtable.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/hwtable.c b/tests/hwtable.c
index e60e914..bfaf613 100644
--- a/tests/hwtable.c
+++ b/tests/hwtable.c
@@ -573,7 +573,7 @@ static void test_internal_nvme(const struct hwt_state *hwt)
assert_ptr_not_equal(mp, NULL);
TEST_PROP(checker_name(&pp->checker), NONE);
TEST_PROP(pp->uid_attribute, DEFAULT_NVME_UID_ATTRIBUTE);
- assert_int_equal(mp->pgpolicy, DEFAULT_PGPOLICY);
+ assert_int_equal(mp->pgpolicy, GROUP_BY_PRIO);
assert_int_equal(mp->no_path_retry, DEFAULT_NO_PATH_RETRY);
assert_int_equal(mp->retain_hwhandler, RETAIN_HWHANDLER_OFF);
@@ -586,7 +586,7 @@ static void test_internal_nvme(const struct hwt_state *hwt)
assert_ptr_not_equal(mp, NULL);
TEST_PROP(checker_name(&pp->checker), NONE);
TEST_PROP(pp->uid_attribute, "ID_WWN");
- assert_int_equal(mp->pgpolicy, MULTIBUS);
+ assert_int_equal(mp->pgpolicy, GROUP_BY_PRIO);
assert_int_equal(mp->no_path_retry, NO_PATH_RETRY_QUEUE);
assert_int_equal(mp->retain_hwhandler, RETAIN_HWHANDLER_OFF);
}
--
2.36.1
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [dm-devel] [PATCH] multipath-tools: tests: fix hwtable test
2022-06-09 10:13 [dm-devel] [PATCH] multipath-tools: tests: fix hwtable test mwilck
@ 2022-06-09 15:22 ` Benjamin Marzinski
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Marzinski @ 2022-06-09 15:22 UTC (permalink / raw)
To: mwilck; +Cc: Christophe Varoqui, dm-devel
On Thu, Jun 09, 2022 at 12:13:55PM +0200, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
> After "libmultipath: hwtable: new defaults for NVMe", we need to fix
> the unit tests.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
> tests/hwtable.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/hwtable.c b/tests/hwtable.c
> index e60e914..bfaf613 100644
> --- a/tests/hwtable.c
> +++ b/tests/hwtable.c
> @@ -573,7 +573,7 @@ static void test_internal_nvme(const struct hwt_state *hwt)
> assert_ptr_not_equal(mp, NULL);
> TEST_PROP(checker_name(&pp->checker), NONE);
> TEST_PROP(pp->uid_attribute, DEFAULT_NVME_UID_ATTRIBUTE);
> - assert_int_equal(mp->pgpolicy, DEFAULT_PGPOLICY);
> + assert_int_equal(mp->pgpolicy, GROUP_BY_PRIO);
> assert_int_equal(mp->no_path_retry, DEFAULT_NO_PATH_RETRY);
> assert_int_equal(mp->retain_hwhandler, RETAIN_HWHANDLER_OFF);
>
> @@ -586,7 +586,7 @@ static void test_internal_nvme(const struct hwt_state *hwt)
> assert_ptr_not_equal(mp, NULL);
> TEST_PROP(checker_name(&pp->checker), NONE);
> TEST_PROP(pp->uid_attribute, "ID_WWN");
> - assert_int_equal(mp->pgpolicy, MULTIBUS);
> + assert_int_equal(mp->pgpolicy, GROUP_BY_PRIO);
> assert_int_equal(mp->no_path_retry, NO_PATH_RETRY_QUEUE);
> assert_int_equal(mp->retain_hwhandler, RETAIN_HWHANDLER_OFF);
> }
> --
> 2.36.1
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-09 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-09 10:13 [dm-devel] [PATCH] multipath-tools: tests: fix hwtable test mwilck
2022-06-09 15:22 ` Benjamin Marzinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.