All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/amd/pm: enable UCLK DS feature for SMU 13.0.0
@ 2022-06-10  6:25 Evan Quan
  2022-06-10  6:25 ` [PATCH 2/2] drm/amd/pm: enable MACO support " Evan Quan
  2022-06-10 16:06 ` [PATCH 1/2] drm/amd/pm: enable UCLK DS feature " Alex Deucher
  0 siblings, 2 replies; 5+ messages in thread
From: Evan Quan @ 2022-06-10  6:25 UTC (permalink / raw)
  To: amd-gfx; +Cc: Alexander.Deucher, Likun.Gao, Evan Quan, Hawking.Zhang

The feature is ready with latest PMFW and IFWI.

Signed-off-by: Evan Quan <evan.quan@amd.com>
Change-Id: I0b1ea6a32bc092eec4b95118a1442597688ee8d0
---
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
index fda89e309b07..495713e4ebd4 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
@@ -306,6 +306,8 @@ smu_v13_0_0_get_allowed_feature_mask(struct smu_context *smu,
 
 	*(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_FW_CTF_BIT);
 
+	*(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_DS_UCLK_BIT);
+
 	return 0;
 }
 
-- 
2.29.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] drm/amd/pm: enable MACO support for SMU 13.0.0
  2022-06-10  6:25 [PATCH 1/2] drm/amd/pm: enable UCLK DS feature for SMU 13.0.0 Evan Quan
@ 2022-06-10  6:25 ` Evan Quan
  2022-06-10 16:08   ` Alex Deucher
  2022-06-10 16:06 ` [PATCH 1/2] drm/amd/pm: enable UCLK DS feature " Alex Deucher
  1 sibling, 1 reply; 5+ messages in thread
From: Evan Quan @ 2022-06-10  6:25 UTC (permalink / raw)
  To: amd-gfx; +Cc: Alexander.Deucher, Likun.Gao, Evan Quan, Hawking.Zhang

Enable BAMACO reset support for SMU 13.0.0.

Signed-off-by: Evan Quan <evan.quan@amd.com>
Change-Id: I67696671c216790a0b6d5b84f7d4b430d734ac3c
--
v1->v2:
  - maximum code sharing around smu13.0.0 and smu13.0.7
---
 .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c    |  3 +-
 .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c  |  3 ++
 .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c  | 52 +------------------
 3 files changed, 7 insertions(+), 51 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
index fba0b87d01fb..f18f9605e586 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
@@ -2271,7 +2271,8 @@ int smu_v13_0_baco_set_state(struct smu_context *smu,
 	if (state == SMU_BACO_STATE_ENTER) {
 		ret = smu_cmn_send_smc_msg_with_param(smu,
 						      SMU_MSG_EnterBaco,
-						      0,
+						      smu_baco->maco_support ?
+						      BACO_SEQ_BAMACO : BACO_SEQ_BACO,
 						      NULL);
 	} else {
 		ret = smu_cmn_send_smc_msg(smu,
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
index 495713e4ebd4..6fb2b072a730 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
@@ -325,6 +325,9 @@ static int smu_v13_0_0_check_powerplay_table(struct smu_context *smu)
 	    powerplay_table->platform_caps & SMU_13_0_0_PP_PLATFORM_CAP_MACO)
 		smu_baco->platform_support = true;
 
+	if (powerplay_table->platform_caps & SMU_13_0_0_PP_PLATFORM_CAP_MACO)
+		smu_baco->maco_support = true;
+
 	table_context->thermal_controller_type =
 		powerplay_table->thermal_controller_type;
 
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
index 693bb6bda350..96ae5ff8e19e 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
@@ -1551,54 +1551,6 @@ static int smu_v13_0_7_set_power_profile_mode(struct smu_context *smu, long *inp
 	return ret;
 }
 
-static int smu_v13_0_7_baco_set_state(struct smu_context *smu,
-			     enum smu_baco_state state)
-{
-	struct smu_baco_context *smu_baco = &smu->smu_baco;
-	struct amdgpu_device *adev = smu->adev;
-	bool is_maco_support = smu_baco->maco_support;
-	int ret;
-
-	if (smu_v13_0_baco_get_state(smu) == state)
-		return 0;
-
-	if (state == SMU_BACO_STATE_ENTER) {
-		ret = smu_cmn_send_smc_msg_with_param(smu,
-						      SMU_MSG_EnterBaco,
-						      (is_maco_support ? 2 : 0),
-						      NULL);
-	} else {
-		ret = smu_cmn_send_smc_msg(smu,
-					   SMU_MSG_ExitBaco,
-					   NULL);
-		if (ret)
-			return ret;
-
-		/* clear vbios scratch 6 and 7 for coming asic reinit */
-		WREG32(adev->bios_scratch_reg_offset + 6, 0);
-		WREG32(adev->bios_scratch_reg_offset + 7, 0);
-	}
-
-	if (!ret)
-		smu_baco->state = state;
-
-	return ret;
-}
-
-static int smu_v13_0_7_baco_enter(struct smu_context *smu)
-{
-	int ret = 0;
-
-	ret = smu_v13_0_7_baco_set_state(smu,
-				       SMU_BACO_STATE_ENTER);
-	if (ret)
-		return ret;
-
-	msleep(10);
-
-	return ret;
-}
-
 static const struct pptable_funcs smu_v13_0_7_ppt_funcs = {
 	.get_allowed_feature_mask = smu_v13_0_7_get_allowed_feature_mask,
 	.set_default_dpm_table = smu_v13_0_7_set_default_dpm_table,
@@ -1653,8 +1605,8 @@ static const struct pptable_funcs smu_v13_0_7_ppt_funcs = {
 	.set_pp_feature_mask = smu_cmn_set_pp_feature_mask,
 	.baco_is_support = smu_v13_0_baco_is_support,
 	.baco_get_state = smu_v13_0_baco_get_state,
-	.baco_set_state = smu_v13_0_7_baco_set_state,
-	.baco_enter = smu_v13_0_7_baco_enter,
+	.baco_set_state = smu_v13_0_baco_set_state,
+	.baco_enter = smu_v13_0_baco_enter,
 	.baco_exit = smu_v13_0_baco_exit,
 	.set_mp1_state = smu_cmn_set_mp1_state,
 };
-- 
2.29.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] drm/amd/pm: enable UCLK DS feature for SMU 13.0.0
  2022-06-10  6:25 [PATCH 1/2] drm/amd/pm: enable UCLK DS feature for SMU 13.0.0 Evan Quan
  2022-06-10  6:25 ` [PATCH 2/2] drm/amd/pm: enable MACO support " Evan Quan
@ 2022-06-10 16:06 ` Alex Deucher
  1 sibling, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-06-10 16:06 UTC (permalink / raw)
  To: Evan Quan; +Cc: Deucher, Alexander, Likun Gao, amd-gfx list, Hawking Zhang

On Fri, Jun 10, 2022 at 2:26 AM Evan Quan <evan.quan@amd.com> wrote:
>
> The feature is ready with latest PMFW and IFWI.
>
> Signed-off-by: Evan Quan <evan.quan@amd.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> Change-Id: I0b1ea6a32bc092eec4b95118a1442597688ee8d0
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> index fda89e309b07..495713e4ebd4 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> @@ -306,6 +306,8 @@ smu_v13_0_0_get_allowed_feature_mask(struct smu_context *smu,
>
>         *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_FW_CTF_BIT);
>
> +       *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_DS_UCLK_BIT);
> +
>         return 0;
>  }
>
> --
> 2.29.0
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] drm/amd/pm: enable MACO support for SMU 13.0.0
  2022-06-10  6:25 ` [PATCH 2/2] drm/amd/pm: enable MACO support " Evan Quan
@ 2022-06-10 16:08   ` Alex Deucher
  2022-06-13  6:36     ` Quan, Evan
  0 siblings, 1 reply; 5+ messages in thread
From: Alex Deucher @ 2022-06-10 16:08 UTC (permalink / raw)
  To: Evan Quan; +Cc: Deucher, Alexander, Likun Gao, amd-gfx list, Hawking Zhang

On Fri, Jun 10, 2022 at 2:26 AM Evan Quan <evan.quan@amd.com> wrote:
>
> Enable BAMACO reset support for SMU 13.0.0.
>
> Signed-off-by: Evan Quan <evan.quan@amd.com>
> Change-Id: I67696671c216790a0b6d5b84f7d4b430d734ac3c
> --
> v1->v2:
>   - maximum code sharing around smu13.0.0 and smu13.0.7
> ---
>  .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c    |  3 +-
>  .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c  |  3 ++
>  .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c  | 52 +------------------
>  3 files changed, 7 insertions(+), 51 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> index fba0b87d01fb..f18f9605e586 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> @@ -2271,7 +2271,8 @@ int smu_v13_0_baco_set_state(struct smu_context *smu,
>         if (state == SMU_BACO_STATE_ENTER) {
>                 ret = smu_cmn_send_smc_msg_with_param(smu,
>                                                       SMU_MSG_EnterBaco,
> -                                                     0,
> +                                                     smu_baco->maco_support ?
> +                                                     BACO_SEQ_BAMACO : BACO_SEQ_BACO,
>                                                       NULL);
>         } else {
>                 ret = smu_cmn_send_smc_msg(smu,
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> index 495713e4ebd4..6fb2b072a730 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> @@ -325,6 +325,9 @@ static int smu_v13_0_0_check_powerplay_table(struct smu_context *smu)
>             powerplay_table->platform_caps & SMU_13_0_0_PP_PLATFORM_CAP_MACO)
>                 smu_baco->platform_support = true;

Not really related to this patch, but is
SMU_13_0_0_PP_PLATFORM_CAP_MACO really used to determine with the
platform supports BACO in general?  Is this right?  I don't see how we
would ever end up using plain BACO.

This patch is:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>


>
> +       if (powerplay_table->platform_caps & SMU_13_0_0_PP_PLATFORM_CAP_MACO)
> +               smu_baco->maco_support = true;
> +
>         table_context->thermal_controller_type =
>                 powerplay_table->thermal_controller_type;
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> index 693bb6bda350..96ae5ff8e19e 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> @@ -1551,54 +1551,6 @@ static int smu_v13_0_7_set_power_profile_mode(struct smu_context *smu, long *inp
>         return ret;
>  }
>
> -static int smu_v13_0_7_baco_set_state(struct smu_context *smu,
> -                            enum smu_baco_state state)
> -{
> -       struct smu_baco_context *smu_baco = &smu->smu_baco;
> -       struct amdgpu_device *adev = smu->adev;
> -       bool is_maco_support = smu_baco->maco_support;
> -       int ret;
> -
> -       if (smu_v13_0_baco_get_state(smu) == state)
> -               return 0;
> -
> -       if (state == SMU_BACO_STATE_ENTER) {
> -               ret = smu_cmn_send_smc_msg_with_param(smu,
> -                                                     SMU_MSG_EnterBaco,
> -                                                     (is_maco_support ? 2 : 0),
> -                                                     NULL);
> -       } else {
> -               ret = smu_cmn_send_smc_msg(smu,
> -                                          SMU_MSG_ExitBaco,
> -                                          NULL);
> -               if (ret)
> -                       return ret;
> -
> -               /* clear vbios scratch 6 and 7 for coming asic reinit */
> -               WREG32(adev->bios_scratch_reg_offset + 6, 0);
> -               WREG32(adev->bios_scratch_reg_offset + 7, 0);
> -       }
> -
> -       if (!ret)
> -               smu_baco->state = state;
> -
> -       return ret;
> -}
> -
> -static int smu_v13_0_7_baco_enter(struct smu_context *smu)
> -{
> -       int ret = 0;
> -
> -       ret = smu_v13_0_7_baco_set_state(smu,
> -                                      SMU_BACO_STATE_ENTER);
> -       if (ret)
> -               return ret;
> -
> -       msleep(10);
> -
> -       return ret;
> -}
> -
>  static const struct pptable_funcs smu_v13_0_7_ppt_funcs = {
>         .get_allowed_feature_mask = smu_v13_0_7_get_allowed_feature_mask,
>         .set_default_dpm_table = smu_v13_0_7_set_default_dpm_table,
> @@ -1653,8 +1605,8 @@ static const struct pptable_funcs smu_v13_0_7_ppt_funcs = {
>         .set_pp_feature_mask = smu_cmn_set_pp_feature_mask,
>         .baco_is_support = smu_v13_0_baco_is_support,
>         .baco_get_state = smu_v13_0_baco_get_state,
> -       .baco_set_state = smu_v13_0_7_baco_set_state,
> -       .baco_enter = smu_v13_0_7_baco_enter,
> +       .baco_set_state = smu_v13_0_baco_set_state,
> +       .baco_enter = smu_v13_0_baco_enter,
>         .baco_exit = smu_v13_0_baco_exit,
>         .set_mp1_state = smu_cmn_set_mp1_state,
>  };
> --
> 2.29.0
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH 2/2] drm/amd/pm: enable MACO support for SMU 13.0.0
  2022-06-10 16:08   ` Alex Deucher
@ 2022-06-13  6:36     ` Quan, Evan
  0 siblings, 0 replies; 5+ messages in thread
From: Quan, Evan @ 2022-06-13  6:36 UTC (permalink / raw)
  To: Alex Deucher; +Cc: Deucher, Alexander, Gao, Likun, amd-gfx list, Zhang, Hawking

[AMD Official Use Only - General]



> -----Original Message-----
> From: Alex Deucher <alexdeucher@gmail.com>
> Sent: Saturday, June 11, 2022 12:08 AM
> To: Quan, Evan <Evan.Quan@amd.com>
> Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Gao, Likun <Likun.Gao@amd.com>; Zhang,
> Hawking <Hawking.Zhang@amd.com>
> Subject: Re: [PATCH 2/2] drm/amd/pm: enable MACO support for SMU
> 13.0.0
> 
> On Fri, Jun 10, 2022 at 2:26 AM Evan Quan <evan.quan@amd.com> wrote:
> >
> > Enable BAMACO reset support for SMU 13.0.0.
> >
> > Signed-off-by: Evan Quan <evan.quan@amd.com>
> > Change-Id: I67696671c216790a0b6d5b84f7d4b430d734ac3c
> > --
> > v1->v2:
> >   - maximum code sharing around smu13.0.0 and smu13.0.7
> > ---
> >  .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c    |  3 +-
> >  .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c  |  3 ++
> > .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c  | 52 +------------------
> >  3 files changed, 7 insertions(+), 51 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> > b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> > index fba0b87d01fb..f18f9605e586 100644
> > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> > @@ -2271,7 +2271,8 @@ int smu_v13_0_baco_set_state(struct
> smu_context *smu,
> >         if (state == SMU_BACO_STATE_ENTER) {
> >                 ret = smu_cmn_send_smc_msg_with_param(smu,
> >                                                       SMU_MSG_EnterBaco,
> > -                                                     0,
> > +                                                     smu_baco->maco_support ?
> > +                                                     BACO_SEQ_BAMACO
> > + : BACO_SEQ_BACO,
> >                                                       NULL);
> >         } else {
> >                 ret = smu_cmn_send_smc_msg(smu, diff --git
> > a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> > b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> > index 495713e4ebd4..6fb2b072a730 100644
> > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> > @@ -325,6 +325,9 @@ static int
> smu_v13_0_0_check_powerplay_table(struct smu_context *smu)
> >             powerplay_table->platform_caps &
> SMU_13_0_0_PP_PLATFORM_CAP_MACO)
> >                 smu_baco->platform_support = true;
> 
> Not really related to this patch, but is
> SMU_13_0_0_PP_PLATFORM_CAP_MACO really used to determine with the
> platform supports BACO in general?  Is this right?  I don't see how we would
> ever end up using plain BACO.
[Quan, Evan] Yes, I think we can drop the SMU_13_0_0_PP_PLATFORM_CAP_MACO check for BACO support.
They should not have direct dependence.

BR
Evan
> 
> This patch is:
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> 
> 
> >
> > +       if (powerplay_table->platform_caps &
> SMU_13_0_0_PP_PLATFORM_CAP_MACO)
> > +               smu_baco->maco_support = true;
> > +
> >         table_context->thermal_controller_type =
> >                 powerplay_table->thermal_controller_type;
> >
> > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> > b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> > index 693bb6bda350..96ae5ff8e19e 100644
> > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> > @@ -1551,54 +1551,6 @@ static int
> smu_v13_0_7_set_power_profile_mode(struct smu_context *smu, long
> *inp
> >         return ret;
> >  }
> >
> > -static int smu_v13_0_7_baco_set_state(struct smu_context *smu,
> > -                            enum smu_baco_state state)
> > -{
> > -       struct smu_baco_context *smu_baco = &smu->smu_baco;
> > -       struct amdgpu_device *adev = smu->adev;
> > -       bool is_maco_support = smu_baco->maco_support;
> > -       int ret;
> > -
> > -       if (smu_v13_0_baco_get_state(smu) == state)
> > -               return 0;
> > -
> > -       if (state == SMU_BACO_STATE_ENTER) {
> > -               ret = smu_cmn_send_smc_msg_with_param(smu,
> > -                                                     SMU_MSG_EnterBaco,
> > -                                                     (is_maco_support ? 2 : 0),
> > -                                                     NULL);
> > -       } else {
> > -               ret = smu_cmn_send_smc_msg(smu,
> > -                                          SMU_MSG_ExitBaco,
> > -                                          NULL);
> > -               if (ret)
> > -                       return ret;
> > -
> > -               /* clear vbios scratch 6 and 7 for coming asic reinit */
> > -               WREG32(adev->bios_scratch_reg_offset + 6, 0);
> > -               WREG32(adev->bios_scratch_reg_offset + 7, 0);
> > -       }
> > -
> > -       if (!ret)
> > -               smu_baco->state = state;
> > -
> > -       return ret;
> > -}
> > -
> > -static int smu_v13_0_7_baco_enter(struct smu_context *smu) -{
> > -       int ret = 0;
> > -
> > -       ret = smu_v13_0_7_baco_set_state(smu,
> > -                                      SMU_BACO_STATE_ENTER);
> > -       if (ret)
> > -               return ret;
> > -
> > -       msleep(10);
> > -
> > -       return ret;
> > -}
> > -
> >  static const struct pptable_funcs smu_v13_0_7_ppt_funcs = {
> >         .get_allowed_feature_mask =
> smu_v13_0_7_get_allowed_feature_mask,
> >         .set_default_dpm_table = smu_v13_0_7_set_default_dpm_table,
> > @@ -1653,8 +1605,8 @@ static const struct pptable_funcs
> smu_v13_0_7_ppt_funcs = {
> >         .set_pp_feature_mask = smu_cmn_set_pp_feature_mask,
> >         .baco_is_support = smu_v13_0_baco_is_support,
> >         .baco_get_state = smu_v13_0_baco_get_state,
> > -       .baco_set_state = smu_v13_0_7_baco_set_state,
> > -       .baco_enter = smu_v13_0_7_baco_enter,
> > +       .baco_set_state = smu_v13_0_baco_set_state,
> > +       .baco_enter = smu_v13_0_baco_enter,
> >         .baco_exit = smu_v13_0_baco_exit,
> >         .set_mp1_state = smu_cmn_set_mp1_state,  };
> > --
> > 2.29.0
> >

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-06-13  6:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-10  6:25 [PATCH 1/2] drm/amd/pm: enable UCLK DS feature for SMU 13.0.0 Evan Quan
2022-06-10  6:25 ` [PATCH 2/2] drm/amd/pm: enable MACO support " Evan Quan
2022-06-10 16:08   ` Alex Deucher
2022-06-13  6:36     ` Quan, Evan
2022-06-10 16:06 ` [PATCH 1/2] drm/amd/pm: enable UCLK DS feature " Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.