All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC PATCH] linux-user: un-parent OBJECT(cpu) when closing thread
@ 2022-06-10 14:38 Alex Bennée
  2022-06-12 16:29 ` Laurent Vivier
  2022-06-21 18:17 ` Laurent Vivier
  0 siblings, 2 replies; 4+ messages in thread
From: Alex Bennée @ 2022-06-10 14:38 UTC (permalink / raw)
  To: qemu-devel; +Cc: peter.maydell, thuth, Alex Bennée, Laurent Vivier

While forcing the CPU to unrealize by hand does trigger the clean-up
code we never fully free resources because refcount never reaches
zero. This is because QOM automatically added objects without an
explicit parent to /unattached/, incrementing the refcount.

Instead of manually triggering unrealization just unparent the object
and let the device machinery deal with that for us.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/866
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 linux-user/syscall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index f55cdebee5..c413d32311 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -8566,7 +8566,7 @@ static abi_long do_syscall1(CPUArchState *cpu_env, int num, abi_long arg1,
         if (CPU_NEXT(first_cpu)) {
             TaskState *ts = cpu->opaque;
 
-            object_property_set_bool(OBJECT(cpu), "realized", false, NULL);
+            object_unparent(OBJECT(cpu));
             object_unref(OBJECT(cpu));
             /*
              * At this point the CPU should be unrealized and removed
-- 
2.30.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-06-23 12:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-10 14:38 [RFC PATCH] linux-user: un-parent OBJECT(cpu) when closing thread Alex Bennée
2022-06-12 16:29 ` Laurent Vivier
2022-06-21 18:17 ` Laurent Vivier
2022-06-23 12:08   ` Laurent Vivier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.