From: Shawn Guo <shawnguo@kernel.org> To: Marek Vasut <marex@denx.de> Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam <festevam@denx.de>, Marcel Ziswiler <marcel.ziswiler@toradex.com>, Peng Fan <peng.fan@nxp.com>, Rob Herring <robh+dt@kernel.org>, NXP Linux Team <linux-imx@nxp.com>, devicetree@vger.kernel.org Subject: Re: [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on MX8Menlo board Date: Sun, 12 Jun 2022 08:30:41 +0800 [thread overview] Message-ID: <20220612003041.GK254723@dragon> (raw) In-Reply-To: <20220521150750.93718-1-marex@denx.de> On Sat, May 21, 2022 at 05:07:50PM +0200, Marek Vasut wrote: > Add SNVS LPGPR bindings on this system, the LPGPR is used to store > boot counter. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Fabio Estevam <festevam@denx.de> > Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com> > Cc: Peng Fan <peng.fan@nxp.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: devicetree@vger.kernel.org > To: linux-arm-kernel@lists.infradead.org > --- > NOTE: Depends on > https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=for-next&id=fee6de80bdd3df976a43f3092a165cb43c072f20 > --- > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts > index 92eaf4ef45638..6956c9bb992be 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts > @@ -303,6 +303,12 @@ &sai2 { > status = "disabled"; > }; > > +&snvs { > + snvs-lpgpr { > + compatible = "fsl,imx7d-snvs-lpgpr"; Should we encode imx8mm specific compatible as well, while you added it in the bindings? Also this is a SoC rather than board device, so we may want to add it in soc.dtsi instead? Shawn > + }; > +}; > + > &uart1 { > uart-has-rtscts; > status = "okay"; > -- > 2.35.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org> To: Marek Vasut <marex@denx.de> Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam <festevam@denx.de>, Marcel Ziswiler <marcel.ziswiler@toradex.com>, Peng Fan <peng.fan@nxp.com>, Rob Herring <robh+dt@kernel.org>, NXP Linux Team <linux-imx@nxp.com>, devicetree@vger.kernel.org Subject: Re: [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on MX8Menlo board Date: Sun, 12 Jun 2022 08:30:41 +0800 [thread overview] Message-ID: <20220612003041.GK254723@dragon> (raw) In-Reply-To: <20220521150750.93718-1-marex@denx.de> On Sat, May 21, 2022 at 05:07:50PM +0200, Marek Vasut wrote: > Add SNVS LPGPR bindings on this system, the LPGPR is used to store > boot counter. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Fabio Estevam <festevam@denx.de> > Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com> > Cc: Peng Fan <peng.fan@nxp.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: devicetree@vger.kernel.org > To: linux-arm-kernel@lists.infradead.org > --- > NOTE: Depends on > https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=for-next&id=fee6de80bdd3df976a43f3092a165cb43c072f20 > --- > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts > index 92eaf4ef45638..6956c9bb992be 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts > @@ -303,6 +303,12 @@ &sai2 { > status = "disabled"; > }; > > +&snvs { > + snvs-lpgpr { > + compatible = "fsl,imx7d-snvs-lpgpr"; Should we encode imx8mm specific compatible as well, while you added it in the bindings? Also this is a SoC rather than board device, so we may want to add it in soc.dtsi instead? Shawn > + }; > +}; > + > &uart1 { > uart-has-rtscts; > status = "okay"; > -- > 2.35.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-12 0:30 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-21 15:07 [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on MX8Menlo board Marek Vasut 2022-05-21 15:07 ` Marek Vasut 2022-06-12 0:30 ` Shawn Guo [this message] 2022-06-12 0:30 ` Shawn Guo 2022-06-12 10:12 ` Marek Vasut 2022-06-12 10:12 ` Marek Vasut
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220612003041.GK254723@dragon \ --to=shawnguo@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=festevam@denx.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=marcel.ziswiler@toradex.com \ --cc=marex@denx.de \ --cc=peng.fan@nxp.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.