* [PATCH] perf test: Record only user callchains
@ 2022-06-14 10:52 Michael Petlan
2022-06-14 12:11 ` German Gomez
2022-06-14 13:17 ` Leo Yan
0 siblings, 2 replies; 8+ messages in thread
From: Michael Petlan @ 2022-06-14 10:52 UTC (permalink / raw)
To: linux-perf-users, acme; +Cc: acme, jolsa, german.gomez
The testcase 'Check Arm64 callgraphs are complete in fp mode' wants to
see the following output:
610 leaf
62f parent
648 main
However, without excluding user callchains, the output might look like:
ffffc2ff40ef1b5c arch_local_irq_enable
ffffc2ff419d032c __schedule
ffffc2ff419d06c0 schedule
ffffc2ff40e4da30 do_notify_resume
ffffc2ff40e421b0 work_pending
610 leaf
62f parent
648 main
Adding '--user-callchains' leaves only the wanted symbols in the chain.
Suggested-by: German Gomez <german.gomez@arm.com>
Tested-by: Michael Petlan <mpetlan@redhat.com>
Signed-off-by: Michael Petlan <mpetlan@redhat.com>
---
tools/perf/tests/shell/test_arm_callgraph_fp.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/shell/test_arm_callgraph_fp.sh b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
index 6ffbb27afaba..ec108d45d3c6 100755
--- a/tools/perf/tests/shell/test_arm_callgraph_fp.sh
+++ b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
@@ -43,7 +43,7 @@ CFLAGS="-g -O0 -fno-inline -fno-omit-frame-pointer"
cc $CFLAGS $TEST_PROGRAM_SOURCE -o $TEST_PROGRAM || exit 1
# Add a 1 second delay to skip samples that are not in the leaf() function
-perf record -o $PERF_DATA --call-graph fp -e cycles//u -D 1000 -- $TEST_PROGRAM 2> /dev/null &
+perf record -o $PERF_DATA --call-graph fp -e cycles//u -D 1000 --user-callchains -- $TEST_PROGRAM 2> /dev/null &
PID=$!
echo " + Recording (PID=$PID)..."
--
2.18.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] perf test: Record only user callchains
2022-06-14 10:52 [PATCH] perf test: Record only user callchains Michael Petlan
@ 2022-06-14 12:11 ` German Gomez
2022-06-14 12:19 ` Michael Petlan
2022-06-14 19:09 ` Arnaldo Carvalho de Melo
2022-06-14 13:17 ` Leo Yan
1 sibling, 2 replies; 8+ messages in thread
From: German Gomez @ 2022-06-14 12:11 UTC (permalink / raw)
To: Michael Petlan, linux-perf-users, acme; +Cc: acme, jolsa, James Clark, Leo Yan
Hi Michael, thanks for the fix
On 14/06/2022 11:52, Michael Petlan wrote:
> The testcase 'Check Arm64 callgraphs are complete in fp mode' wants to
> see the following output:
>
> 610 leaf
> 62f parent
> 648 main
>
> However, without excluding user callchains, the output might look like:
I think you meant "kernel callchains"
> ffffc2ff40ef1b5c arch_local_irq_enable
> ffffc2ff419d032c __schedule
> ffffc2ff419d06c0 schedule
> ffffc2ff40e4da30 do_notify_resume
> ffffc2ff40e421b0 work_pending
> 610 leaf
> 62f parent
> 648 main
>
> Adding '--user-callchains' leaves only the wanted symbols in the chain.
>
> Suggested-by: German Gomez <german.gomez@arm.com>
> Tested-by: Michael Petlan <mpetlan@redhat.com>
> Signed-off-by: Michael Petlan <mpetlan@redhat.com>
Fixes: cd6382d82752 ("perf test arm64: Test unwinding using fame-pointer (fp) mode")
Reviewed-by: German Gomez <german.gomez@arm.com>
German
> ---
> tools/perf/tests/shell/test_arm_callgraph_fp.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/test_arm_callgraph_fp.sh b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> index 6ffbb27afaba..ec108d45d3c6 100755
> --- a/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> +++ b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> @@ -43,7 +43,7 @@ CFLAGS="-g -O0 -fno-inline -fno-omit-frame-pointer"
> cc $CFLAGS $TEST_PROGRAM_SOURCE -o $TEST_PROGRAM || exit 1
>
> # Add a 1 second delay to skip samples that are not in the leaf() function
> -perf record -o $PERF_DATA --call-graph fp -e cycles//u -D 1000 -- $TEST_PROGRAM 2> /dev/null &
> +perf record -o $PERF_DATA --call-graph fp -e cycles//u -D 1000 --user-callchains -- $TEST_PROGRAM 2> /dev/null &
> PID=$!
>
> echo " + Recording (PID=$PID)..."
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf test: Record only user callchains
2022-06-14 12:11 ` German Gomez
@ 2022-06-14 12:19 ` Michael Petlan
2022-06-14 19:09 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 8+ messages in thread
From: Michael Petlan @ 2022-06-14 12:19 UTC (permalink / raw)
To: German Gomez; +Cc: linux-perf-users, acme, acme, jolsa, James Clark, Leo Yan
On Tue, 14 Jun 2022, German Gomez wrote:
> Hi Michael, thanks for the fix
>
> On 14/06/2022 11:52, Michael Petlan wrote:
> > The testcase 'Check Arm64 callgraphs are complete in fp mode' wants to
> > see the following output:
> >
> > 610 leaf
> > 62f parent
> > 648 main
> >
> > However, without excluding user callchains, the output might look like:
>
> I think you meant "kernel callchains"
Oh... of course I did. Thanks.
>
> > ffffc2ff40ef1b5c arch_local_irq_enable
> > ffffc2ff419d032c __schedule
> > ffffc2ff419d06c0 schedule
> > ffffc2ff40e4da30 do_notify_resume
> > ffffc2ff40e421b0 work_pending
> > 610 leaf
> > 62f parent
> > 648 main
> >
> > Adding '--user-callchains' leaves only the wanted symbols in the chain.
> >
> > Suggested-by: German Gomez <german.gomez@arm.com>
> > Tested-by: Michael Petlan <mpetlan@redhat.com>
> > Signed-off-by: Michael Petlan <mpetlan@redhat.com>
>
> Fixes: cd6382d82752 ("perf test arm64: Test unwinding using fame-pointer (fp) mode")
> Reviewed-by: German Gomez <german.gomez@arm.com>
>
> German
>
> > ---
> > tools/perf/tests/shell/test_arm_callgraph_fp.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/tests/shell/test_arm_callgraph_fp.sh b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> > index 6ffbb27afaba..ec108d45d3c6 100755
> > --- a/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> > +++ b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> > @@ -43,7 +43,7 @@ CFLAGS="-g -O0 -fno-inline -fno-omit-frame-pointer"
> > cc $CFLAGS $TEST_PROGRAM_SOURCE -o $TEST_PROGRAM || exit 1
> >
> > # Add a 1 second delay to skip samples that are not in the leaf() function
> > -perf record -o $PERF_DATA --call-graph fp -e cycles//u -D 1000 -- $TEST_PROGRAM 2> /dev/null &
> > +perf record -o $PERF_DATA --call-graph fp -e cycles//u -D 1000 --user-callchains -- $TEST_PROGRAM 2> /dev/null &
> > PID=$!
> >
> > echo " + Recording (PID=$PID)..."
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf test: Record only user callchains
2022-06-14 10:52 [PATCH] perf test: Record only user callchains Michael Petlan
2022-06-14 12:11 ` German Gomez
@ 2022-06-14 13:17 ` Leo Yan
2022-06-14 19:09 ` Arnaldo Carvalho de Melo
1 sibling, 1 reply; 8+ messages in thread
From: Leo Yan @ 2022-06-14 13:17 UTC (permalink / raw)
To: Michael Petlan; +Cc: linux-perf-users, acme, acme, jolsa, german.gomez
On Tue, Jun 14, 2022 at 12:52:07PM +0200, Michael Petlan wrote:
> The testcase 'Check Arm64 callgraphs are complete in fp mode' wants to
> see the following output:
>
> 610 leaf
> 62f parent
> 648 main
>
> However, without excluding user callchains, the output might look like:
> ffffc2ff40ef1b5c arch_local_irq_enable
> ffffc2ff419d032c __schedule
> ffffc2ff419d06c0 schedule
> ffffc2ff40e4da30 do_notify_resume
> ffffc2ff40e421b0 work_pending
> 610 leaf
> 62f parent
> 648 main
>
> Adding '--user-callchains' leaves only the wanted symbols in the chain.
>
> Suggested-by: German Gomez <german.gomez@arm.com>
> Tested-by: Michael Petlan <mpetlan@redhat.com>
Since you are the patch's author, it's not necessary to add your
tested tag.
> Signed-off-by: Michael Petlan <mpetlan@redhat.com>
With addressing German's comment for "excluding kernel callchains":
Reviewed-by: Leo Yan <leo.yan@linaro.org>
> ---
> tools/perf/tests/shell/test_arm_callgraph_fp.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/test_arm_callgraph_fp.sh b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> index 6ffbb27afaba..ec108d45d3c6 100755
> --- a/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> +++ b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> @@ -43,7 +43,7 @@ CFLAGS="-g -O0 -fno-inline -fno-omit-frame-pointer"
> cc $CFLAGS $TEST_PROGRAM_SOURCE -o $TEST_PROGRAM || exit 1
>
> # Add a 1 second delay to skip samples that are not in the leaf() function
> -perf record -o $PERF_DATA --call-graph fp -e cycles//u -D 1000 -- $TEST_PROGRAM 2> /dev/null &
> +perf record -o $PERF_DATA --call-graph fp -e cycles//u -D 1000 --user-callchains -- $TEST_PROGRAM 2> /dev/null &
> PID=$!
>
> echo " + Recording (PID=$PID)..."
> --
> 2.18.4
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf test: Record only user callchains
2022-06-14 12:11 ` German Gomez
2022-06-14 12:19 ` Michael Petlan
@ 2022-06-14 19:09 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 8+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-06-14 19:09 UTC (permalink / raw)
To: German Gomez
Cc: Michael Petlan, linux-perf-users, acme, jolsa, James Clark, Leo Yan
Em Tue, Jun 14, 2022 at 01:11:20PM +0100, German Gomez escreveu:
> Hi Michael, thanks for the fix
>
> On 14/06/2022 11:52, Michael Petlan wrote:
> > The testcase 'Check Arm64 callgraphs are complete in fp mode' wants to
> > see the following output:
> >
> > 610 leaf
> > 62f parent
> > 648 main
> >
> > However, without excluding user callchains, the output might look like:
>
> I think you meant "kernel callchains"
Fixed
> > ffffc2ff40ef1b5c arch_local_irq_enable
> > ffffc2ff419d032c __schedule
> > ffffc2ff419d06c0 schedule
> > ffffc2ff40e4da30 do_notify_resume
> > ffffc2ff40e421b0 work_pending
> > 610 leaf
> > 62f parent
> > 648 main
> >
> > Adding '--user-callchains' leaves only the wanted symbols in the chain.
> >
> > Suggested-by: German Gomez <german.gomez@arm.com>
> > Tested-by: Michael Petlan <mpetlan@redhat.com>
> > Signed-off-by: Michael Petlan <mpetlan@redhat.com>
>
> Fixes: cd6382d82752 ("perf test arm64: Test unwinding using fame-pointer (fp) mode")
> Reviewed-by: German Gomez <german.gomez@arm.com>
Added, thanks.
- Arnaldo
> German
>
> > ---
> > tools/perf/tests/shell/test_arm_callgraph_fp.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/tests/shell/test_arm_callgraph_fp.sh b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> > index 6ffbb27afaba..ec108d45d3c6 100755
> > --- a/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> > +++ b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> > @@ -43,7 +43,7 @@ CFLAGS="-g -O0 -fno-inline -fno-omit-frame-pointer"
> > cc $CFLAGS $TEST_PROGRAM_SOURCE -o $TEST_PROGRAM || exit 1
> >
> > # Add a 1 second delay to skip samples that are not in the leaf() function
> > -perf record -o $PERF_DATA --call-graph fp -e cycles//u -D 1000 -- $TEST_PROGRAM 2> /dev/null &
> > +perf record -o $PERF_DATA --call-graph fp -e cycles//u -D 1000 --user-callchains -- $TEST_PROGRAM 2> /dev/null &
> > PID=$!
> >
> > echo " + Recording (PID=$PID)..."
--
- Arnaldo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf test: Record only user callchains
2022-06-14 13:17 ` Leo Yan
@ 2022-06-14 19:09 ` Arnaldo Carvalho de Melo
2022-06-15 8:14 ` Leo Yan
0 siblings, 1 reply; 8+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-06-14 19:09 UTC (permalink / raw)
To: Leo Yan; +Cc: Michael Petlan, linux-perf-users, acme, jolsa, german.gomez
Em Tue, Jun 14, 2022 at 09:17:04PM +0800, Leo Yan escreveu:
> On Tue, Jun 14, 2022 at 12:52:07PM +0200, Michael Petlan wrote:
> > The testcase 'Check Arm64 callgraphs are complete in fp mode' wants to
> > see the following output:
> >
> > 610 leaf
> > 62f parent
> > 648 main
> >
> > However, without excluding user callchains, the output might look like:
> > ffffc2ff40ef1b5c arch_local_irq_enable
> > ffffc2ff419d032c __schedule
> > ffffc2ff419d06c0 schedule
> > ffffc2ff40e4da30 do_notify_resume
> > ffffc2ff40e421b0 work_pending
> > 610 leaf
> > 62f parent
> > 648 main
> >
> > Adding '--user-callchains' leaves only the wanted symbols in the chain.
> >
> > Suggested-by: German Gomez <german.gomez@arm.com>
> > Tested-by: Michael Petlan <mpetlan@redhat.com>
>
> Since you are the patch's author, it's not necessary to add your
> tested tag.
Right, removed, we expect authors test their patches :-)
> > Signed-off-by: Michael Petlan <mpetlan@redhat.com>
>
> With addressing German's comment for "excluding kernel callchains":
Addressed.
> Reviewed-by: Leo Yan <leo.yan@linaro.org>
Thanks, added.
- Arnaldo
> > ---
> > tools/perf/tests/shell/test_arm_callgraph_fp.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/tests/shell/test_arm_callgraph_fp.sh b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> > index 6ffbb27afaba..ec108d45d3c6 100755
> > --- a/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> > +++ b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> > @@ -43,7 +43,7 @@ CFLAGS="-g -O0 -fno-inline -fno-omit-frame-pointer"
> > cc $CFLAGS $TEST_PROGRAM_SOURCE -o $TEST_PROGRAM || exit 1
> >
> > # Add a 1 second delay to skip samples that are not in the leaf() function
> > -perf record -o $PERF_DATA --call-graph fp -e cycles//u -D 1000 -- $TEST_PROGRAM 2> /dev/null &
> > +perf record -o $PERF_DATA --call-graph fp -e cycles//u -D 1000 --user-callchains -- $TEST_PROGRAM 2> /dev/null &
> > PID=$!
> >
> > echo " + Recording (PID=$PID)..."
> > --
> > 2.18.4
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf test: Record only user callchains
2022-06-14 19:09 ` Arnaldo Carvalho de Melo
@ 2022-06-15 8:14 ` Leo Yan
2022-06-15 13:21 ` German Gomez
0 siblings, 1 reply; 8+ messages in thread
From: Leo Yan @ 2022-06-15 8:14 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Michael Petlan, linux-perf-users, acme, jolsa, german.gomez
On Tue, Jun 14, 2022 at 04:09:48PM -0300, Arnaldo Carvalho de Melo wrote:
[...]
> > With addressing German's comment for "excluding kernel callchains":
>
> Addressed.
>
> > Reviewed-by: Leo Yan <leo.yan@linaro.org>
>
> Thanks, added.
Thanks a lot, Arnaldo!
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf test: Record only user callchains
2022-06-15 8:14 ` Leo Yan
@ 2022-06-15 13:21 ` German Gomez
0 siblings, 0 replies; 8+ messages in thread
From: German Gomez @ 2022-06-15 13:21 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Michael Petlan, linux-perf-users, acme, jolsa, Leo Yan
On 15/06/2022 09:14, Leo Yan wrote:
> On Tue, Jun 14, 2022 at 04:09:48PM -0300, Arnaldo Carvalho de Melo wrote:
>
> [...]
>
>>> With addressing German's comment for "excluding kernel callchains":
>> Addressed.
>>
>>> Reviewed-by: Leo Yan <leo.yan@linaro.org>
>> Thanks, added.
> Thanks a lot, Arnaldo!
+1, thank you for the edits and merging
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-06-15 13:21 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-14 10:52 [PATCH] perf test: Record only user callchains Michael Petlan
2022-06-14 12:11 ` German Gomez
2022-06-14 12:19 ` Michael Petlan
2022-06-14 19:09 ` Arnaldo Carvalho de Melo
2022-06-14 13:17 ` Leo Yan
2022-06-14 19:09 ` Arnaldo Carvalho de Melo
2022-06-15 8:14 ` Leo Yan
2022-06-15 13:21 ` German Gomez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.