From: Randy Dunlap <rdunlap@infradead.org> To: dri-devel@lists.freedesktop.org Cc: "Randy Dunlap" <rdunlap@infradead.org>, "Pan, Xinhui" <Xinhui.Pan@amd.com>, patches@lists.linux.dev, amd-gfx@lists.freedesktop.org, "Wayne Lin" <Wayne.Lin@amd.com>, "Alex Deucher" <alexander.deucher@amd.com>, "Christian König" <christian.koenig@amd.com> Subject: [PATCH] drm/amd/display: add stub for crtc_debugfs_init() Date: Tue, 14 Jun 2022 08:57:26 -0700 [thread overview] Message-ID: <20220614155726.26211-1-rdunlap@infradead.org> (raw) Fix build error when CONFIG_DEBUG_FS is not enabled by adding a stub function for crtc_debugfs_init(). Eliminates this build error: ../drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function ‘amdgpu_dm_crtc_late_register’: ../drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6599:2: error: implicit declaration of function ‘crtc_debugfs_init’; did you mean ‘amdgpu_debugfs_init’? [-Werror=implicit-function-declaration] crtc_debugfs_init(crtc); ^~~~~~~~~~~~~~~~~ amdgpu_debugfs_init Fixes: 86bc22191892 ("drm/amd/display: Support crc on specific region") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Wayne Lin <Wayne.Lin@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Christian König <christian.koenig@amd.com> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com> Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 -- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.h | 6 ++++++ 2 files changed, 6 insertions(+), 2 deletions(-) --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -57,9 +57,7 @@ #include "amdgpu_dm_irq.h" #include "dm_helpers.h" #include "amdgpu_dm_mst_types.h" -#if defined(CONFIG_DEBUG_FS) #include "amdgpu_dm_debugfs.h" -#endif #include "amdgpu_dm_psr.h" #include "ivsrcid/ivsrcid_vislands30.h" --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.h +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.h @@ -31,6 +31,12 @@ void connector_debugfs_init(struct amdgpu_dm_connector *connector); void dtn_debugfs_init(struct amdgpu_device *adev); + +#ifdef CONFIG_DEBUG_FS void crtc_debugfs_init(struct drm_crtc *crtc); +#else +static inline void crtc_debugfs_init(struct drm_crtc *crtc) +{} +#endif #endif
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org> To: dri-devel@lists.freedesktop.org Cc: patches@lists.linux.dev, "Randy Dunlap" <rdunlap@infradead.org>, "Wayne Lin" <Wayne.Lin@amd.com>, "Alex Deucher" <alexander.deucher@amd.com>, "Christian König" <christian.koenig@amd.com>, "Pan, Xinhui" <Xinhui.Pan@amd.com>, amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amd/display: add stub for crtc_debugfs_init() Date: Tue, 14 Jun 2022 08:57:26 -0700 [thread overview] Message-ID: <20220614155726.26211-1-rdunlap@infradead.org> (raw) Fix build error when CONFIG_DEBUG_FS is not enabled by adding a stub function for crtc_debugfs_init(). Eliminates this build error: ../drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function ‘amdgpu_dm_crtc_late_register’: ../drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6599:2: error: implicit declaration of function ‘crtc_debugfs_init’; did you mean ‘amdgpu_debugfs_init’? [-Werror=implicit-function-declaration] crtc_debugfs_init(crtc); ^~~~~~~~~~~~~~~~~ amdgpu_debugfs_init Fixes: 86bc22191892 ("drm/amd/display: Support crc on specific region") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Wayne Lin <Wayne.Lin@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Christian König <christian.koenig@amd.com> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com> Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 -- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.h | 6 ++++++ 2 files changed, 6 insertions(+), 2 deletions(-) --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -57,9 +57,7 @@ #include "amdgpu_dm_irq.h" #include "dm_helpers.h" #include "amdgpu_dm_mst_types.h" -#if defined(CONFIG_DEBUG_FS) #include "amdgpu_dm_debugfs.h" -#endif #include "amdgpu_dm_psr.h" #include "ivsrcid/ivsrcid_vislands30.h" --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.h +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.h @@ -31,6 +31,12 @@ void connector_debugfs_init(struct amdgpu_dm_connector *connector); void dtn_debugfs_init(struct amdgpu_device *adev); + +#ifdef CONFIG_DEBUG_FS void crtc_debugfs_init(struct drm_crtc *crtc); +#else +static inline void crtc_debugfs_init(struct drm_crtc *crtc) +{} +#endif #endif
next reply other threads:[~2022-06-14 15:57 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-14 15:57 Randy Dunlap [this message] 2022-06-14 15:57 ` [PATCH] drm/amd/display: add stub for crtc_debugfs_init() Randy Dunlap 2022-06-14 17:45 ` Harry Wentland 2022-06-14 17:53 ` Randy Dunlap
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220614155726.26211-1-rdunlap@infradead.org \ --to=rdunlap@infradead.org \ --cc=Wayne.Lin@amd.com \ --cc=Xinhui.Pan@amd.com \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=christian.koenig@amd.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=patches@lists.linux.dev \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.