* [PATCH] arch: arm: mach-ux500: Add missing of_node_put() in pm_domain.c
@ 2022-06-15 9:40 ` heliang
0 siblings, 0 replies; 2+ messages in thread
From: heliang @ 2022-06-15 9:40 UTC (permalink / raw)
To: linus.walleij, linux; +Cc: linux-arm-kernel, linux-kernel, windhl
In ux500_pm_domains_init(), of_find_matching_node() will return a
node pointer with refcount incremented. We should use of_node_put()
in fail path or when it is not used anymore.
Signed-off-by: heliang <windhl@126.com>
---
arch/arm/mach-ux500/pm_domains.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-ux500/pm_domains.c b/arch/arm/mach-ux500/pm_domains.c
index 427b9ac4af6c..80152e195fdd 100644
--- a/arch/arm/mach-ux500/pm_domains.c
+++ b/arch/arm/mach-ux500/pm_domains.c
@@ -66,8 +66,10 @@ int __init ux500_pm_domains_init(void)
genpd_data = kzalloc(sizeof(*genpd_data), GFP_KERNEL);
if (!genpd_data)
+ {
+ of_node_put(np);
return -ENOMEM;
-
+ }
genpd_data->domains = ux500_pm_domains;
genpd_data->num_domains = ARRAY_SIZE(ux500_pm_domains);
@@ -75,5 +77,6 @@ int __init ux500_pm_domains_init(void)
pm_genpd_init(ux500_pm_domains[i], NULL, false);
of_genpd_add_provider_onecell(np, genpd_data);
+ of_node_put(np);
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] arch: arm: mach-ux500: Add missing of_node_put() in pm_domain.c
@ 2022-06-15 9:40 ` heliang
0 siblings, 0 replies; 2+ messages in thread
From: heliang @ 2022-06-15 9:40 UTC (permalink / raw)
To: linus.walleij, linux; +Cc: linux-arm-kernel, linux-kernel, windhl
In ux500_pm_domains_init(), of_find_matching_node() will return a
node pointer with refcount incremented. We should use of_node_put()
in fail path or when it is not used anymore.
Signed-off-by: heliang <windhl@126.com>
---
arch/arm/mach-ux500/pm_domains.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-ux500/pm_domains.c b/arch/arm/mach-ux500/pm_domains.c
index 427b9ac4af6c..80152e195fdd 100644
--- a/arch/arm/mach-ux500/pm_domains.c
+++ b/arch/arm/mach-ux500/pm_domains.c
@@ -66,8 +66,10 @@ int __init ux500_pm_domains_init(void)
genpd_data = kzalloc(sizeof(*genpd_data), GFP_KERNEL);
if (!genpd_data)
+ {
+ of_node_put(np);
return -ENOMEM;
-
+ }
genpd_data->domains = ux500_pm_domains;
genpd_data->num_domains = ARRAY_SIZE(ux500_pm_domains);
@@ -75,5 +77,6 @@ int __init ux500_pm_domains_init(void)
pm_genpd_init(ux500_pm_domains[i], NULL, false);
of_genpd_add_provider_onecell(np, genpd_data);
+ of_node_put(np);
return 0;
}
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-15 9:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-15 9:40 [PATCH] arch: arm: mach-ux500: Add missing of_node_put() in pm_domain.c heliang
2022-06-15 9:40 ` heliang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.