* [PATCH] arch: powerpc: platforms: 85xx: Add missing of_node_put in sgy_cts1000.c
@ 2022-06-15 12:07 ` Liang He
0 siblings, 0 replies; 5+ messages in thread
From: Liang He @ 2022-06-15 12:07 UTC (permalink / raw)
To: oss, mpe, benh, paulus; +Cc: linuxppc-dev, linux-kernel, Liang He
Signed-off-by: Liang He <windhl@126.com>
---
arch/powerpc/platforms/85xx/sgy_cts1000.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/powerpc/platforms/85xx/sgy_cts1000.c b/arch/powerpc/platforms/85xx/sgy_cts1000.c
index 98ae64075193..2a45b30852b2 100644
--- a/arch/powerpc/platforms/85xx/sgy_cts1000.c
+++ b/arch/powerpc/platforms/85xx/sgy_cts1000.c
@@ -85,17 +85,24 @@ static int gpio_halt_probe(struct platform_device *pdev)
/* Technically we could just read the first one, but punish
* DT writers for invalid form. */
if (of_gpio_count(halt_node) != 1)
+ {
+ of_node_put(halt_node);
return -EINVAL;
+ }
/* Get the gpio number relative to the dynamic base. */
gpio = of_get_gpio_flags(halt_node, 0, &flags);
if (!gpio_is_valid(gpio))
+ {
+ of_node_put(halt_node);
return -EINVAL;
+ }
err = gpio_request(gpio, "gpio-halt");
if (err) {
printk(KERN_ERR "gpio-halt: error requesting GPIO %d.\n",
gpio);
+ of_node_put(halt_node);
halt_node = NULL;
return err;
}
@@ -112,6 +119,7 @@ static int gpio_halt_probe(struct platform_device *pdev)
printk(KERN_ERR "gpio-halt: error requesting IRQ %d for "
"GPIO %d.\n", irq, gpio);
gpio_free(gpio);
+ of_node_put(halt_node);
halt_node = NULL;
return err;
}
@@ -123,6 +131,8 @@ static int gpio_halt_probe(struct platform_device *pdev)
printk(KERN_INFO "gpio-halt: registered GPIO %d (%d trigger, %d"
" irq).\n", gpio, trigger, irq);
+ of_node_put(halt_node);
+
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] arch: powerpc: platforms: 85xx: Add missing of_node_put in sgy_cts1000.c
@ 2022-06-15 12:07 ` Liang He
0 siblings, 0 replies; 5+ messages in thread
From: Liang He @ 2022-06-15 12:07 UTC (permalink / raw)
To: oss, mpe, benh, paulus; +Cc: Liang He, linuxppc-dev, linux-kernel
Signed-off-by: Liang He <windhl@126.com>
---
arch/powerpc/platforms/85xx/sgy_cts1000.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/powerpc/platforms/85xx/sgy_cts1000.c b/arch/powerpc/platforms/85xx/sgy_cts1000.c
index 98ae64075193..2a45b30852b2 100644
--- a/arch/powerpc/platforms/85xx/sgy_cts1000.c
+++ b/arch/powerpc/platforms/85xx/sgy_cts1000.c
@@ -85,17 +85,24 @@ static int gpio_halt_probe(struct platform_device *pdev)
/* Technically we could just read the first one, but punish
* DT writers for invalid form. */
if (of_gpio_count(halt_node) != 1)
+ {
+ of_node_put(halt_node);
return -EINVAL;
+ }
/* Get the gpio number relative to the dynamic base. */
gpio = of_get_gpio_flags(halt_node, 0, &flags);
if (!gpio_is_valid(gpio))
+ {
+ of_node_put(halt_node);
return -EINVAL;
+ }
err = gpio_request(gpio, "gpio-halt");
if (err) {
printk(KERN_ERR "gpio-halt: error requesting GPIO %d.\n",
gpio);
+ of_node_put(halt_node);
halt_node = NULL;
return err;
}
@@ -112,6 +119,7 @@ static int gpio_halt_probe(struct platform_device *pdev)
printk(KERN_ERR "gpio-halt: error requesting IRQ %d for "
"GPIO %d.\n", irq, gpio);
gpio_free(gpio);
+ of_node_put(halt_node);
halt_node = NULL;
return err;
}
@@ -123,6 +131,8 @@ static int gpio_halt_probe(struct platform_device *pdev)
printk(KERN_INFO "gpio-halt: registered GPIO %d (%d trigger, %d"
" irq).\n", gpio, trigger, irq);
+ of_node_put(halt_node);
+
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arch: powerpc: platforms: 85xx: Add missing of_node_put in sgy_cts1000.c
2022-06-15 12:07 ` Liang He
(?)
@ 2022-06-16 14:49 ` Christophe Leroy
2022-06-16 14:56 ` Liang He
-1 siblings, 1 reply; 5+ messages in thread
From: Christophe Leroy @ 2022-06-16 14:49 UTC (permalink / raw)
To: Liang He, oss, mpe, benh, paulus; +Cc: linuxppc-dev, linux-kernel
Le 15/06/2022 à 14:07, Liang He a écrit :
> [You don't often get email from windhl@126.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
> arch/powerpc/platforms/85xx/sgy_cts1000.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/powerpc/platforms/85xx/sgy_cts1000.c b/arch/powerpc/platforms/85xx/sgy_cts1000.c
> index 98ae64075193..2a45b30852b2 100644
> --- a/arch/powerpc/platforms/85xx/sgy_cts1000.c
> +++ b/arch/powerpc/platforms/85xx/sgy_cts1000.c
> @@ -85,17 +85,24 @@ static int gpio_halt_probe(struct platform_device *pdev)
> /* Technically we could just read the first one, but punish
> * DT writers for invalid form. */
> if (of_gpio_count(halt_node) != 1)
> + {
> + of_node_put(halt_node);
Duplicating the same code at multiple exit points is bad practice.
If you can't do a simple 'return' exit, you should use 'goto' to a
common error path exit.
> return -EINVAL;
> + }
>
> /* Get the gpio number relative to the dynamic base. */
> gpio = of_get_gpio_flags(halt_node, 0, &flags);
> if (!gpio_is_valid(gpio))
> + {
> + of_node_put(halt_node);
> return -EINVAL;
> + }
>
> err = gpio_request(gpio, "gpio-halt");
> if (err) {
> printk(KERN_ERR "gpio-halt: error requesting GPIO %d.\n",
> gpio);
> + of_node_put(halt_node);
> halt_node = NULL;
> return err;
> }
> @@ -112,6 +119,7 @@ static int gpio_halt_probe(struct platform_device *pdev)
> printk(KERN_ERR "gpio-halt: error requesting IRQ %d for "
> "GPIO %d.\n", irq, gpio);
> gpio_free(gpio);
> + of_node_put(halt_node);
> halt_node = NULL;
> return err;
> }
> @@ -123,6 +131,8 @@ static int gpio_halt_probe(struct platform_device *pdev)
> printk(KERN_INFO "gpio-halt: registered GPIO %d (%d trigger, %d"
> " irq).\n", gpio, trigger, irq);
>
> + of_node_put(halt_node);
> +
> return 0;
> }
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re:Re: [PATCH] arch: powerpc: platforms: 85xx: Add missing of_node_put in sgy_cts1000.c
2022-06-16 14:49 ` Christophe Leroy
@ 2022-06-16 14:56 ` Liang He
0 siblings, 0 replies; 5+ messages in thread
From: Liang He @ 2022-06-16 14:56 UTC (permalink / raw)
To: Christophe Leroy; +Cc: oss, mpe, benh, paulus, linuxppc-dev, linux-kernel
At 2022-06-16 22:49:36, "Christophe Leroy" <christophe.leroy@csgroup.eu> wrote:
>
>
>Le 15/06/2022 à 14:07, Liang He a écrit :
>> [You don't often get email from windhl@126.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Signed-off-by: Liang He <windhl@126.com>
>> ---
>> arch/powerpc/platforms/85xx/sgy_cts1000.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/powerpc/platforms/85xx/sgy_cts1000.c b/arch/powerpc/platforms/85xx/sgy_cts1000.c
>> index 98ae64075193..2a45b30852b2 100644
>> --- a/arch/powerpc/platforms/85xx/sgy_cts1000.c
>> +++ b/arch/powerpc/platforms/85xx/sgy_cts1000.c
>> @@ -85,17 +85,24 @@ static int gpio_halt_probe(struct platform_device *pdev)
>> /* Technically we could just read the first one, but punish
>> * DT writers for invalid form. */
>> if (of_gpio_count(halt_node) != 1)
>> + {
>> + of_node_put(halt_node);
>
>Duplicating the same code at multiple exit points is bad practice.
>
>If you can't do a simple 'return' exit, you should use 'goto' to a
>common error path exit.
Thanks for your valuable advice, I will resend a new patch for that.
>
>> return -EINVAL;
>> + }
>>
>> /* Get the gpio number relative to the dynamic base. */
>> gpio = of_get_gpio_flags(halt_node, 0, &flags);
>> if (!gpio_is_valid(gpio))
>> + {
>> + of_node_put(halt_node);
>> return -EINVAL;
>> + }
>>
>> err = gpio_request(gpio, "gpio-halt");
>> if (err) {
>> printk(KERN_ERR "gpio-halt: error requesting GPIO %d.\n",
>> gpio);
>> + of_node_put(halt_node);
>> halt_node = NULL;
>> return err;
>> }
>> @@ -112,6 +119,7 @@ static int gpio_halt_probe(struct platform_device *pdev)
>> printk(KERN_ERR "gpio-halt: error requesting IRQ %d for "
>> "GPIO %d.\n", irq, gpio);
>> gpio_free(gpio);
>> + of_node_put(halt_node);
>> halt_node = NULL;
>> return err;
>> }
>> @@ -123,6 +131,8 @@ static int gpio_halt_probe(struct platform_device *pdev)
>> printk(KERN_INFO "gpio-halt: registered GPIO %d (%d trigger, %d"
>> " irq).\n", gpio, trigger, irq);
>>
>> + of_node_put(halt_node);
>> +
>> return 0;
>> }
>>
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re:Re: [PATCH] arch: powerpc: platforms: 85xx: Add missing of_node_put in sgy_cts1000.c
@ 2022-06-16 14:56 ` Liang He
0 siblings, 0 replies; 5+ messages in thread
From: Liang He @ 2022-06-16 14:56 UTC (permalink / raw)
To: Christophe Leroy; +Cc: linux-kernel, oss, paulus, linuxppc-dev
At 2022-06-16 22:49:36, "Christophe Leroy" <christophe.leroy@csgroup.eu> wrote:
>
>
>Le 15/06/2022 à 14:07, Liang He a écrit :
>> [You don't often get email from windhl@126.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Signed-off-by: Liang He <windhl@126.com>
>> ---
>> arch/powerpc/platforms/85xx/sgy_cts1000.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/powerpc/platforms/85xx/sgy_cts1000.c b/arch/powerpc/platforms/85xx/sgy_cts1000.c
>> index 98ae64075193..2a45b30852b2 100644
>> --- a/arch/powerpc/platforms/85xx/sgy_cts1000.c
>> +++ b/arch/powerpc/platforms/85xx/sgy_cts1000.c
>> @@ -85,17 +85,24 @@ static int gpio_halt_probe(struct platform_device *pdev)
>> /* Technically we could just read the first one, but punish
>> * DT writers for invalid form. */
>> if (of_gpio_count(halt_node) != 1)
>> + {
>> + of_node_put(halt_node);
>
>Duplicating the same code at multiple exit points is bad practice.
>
>If you can't do a simple 'return' exit, you should use 'goto' to a
>common error path exit.
Thanks for your valuable advice, I will resend a new patch for that.
>
>> return -EINVAL;
>> + }
>>
>> /* Get the gpio number relative to the dynamic base. */
>> gpio = of_get_gpio_flags(halt_node, 0, &flags);
>> if (!gpio_is_valid(gpio))
>> + {
>> + of_node_put(halt_node);
>> return -EINVAL;
>> + }
>>
>> err = gpio_request(gpio, "gpio-halt");
>> if (err) {
>> printk(KERN_ERR "gpio-halt: error requesting GPIO %d.\n",
>> gpio);
>> + of_node_put(halt_node);
>> halt_node = NULL;
>> return err;
>> }
>> @@ -112,6 +119,7 @@ static int gpio_halt_probe(struct platform_device *pdev)
>> printk(KERN_ERR "gpio-halt: error requesting IRQ %d for "
>> "GPIO %d.\n", irq, gpio);
>> gpio_free(gpio);
>> + of_node_put(halt_node);
>> halt_node = NULL;
>> return err;
>> }
>> @@ -123,6 +131,8 @@ static int gpio_halt_probe(struct platform_device *pdev)
>> printk(KERN_INFO "gpio-halt: registered GPIO %d (%d trigger, %d"
>> " irq).\n", gpio, trigger, irq);
>>
>> + of_node_put(halt_node);
>> +
>> return 0;
>> }
>>
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-16 15:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-15 12:07 [PATCH] arch: powerpc: platforms: 85xx: Add missing of_node_put in sgy_cts1000.c Liang He
2022-06-15 12:07 ` Liang He
2022-06-16 14:49 ` Christophe Leroy
2022-06-16 14:56 ` Liang He
2022-06-16 14:56 ` Liang He
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.