From: Pavel Machek <pavel@ucw.cz>
To: David Wang <David_Wang6097@jabil.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
edward_chen@jabil.com, ben_pai@jabil.com
Subject: Re: [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC
Date: Wed, 15 Jun 2022 15:28:41 +0200 [thread overview]
Message-ID: <20220615132841.GC1429@bug> (raw)
In-Reply-To: <20220531011100.882643-1-David_Wang6097@jabil.com>
Hi!
> The initial introduction of the jabil server with AST2600 BMC SoC.
> + led-0 {
> + label = "identify";
> + color = <LED_COLOR_ID_BLUE>;
> + function = LED_FUNCTION_INDICATOR;
> + retain-state-shutdown;
> + gpios = <&gpio0 ASPEED_GPIO(B, 7) GPIO_ACTIVE_LOW>;
> + };
> +
> + led-1 {
> + label = "status_amber";
> + label = "status_green";
> + label = "status_susack";
> + led-4 {
> + label = "power-amber";
> + label = "fan1-fault";
Please take a look at LED documentation and try to come up with something more in line
with existing conventions. Also please cc linux-leds list.
Best regards,
Pavel
next prev parent reply other threads:[~2022-06-15 13:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 1:10 [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC David Wang
2022-05-31 1:10 ` [PATCH v5 3/3] dt-bindings: arm: aspeed: document board compatibles David Wang
2022-05-31 10:23 ` Krzysztof Kozlowski
2022-06-22 10:14 ` (subset) " Krzysztof Kozlowski
2022-05-31 1:11 ` [PATCH v5 2/3] dt-bindings: vendor-prefixes: document jabil vendors for Aspeed BMC boards David Wang
2022-05-31 10:24 ` Krzysztof Kozlowski
2022-05-31 10:23 ` [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC Krzysztof Kozlowski
2022-06-15 13:28 ` Pavel Machek [this message]
2022-06-01 8:08 David Wang
2022-06-01 8:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615132841.GC1429@bug \
--to=pavel@ucw.cz \
--cc=David_Wang6097@jabil.com \
--cc=ben_pai@jabil.com \
--cc=devicetree@vger.kernel.org \
--cc=edward_chen@jabil.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.